mtd: rawnand: fsl_elbc: Fix reading address pointer from DT
Subsystems (2)
PATCH 1/1 mtd: rawnand: fsl_elbc: Fix reading address pointer from DT
During compilation gcc throws warning:
drivers/mtd/nand/raw/fsl_elbc_nand.c: In function ‘fsl_elbc_nand_probe’:
drivers/mtd/nand/raw/fsl_elbc_nand.c:841:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
return fsl_elbc_chip_init(0, (void *)dev_read_addr(dev), dev);
^
Fix it by using dev_read_addr_ptr() function which returns pointer instead of dev_read_addr() which returns integer type.
--- drivers/mtd/nand/raw/fsl_elbc_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/raw/fsl_elbc_nand.c +1 -1
@@ -839,7 +839,7 @@ void board_nand_init(void)static int fsl_elbc_nand_probe (struct udevice *dev) { -return fsl_elbc_chip_init (0 , (void *)dev_read_addr (dev), dev); +return fsl_elbc_chip_init (0 ,dev_read_addr_ptr (dev), dev); }static const struct udevice_id fsl_elbc_nand_dt_ids[] = {
Signature · 1 line
2.20.1
Hi Pali
Quoted 30 lines · Pali Rohár
During compilation gcc throws warning:
drivers/mtd/nand/raw/fsl_elbc_nand.c: In function ‘fsl_elbc_nand_probe’:
drivers/mtd/nand/raw/fsl_elbc_nand.c:841:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
returnfsl_elbc_chip_init(0, (void *)dev_read_addr(dev), dev);
^Fix it by using
dev_read_addr_ptr()function which returns pointer instead ofdev_read_addr()which returns integer type.Signed-off-by Pali Rohár <[email protected]>--- drivers/mtd/nand/raw/fsl_elbc_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mtd/nand/raw/fsl_elbc_nand.c +1
-2@@ -839,7 +839,7 @@ void board_nand_init(void)static int fsl_elbc_nand_probe (struct udevice *dev) { -return fsl_elbc_chip_init (0 , (void *)dev_read_addr (dev), dev); +return fsl_elbc_chip_init (0 ,dev_read_addr_ptr (dev), dev); }static const struct udevice_id fsl_elbc_nand_dt_ids[] = { --
Quoted 2 lines
2.20.1
Thanks and regards,
Dario
Signature · 17 lines
Dario Binacchi Embedded Linux Developer [email protected] __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 [email protected] www.amarulasolutions.com
Quoted 32 lines · Dario Binacchi
Hi Pali
Quoted 28 lines · Pali Rohár
During compilation gcc throws warning:
drivers/mtd/nand/raw/fsl_elbc_nand.c: In function ‘fsl_elbc_nand_probe’:
drivers/mtd/nand/raw/fsl_elbc_nand.c:841:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
returnfsl_elbc_chip_init(0, (void *)dev_read_addr(dev), dev);
^Fix it by using
dev_read_addr_ptr()function which returns pointer instead ofdev_read_addr()which returns integer type.Signed-off-by Pali Rohár <[email protected]>--- drivers/mtd/nand/raw/fsl_elbc_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mtd/nand/raw/fsl_elbc_nand.c +1
-1@@ -839,7 +839,7 @@ void board_nand_init(void)static int fsl_elbc_nand_probe (struct udevice *dev) { -return fsl_elbc_chip_init (0 , (void *)dev_read_addr (dev), dev); +return fsl_elbc_chip_init (0 ,dev_read_addr_ptr (dev), dev); }
Quoted 7 lines
Quoted 4 lines
drivers/mtd/nand/raw/fsl_elbc_nand.c +0
-1static const struct udevice_id fsl_elbc_nand_dt_ids[] = { --2.20.1
Reviewed-by Dario Binacchi <[email protected]>
Applied thanks
Quoted 21 lines
Thanks and regards,
Dario
--Dario Binacchi
Embedded Linux Developer
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
[email protected]www.amarulasolutions.com
Signature · 11 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com