Skip to contentSkip to conversation

i40e: Fix incorrect address type for IPv6 flow rules

PATCH In review Sokolowski, Jan 2 participants 2 messages Aug 19, 2022 – Aug 23, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e: Fix incorrect address type for IPv6 flow rules

From: Sylwester Dziedziuch <[email protected]>

It was not possible to create 1-tuple flow director rule for IPv6 flow type. It was caused by incorrectly checking for source IP address when validating user provided destination IP address.

Fix this by changing ip6src to correct ip6dst address in destination IP address validation for IPv6 flow type.

Fixes efca91e89b67 ("i40e: Add flow director support for IPv6")
---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e_ethtool.c +1 -1
index 156e92c43780..e9cd0fa6a0d2 100644
@@ -4485,7 +4485,7 @@ static int i40e_check_fdir_input_set(struct i40e_vsi *vsi,
 				    (struct in6_addr *)&ipv6_full_mask))
 			new_mask |= I40E_L3_V6_DST_MASK;
 		else if (ipv6_addr_any((struct in6_addr *)
-				       &usr_ip6_spec->ip6src))
+				       &usr_ip6_spec->ip6dst))
 			new_mask &= ~I40E_L3_V6_DST_MASK;
 		else
 			return -EOPNOTSUPP;
Signature · 6 lines
2.31.1

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by on v1 1/1
#1 lore raw
Quoted 17 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Sokolowski, Jan
Sent: Friday, August 19, 2022 4:16 PM
To: [email protected]
Cc: Dziedziuch, SylwesterX <[email protected]>
Subject: [Intel-wired-lan] [PATCH net v1] i40e: Fix incorrect address type for IPv6 flow rules

From: Sylwester Dziedziuch <[email protected]>

It was not possible to create 1-tuple flow director rule for IPv6 flow type. It was caused by incorrectly checking for source IP address when validating user provided destination IP address.

Quoted 9 lines

Fix this by changing ip6src to correct ip6dst address in destination IP address validation for IPv6 flow type.

Fixes efca91e89b67 ("i40e: Add flow director support for IPv6")
---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan