util-linux: Remove raw flags in EXTRA_OECONF
PATCH 1/1 util-linux: Remove raw flags in EXTRA_OECONF
Having both enable and disable flags for raw is confusing. Raw should not be enabled so both flags can be removed.
--- meta/recipes-core/util-linux/util-linux_2.38.1.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-core/util-linux/util-linux_2.38.1.bb +2 -2
@@ -69,12 +69,12 @@ EXTRA_OECONF = "\ --enable-libuuid --enable-libblkid \ \ --enable-fsck --enable-kill --enable-last --enable-mesg \ - --enable-mount --enable-partx --enable-raw --enable-rfkill \ + --enable-mount --enable-partx --enable-rfkill \ --enable-unshare --enable-write \ \ --disable-bfs --disable-login \ --disable-makeinstall-chown --disable-minix --disable-newgrp \ - --disable-use-tty-group --disable-vipw --disable-raw \ + --disable-use-tty-group --disable-vipw \ \ --without-udev \ \
Signature · 1 line
2.37.1
Quoted 25 lines
-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Mateusz Marciniec
Sent: den 19 augusti 2022 13:34
To: [email protected]
Cc: Mateusz Marciniec <[email protected]>; Tomasz Dziendzielski <[email protected]>
Subject: [OE-core] [PATCH] util-linux: Remove raw flags inEXTRA_OECONFHaving both enable and disable flags for raw is confusing. Raw should not be enabled so both flags can be removed.
Signed-off-by Mateusz Marciniec <[email protected]>Signed-off-by Tomasz Dziendzielski <[email protected]>--- meta/recipes-core/util-linux/util-linux_2.38.1.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)meta/recipes-core/util-linux/util-linux_2.38.1.bb +0
-0@@ -69,12 +69,12 @@ EXTRA_OECONF = "\ --enable-libuuid --enable-libblkid \
meta/recipes-core/util-linux/util-linux_2.38.1.bb EXTRA_OECONF = "\ · line 77
Quoted 10 lines
meta/recipes-core/util-linux/util-linux_2.38.1.bb +2
-2\ --enable-fsck --enable-kill --enable-last --enable-mesg \ - --enable-mount --enable-partx --enable-raw --enable-rfkill \ + --enable-mount --enable-partx --enable-rfkill \ --enable-unshare --enable-write \ \ --disable-bfs --disable-login \ --disable-makeinstall-chown --disable-minix --disable-newgrp \ - --disable-use-tty-group --disable-vipw --disable-raw \ + --disable-use-tty-group --disable-vipw \
A quick look in configure.ac for util-linux indicates that it will start to look for linux/raw.h and enable raw support if it exists if you remove the --disable-raw option. So you should leave the --disable-raw option to maintain the current deterministic behavior.
Quoted 5 lines
meta/recipes-core/util-linux/util-linux_2.38.1.bb +0
-1\ --without-udev \ \ --2.37.1
//Peter
Yes, you are right, I corrected it in the new version of patch. Thanks for pointing that out.
Best Regards,
Mateusz Marciniec
pt., 19 sie 2022 o 16:38 Peter Kjellerstedt <[email protected]> napisał(a):
Quoted 50 lines
Quoted 25 lines
-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Mateusz Marciniec
Sent: den 19 augusti 2022 13:34
To: [email protected]
Cc: Mateusz Marciniec <[email protected]>; Tomasz Dziendzielski <[email protected]>
Subject: [OE-core] [PATCH] util-linux: Remove raw flags inEXTRA_OECONFHaving both enable and disable flags for raw is confusing. Raw should not be enabled so both flags can be removed.
Signed-off-by Mateusz Marciniec <[email protected]>Signed-off-by Tomasz Dziendzielski <[email protected]>--- meta/recipes-core/util-linux/util-linux_2.38.1.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)meta/recipes-core/util-linux/util-linux_2.38.1.bb +0
-0@@ -69,12 +69,12 @@ EXTRA_OECONF = "\ --enable-libuuid --enable-libblkid \meta/recipes-core/util-linux/util-linux_2.38.1.bb EXTRA_OECONF = "\ · line 77
Quoted 10 lines
meta/recipes-core/util-linux/util-linux_2.38.1.bb +2
-2\ --enable-fsck --enable-kill --enable-last --enable-mesg \ - --enable-mount --enable-partx --enable-raw --enable-rfkill \ + --enable-mount --enable-partx --enable-rfkill \ --enable-unshare --enable-write \ \ --disable-bfs --disable-login \ --disable-makeinstall-chown --disable-minix --disable-newgrp \ - --disable-use-tty-group --disable-vipw --disable-raw \ + --disable-use-tty-group --disable-vipw \A quick look in configure.ac for util-linux indicates that it will start to look for
linux/raw.hand enable raw support if it exists if you remove the --disable-raw option. So you should leave the --disable-raw option to maintain the current deterministic behavior.Quoted 5 lines
meta/recipes-core/util-linux/util-linux_2.38.1.bb +0
-1\ --without-udev \ \ --2.37.1
//Peter