Skip to contentSkip to conversation

KVM: selftests: Update top-of-file comment in psci_test

PATCH RESEND Applied Oliver Upton 2 participants 2 messages Aug 19, 2022 – Sep 28, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 KVM: selftests: Update top-of-file comment in psci_test

Fix the comment to accurately describe the test and recently added SYSTEM_SUSPEND test case.

What was once psci_cpu_on_test was renamed and extended to squeeze in a test case for PSCI SYSTEM_SUSPEND. Nonetheless, the author of those changes (whoever they may be...) failed to update the file comment to reflect what had changed.

---

Forgetting the name of the darned UAPI event. Tsk tsk.

 tools/testing/selftests/kvm/aarch64/psci_test.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
tools/testing/selftests/kvm/aarch64/psci_test.c +6 -4
index f7621f6e938e..e0b9e81a3e09 100644
@@ -1,12 +1,14 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * psci_cpu_on_test - Test that the observable state of a vCPU targeted by the
- * CPU_ON PSCI call matches what the caller requested.
+ * psci_test - Tests relating to KVM's PSCI implementation.
  *
  * Copyright (c) 2021 Google LLC.
  *
- * This is a regression test for a race between KVM servicing the PSCI call and
- * userspace reading the vCPUs registers.
+ * This test includes:
+ *  - A regression test for a race between KVM servicing the PSCI CPU_ON call
+ *    and userspace reading the targeted vCPU's registers.
+ *  - A test for KVM's handling of PSCI SYSTEM_SUSPEND and the associated
+ *    KVM_SYSTEM_EVENT_SUSPEND UAPI.
  */
 
 #define _GNU_SOURCE

base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868

Signature · 6 lines
2.37.1.595.g718a3a8f04-goog

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
maintainer Applied
#1 lore raw
Quoted 7 lines · Oliver Upton

Fix the comment to accurately describe the test and recently added SYSTEM_SUSPEND test case.

What was once psci_cpu_on_test was renamed and extended to squeeze in a test case for PSCI SYSTEM_SUSPEND. Nonetheless, the author of those changes (whoever they may be...) failed to update the file comment to reflect what had changed.

Applied to next, thanks!

[1/1] KVM: selftests: Update top-of-file comment in psci_test

      commit: 448e711693e48d03f7933ab3673334701b0c3f41

Cheers,

	M.
Signature · 1 line
Without deviation from the norm, progress is not possible.