clk: nomadik: Add missing of_node_put()
Subsystems (2)
PATCH v4 1/1 clk: nomadik: Add missing of_node_put()
In nomadik_src_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore.
---
changelog:
v4: split v3 into nmadik and tegra
v3: merge clk 'missing of_node_put()' patches into one commit.
v2: use Liang He as real name for S-o-b.
v1: fix the missing of_node_put().
drivers/clk/clk-nomadik.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/clk/clk-nomadik.c +4 -1
@@ -99,7 +99,7 @@ static void __init nomadik_src_init(void)if (!src_base) {pr_err ("%s: must have src parent node with REGS (%pOFn)\n" , __func__, np); -return ; + goto out_put; }/* Set all timers to use the 2.4 MHz TIMCLK */
@@ -132,6 +132,9 @@ static void __init nomadik_src_init(void) }writel (val, src_base +SRC_XTALCR );register_reboot_notifier (&nomadik_clk_reboot_notifier); + +out_put: +of_node_put (np); }/**
Signature · 7 lines
2.25.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 5 lines · Liang He
In
nomadik_src_init(),of_find_matching_node()will return a node pointer with refcount incremented. We should useof_node_put()in fail path or when it is not used anymore.Signed-off-by Liang He <[email protected]>
Yours,
Linus Walleij
Quoting Liang He (2022-06-16 18:43:08)
Quoted 6 lines
In
nomadik_src_init(),of_find_matching_node()will return a node pointer with refcount incremented. We should useof_node_put()in fail path or when it is not used anymore.Signed-off-by Liang He <[email protected]>---
Applied to clk-next