clk: oxnas: Hold reference returned by of_get_parent()
PATCH v2 1/1 clk: oxnas: Hold reference returned by of_get_parent()
In oxnas_stdclk_probe(), we need to hold the reference returned by of_get_parent() and use it to call of_node_put() for refcount balance.
Fixes 0bbd72b4c64f ("clk: Add Oxford Semiconductor OXNAS Standard Clocks")
Signed-off-by Liang He <[email protected]>
---
changelog:
v2: change 'tp' with 'parent_np', change title format to xx:yy:zz
v1: hold reference returned by of_get_parent()
v1-link: https://lore.kernel.org/all/[email protected]/
Patched file has been copmiled test in 5.19rc2.
drivers/clk/clk-oxnas.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/clk/clk-oxnas.c +4 -2
@@ -207,7 +207,7 @@ static const struct of_device_id oxnas_stdclk_dt_ids[] = {static int oxnas_stdclk_probe (struct platform_device *pdev) { -struct device_node *np = pdev->dev.of_node; +struct device_node *np = pdev->dev.of_node, *parent_np;const struct oxnas_stdclk_data *data;struct regmap *regmap;int ret;
@@ -215,7 +215,9 @@ static int oxnas_stdclk_probe(struct platform_device *pdev) data =of_device_get_match_data (&pdev->dev); - regmap =syscon_node_to_regmap (of_get_parent (np)); + parent_np =of_get_parent (np); + regmap =syscon_node_to_regmap (parent_np); +of_node_put (parent_np);if (IS_ERR (regmap)) {dev_err (&pdev->dev,"failed to have parent regmap\n" );return PTR_ERR (regmap);
Signature · 1 line
2.25.1
Quoting Liang He (2022-06-28 07:31:55)
Quoted 7 lines
In
oxnas_stdclk_probe(), we need to hold the reference returned byof_get_parent()and use it to callof_node_put()for refcount balance.Fixes 0bbd72b4c64f ("clk: Add Oxford Semiconductor OXNAS Standard Clocks")Signed-off-by Liang He <[email protected]>---
Applied to clk-next