batman-adv: Fix hang up with small MTU hard-interface
PATCH 1/1 batman-adv: Fix hang up with small MTU hard-interface
The system hangs up when batman-adv soft-interface is created on hard-interface with small MTU. For example, the following commands create batman-adv soft-interface on dummy interface with zero MTU:
# ip link add name dummy0 type dummy # ip link set mtu 0 dev dummy0 # ip link set up dev dummy0 # ip link add name bat0 type batadv # ip link set dev dummy0 master bat0
These commands cause the system hang up with the following messages:
[ 90.578925][ T6689] batman_adv: bat0: Adding interface: dummy0 [ 90.580884][ T6689] batman_adv: bat0: The MTU of interface dummy0 is too small (0) to handle the transport of batman-adv packets. Packets going over this interface will be fragmented on layer2 which could impact the performance. Setting the MTU to 1560 would solve the problem. [ 90.586264][ T6689] batman_adv: bat0: Interface activated: dummy0 [ 90.590061][ T6689] batman_adv: bat0: Forced to purge local tt entries to fit new maximum fragment MTU (-320) [ 90.595517][ T6689] batman_adv: bat0: Forced to purge local tt entries to fit new maximum fragment MTU (-320) [ 90.598499][ T6689] batman_adv: bat0: Forced to purge local tt entries to fit new maximum fragment MTU (-320)
This patch fixes this issue by returning error when enabling hard-interface with small MTU size.
--- net/batman-adv/hard-interface.c | 3 +++ 1 file changed, 3 insertions(+)
net/batman-adv/hard-interface.c +3 -0
@@ -700,6 +700,9 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,int max_header_len =batadv_max_header_len ();int ret; +if (hard_iface->net_dev->mtu <ETH_MIN_MTU + max_header_len) +return -EINVAL ; +if (hard_iface->if_status !=BATADV_IF_NOT_IN_USE ) goto out;
Signature · 1 line
2.37.2
ping?
Quoted 44 lines · Shigeru Yoshida
The system hangs up when batman-adv soft-interface is created on hard-interface with small MTU. For example, the following commands create batman-adv soft-interface on dummy interface with zero MTU:
# ip link add name dummy0 type dummy # ip link set mtu 0 dev dummy0 # ip link set up dev dummy0 # ip link add name bat0 type batadv # ip link set dev dummy0 master bat0These commands cause the system hang up with the following messages:
[ 90.578925][ T6689] batman_adv: bat0: Adding interface: dummy0 [ 90.580884][ T6689] batman_adv: bat0: The MTU of interface dummy0 is too small (0) to handle the transport of batman-adv packets. Packets going over this interface will be fragmented on layer2 which could impact the performance. Setting the MTU to 1560 would solve the problem. [ 90.586264][ T6689] batman_adv: bat0: Interface activated: dummy0 [ 90.590061][ T6689] batman_adv: bat0: Forced to purge local tt entries to fit new maximum fragment MTU (-320) [ 90.595517][ T6689] batman_adv: bat0: Forced to purge local tt entries to fit new maximum fragment MTU (-320) [ 90.598499][ T6689] batman_adv: bat0: Forced to purge local tt entries to fit new maximum fragment MTU (-320)This patch fixes this issue by returning error when enabling hard-interface with small MTU size.
Signed-off-by Shigeru Yoshida <[email protected]>--- net/batman-adv/hard-interface.c | 3 +++ 1 file changed, 3 insertions(+)net/batman-adv/hard-interface.c +3
-0@@ -700,6 +700,9 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,int max_header_len =batadv_max_header_len ();int ret; +if (hard_iface->net_dev->mtu <ETH_MIN_MTU + max_header_len) +return -EINVAL ; +if (hard_iface->if_status !=BATADV_IF_NOT_IN_USE ) goto out;Signature · 1 line
2.37.2
Sven Eckelmann
maintainerQuoted 1 line · On Wednesday, 7 September 2022 18:00:37 CEST Shigeru Yoshida wrote:
ping?
This was applied a while ago:
https://git.open-mesh.org/linux-merge.git/commit/b1cb8a71f1eaec4eb77051590f7f561f25b15e32
Kind regards,
Sven
Re: [PATCH] batman-adv: Fix hang up with small MTU hard-interface,Re: [PATCH] batman-adv: Fix hang up with small MTU hard-interface
Hi Sven,
Quoted 6 lines · Sven Eckelmann
Quoted 1 line · On Wednesday, 7 September 2022 18:00:37 CEST Shigeru Yoshida wrote:
ping?
This was applied a while ago:
https://git.open-mesh.org/linux-merge.git/commit/b1cb8a71f1eaec4eb77051590f7f561f25b15e32
Sorry, I didn't notice that. Thank you so much!!
Thanks,
Shigeru
Quoted 3 lines
Kind regards,
Sven