utils/genrandconfig: add jquery-ui-themes handling
PATCH 1/1 utils/genrandconfig: add jquery-ui-themes handling
Add a custom case to make sure that a random configuration with an empty theme for jquery-ui-themes doesn't fail. It reverts to BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE in that case.
Fixes:
- http://autobuild.buildroot.org/results/b38f605795b1c60d8253313ce9478c4b1991d390
--- utils/genrandconfig | 5 +++++ 1 file changed, 5 insertions(+)
utils/genrandconfig +5 -0
@@ -547,6 +547,11 @@ def fixup_config(sysinfo, configfile): if 'BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT=y\n' in configlines: return False + if 'BR2_PACKAGE_JQUERY_UI_THEMES=y\n' in configlines and \ + 'BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n' in configlines: + configlines.append('BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y\n') + configlines.remove('BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n') + if 'BR2_TARGET_OPENSBI=y\n' in configlines and \ 'BR2_TARGET_OPENSBI_CUSTOM_GIT=y\n' in configlines and \ 'BR2_TARGET_OPENSBI_CUSTOM_REPO_URL=""\n' in configlines:
Signature · 6 lines
2.35.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
On 2022-08-20 13:33 +0200, Fabrice Fontaine spake thusly:
Quoted 17 lines
Add a custom case to make sure that a random configuration with an empty theme for jquery-ui-themes doesn't fail. It reverts to
BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIEin that case.Fixes:
- http://autobuild.buildroot.org/results/b38f605795b1c60d8253313ce9478c4b1991d390Signed-off-by Fabrice Fontaine <[email protected]>--- utils/genrandconfig | 5 +++++ 1 file changed, 5 insertions(+)utils/genrandconfig +0
-0
utils/genrandconfig def fixup_config(sysinfo, configfile): · line 551
Quoted 5 lines
utils/genrandconfig +2
-0@@ -547,6 +547,11 @@ def fixup_config(sysinfo, configfile): if 'BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT=y\n' in configlines: return False + if 'BR2_PACKAGE_JQUERY_UI_THEMES=y\n' in configlines and \ + 'BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n' in configlines:
I am not sure how we can end up with an empty BR2_PACKAGE_JQUERY_UI_THEMES_THEME. Indeed, it is filled from a choice, and unless there is a typo in one of the config options, there are as many defaults for it as there are entries in the choice...
And if you look at the .config file, there is actually something selected in that choice, BR2_PACKAGE_JQUERY_UI_THEMES_VADER=y, but indeed BR2_PACKAGE_JQUERY_UI_THEMES_THEME is not even set. It's not that it is empty, it is not set at all!
So, the .config file is not correct.
So, I think the issue is about fixing genrandconfig to generate .config files that are correct to begin with. Priobably, running "make olddefconfig" before checking the configuration is required? At least, when I do that localy, the .config now properly contains BR2_PACKAGE_JQUERY_UI_THEMES_THEME="vader".
But wait, wait... We already run 'make olddefconfig'! What's going on here?
Regards,
Yann E. MORIN.
Quoted 13 lines
utils/genrandconfig +3
-0+ configlines.append('BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y\n') + configlines.remove('BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n') + if 'BR2_TARGET_OPENSBI=y\n' in configlines and \ 'BR2_TARGET_OPENSBI_CUSTOM_GIT=y\n' in configlines and \ 'BR2_TARGET_OPENSBI_CUSTOM_REPO_URL=""\n' in configlines:Signature · 6 lines
2.35.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Fabrice, All,
On 2022-08-21 11:49 +0200, Yann E. MORIN spake thusly:
Quoted 4 lines
On 2022-08-20 13:33 +0200, Fabrice Fontaine spake thusly:
Quoted 3 lines
Add a custom case to make sure that a random configuration with an empty theme for jquery-ui-themes doesn't fail. It reverts to
BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIEin that case.
[--SNIP--]
Quoted 11 lines
I am not sure how we can end up with an empty
BR2_PACKAGE_JQUERY_UI_THEMES_THEME. Indeed, it is filled from a choice, and unless there is a typo in one of the config options, there are as many defaults for it as there are entries in the choice...And if you look at the .config file, there is actually something selected in that choice, BR2_PACKAGE_JQUERY_UI_THEMES_VADER=y, but indeed
BR2_PACKAGE_JQUERY_UI_THEMES_THEMEis not even set. It's not that it is empty, it is not set at all!So, the .config file is not correct.
Note: there is a known issue, where choices are not randomised when starting of a existing config fragment, like we actually do with randpackageconfig, in which case the first entry in the choice is always selected. But that case still yie;ds a correct .config, where BR2_PACKAGE_JQUERY_UI_THEMES_THEME is indeed set. E.g.:
$ make randconfig # jquery has no depenency, so whatever config we get is OK
$ make randpackageconfig
# after a few iterations, you will end up with: $ grep JQUERY_UI_THEMES .config
BR2_PACKAGE_JQUERY_UI_THEMES=y
BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y
[...]
BR2_PACKAGE_JQUERY_UI_THEMES_THEME="black-tie"So, for fun, I had the following snippet run:
while true; do
./utils/genrandconfig 2>&1 |grep KCONFIG_SEED= if grep -q BR2_PACKAGE_JQUERY_UI_THEMES=y .config; then
echo 'Got JQuery UI themes...'
grep BR2_PACKAGE_JQUERY_UI_THEMES_ .config grep -q BR2_PACKAGE_JQUERY_UI_THEMES_THEME= .config \
|| { echo 'Missing theme...'; break; }
fi
done
All I could eventually get was one instance of indeed non-randomised choice:
Got JQuery UI themes... BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y
# BR2_PACKAGE_JQUERY_UI_THEMES_BLITZER is not set # BR2_PACKAGE_JQUERY_UI_THEMES_CUPERTINO is not set # BR2_PACKAGE_JQUERY_UI_THEMES_DARK_HIVE is not set # BR2_PACKAGE_JQUERY_UI_THEMES_DOT_LUV is not set # BR2_PACKAGE_JQUERY_UI_THEMES_EGGPLANT is not set # BR2_PACKAGE_JQUERY_UI_THEMES_EXCITE_BIKE is not set # BR2_PACKAGE_JQUERY_UI_THEMES_FLICK is not set # BR2_PACKAGE_JQUERY_UI_THEMES_HOT_SNEAKS is not set # BR2_PACKAGE_JQUERY_UI_THEMES_HUMANITY is not set # BR2_PACKAGE_JQUERY_UI_THEMES_LE_FROG is not set # BR2_PACKAGE_JQUERY_UI_THEMES_MINT_CHOC is not set # BR2_PACKAGE_JQUERY_UI_THEMES_OVERCAST is not set # BR2_PACKAGE_JQUERY_UI_THEMES_PEPPER_GRINDER is not set # BR2_PACKAGE_JQUERY_UI_THEMES_REDMOND is not set # BR2_PACKAGE_JQUERY_UI_THEMES_SMOOTHNESS is not set # BR2_PACKAGE_JQUERY_UI_THEMES_SOUTH_STREET is not set # BR2_PACKAGE_JQUERY_UI_THEMES_START is not set # BR2_PACKAGE_JQUERY_UI_THEMES_SUNNY is not set # BR2_PACKAGE_JQUERY_UI_THEMES_SWANKY_PURSE is not set # BR2_PACKAGE_JQUERY_UI_THEMES_TRONTASTIC is not set # BR2_PACKAGE_JQUERY_UI_THEMES_UI_DARKNESS is not set # BR2_PACKAGE_JQUERY_UI_THEMES_UI_LIGHTNESS is not set # BR2_PACKAGE_JQUERY_UI_THEMES_VADER is not set BR2_PACKAGE_JQUERY_UI_THEMES_THEME="black-tie"
Also, the script ran for more than two hours before I stopped it, and jquery UI themes was seldom selectedonly two out of hundreds of configurations had it... I've restarted it and will let it spin for a while...
So, I am very puzzled as to why and how we would ever get an unset BR2_PACKAGE_JQUERY_UI_THEMES_THEME...
Regards,
Yann E. MORIN.
Quoted 37 lines
So, I think the issue is about fixing genrandconfig to generate .config files that are correct to begin with. Priobably, running "make olddefconfig" before checking the configuration is required? At least, when I do that localy, the .config now properly contains BR2_PACKAGE_JQUERY_UI_THEMES_THEME="vader".
But wait, wait... We already run 'make olddefconfig'! What's going on here?
Regards,
Yann E. MORIN.Quoted 13 lines
utils/genrandconfig +3
-0+ configlines.append('BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y\n') + configlines.remove('BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n') + if 'BR2_TARGET_OPENSBI=y\n' in configlines and \ 'BR2_TARGET_OPENSBI_CUSTOM_GIT=y\n' in configlines and \ 'BR2_TARGET_OPENSBI_CUSTOM_REPO_URL=""\n' in configlines:Signature · 6 lines
2.35.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildrootSignature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Fabrice, All,
On 2022-08-21 14:03 +0200, Yann E. MORIN spake thusly:
Quoted 17 lines
On 2022-08-21 11:49 +0200, Yann E. MORIN spake thusly:
Quoted 4 lines
On 2022-08-20 13:33 +0200, Fabrice Fontaine spake thusly:
Quoted 3 lines
Add a custom case to make sure that a random configuration with an empty theme for jquery-ui-themes doesn't fail. It reverts to
BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIEin that case.[--SNIP--]
Quoted 11 lines
I am not sure how we can end up with an empty
BR2_PACKAGE_JQUERY_UI_THEMES_THEME. Indeed, it is filled from a choice, and unless there is a typo in one of the config options, there are as many defaults for it as there are entries in the choice...And if you look at the .config file, there is actually something selected in that choice, BR2_PACKAGE_JQUERY_UI_THEMES_VADER=y, but indeed
BR2_PACKAGE_JQUERY_UI_THEMES_THEMEis not even set. It's not that it is empty, it is not set at all!So, the .config file is not correct.
[--SNIP--]
Quoted 10 lines
So, for fun, I had the following snippet run:
while true; do
./utils/genrandconfig 2>&1 |grep KCONFIG_SEED= if grep -q BR2_PACKAGE_JQUERY_UI_THEMES=y .config; then
echo 'Got JQuery UI themes...'
grepBR2_PACKAGE_JQUERY_UI_THEMES_.config grep -q BR2_PACKAGE_JQUERY_UI_THEMES_THEME= .config \
|| { echo 'Missing theme...'; break; }
fi
done
This has now been running for almost 48 hours straight, and there has been 10005 configs generated, 55 with BR2_PACKAGE_JQUERY_UI_THEMES enabled, of which none with BR2_PACKAGE_JQUERY_UI_THEMES_THEME unset.
Regards,
Yann E. MORIN.
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 32 lines · Yann E. MORIN
Fabrice, All,
On 2022-08-21 14:03 +0200, Yann E. MORIN spake thusly:
Quoted 17 lines
On 2022-08-21 11:49 +0200, Yann E. MORIN spake thusly:
Quoted 4 lines
On 2022-08-20 13:33 +0200, Fabrice Fontaine spake thusly:
Quoted 3 lines
Add a custom case to make sure that a random configuration with an empty theme for jquery-ui-themes doesn't fail. It reverts to
BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIEin that case.[--SNIP--]
Quoted 11 lines
I am not sure how we can end up with an empty
BR2_PACKAGE_JQUERY_UI_THEMES_THEME. Indeed, it is filled from a choice, and unless there is a typo in one of the config options, there are as many defaults for it as there are entries in the choice...And if you look at the .config file, there is actually something selected in that choice, BR2_PACKAGE_JQUERY_UI_THEMES_VADER=y, but indeed
BR2_PACKAGE_JQUERY_UI_THEMES_THEMEis not even set. It's not that it is empty, it is not set at all!So, the .config file is not correct.
[--SNIP--]
Quoted 10 lines
So, for fun, I had the following snippet run:
while true; do
./utils/genrandconfig 2>&1 |grep KCONFIG_SEED= if grep -q BR2_PACKAGE_JQUERY_UI_THEMES=y .config; then
echo 'Got JQuery UI themes...'
grepBR2_PACKAGE_JQUERY_UI_THEMES_.config grep -q BR2_PACKAGE_JQUERY_UI_THEMES_THEME= .config \
|| { echo 'Missing theme...'; break; }
fi
done
Quoted 3 lines
This has now been running for almost 48 hours straight, and there has been 10005 configs generated, 55 with
BR2_PACKAGE_JQUERY_UI_THEMESenabled, of which none withBR2_PACKAGE_JQUERY_UI_THEMES_THEMEunset.
Isn't it simply fixed by commit f008c74061e604069d9716ac97d2a3f78c9f00b3 ? The
autobuild failure didn't contain that commit yet.
Patch marked as superseded.
Regards,
Arnout
Quoted 4 lines
Regards,
Yann E. MORIN.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
ARnout, All,
On 2022-08-23 22:14 +0200, Arnout Vandecappelle spake thusly:
Quoted 1 line · Yann E. MORIN
[--SNIP--]
Quoted 5 lines
Quoted 3 lines
This has now been running for almost 48 hours straight, and there has been 10005 configs generated, 55 with
BR2_PACKAGE_JQUERY_UI_THEMESenabled, of which none withBR2_PACKAGE_JQUERY_UI_THEMES_THEMEunset.Isn't it simply fixed by commit
f008c74061e604069d9716ac97d2a3f78c9f00b3?
The autobuild failure didn't contain that commit yet.
Damn. I only ever looked at the genrandconfig git log, and did not even think about looking at the pacgae log. Sigh...
Thanks for the heads-up.
Regards,
Yann E. MORIN.
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot