riscv: compat: s/failed/unsupported if compat mode isn't supported
PATCH 1/1 riscv: compat: s/failed/unsupported if compat mode isn't supported
When compat mode isn't supported(I believe this is the most case now), kernel will emit somthing as:
[ 0.050407] riscv: ELF compat mode failed
This msg may make users think there's something wrong with the kernel itself, replace "failed" with "unsupported" to make it clear. In fact this is the real compat_mode_supported meaning. After the patch, the msg would be:
[ 0.050407] riscv: ELF compat mode unsupported
--- arch/riscv/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/kernel/process.c +1 -1
@@ -105,7 +105,7 @@ static int __init compat_mode_detect(void)csr_write (CSR_STATUS , tmp);pr_info ("riscv: ELF compat mode %s" , - compat_mode_supported ?"supported" :"failed" ); + compat_mode_supported ?"supported" :"unsupported" );return 0 ; }
Signature · 1 line
2.34.1
Quoted 7 lines · Jisheng Zhang
When compat mode isn't supported(I believe this is the most case now), kernel will emit somthing as:
[ 0.050407] riscv: ELF compat mode failedThis msg may make users think there's something wrong with the kernel itself, replace "failed" with "unsupported" to make it clear. In fact
Quoted 25 lines
this is the real
compat_mode_supportedmeaning. After the patch, the msg would be:[ 0.050407] riscv: ELF compat mode unsupportedSigned-off-by Jisheng Zhang <[email protected]>--- arch/riscv/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/kernel/process.c +1
-2@@ -105,7 +105,7 @@ static int __init compat_mode_detect(void)csr_write (CSR_STATUS , tmp);pr_info ("riscv: ELF compat mode %s" , - compat_mode_supported ?"supported" :"failed" ); + compat_mode_supported ?"supported" :"unsupported" );return 0 ; } --2.34.1
Signature · 2 lines
Best Regards Guo Ren
Palmer Dabbelt
maintainerQuoted 20 lines · On Sun, 21 Aug 2022 07:18:19 PDT (-0700), [email protected] wrote:
When compat mode isn't supported(I believe this is the most case now), kernel will emit somthing as:
[ 0.050407] riscv: ELF compat mode failedThis msg may make users think there's something wrong with the kernel itself, replace "failed" with "unsupported" to make it clear. In fact this is the real
compat_mode_supportedmeaning. After the patch, the msg would be:[ 0.050407] riscv: ELF compat mode unsupportedSigned-off-by Jisheng Zhang <[email protected]>--- arch/riscv/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/kernel/process.c +0
-0
arch/riscv/kernel/process.c static int __init compat_mode_detect(void) · line 111
Quoted 8 lines
arch/riscv/kernel/process.c +1
-1@@ -105,7 +105,7 @@ static int __init compat_mode_detect(void)csr_write (CSR_STATUS , tmp);pr_info ("riscv: ELF compat mode %s" , - compat_mode_supported ?"supported" :"failed" ); + compat_mode_supported ?"supported" :"unsupported" );return 0 ; }
Thanks, this is on for-next.