kunit: fix assert_type for KUNIT_EXPECT_LE_MSG()
PATCH 1/1 kunit: fix assert_type for KUNIT_EXPECT_LE_MSG()
When replacing KUNIT_BINARY_LE_MSG_ASSERTION() with KUNIT_BINARY_INT_ASSERTION() for KUNIT_EXPECT_LE_MSG(), the assert_type parameter was changed from KUNIT_EXPECTATION to KUNIT_ASSERTION. This causes KUNIT_EXPECT_LE_MSG() and KUNIT_ASSERT_LE_MSG() to behave the same way, and tests after a failed KUNIT_EXPECT_LE_MSG() are not run.
Call KUNIT_BINARY_INT_ASSERTIO() with KUNIT_EXPECTATION for again match the documented behavior for KUNIT_EXPECT_* macros.
--- include/kunit/test.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/kunit/test.h +1 -1
@@ -826,7 +826,7 @@ do { \#define KUNIT_EXPECT_LE_MSG (test, left, right, fmt, ...) \ KUNIT_BINARY_INT_ASSERTION(test, \ - KUNIT_ASSERTION, \ + KUNIT_EXPECTATION, \ left, <=, right, \ fmt, \ ##__VA_ARGS__)
Signature · 1 line
2.37.2
Hi everyone,
Quoted 6 lines · Sander Vanheule
When replacing
KUNIT_BINARY_LE_MSG_ASSERTION()withKUNIT_BINARY_INT_ASSERTION()forKUNIT_EXPECT_LE_MSG(), theassert_typeparameter was changed fromKUNIT_EXPECTATIONto KUNIT_ASSERTION. This causesKUNIT_EXPECT_LE_MSG()andKUNIT_ASSERT_LE_MSG()to behave the same way, and tests after a failedKUNIT_EXPECT_LE_MSG()are not run.
Quoted 6 lines
Call
KUNIT_BINARY_INT_ASSERTIO()withKUNIT_EXPECTATIONfor again match the documented behavior for KUNIT_EXPECT_* macros.Fixes 40f39777ce4f ("kunit: decrease macro layering for integer asserts")Signed-off-by Sander Vanheule <[email protected]>---
My apologies for the sloppiness, but I accidentally sent out an incomplete version of this patch. Please disregards this patch, v2 is already posted.
Sorry for the noise!
Best,
Sander
Quoted 24 lines
include/kunit/test.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)include/kunit/test.h +0
-0@@ -826,7 +826,7 @@ do { \
#defineKUNIT_EXPECT_LE_MSG(test, left, right, fmt, ...)\
KUNIT_BINARY_INT_ASSERTION(test,
\
-KUNIT_ASSERTION, \
+KUNIT_EXPECTATION, \
left, <=, right, \
fmt,
\
##__VA_ARGS__)