thermal/drivers/qcom: Drop false build dependency of all QCOM drivers on QCOM_TSENS
PATCH 1/1 thermal/drivers/qcom: Drop false build dependency of all QCOM drivers on QCOM_TSENS
From: Jonathan Cameron <[email protected]>
The SPMI QCOM drivers have no dependency in Kconfig, but the Makefile will not be included without QCOM_TSENS. This unnecessarily reduces build coverage.
---
Run into whilst trying to build test a namespace move for the IIO interfaces used in these drivers.
Maintainers entry for TSENS should probably also be made more specific.
--- drivers/thermal/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/Makefile +1 -1
@@ -52,7 +52,7 @@ obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o obj-y += intel/ obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/ obj-y += st/ -obj-$(CONFIG_QCOM_TSENS) += qcom/ +obj-y += qcom/ obj-y += tegra/ obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o
Signature · 1 line
2.37.2
Hi,
Quoted 6 lines · Jonathan Cameron
From: Jonathan Cameron <[email protected]>
The SPMI QCOM drivers have no dependency in
Kconfig, but theMakefilewill not be included withoutQCOM_TSENS. This unnecessarily reduces build coverage.
Quoted 7 lines
Signed-off-by Jonathan Cameron <[email protected]>Cc Dmitry Baryshkov <[email protected]>Cc Bhupesh Sharma <[email protected]>---
Run into whilst trying to build test a namespace move for the IIO interfaces used in these drivers.
Good catch. Actually, I am working on a detailed cleanup of the Makefile, Kconfig and Maintainers entries for qcom thermal driver entries as in the present form having all entries inside qcom/ directory dependent on CONFIG_QCOM_TSENS doesn't seem optimal (especially with new driver files being added).
Quoted 11 lines
Maintainers entry for TSENS should probably also be made more specific.
--- drivers/thermal/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thermal/Makefile +0
-0
drivers/thermal/Makefile obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o · line 58
Quoted 8 lines
drivers/thermal/Makefile +1
-1@@ -52,7 +52,7 @@ obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o obj-y += intel/ obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/ obj-y += st/ -obj-$(CONFIG_QCOM_TSENS) += qcom/ +obj-y += qcom/ obj-y += tegra/ obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o
For now, this looks good to me, so:
Thanks.
Quoted 10 lines · Jonathan Cameron
From: Jonathan Cameron <[email protected]>
The SPMI QCOM drivers have no dependency in
Kconfig, but theMakefilewill not be included withoutQCOM_TSENS. This unnecessarily reduces build coverage.Signed-off-by Jonathan Cameron <[email protected]>Cc Dmitry Baryshkov <[email protected]>Cc Bhupesh Sharma <[email protected]>
Quoted 27 lines
---
Run into whilst trying to build test a namespace move for the IIO interfaces used in these drivers.
Maintainers entry for TSENS should probably also be made more specific.
--- drivers/thermal/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thermal/Makefile +1
-2@@ -52,7 +52,7 @@ obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o obj-y += intel/ obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/ obj-y += st/ -obj-$(CONFIG_QCOM_TSENS) += qcom/ +obj-y += qcom/ obj-y += tegra/ obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o --2.37.2