riscv: enable THP_SWAP for RV64
PATCH 1/1 riscv: enable THP_SWAP for RV64
I have a Sipeed Lichee RV dock board which only has 512MB DDR, so memory optimizations such as swap on zram are helpful. As is seen in commit d0637c505f8a ("arm64: enable THP_SWAP for arm64") and commit bd4c82c22c367e ("mm, THP, swap: delay splitting THP after swapped out"), THP_SWAP can improve the swap throughput significantly.
Enable THP_SWAP for RV64, testing the micro-benchmark which is introduced by commit d0637c505f8a ("arm64: enable THP_SWAP for arm64") shows below numbers on the Lichee RV dock board:
thp swp throughput w/o patch: 66908 bytes/ms (mean of 10 tests) thp swp throughput w/ patch: 322638 bytes/ms (mean of 10 tests)
Improved by 382%!
--- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/riscv/Kconfig +1 -0
@@ -45,6 +45,7 @@ config RISCV select ARCH_WANT_FRAME_POINTERS select ARCH_WANT_GENERAL_HUGETLB select ARCH_WANT_HUGE_PMD_SHARE if 64BIT + select ARCH_WANTS_THP_SWAP if TRANSPARENT_HUGEPAGE select BINFMT_FLAT_NO_DATA_START_OFFSET if !MMU select BUILDTIME_TABLE_SORT if MMU select CLONE_BACKWARDS
Signature · 1 line
2.34.1
Quoted 35 lines · Jisheng Zhang
I have a Sipeed Lichee RV dock board which only has 512MB DDR, so memory optimizations such as swap on zram are helpful. As is seen in commit
d0637c505f8a("arm64: enableTHP_SWAPfor arm64") and commitbd4c82c22c367e("mm, THP, swap: delay splitting THP after swapped out"),THP_SWAPcan improve the swap throughput significantly.Enable
THP_SWAPfor RV64, testing the micro-benchmark which is introduced by commitd0637c505f8a("arm64: enableTHP_SWAPfor arm64") shows below numbers on the Lichee RV dock board:thp swp throughput w/o patch: 66908 bytes/ms (mean of 10 tests) thp swp throughput w/ patch: 322638 bytes/ms (mean of 10 tests)
Improved by 382%!
Signed-off-by Jisheng Zhang <[email protected]>--- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+)arch/riscv/Kconfig +1
-0@@ -45,6 +45,7 @@ config RISCV select ARCH_WANT_FRAME_POINTERS select ARCH_WANT_GENERAL_HUGETLB select ARCH_WANT_HUGE_PMD_SHARE if 64BIT + select ARCH_WANTS_THP_SWAP if TRANSPARENT_HUGEPAGE select BINFMT_FLAT_NO_DATA_START_OFFSET if !MMU select BUILDTIME_TABLE_SORT if MMU select CLONE_BACKWARDSSignature · 1 line
2.34.1
That looks like a good idea to me.
Palmer Dabbelt
maintainerQuoted 25 lines · On Sun, 21 Aug 2022 10:05:59 PDT (-0700), [email protected] wrote:
I have a Sipeed Lichee RV dock board which only has 512MB DDR, so memory optimizations such as swap on zram are helpful. As is seen in commit
d0637c505f8a("arm64: enableTHP_SWAPfor arm64") and commitbd4c82c22c367e("mm, THP, swap: delay splitting THP after swapped out"),THP_SWAPcan improve the swap throughput significantly.Enable
THP_SWAPfor RV64, testing the micro-benchmark which is introduced by commitd0637c505f8a("arm64: enableTHP_SWAPfor arm64") shows below numbers on the Lichee RV dock board:thp swp throughput w/o patch: 66908 bytes/ms (mean of 10 tests) thp swp throughput w/ patch: 322638 bytes/ms (mean of 10 tests)
Improved by 382%!
Signed-off-by Jisheng Zhang <[email protected]>--- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+)arch/riscv/Kconfig +0
-0
arch/riscv/Kconfig config RISCV · line 51
Quoted 7 lines
arch/riscv/Kconfig +1
-0@@ -45,6 +45,7 @@ config RISCV select ARCH_WANT_FRAME_POINTERS select ARCH_WANT_GENERAL_HUGETLB select ARCH_WANT_HUGE_PMD_SHARE if 64BIT + select ARCH_WANTS_THP_SWAP if TRANSPARENT_HUGEPAGE select BINFMT_FLAT_NO_DATA_START_OFFSET if !MMU select BUILDTIME_TABLE_SORT if MMU select CLONE_BACKWARDS
Thanks, this is on for-next.
Quoted 21 lines · Palmer Dabbelt
Quoted 20 lines · On Sun, 21 Aug 2022 10:05:59 PDT (-0700), [email protected] wrote:
I have a Sipeed Lichee RV dock board which only has 512MB DDR, so memory optimizations such as swap on zram are helpful. As is seen in commit
d0637c505f8a("arm64: enableTHP_SWAPfor arm64") and commitbd4c82c22c367e("mm, THP, swap: delay splitting THP after swapped out"),THP_SWAPcan improve the swap throughput significantly.Enable
THP_SWAPfor RV64, testing the micro-benchmark which is introduced by commitd0637c505f8a("arm64: enableTHP_SWAPfor arm64") shows below numbers on the Lichee RV dock board:thp swp throughput w/o patch: 66908 bytes/ms (mean of 10 tests) thp swp throughput w/ patch: 322638 bytes/ms (mean of 10 tests)
Improved by 382%!
Signed-off-by Jisheng Zhang <[email protected]>--- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+)
Quoted 14 lines
arch/riscv/Kconfig config RISCV · line 51
Quoted 12 lines
arch/riscv/Kconfig +1
-0@@ -45,6 +45,7 @@ config RISCV select ARCH_WANT_FRAME_POINTERS select ARCH_WANT_GENERAL_HUGETLB select ARCH_WANT_HUGE_PMD_SHARE if 64BIT + select ARCH_WANTS_THP_SWAP if TRANSPARENT_HUGEPAGE select BINFMT_FLAT_NO_DATA_START_OFFSET if !MMU select BUILDTIME_TABLE_SORT if MMU select CLONE_BACKWARDSThanks, this is on for-next.
FYI, this is v1 of a patchset that went to v3.
v3 only changed the commit message, but v2 had a functional change.
v3 is here:
https://lore.kernel.org/all/[email protected]/
Thanks,
Conor.
Palmer Dabbelt
maintainerQuoted 37 lines · On Wed, 05 Oct 2022 23:53:03 PDT (-0700), [email protected] wrote:
Quoted 21 lines · Palmer Dabbelt
Quoted 20 lines · On Sun, 21 Aug 2022 10:05:59 PDT (-0700), [email protected] wrote:
I have a Sipeed Lichee RV dock board which only has 512MB DDR, so memory optimizations such as swap on zram are helpful. As is seen in commit
d0637c505f8a("arm64: enableTHP_SWAPfor arm64") and commitbd4c82c22c367e("mm, THP, swap: delay splitting THP after swapped out"),THP_SWAPcan improve the swap throughput significantly.Enable
THP_SWAPfor RV64, testing the micro-benchmark which is introduced by commitd0637c505f8a("arm64: enableTHP_SWAPfor arm64") shows below numbers on the Lichee RV dock board:thp swp throughput w/o patch: 66908 bytes/ms (mean of 10 tests) thp swp throughput w/ patch: 322638 bytes/ms (mean of 10 tests)
Improved by 382%!
Signed-off-by Jisheng Zhang <[email protected]>--- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+)Quoted 14 lines
arch/riscv/Kconfig config RISCV · line 51
Quoted 12 lines
arch/riscv/Kconfig +1
-0@@ -45,6 +45,7 @@ config RISCV select ARCH_WANT_FRAME_POINTERS select ARCH_WANT_GENERAL_HUGETLB select ARCH_WANT_HUGE_PMD_SHARE if 64BIT + select ARCH_WANTS_THP_SWAP if TRANSPARENT_HUGEPAGE select BINFMT_FLAT_NO_DATA_START_OFFSET if !MMU select BUILDTIME_TABLE_SORT if MMU select CLONE_BACKWARDSThanks, this is on for-next.
Quoted 5 lines
FYI, this is v1 of a patchset that went to v3.
v3 only changed the commit message, but v2 had a functional change.
Thanks, not sure why I missed those. I've put the v3 on for-next.
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv