Skip to contentSkip to conversation

xfs: don't bump the i_version on an atime update in xfs_vn_update_time

PATCH NAK Jeff Layton 2 participants 2 messages Aug 22, 2022

Subsystems (5)
lore
Share & tools
lore

Jeff Layton

author maintainer
#0 lore raw

PATCH v2 1/1 xfs: don't bump the i_version on an atime update in xfs_vn_update_time

xfs will update the i_version when updating only the atime value, which is not desirable for any of the current consumers of i_version. Doing so leads to unnecessary cache invalidations on NFS and extra measurement activity in IMA.

Add a new XFS_ILOG_NOIVER flag, and use that to indicate that the transaction should not update the i_version. Set that value in xfs_vn_update_time if we're only updating the atime.

Cc Dave Chinner <[email protected]>
Cc NeilBrown <[email protected]>
Cc Trond Myklebust <[email protected]>
Cc David Wysochanski <[email protected]>
---
 fs/xfs/libxfs/xfs_log_format.h  |  2 +-
 fs/xfs/libxfs/xfs_trans_inode.c |  2 +-
 fs/xfs/xfs_iops.c               | 11 +++++++++--
 3 files changed, 11 insertions(+), 4 deletions(-)

v2: don't set the NOIVERS flag if S_VERSION is set

fs/xfs/libxfs/xfs_log_format.h +1 -1
index b351b9dc6561..866a4c5cf70c 100644
@@ -323,7 +323,7 @@ struct xfs_inode_log_format_32 {
 #define	XFS_ILOG_ABROOT	0x100	/* log i_af.i_broot */
 #define XFS_ILOG_DOWNER	0x200	/* change the data fork owner on replay */
 #define XFS_ILOG_AOWNER	0x400	/* change the attr fork owner on replay */
-
+#define XFS_ILOG_NOIVER	0x800	/* don't bump i_version */
 
 /*
  * The timestamps are dirty, but not necessarily anything else in the inode
fs/xfs/libxfs/xfs_trans_inode.c +1 -1
index 8b5547073379..ffe6d296e7f9 100644
@@ -126,7 +126,7 @@ xfs_trans_log_inode(
 	 * unconditionally.
 	 */
 	if (!test_and_set_bit(XFS_LI_DIRTY, &iip->ili_item.li_flags)) {
-		if (IS_I_VERSION(inode) &&
+		if (!(flags & XFS_ILOG_NOIVER) && IS_I_VERSION(inode) &&
 		    inode_maybe_inc_iversion(inode, flags & XFS_ILOG_CORE))
 			iversion_flags = XFS_ILOG_CORE;
 	}
fs/xfs/xfs_iops.c +9 -2
index 45518b8c613c..94f14d96641b 100644
@@ -1041,10 +1041,17 @@ xfs_vn_update_time(
 		return error;
 
 	xfs_ilock(ip, XFS_ILOCK_EXCL);
-	if (flags & S_CTIME)
+
+	if (!(flags & S_VERSION))
+		log_flags |= XFS_ILOG_NOIVER;
+	if (flags & S_CTIME) {
 		inode->i_ctime = *now;
-	if (flags & S_MTIME)
+		log_flags &= ~XFS_ILOG_NOIVER;
+	}
+	if (flags & S_MTIME) {
 		inode->i_mtime = *now;
+		log_flags &= ~XFS_ILOG_NOIVER;
+	}
 	if (flags & S_ATIME)
 		inode->i_atime = *now;
 
Signature · 1 line
2.37.2
#1 lore raw
Quoted 9 lines · Jeff Layton

xfs will update the i_version when updating only the atime value, which is not desirable for any of the current consumers of i_version. Doing so leads to unnecessary cache invalidations on NFS and extra measurement activity in IMA.

Add a new XFS_ILOG_NOIVER flag, and use that to indicate that the transaction should not update the i_version. Set that value in xfs_vn_update_time if we're only updating the atime.

Quoted 5 lines
Cc Dave Chinner <[email protected]>
Cc NeilBrown <[email protected]>
Cc Trond Myklebust <[email protected]>
Cc David Wysochanski <[email protected]>

NACK.

We need to define exactly what iversion covers first before we go changing how filesystems update it. We only want to change iversion behaviour once, and we want it done right the first time.

-Dave.

Signature · 2 lines
Dave Chinner
[email protected]