Skip to contentSkip to conversation

clk: tegra: Fix refcount leak in tegra114_clock_init

PATCH Applied Miaoqian Lin 2 participants 2 messages May 23, 2022 – Aug 23, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: tegra: Fix refcount leak in tegra114_clock_init

of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes 2cb5efefd6f7 ("clk: tegra: Implement clocks for Tegra114")
---
 drivers/clk/tegra/clk-tegra114.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/tegra/clk-tegra114.c +1 -0
index ef718c4b3826..f7405a58877e 100644
@@ -1317,6 +1317,7 @@ static void __init tegra114_clock_init(struct device_node *np)
 	}
 
 	pmc_base = of_iomap(node, 0);
+	of_node_put(node);
 	if (!pmc_base) {
 		pr_err("Can't map pmc registers\n");
 		WARN_ON(1);
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw

Quoting Miaoqian Lin (2022-05-23 07:38:34)

Quoted 7 lines

of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes 2cb5efefd6f7 ("clk: tegra: Implement clocks for Tegra114")

---

Applied to clk-next