Skip to contentSkip to conversation

media: dt-bindings: Add missing (unevaluated|additional)Properties on child nodes

PATCH Applied Rob Herring 2 participants 3 messages Aug 23, 2022 – Aug 29, 2022

Subsystems (6)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 media: dt-bindings: Add missing (unevaluated|additional)Properties on child nodes

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

---
 Documentation/devicetree/bindings/media/microchip,csi2dc.yaml   | 2 ++
 Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml | 1 +
 Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml | 1 +
 Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml  | 1 +
 Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml  | 1 +
 Documentation/devicetree/bindings/media/qcom,sdm660-venus.yaml  | 1 +
 .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml         | 1 +
 Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml  | 1 +
 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml  | 1 +
 9 files changed, 10 insertions(+)
Documentation/devicetree/bindings/media/microchip,csi2dc.yaml +2 -0
index e8544fb2d034..b3a345fc6464 100644
@@ -75,6 +75,7 @@ properties:
     properties:
       port@0:
         $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description:
           Input port node, single endpoint describing the input port.
 
@@ -103,6 +104,7 @@ properties:
 
       port@1:
         $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description:
           Output port node, single endpoint describing the output port.
 
Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml +1 -0
index 59ab16ad12f1..2abb7d21c0d1 100644
@@ -68,6 +68,7 @@ properties:
 
   video-firmware:
     type: object
+    additionalProperties: false
 
     description: |
       Firmware subnode is needed when the platform does not
Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml +1 -0
index 199f45217b4a..29d0cb6c6ebe 100644
@@ -95,6 +95,7 @@ properties:
 
   video-firmware:
     type: object
+    additionalProperties: false
 
     description: |
       Firmware subnode is needed when the platform does not
Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml +1 -0
index 90b4af2c9724..42ee3f06c6be 100644
@@ -86,6 +86,7 @@ properties:
 
   video-firmware:
     type: object
+    additionalProperties: false
 
     description: |
       Firmware subnode is needed when the platform does not
Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml +1 -0
index e2874683b4d5..cf361dd9de08 100644
@@ -86,6 +86,7 @@ properties:
 
   video-firmware:
     type: object
+    additionalProperties: false
 
     description: |
       Firmware subnode is needed when the platform does not
Documentation/devicetree/bindings/media/qcom,sdm660-venus.yaml +1 -0
index 33da7d3cfd38..45e3f58f52bd 100644
@@ -104,6 +104,7 @@ properties:
 
   video-firmware:
     type: object
+    additionalProperties: false
 
     description: |
       Firmware subnode is needed when the platform does not
Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml +1 -0
index 177bf81544b1..8edc8a2f43a5 100644
@@ -81,6 +81,7 @@ properties:
 
   video-firmware:
     type: object
+    additionalProperties: false
 
     description: |
       Firmware subnode is needed when the platform does not
Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml +1 -0
index 680f37726fdf..57d503373efe 100644
@@ -96,6 +96,7 @@ properties:
 
   video-firmware:
     type: object
+    additionalProperties: false
 
     description: |
       Firmware subnode is needed when the platform does not
Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml +1 -0
index ebf8f3d866a5..4b7a12523dcf 100644
@@ -92,6 +92,7 @@ properties:
 
   video-firmware:
     type: object
+    additionalProperties: false
 
     description: |
       Firmware subnode is needed when the platform does not
Signature · 1 line
2.34.1
author maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 5 lines · Rob Herring

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

Quoted 12 lines
---
 Documentation/devicetree/bindings/media/microchip,csi2dc.yaml   | 2 ++
 Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml | 1 +
 Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml | 1 +
 Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml  | 1 +
 Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml  | 1 +
 Documentation/devicetree/bindings/media/qcom,sdm660-venus.yaml  | 1 +
 .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml         | 1 +
 Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml  | 1 +
 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml  | 1 +
 9 files changed, 10 insertions(+)

Applied, thanks!