of: unittest: taint the kernel when of unittest runs
PATCH 1/1 of: unittest: taint the kernel when of unittest runs
From: Frank Rowand <[email protected]>
Make OF unittest trigger the new TAINT_TEST taint when OF unittest runs. Due to OF unittest not being intended to run on production systems, and potentially causing problems (or security issues like leaking kernel addresses), the kernel's state should not be considered safe for production use after OF unittest runs.
---
Follow the precedent set by KUnit tests in v6.0-rc1:
commit c272612cb4a2 ("kunit: Taint the kernel when KUnit tests are run") commit 2852ca7fba9f ("panic: Taint kernel if tests are run")
drivers/of/unittest.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/of/unittest.c +3 -0
@@ -3467,6 +3467,9 @@ static int __init of_unittest(void)pr_info ("start of unittest - you will see error messages\n" ); +/* Taint the kernel so we know we've run tests. */ +add_taint (TAINT_TEST ,LOCKDEP_STILL_OK ); +/* adding data for unittest */ if (IS_ENABLED (CONFIG_UML ))
Signature · 1 line
Frank Rowand <[email protected]>
Quoted 9 lines · On Tue, 23 Aug 2022 15:01:52 -0500, [email protected] wrote:
From: Frank Rowand <[email protected]>
Make OF unittest trigger the new
TAINT_TESTtaint when OF unittest runs. Due to OF unittest not being intended to run on production systems, and potentially causing problems (or security issues like leaking kernel addresses), the kernel's state should not be considered safe for production use after OF unittest runs.Signed-off-by Frank Rowand <[email protected]>
Quoted 9 lines
---
Follow the precedent set by KUnit tests in v6.0-rc1:
commitc272612cb4a2("kunit: Taint the kernel when KUnit tests are run") commit2852ca7fba9f("panic: Taint kernel if tests are run")drivers/of/unittest.c | 3 +++ 1 file changed, 3 insertions(+)
Applied, thanks!