selftests: remove unused variable in close_range test
Subsystems (2)
PATCH 1/1 selftests: remove unused variable in close_range test
From: Andrew Delgadillo <[email protected]>
commit 2c5db60e46ad ("tests: add close_range() tests") adds the close_range test under the core namespace. In its current form, the close_range test has an unused variable, namely, ret. For those building with -Werror,-Wall, this breaks the build.
Without this patch:
$ make -C tools/testing/selftests/ TARGETS=core V=1 CFLAGS="-Werror -Wall"
Quoted 4 lines
make: Entering directory '/.../kernel-src/tools/testing/selftests' make[1]: Entering directory '/.../kernel-src/tools/testing/selftests/core'
gcc -Werror -Wallclose_range_test.c-o /.../kernel-src/tools/testing/selftests/core/close_range_testclose_range_test.c: In function 'core_close_range':
Quoted 8 lines
close_range_test.c:55:16: error: unused variable 'ret' [-Werror=unused-variable]
55 | int i, ret;
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [../lib.mk:135: /.../kernel-src/tools/testing/selftests/core/close_range_test] Error 1 make[1]: Leaving directory '/.../kernel-src/tools/testing/selftests/core'
make: *** [Makefile:155: all] Error 2
make: Leaving directory '/.../kernel-src/tools/testing/selftests'
With this patch:
$ make -C tools/testing/selftests/ TARGETS=core V=1 CFLAGS="-Werror -Wall"
Quoted 5 lines
make: Entering directory '/.../kernel-src/tools/testing/selftests' make[1]: Entering directory '/.../kernel-src/tools/testing/selftests/core'
gcc -Werror -Wallclose_range_test.c-o /.../kernel-src/tools/testing/selftests/core/close_range_test
make[1]: Leaving directory '/.../kernel-src/tools/testing/selftests/core'
make: Leaving directory '/.../kernel-src/tools/testing/selftests'
--- tools/testing/selftests/core/close_range_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/core/close_range_test.c +1 -1
@@ -52,7 +52,7 @@ static inline int sys_close_range(unsigned int fd, unsigned int max_fd,TEST (core_close_range) { -int i, ret; +int i;int open_fds[101 ];for (i =0 ; i <ARRAY_SIZE (open_fds); i++) {
Signature · 1 line
2.37.1.595.g718a3a8f04-goog
Quoted 30 lines · Andrew Delgadilo
From: Andrew Delgadillo <[email protected]>
commit
2c5db60e46ad("tests: addclose_range()tests") adds theclose_rangetest under the core namespace. In its current form, theclose_rangetest has an unused variable, namely, ret. For those building with -Werror,-Wall, this breaks the build.Without this patch:
$ make -C tools/testing/selftests/ TARGETS=core V=1 CFLAGS="-Werror -Wall"Quoted 4 lines
make: Entering directory '/.../kernel-src/tools/testing/selftests' make[1]: Entering directory '/.../kernel-src/tools/testing/selftests/core'
gcc -Werror -Wallclose_range_test.c-o /.../kernel-src/tools/testing/selftests/core/close_range_testclose_range_test.c: In function 'core_close_range':Quoted 8 lines
close_range_test.c:55:16: error: unused variable 'ret' [-Werror=unused-variable]
55 | int i, ret;
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [../lib.mk:135: /.../kernel-src/tools/testing/selftests/core/close_range_test] Error 1 make[1]: Leaving directory '/.../kernel-src/tools/testing/selftests/core'
make: *** [Makefile:155: all] Error 2
make: Leaving directory '/.../kernel-src/tools/testing/selftests'With this patch:
$ make -C tools/testing/selftests/ TARGETS=core V=1 CFLAGS="-Werror -Wall"Quoted 5 lines
make: Entering directory '/.../kernel-src/tools/testing/selftests' make[1]: Entering directory '/.../kernel-src/tools/testing/selftests/core'
gcc -Werror -Wallclose_range_test.c-o /.../kernel-src/tools/testing/selftests/core/close_range_test
make[1]: Leaving directory '/.../kernel-src/tools/testing/selftests/core'
make: Leaving directory '/.../kernel-src/tools/testing/selftests'
Quoted 4 lines
Fixes 2c5db60e46ad ("tests: add close_range() tests")Cc <[email protected]>Signed-off-by Andrew Delgadillo <[email protected]>---
Thanks,