Skip to contentSkip to conversation

statx04: skip test on ntfs filesystem

PATCH In review Avinesh Kumar 3 participants 4 messages Aug 24, 2022 – Sep 7, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 statx04: skip test on ntfs filesystem

Fixes #956
Reported-by pragat220
---
 testcases/kernel/syscalls/statx/statx04.c | 1 +
 1 file changed, 1 insertion(+)
testcases/kernel/syscalls/statx/statx04.c +1 -0
index 98f9a6315..3923b7f8e 100644
@@ -132,6 +132,7 @@ static struct tst_test test = {
 	.min_kver = "4.11",
 	.skip_filesystems = (const char *const[]) {
 		"fuse",
+		"ntfs",
 		NULL
 	},
 	.tags = (const struct tst_tag[]) {
Signature · 5 lines
2.37.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Avinesh

I just want to know whether this patch was verified by pragat22 or you?

ps: I don't have environment to test this.

Best Regards
Yang Xu

Quoted 20 lines
Fixes #956
Reported-by pragat220
---
  testcases/kernel/syscalls/statx/statx04.c | 1 +
  1 file changed, 1 insertion(+)
testcases/kernel/syscalls/statx/statx04.c +1 -0
index 98f9a6315..3923b7f8e 100644
@@ -132,6 +132,7 @@ static struct tst_test test = {
  	.min_kver = "4.11",
  	.skip_filesystems = (const char *const[]) {
  		"fuse",
+		"ntfs",
  		NULL
  	},
  	.tags = (const struct tst_tag[]) {
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by
#2 lore raw

Hi all,

@Avinesh: it's always better to put the explanation *why* to git commit message. Adding just a ticket is not enough.

Quoted 6 lines

Hi Avinesh

I just want to know whether this patch was verified by pragat22 or you?

ps: I don't have environment to test this.

You can test it:
# LTP_SINGLE_FS_TYPE=ntfs ./statx04

I have tested this on various systems without setting LTP_SINGLE_FS_TYPE, most of them are skipped due "fuse", but on Alpine with v2022.5.17 (libntfs-3g) it is *not* caught:

# ./statx04
tst_supported_fs_types.c:89: TINFO: Kernel supports ntfs
tst_supported_fs_types.c:51: TINFO: mkfs.ntfs does exist
...
tst_test.c:1599: TINFO: === Testing on ntfs ===
tst_test.c:1064: TINFO: Formatting /dev/loop0 with ntfs opts='' extra opts=''
The partition start sector was not specified for /dev/loop0 and it could not be obtained automatically.  It has been set to 0.
The number of sectors per track was not specified for /dev/loop0 and it could not be obtained automatically.  It has been set to 0.
The number of heads was not specified for /dev/loop0 and it could not be obtained automatically.  It has been set to 0.
To boot from a device, Windows needs the 'partition start sector', the 'sectors per track' and the 'number of heads' to be set.
Windows will not be able to boot from this device.
tst_test.c:1078: TINFO: Trying FUSE...
statx04.c:93: TBROK: Unexpected ioctl() error: EINVAL (22)

Please do not merge this, I've ask the reported for name and email (so that I can put his credential) and also put some extra info (explanation why fuse is not enough).

Kind regards,
Petr

Quoted 22 lines

Best Regards
Yang Xu

Quoted 20 lines
Fixes #956
Reported-by pragat220
---
  testcases/kernel/syscalls/statx/statx04.c | 1 +
  1 file changed, 1 insertion(+)
testcases/kernel/syscalls/statx/statx04.c +1 -0
index 98f9a6315..3923b7f8e 100644
@@ -132,6 +132,7 @@ static struct tst_test test = {
  	.min_kver = "4.11",
  	.skip_filesystems = (const char *const[]) {
  		"fuse",
+		"ntfs",
  		NULL
  	},
  	.tags = (const struct tst_tag[]) {
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Hi,

FYI fix merged.
Thanks!

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp