ceph: increment i_version when doing a setattr with caps
PATCH 1/1 ceph: increment i_version when doing a setattr with caps
When the client has enough caps to satisfy a setattr locally without having to talk to the server, we currently do the setattr without incrementing the change attribute.
Ensure that if the ctime changes locally, then the change attribute does too.
Signed-off-by Jeff Layton <[email protected]>
--- fs/ceph/inode.c | 1 + 1 file changed, 1 insertion(+)
fs/ceph/inode.c +1 -0
@@ -2192,6 +2192,7 @@ int __ceph_setattr(struct inode *inode, struct iattr *attr) inode_dirty_flags =__ceph_mark_dirty_caps (ci, dirtied, &prealloc_cf); inode->i_ctime = attr->ia_ctime; +inode_inc_iversion_raw (inode); } release &= issued;
Signature · 1 line
2.37.2
Quoted 17 lines · Jeff Layton
When the client has enough caps to satisfy a setattr locally without having to talk to the server, we currently do the setattr without incrementing the change attribute.
Ensure that if the ctime changes locally, then the change attribute does too.
Signed-off-by Jeff Layton <[email protected]>--- fs/ceph/inode.c | 1 + 1 file changed, 1 insertion(+)fs/ceph/inode.c +0
-0
fs/ceph/inode.c int __ceph_setattr(struct inode *inode, struct iattr *attr) · line 2198
Quoted 7 lines
fs/ceph/inode.c +1
-0@@ -2192,6 +2192,7 @@ int __ceph_setattr(struct inode *inode, struct iattr *attr) inode_dirty_flags =__ceph_mark_dirty_caps (ci, dirtied, &prealloc_cf); inode->i_ctime = attr->ia_ctime; +inode_inc_iversion_raw (inode); } release &= issued;
Good catch!
Merged into the testing branch.
Thanks!
-- Xiubo