Skip to contentSkip to conversation

kernel-shark: Build missed_event as GUI plugin

PATCH In review Daniel Wagner 2 participants 2 messages Aug 24, 2022 – Aug 26, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel-shark: Build missed_event as GUI plugin

missed_events depends on GUI elements hence it should be build as GUI plugin.

---

I had some build errors due to global build flags in our build service:

Linker flags : -flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now

 src/plugins/CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
src/plugins/CMakeLists.txt +2 -2
index e9d906863424..49aee3ed7560 100644
@@ -61,8 +61,8 @@ if (Qt5Widgets_FOUND AND TT_FONT_FILE)
 
 endif (Qt5Widgets_FOUND AND TT_FONT_FILE)
 
-BUILD_PLUGIN(NAME missed_events
-             SOURCE missed_events.c MissedEvents.cpp)
+BUILD_GUI_PLUGIN(NAME missed_events
+		 SOURCE missed_events.c MissedEvents.cpp)
 list(APPEND PLUGIN_LIST "missed_events")
 
 install(TARGETS ${PLUGIN_LIST}
Signature · 1 line
2.37.1
#1 lore raw

Thanks Daniel!
Yordan

Quoted 28 lines · Daniel Wagner

missed_events depends on GUI elements hence it should be build as GUI plugin.

---

I had some build errors due to global build flags in our build service:

Linker flags : -flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now

  src/plugins/CMakeLists.txt | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
src/plugins/CMakeLists.txt +2 -2
index e9d906863424..49aee3ed7560 100644
@@ -61,8 +61,8 @@ if (Qt5Widgets_FOUND AND TT_FONT_FILE)
 
  endif (Qt5Widgets_FOUND AND TT_FONT_FILE)
 
-BUILD_PLUGIN(NAME missed_events
-             SOURCE missed_events.c MissedEvents.cpp)
+BUILD_GUI_PLUGIN(NAME missed_events
+		 SOURCE missed_events.c MissedEvents.cpp)
  list(APPEND PLUGIN_LIST "missed_events")
 
  install(TARGETS ${PLUGIN_LIST}