Skip to contentSkip to conversation

dt-bindings: arm: coresight: Add 'power-domains' property

PATCH In review Rob Herring 3 participants 5 messages Jul 21, 2022 – Aug 25, 2022

Subsystems (3)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: arm: coresight: Add 'power-domains' property

Coresight components may be in a power domain which is the case for the Arm Juno board. Allow a single 'power-domains' entry for Coresight components.

---
 Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml  | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml   | 3 +++
 .../devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml  | 3 +++
 .../bindings/arm/arm,coresight-dynamic-replicator.yaml         | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml   | 3 +++
 .../devicetree/bindings/arm/arm,coresight-static-funnel.yaml   | 3 +++
 .../bindings/arm/arm,coresight-static-replicator.yaml          | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml   | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml   | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml  | 3 +++
 .../devicetree/bindings/arm/arm,embedded-trace-extension.yaml  | 3 +++
 12 files changed, 36 insertions(+)
Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml +3 -0
index d783d9276124..2bae06eed693 100644
@@ -61,6 +61,9 @@ properties:
     maxItems: 1
     description: Address translation error interrupt
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml +3 -0
index 72ffe4d1e948..0c5b875cb654 100644
@@ -98,6 +98,9 @@ properties:
       base cti node if compatible string arm,coresight-cti-v8-arch is used,
       or may appear in a trig-conns child node when appropriate.
 
+  power-domains:
+    maxItems: 1
+
   arm,cti-ctm-id:
     $ref: /schemas/types.yaml#/definitions/uint32
     description:
Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml +3 -0
index 1eeedc22857c..44a1041cb0fc 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
 
Documentation/devicetree/bindings/arm/arm,coresight-dynamic-replicator.yaml +3 -0
index a26ed9214e00..03792e9bd97a 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   qcom,replicator-loses-context:
     type: boolean
     description:
Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml +3 -0
index fd06ede26ceb..90679788e0bf 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml +3 -0
index e0377ce48537..01200f67504a 100644
@@ -73,6 +73,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   arm,coresight-loses-context-with-cpu:
     type: boolean
     description:
Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml +3 -0
index b9da30ab9ccd..06a1d346982c 100644
@@ -27,6 +27,9 @@ properties:
   compatible:
     const: arm,coresight-static-funnel
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
 
Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml +3 -0
index 66ee97370fb2..5178e7fdff0b 100644
@@ -27,6 +27,9 @@ properties:
   compatible:
     const: arm,coresight-static-replicator
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml +3 -0
index 905008faa012..378380c3f5aa 100644
@@ -61,6 +61,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   out-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml +3 -0
index 3463b6e53aef..e0b88a71356a 100644
@@ -55,6 +55,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   arm,buffer-size:
     $ref: /schemas/types.yaml#/definitions/uint32
     deprecated: true
Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml +3 -0
index e80d48200c37..61a0cdc27745 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml +3 -0
index 5f07fb166c56..108460627d9a 100644
@@ -33,6 +33,9 @@ properties:
       Handle to the cpu this ETE is bound to.
     $ref: /schemas/types.yaml#/definitions/phandle
 
+  power-domains:
+    maxItems: 1
+
   out-ports:
     description: |
       Output connections from the ETE to legacy CoreSight trace bus.
Signature · 1 line
2.34.1
author maintainer
#1 lore raw

PATCH 2/2 dt-bindings: arm: coresight-tmc: Add 'iommu' property

The Coresight TMC component may be behind an IOMMU which is the case for the Arm Juno SoC and some Qualcomm SoCs. Add 'iommus' property to the binding.

---
 Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml +3 -0
index e0b88a71356a..cb8dceaca70e 100644
@@ -55,6 +55,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  iommus:
+    maxItems: 1
+
   power-domains:
     maxItems: 1
 
Signature · 1 line
2.34.1
Reviewed-by on v1 1/2
#2 lore raw
In reply to Rob Herring
Quoted 3 lines · Rob Herring

Coresight components may be in a power domain which is the case for the Arm Juno board. Allow a single 'power-domains' entry for Coresight components.

I assume the maxItems can be changed in case if some platforms have multiple power domains especially for some per CPU coresight ETR/debug components.

But for now, it looks good.

--
Regards,
Sudeep

author maintainer
#3 lore raw
In reply to Rob Herring
Quoted 3 lines · Rob Herring

Coresight components may be in a power domain which is the case for the Arm Juno board. Allow a single 'power-domains' entry for Coresight components.

Ping.

Quoted 188 lines
---
 Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml  | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml   | 3 +++
 .../devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml  | 3 +++
 .../bindings/arm/arm,coresight-dynamic-replicator.yaml         | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml   | 3 +++
 .../devicetree/bindings/arm/arm,coresight-static-funnel.yaml   | 3 +++
 .../bindings/arm/arm,coresight-static-replicator.yaml          | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml   | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml   | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml  | 3 +++
 .../devicetree/bindings/arm/arm,embedded-trace-extension.yaml  | 3 +++
 12 files changed, 36 insertions(+)
Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml +3 -0
index d783d9276124..2bae06eed693 100644
@@ -61,6 +61,9 @@ properties:
     maxItems: 1
     description: Address translation error interrupt
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml +3 -0
index 72ffe4d1e948..0c5b875cb654 100644
@@ -98,6 +98,9 @@ properties:
       base cti node if compatible string arm,coresight-cti-v8-arch is used,
       or may appear in a trig-conns child node when appropriate.
 
+  power-domains:
+    maxItems: 1
+
   arm,cti-ctm-id:
     $ref: /schemas/types.yaml#/definitions/uint32
     description:
Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml +3 -0
index 1eeedc22857c..44a1041cb0fc 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
 
Documentation/devicetree/bindings/arm/arm,coresight-dynamic-replicator.yaml +3 -0
index a26ed9214e00..03792e9bd97a 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   qcom,replicator-loses-context:
     type: boolean
     description:
Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml +3 -0
index fd06ede26ceb..90679788e0bf 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml +3 -0
index e0377ce48537..01200f67504a 100644
@@ -73,6 +73,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   arm,coresight-loses-context-with-cpu:
     type: boolean
     description:
Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml +3 -0
index b9da30ab9ccd..06a1d346982c 100644
@@ -27,6 +27,9 @@ properties:
   compatible:
     const: arm,coresight-static-funnel
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
 
Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml +3 -0
index 66ee97370fb2..5178e7fdff0b 100644
@@ -27,6 +27,9 @@ properties:
   compatible:
     const: arm,coresight-static-replicator
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml +3 -0
index 905008faa012..378380c3f5aa 100644
@@ -61,6 +61,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   out-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml +3 -0
index 3463b6e53aef..e0b88a71356a 100644
@@ -55,6 +55,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   arm,buffer-size:
     $ref: /schemas/types.yaml#/definitions/uint32
     deprecated: true
Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml +3 -0
index e80d48200c37..61a0cdc27745 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml +3 -1
index 5f07fb166c56..108460627d9a 100644
@@ -33,6 +33,9 @@ properties:
       Handle to the cpu this ETE is bound to.
     $ref: /schemas/types.yaml#/definitions/phandle
 
+  power-domains:
+    maxItems: 1
+
   out-ports:
     description: |
       Output connections from the ETE to legacy CoreSight trace bus.
--

2.34.1

#4 lore raw
Quoted 6 lines · Rob Herring
Quoted 3 lines · Rob Herring

Coresight components may be in a power domain which is the case for the Arm Juno board. Allow a single 'power-domains' entry for Coresight components.

Ping.

Somehow this fell through the cracks. I've applied both patches.

Thanks,
Mathieu

Quoted 189 lines
Quoted 189 lines
---
 Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml  | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml   | 3 +++
 .../devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml  | 3 +++
 .../bindings/arm/arm,coresight-dynamic-replicator.yaml         | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml   | 3 +++
 .../devicetree/bindings/arm/arm,coresight-static-funnel.yaml   | 3 +++
 .../bindings/arm/arm,coresight-static-replicator.yaml          | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml   | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml   | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml  | 3 +++
 .../devicetree/bindings/arm/arm,embedded-trace-extension.yaml  | 3 +++
 12 files changed, 36 insertions(+)
Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml +3 -0
index d783d9276124..2bae06eed693 100644
@@ -61,6 +61,9 @@ properties:
     maxItems: 1
     description: Address translation error interrupt
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml +3 -0
index 72ffe4d1e948..0c5b875cb654 100644
@@ -98,6 +98,9 @@ properties:
       base cti node if compatible string arm,coresight-cti-v8-arch is used,
       or may appear in a trig-conns child node when appropriate.
 
+  power-domains:
+    maxItems: 1
+
   arm,cti-ctm-id:
     $ref: /schemas/types.yaml#/definitions/uint32
     description:
Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml +3 -0
index 1eeedc22857c..44a1041cb0fc 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
 
Documentation/devicetree/bindings/arm/arm,coresight-dynamic-replicator.yaml +3 -0
index a26ed9214e00..03792e9bd97a 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   qcom,replicator-loses-context:
     type: boolean
     description:
Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml +3 -0
index fd06ede26ceb..90679788e0bf 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml +3 -0
index e0377ce48537..01200f67504a 100644
@@ -73,6 +73,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   arm,coresight-loses-context-with-cpu:
     type: boolean
     description:
Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml +3 -0
index b9da30ab9ccd..06a1d346982c 100644
@@ -27,6 +27,9 @@ properties:
   compatible:
     const: arm,coresight-static-funnel
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
 
Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml +3 -0
index 66ee97370fb2..5178e7fdff0b 100644
@@ -27,6 +27,9 @@ properties:
   compatible:
     const: arm,coresight-static-replicator
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml +3 -0
index 905008faa012..378380c3f5aa 100644
@@ -61,6 +61,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   out-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml +3 -0
index 3463b6e53aef..e0b88a71356a 100644
@@ -55,6 +55,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   arm,buffer-size:
     $ref: /schemas/types.yaml#/definitions/uint32
     deprecated: true
Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml +3 -0
index e80d48200c37..61a0cdc27745 100644
@@ -54,6 +54,9 @@ properties:
       - const: apb_pclk
       - const: atclk
 
+  power-domains:
+    maxItems: 1
+
   in-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml +3 -1
index 5f07fb166c56..108460627d9a 100644
@@ -33,6 +33,9 @@ properties:
       Handle to the cpu this ETE is bound to.
     $ref: /schemas/types.yaml#/definitions/phandle
 
+  power-domains:
+    maxItems: 1
+
   out-ports:
     description: |
       Output connections from the ETE to legacy CoreSight trace bus.
--

2.34.1