Skip to contentSkip to conversation

dt-bindings: display: adi,adv75xx: Add missing graph schema references

PATCH Applied Rob Herring 3 participants 4 messages Aug 23, 2022 – Aug 25, 2022

Subsystems (4)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: display: adi,adv75xx: Add missing graph schema references

DT bindings using the graph binding must have references to the graph binding schema. These are missing from the adi,adv7511 and adi,adv7533 bindings, so add them.

---
 .../bindings/display/bridge/adi,adv7511.yaml       | 14 ++++++--------
 .../bindings/display/bridge/adi,adv7533.yaml       | 14 ++++++--------
 2 files changed, 12 insertions(+), 16 deletions(-)
Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml +6 -8
index f08a01dfedf3..5bbe81862c8f 100644
@@ -117,23 +117,21 @@ properties:
 
   ports:
     description:
-      The ADV7511(W)/13 has two video ports and one audio port. This node
-      models their connections as documented in
-      Documentation/devicetree/bindings/media/video-interfaces.txt
-      Documentation/devicetree/bindings/graph.txt
-    type: object
+      The ADV7511(W)/13 has two video ports and one audio port.
+    $ref: /schemas/graph.yaml#/properties/ports
+
     properties:
       port@0:
         description: Video port for the RGB or YUV input.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
       port@1:
         description: Video port for the HDMI output.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
       port@2:
         description: Audio port for the HDMI output.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
 # adi,input-colorspace and adi,input-clock are required except in
 # "rgb 1x" and "yuv444 1x" modes, in which case they must not be
Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml +6 -8
index f36209137c8a..987aa83c2649 100644
@@ -91,25 +91,23 @@ properties:
 
   ports:
     description:
-      The ADV7533/35 has two video ports and one audio port. This node
-      models their connections as documented in
-      Documentation/devicetree/bindings/media/video-interfaces.txt
-      Documentation/devicetree/bindings/graph.txt
-    type: object
+      The ADV7533/35 has two video ports and one audio port.
+    $ref: /schemas/graph.yaml#/properties/ports
+
     properties:
       port@0:
         description:
           Video port for the DSI input. The remote endpoint phandle
           should be a reference to a valid mipi_dsi_host_device.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
       port@1:
         description: Video port for the HDMI output.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
       port@2:
         description: Audio port for the HDMI output.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
 required:
   - compatible
Signature · 1 line
2.34.1
reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring

Hi Rob,

Thank you for the patch.

Quoted 5 lines · Rob Herring

DT bindings using the graph binding must have references to the graph binding schema. These are missing from the adi,adv7511 and adi,adv7533 bindings, so add them.

Quoted 75 lines
---
 .../bindings/display/bridge/adi,adv7511.yaml       | 14 ++++++--------
 .../bindings/display/bridge/adi,adv7533.yaml       | 14 ++++++--------
 2 files changed, 12 insertions(+), 16 deletions(-)
Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml +6 -8
index f08a01dfedf3..5bbe81862c8f 100644
@@ -117,23 +117,21 @@ properties:
 
   ports:
     description:
-      The ADV7511(W)/13 has two video ports and one audio port. This node
-      models their connections as documented in
-      Documentation/devicetree/bindings/media/video-interfaces.txt
-      Documentation/devicetree/bindings/graph.txt
-    type: object
+      The ADV7511(W)/13 has two video ports and one audio port.
+    $ref: /schemas/graph.yaml#/properties/ports
+
     properties:
       port@0:
         description: Video port for the RGB or YUV input.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
       port@1:
         description: Video port for the HDMI output.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
       port@2:
         description: Audio port for the HDMI output.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
 # adi,input-colorspace and adi,input-clock are required except in
 # "rgb 1x" and "yuv444 1x" modes, in which case they must not be
Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml +6 -8
index f36209137c8a..987aa83c2649 100644
@@ -91,25 +91,23 @@ properties:
 
   ports:
     description:
-      The ADV7533/35 has two video ports and one audio port. This node
-      models their connections as documented in
-      Documentation/devicetree/bindings/media/video-interfaces.txt
-      Documentation/devicetree/bindings/graph.txt
-    type: object
+      The ADV7533/35 has two video ports and one audio port.
+    $ref: /schemas/graph.yaml#/properties/ports
+
     properties:
       port@0:
         description:
           Video port for the DSI input. The remote endpoint phandle
           should be a reference to a valid mipi_dsi_host_device.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
       port@1:
         description: Video port for the HDMI output.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
       port@2:
         description: Audio port for the HDMI output.
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
 
 required:
   - compatible
Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer Applied
#3 lore raw
In reply to Rob Herring
Quoted 10 lines · Rob Herring

DT bindings using the graph binding must have references to the graph binding schema. These are missing from the adi,adv7511 and adi,adv7533 bindings, so add them.

---
 .../bindings/display/bridge/adi,adv7511.yaml       | 14 ++++++--------
 .../bindings/display/bridge/adi,adv7533.yaml       | 14 ++++++--------
 2 files changed, 12 insertions(+), 16 deletions(-)

Applied, thanks!