Skip to contentSkip to conversation

getpagesize01: Rewrite using new LTP API

PATCH In review Avinesh Kumar 2 participants 2 messages Aug 26, 2022 – Aug 31, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 getpagesize01: Rewrite using new LTP API

---
 .../syscalls/getpagesize/getpagesize01.c      | 112 +++---------------
 1 file changed, 18 insertions(+), 94 deletions(-)
testcases/kernel/syscalls/getpagesize/getpagesize01.c +18 -94
index 0d0465827..eb1f3d2b1 100644
@@ -1,105 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright (c) International Business Machines  Corp., 2005
+ *   Robbie Williamson <[email protected]>
  * Copyright (c) Wipro Technologies Ltd, 2005.  All Rights Reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it would be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
- *
+ *   Prashant P Yendigeri <[email protected]>
+ * Copyright (c) 2022 SUSE LLC Avinesh Kumar <[email protected]>
  */
-/**********************************************************
- *
- *    TEST IDENTIFIER   : getpagesize01
- *
- *    EXECUTED BY       : root / superuser
- *
- *    TEST TITLE        : Basic tests for getpagesize(2)
- *
- *    TEST CASE TOTAL   : 1
- *
- *    AUTHOR            : Prashant P Yendigeri
- *                        <[email protected]>
- *			  Robbie Williamson
- *			  <[email protected]>
- *
- *    DESCRIPTION
- *      This is a Phase I test for the getpagesize(2) system call.
- *      It is intended to provide a limited exposure of the system call.
- *
- **********************************************************/
-
-#include <stdio.h>
-#include <unistd.h>
-#include <errno.h>
-
-#include "test.h"
-
-void setup();
-void cleanup();
-
-char *TCID = "getpagesize01";
-int TST_TOTAL = 1;
 
-int main(int ac, char **av)
-{
-	int lc;
-
-	int size, ret_sysconf;
-	/***************************************************************
-	 * parse standard options
-	 ***************************************************************/
-	tst_parse_opts(ac, av, NULL, NULL);
-
-	setup();
-
-	for (lc = 0; TEST_LOOPING(lc); lc++) {
-
-		tst_count = 0;
-
-		TEST(getpagesize());
-
-		if (TEST_RETURN == -1) {
-			tst_resm(TFAIL | TTERRNO, "getpagesize failed");
-			continue;	/* next loop for MTKERNEL */
-		}
-
-		size = getpagesize();
-		tst_resm(TINFO, "Page Size is %d", size);
-		ret_sysconf = sysconf(_SC_PAGESIZE);
-#ifdef DEBUG
-		tst_resm(TINFO,
-			 "Checking whether getpagesize returned same as sysconf");
-#endif
-		if (size == ret_sysconf)
-			tst_resm(TPASS,
-				 "getpagesize - Page size returned %d",
-				 ret_sysconf);
-		else
-			tst_resm(TFAIL,
-				 "getpagesize - Page size returned %d",
-				 ret_sysconf);
-	}
+/*\
+ * [Description]
+ *
+ * Verify that getpagesize(2) returns the number of bytes in a
+ * memory page as expected.
+ */
 
-	cleanup();
-	tst_exit();
-}
+#include "tst_test.h"
 
-void setup(void)
+static void run(void)
 {
+	int pagesize_sysconf;
 
-	tst_sig(NOFORK, DEF_HANDLER, cleanup);
-
-	TEST_PAUSE;
+	pagesize_sysconf = sysconf(_SC_PAGESIZE);
+	TST_EXP_VAL(getpagesize(), pagesize_sysconf);
 }
 
-void cleanup(void)
-{
-}
+static struct tst_test test = {
+	.test_all = run
+};
Signature · 5 lines
2.37.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Patch applied, thanks!

Signature · 2 lines
Regards,
Li Wang
Signature · 2 lines
-- 
Mailing list info: https://lists.linux.it/listinfo/ltp