Convert NFS with fscache to the netfs API
Subsystems (2)
v2 cover Convert NFS with fscache to the netfs API
This patchset converts NFS with fscache non-direct READ IO paths to use the netfs API with a non-invasive approach. The existing NFS pgio layer does not need extensive changes, and is the best way so far I've found to address Trond's concerns about modifying the IO path [1] as well as only enabling netfs when fscache is configured and enabled [2]. I have not yet attempted performance comparisions to address Chuck Lever's concern [3], though this is probably less of a concern now, since netfs is not used unless fscache is configured and enabled.
The main patch to be reviewed is patch #3 which converts nfs_read_folio and nfs_readahead.
Changes since v1
- PATCH 2,3: #ifdef CONFIG_NFS_FSCACHE all netfs bits
- PATCH 3: Minimize changes to nfs_read_folio
- PATCH 3: Add spinlock around updating of RPC accounting info inside nfs_complete_read (this resolved previous hang issue #3 on generic/075)
The patches are moving in the right direction, and is the best I have come up with so far to move things forward. The patches are fairly stable as evidenced with xfstests generic with various servers. The known issues are as follows:
1. Unit test setting rsize < readahead does not properly read from fscache but re-reads data from the NFS server
* This will be fixed once another linux-cachefs [4] patch to resolve "Stop read optimisation when folio removed from pagecache"
2. "Cache volume key already in use" after xfstest runs
* xfstests (hammerspace with vers=4.2,fsc) shows the following on the
console after some tests:
"NFS: Cache volume key already in use (nfs,4.1,2,c50,cfe0100a,3,,,8000,100000,100000,bb8,ea60,7530,ea60,1)"
* This may be fixed with another patch [4] that is in progress
3. Hang with xfstests involving directIO writes + reads
* seen with NFSv4.1, NetApp (ontap9) NFS server
* seen one time with generic/209, one time with generic/451
* root of the problem is the added netfs RPC accounting is not handling read errors such as BAD_STATEID properly; might need to move the logic to anothe location such as nfs_initiate_read() and nfs_readpage_done()
4. Data corruption seen with unit test where rsize < readahead
* Seen with vanilla 6.0-rc2 (did not occur on 5.19); likely unrelated
to this patchset
mount -o vers=4.2,fsc,rsize=8192 127.0.0.1:/export /mnt
dd if=/dev/urandom of=/tmp/integrity-rsize-file1.bin bs=16k count=1
./nfs-readahead.sh set /mnt 16384
dd if=/tmp/integrity-rsize-file1.bin of=/mnt/integrity-rsize-file1.bin bs=16k count=1
echo 3 > /proc/sys/vm/drop_caches
md5sum /mnt/integrity-rsize-file1.bin /tmp/integrity-rsize-file1.bin
md5sums don't match, MD5_NFS = 00eaf1a5bc1b3dfd54711db551619afa != MD5_LOCAL = e8d835c83ba1f1264869dc40673fa20c
The patchset is based on 6.0-rc2 and has been pushed to github at:
https://github.com/DaveWysochanskiRH/kernel/commits/nfs-fscache-netfs
[1] https://lore.kernel.org/linux-nfs/[email protected]/
[2] https://lore.kernel.org/linux-nfs/[email protected]/
[3] https://marc.info/?l=linux-nfs&m=160597917525083&w=4
[4] https://www.mail-archive.com/[email protected]/msg03043.html
[5] https://marc.info/?l=linux-nfs&m=165962662200679&w=4
Dave Wysochanski (3):
NFS: Rename readpage_async_filler to nfs_pageio_add_page
NFS: Add support for netfs in struct nfs_inode and Kconfig
NFS: Convert nfs_read_folio and nfs_readahead to netfs APIs
fs/nfs/Kconfig | 1 + fs/nfs/delegation.c | 2 +- fs/nfs/dir.c | 2 +- fs/nfs/fscache.c | 191 ++++++++++++++++++--------------------- fs/nfs/fscache.h | 77 ++++++++-------- fs/nfs/inode.c | 8 +- fs/nfs/internal.h | 10 +- fs/nfs/pagelist.c | 14 +++ fs/nfs/pnfs.c | 12 +-- fs/nfs/read.c | 117 ++++++++---------------- fs/nfs/write.c | 2 +- include/linux/nfs_fs.h | 19 +--- include/linux/nfs_page.h | 1 + include/linux/nfs_xdr.h | 1 + 14 files changed, 210 insertions(+), 247 deletions(-)
Signature · 1 line
2.31.1
RFC PATCH v2 1/3 NFS: Rename readpage_async_filler to nfs_pageio_add_page
Rename readpage_async_filler to nfs_pageio_add_page to better reflect what this function does (add a page to the nfs_pageio_descriptor), and simplify arguments to this function by removing struct nfs_readdesc.
--- fs/nfs/read.c | 60 +++++++++++++++++++++++++-------------------------- 1 file changed, 30 insertions(+), 30 deletions(-)
fs/nfs/read.c +30 -30
@@ -127,11 +127,6 @@ static void nfs_readpage_release(struct nfs_page *req, int error)nfs_release_request (req); } -struct nfs_readdesc { -struct nfs_pageio_descriptor pgio; -struct nfs_open_context *ctx; -}; -static void nfs_page_group_set_uptodate (struct nfs_page *req) {if (nfs_page_group_sync_on_bit (req,PG_UPTODATE ))
@@ -153,7 +148,8 @@ static void nfs_read_completion(struct nfs_pgio_header *hdr)if (test_bit (NFS_IOHDR_EOF , &hdr->flags)) {/* note: regions of the page not covered by a -* request are zeroed in readpage_async_filler */ +* request are zeroed in nfs_pageio_add_page +*/ if (bytes > hdr->good_bytes) {/* nothing in this request was good, so zero * the full extent of the request */
@@ -281,8 +277,10 @@ static void nfs_readpage_result(struct rpc_task *task,nfs_readpage_retry (task, hdr); } -static int -readpage_async_filler (struct nfs_readdesc *desc,struct page *page) +int +nfs_pageio_add_page (struct nfs_pageio_descriptor *pgio, +struct nfs_open_context *ctx, +struct page *page) {struct inode *inode =page_file_mapping (page)->host;unsigned int rsize =NFS_SERVER (inode)->rsize;
@@ -302,15 +300,15 @@ readpage_async_filler(struct nfs_readdesc *desc, struct page *page) goto out_unlock; } - new =nfs_create_request (desc->ctx, page,0 , aligned_len); + new =nfs_create_request (ctx, page,0 , aligned_len);if (IS_ERR (new)) goto out_error;if (len <PAGE_SIZE )zero_user_segment (page, len,PAGE_SIZE ); -if (!nfs_pageio_add_request (&desc->pgio, new)) { +if (!nfs_pageio_add_request (pgio, new)) {nfs_list_remove_request (new); - error = desc->pgio.pg_error; + error = pgio->pg_error;nfs_readpage_release (new, error); goto out; }
@@ -332,7 +330,8 @@ readpage_async_filler(struct nfs_readdesc *desc, struct page *page)int nfs_read_folio (struct file *file,struct folio *folio) {struct page *page = &folio->page; -struct nfs_readdesc desc; +struct nfs_pageio_descriptor pgio; +struct nfs_open_context *ctx;struct inode *inode =page_file_mapping (page)->host;int ret;
@@ -358,29 +357,29 @@ int nfs_read_folio(struct file *file, struct folio *folio)if (file ==NULL ) { ret = -EBADF ; - desc.ctx =nfs_find_open_context (inode,NULL ,FMODE_READ ); -if (desc.ctx ==NULL ) + ctx =nfs_find_open_context (inode,NULL ,FMODE_READ ); +if (ctx ==NULL ) goto out_unlock; }else - desc.ctx =get_nfs_open_context (nfs_file_open_context (file)); + ctx =get_nfs_open_context (nfs_file_open_context (file)); -xchg (&desc.ctx->error,0 ); -nfs_pageio_init_read (&desc.pgio, inode, false, +xchg (&ctx->error,0 ); +nfs_pageio_init_read (&pgio, inode, false, &nfs_async_read_completion_ops); - ret =readpage_async_filler (&desc, page); + ret =nfs_pageio_add_page (&pgio, ctx, page);if (ret) goto out; -nfs_pageio_complete_read (&desc.pgio); - ret = desc.pgio.pg_error <0 ? desc.pgio.pg_error :0 ; +nfs_pageio_complete_read (&pgio); + ret = pgio.pg_error <0 ? pgio.pg_error :0 ;if (!ret) { ret =wait_on_page_locked_killable (page);if (!PageUptodate (page) && !ret) - ret =xchg (&desc.ctx->error,0 ); + ret =xchg (&ctx->error,0 ); } out: -put_nfs_open_context (desc.ctx); +put_nfs_open_context (ctx);trace_nfs_aop_readpage_done (inode, page, ret);return ret; out_unlock:
@@ -391,9 +390,10 @@ int nfs_read_folio(struct file *file, struct folio *folio)void nfs_readahead (struct readahead_control *ractl) { +struct nfs_pageio_descriptor pgio; +struct nfs_open_context *ctx;unsigned int nr_pages =readahead_count (ractl);struct file *file = ractl->file; -struct nfs_readdesc desc;struct inode *inode = ractl->mapping->host;struct page *page;int ret;
@@ -407,25 +407,25 @@ void nfs_readahead(struct readahead_control *ractl)if (file ==NULL ) { ret = -EBADF ; - desc.ctx =nfs_find_open_context (inode,NULL ,FMODE_READ ); -if (desc.ctx ==NULL ) + ctx =nfs_find_open_context (inode,NULL ,FMODE_READ ); +if (ctx ==NULL ) goto out; }else - desc.ctx =get_nfs_open_context (nfs_file_open_context (file)); + ctx =get_nfs_open_context (nfs_file_open_context (file)); -nfs_pageio_init_read (&desc.pgio, inode, false, +nfs_pageio_init_read (&pgio, inode, false, &nfs_async_read_completion_ops);while ((page =readahead_page (ractl)) !=NULL ) { - ret =readpage_async_filler (&desc, page); + ret =nfs_pageio_add_page (&pgio, ctx, page);put_page (page);if (ret)break ; } -nfs_pageio_complete_read (&desc.pgio); +nfs_pageio_complete_read (&pgio); -put_nfs_open_context (desc.ctx); +put_nfs_open_context (ctx); out:trace_nfs_aop_readahead_done (inode, nr_pages, ret); }
Signature · 1 line
2.31.1
RFC PATCH v2 2/3 NFS: Configure support for netfs when NFS fscache is configured
In reply to Dave WysochanskiAs first steps for support of the netfs library when NFS_FSCACHE is configured, add NETFS_SUPPORT to Kconfig and add the required netfs_inode into struct nfs_inode.
Using netfs requires we move the VFS inode structure to be stored inside struct netfs_inode, along with the fscache_cookie. Thus, create a new helper, NFSI_TO_INODE(), which is defined differently depending on whether NFS_FSCACHE is configured. In addition, use the netfs_inode() and netfs_i_cookie() helpers, and remove our own helper, nfs_i_fscache().
Later patches will convert NFS fscache to fully use netfs.
--- fs/nfs/Kconfig | 1 + fs/nfs/delegation.c | 2 +- fs/nfs/dir.c | 2 +- fs/nfs/fscache.c | 20 +++++++++----------- fs/nfs/fscache.h | 15 ++++++--------- fs/nfs/inode.c | 6 +++--- fs/nfs/internal.h | 2 +- fs/nfs/pnfs.c | 12 ++++++------ fs/nfs/write.c | 2 +- include/linux/nfs_fs.h | 36 ++++++++++++++++++++++++------------ 10 files changed, 53 insertions(+), 45 deletions(-)
fs/nfs/Kconfig +1 -0
@@ -171,6 +171,7 @@ config ROOT_NFS config NFS_FSCACHE bool "Provide NFS client caching support" depends on NFS_FS=m && FSCACHE || NFS_FS=y && FSCACHE=y + select NETFS_SUPPORT help Say Y here if you want NFS data to be cached locally on disc through the general filesystem cache manager
fs/nfs/delegation.c +1 -1
@@ -306,7 +306,7 @@ nfs_start_delegation_return_locked(struct nfs_inode *nfsi) }spin_unlock (&delegation->lock);if (ret) -nfs_clear_verifier_delegated (&nfsi->vfs_inode); +nfs_clear_verifier_delegated (NFSI_TO_INODE (nfsi)); out:return ret; }
fs/nfs/dir.c +1 -1
@@ -2796,7 +2796,7 @@ nfs_do_access_cache_scan(unsigned int nr_to_scan)if (nr_to_scan-- ==0 )break ; - inode = &nfsi->vfs_inode; + inode =NFSI_TO_INODE (nfsi);spin_lock (&inode->i_lock);if (list_empty (&nfsi->access_cache_entry_lru)) goto remove_lru_entry;
fs/nfs/fscache.c +9 -11
@@ -163,13 +163,14 @@ void nfs_fscache_init_inode(struct inode *inode)struct nfs_server *nfss =NFS_SERVER (inode);struct nfs_inode *nfsi =NFS_I (inode); - nfsi->fscache =NULL ; +netfs_inode (inode)->cache =NULL ;if (!(nfss->fscache &&S_ISREG (inode->i_mode)))return ;nfs_fscache_update_auxdata (&auxdata, inode); - nfsi->fscache = fscache_acquire_cookie(NFS_SB(inode->i_sb)->fscache, + netfs_inode(inode)->cache = fscache_acquire_cookie( + nfss->fscache, 0, nfsi->fh.data, /* index_key */ nfsi->fh.size,
@@ -183,11 +184,8 @@ void nfs_fscache_init_inode(struct inode *inode)*/ void nfs_fscache_clear_inode (struct inode *inode) { -struct nfs_inode *nfsi =NFS_I (inode); -struct fscache_cookie *cookie =nfs_i_fscache (inode); - -fscache_relinquish_cookie (cookie, false); - nfsi->fscache =NULL ; +fscache_relinquish_cookie (netfs_i_cookie (&NFS_I (inode)->netfs), false); +netfs_inode (inode)->cache =NULL ; }/*
@@ -212,7 +210,7 @@ void nfs_fscache_clear_inode(struct inode *inode)void nfs_fscache_open_file (struct inode *inode,struct file *filp) {struct nfs_fscache_inode_auxdata auxdata; -struct fscache_cookie *cookie =nfs_i_fscache (inode); +struct fscache_cookie *cookie =netfs_i_cookie (&NFS_I (inode)->netfs);bool open_for_write =inode_is_open_for_write (inode);if (!fscache_cookie_valid (cookie))
@@ -230,7 +228,7 @@ EXPORT_SYMBOL_GPL(nfs_fscache_open_file);void nfs_fscache_release_file (struct inode *inode,struct file *filp) {struct nfs_fscache_inode_auxdata auxdata; -struct fscache_cookie *cookie =nfs_i_fscache (inode); +struct fscache_cookie *cookie =netfs_i_cookie (&NFS_I (inode)->netfs);loff_t i_size =i_size_read (inode);nfs_fscache_update_auxdata (&auxdata, inode);
@@ -243,7 +241,7 @@ void nfs_fscache_release_file(struct inode *inode, struct file *filp)static int fscache_fallback_read_page (struct inode *inode,struct page *page) {struct netfs_cache_resources cres; -struct fscache_cookie *cookie =nfs_i_fscache (inode); +struct fscache_cookie *cookie =netfs_i_cookie (&NFS_I (inode)->netfs);struct iov_iter iter;struct bio_vec bvec[1 ];int ret;
@@ -271,7 +269,7 @@ static int fscache_fallback_write_page(struct inode *inode, struct page *page, bool no_space_allocated_yet) {struct netfs_cache_resources cres; -struct fscache_cookie *cookie =nfs_i_fscache (inode); +struct fscache_cookie *cookie =netfs_i_cookie (&NFS_I (inode)->netfs);struct iov_iter iter;struct bio_vec bvec[1 ];loff_t start =page_offset (page);
fs/nfs/fscache.h +6 -9
@@ -54,7 +54,7 @@ static inline bool nfs_fscache_release_folio(struct folio *folio, gfp_t gfp)if (current_is_kswapd () || !(gfp & __GFP_FS))return false;folio_wait_fscache (folio); -fscache_note_page_release (nfs_i_fscache (folio->mapping->host)); +fscache_note_page_release (netfs_i_cookie (&NFS_I (folio->mapping->host)->netfs));nfs_inc_fscache_stats (folio->mapping->host,NFSIOS_FSCACHE_PAGES_UNCACHED ); }
@@ -66,7 +66,7 @@ static inline bool nfs_fscache_release_folio(struct folio *folio, gfp_t gfp)*/ static inline int nfs_fscache_read_page (struct inode *inode,struct page *page) { -if (nfs_i_fscache (inode)) +if (netfs_inode (inode)->cache)return __nfs_fscache_read_page (inode, page);return -ENOBUFS ; }
@@ -78,7 +78,7 @@ static inline int nfs_fscache_read_page(struct inode *inode, struct page *page)static inline void nfs_fscache_write_page (struct inode *inode,struct page *page) { -if (nfs_i_fscache (inode)) +if (netfs_inode (inode)->cache)__nfs_fscache_write_page (inode, page); }
@@ -101,13 +101,10 @@ static inline void nfs_fscache_update_auxdata(struct nfs_fscache_inode_auxdata *static inline void nfs_fscache_invalidate (struct inode *inode,int flags) {struct nfs_fscache_inode_auxdata auxdata; -struct nfs_inode *nfsi =NFS_I (inode); +struct fscache_cookie *cookie =netfs_i_cookie (&NFS_I (inode)->netfs); -if (nfsi->fscache) { -nfs_fscache_update_auxdata (&auxdata, inode); -fscache_invalidate (nfsi->fscache, &auxdata, -i_size_read (inode), flags); - } +nfs_fscache_update_auxdata (&auxdata, inode); +fscache_invalidate (cookie, &auxdata,i_size_read (inode), flags); }/*
fs/nfs/inode.c +3 -3
@@ -1410,7 +1410,7 @@ int nfs_revalidate_mapping(struct inode *inode, struct address_space *mapping)static bool nfs_file_has_writers (struct nfs_inode *nfsi) { -struct inode *inode = &nfsi->vfs_inode; +struct inode *inode =NFSI_TO_INODE (nfsi);if (!S_ISREG (inode->i_mode))return false;
@@ -2248,7 +2248,7 @@ struct inode *nfs_alloc_inode(struct super_block *sb)#ifdef CONFIG_NFS_V4_2 nfsi->xattr_cache =NULL ;#endif -return &nfsi->vfs_inode; +return NFSI_TO_INODE (nfsi); }EXPORT_SYMBOL_GPL (nfs_alloc_inode);
@@ -2272,7 +2272,7 @@ static void init_once(void *foo) {struct nfs_inode *nfsi = (struct nfs_inode *) foo; -inode_init_once (&nfsi->vfs_inode); +inode_init_once (NFSI_TO_INODE (nfsi));INIT_LIST_HEAD (&nfsi->open_files);INIT_LIST_HEAD (&nfsi->access_cache_entry_lru);INIT_LIST_HEAD (&nfsi->access_cache_inode_lru);
fs/nfs/internal.h +1 -1
@@ -355,7 +355,7 @@ nfs4_label_copy(struct nfs4_label *dst, struct nfs4_label *src)static inline void nfs_zap_label_cache_locked (struct nfs_inode *nfsi) { -if (nfs_server_capable (&nfsi->vfs_inode,NFS_CAP_SECURITY_LABEL )) +if (nfs_server_capable (NFSI_TO_INODE (nfsi),NFS_CAP_SECURITY_LABEL )) nfsi->cache_validity |=NFS_INO_INVALID_LABEL ; }#else
fs/nfs/pnfs.c +6 -6
@@ -763,19 +763,19 @@ static struct pnfs_layout_hdr *__pnfs_destroy_layout(struct nfs_inode *nfsi)struct pnfs_layout_hdr *lo;LIST_HEAD (tmp_list); -spin_lock (&nfsi->vfs_inode.i_lock); +spin_lock (&NFSI_TO_INODE (nfsi)->i_lock); lo = nfsi->layout;if (lo) {pnfs_get_layout_hdr (lo);pnfs_mark_layout_stateid_invalid (lo, &tmp_list);pnfs_layout_clear_fail_bit (lo,NFS_LAYOUT_RO_FAILED );pnfs_layout_clear_fail_bit (lo,NFS_LAYOUT_RW_FAILED ); -spin_unlock (&nfsi->vfs_inode.i_lock); +spin_unlock (&NFSI_TO_INODE (nfsi)->i_lock);pnfs_free_lseg_list (&tmp_list); -nfs_commit_inode (&nfsi->vfs_inode,0 ); +nfs_commit_inode (NFSI_TO_INODE (nfsi),0 );pnfs_put_layout_hdr (lo); }else -spin_unlock (&nfsi->vfs_inode.i_lock); +spin_unlock (&NFSI_TO_INODE (nfsi)->i_lock);return lo; }
@@ -790,9 +790,9 @@ static bool pnfs_layout_removed(struct nfs_inode *nfsi, {bool ret; -spin_lock (&nfsi->vfs_inode.i_lock); +spin_lock (&NFSI_TO_INODE (nfsi)->i_lock); ret = nfsi->layout != lo; -spin_unlock (&nfsi->vfs_inode.i_lock); +spin_unlock (&NFSI_TO_INODE (nfsi)->i_lock);return ret; }
fs/nfs/write.c +1 -1
@@ -828,7 +828,7 @@ nfs_page_search_commits_for_head_request_locked(struct nfs_inode *nfsi, {struct nfs_page *freq, *t;struct nfs_commit_info cinfo; -struct inode *inode = &nfsi->vfs_inode; +struct inode *inode =NFSI_TO_INODE (nfsi);nfs_init_cinfo_from_inode (&cinfo, inode);
include/linux/nfs_fs.h +24 -12
@@ -31,6 +31,10 @@#include <linux/sunrpc/auth.h> #include <linux/sunrpc/clnt.h> +#ifdef CONFIG_NFS_FSCACHE +#include <linux/netfs.h> +#endif +#include <linux/nfs.h> #include <linux/nfs2.h> #include <linux/nfs3.h>
@@ -122,6 +126,10 @@ struct nfs4_xattr_cache;* nfs fs inode data in memory */ struct nfs_inode { +#ifdef CONFIG_NFS_FSCACHE +struct netfs_inode netfs;/* Netfslib context and inode */ +#endif +/* * The 64bit 'inode number' */
@@ -203,10 +211,10 @@ struct nfs_inode {/* how many bytes have been written/read and how many bytes queued up */ __u64 write_io;__u64 read_io; -#ifdef CONFIG_NFS_FSCACHE -struct fscache_cookie *fscache; +#ifndef CONFIG_NFS_FSCACHE +/* fscache uses netfs, and netfs_inode contains the inode */ +struct inode vfs_inode;#endif -struct inode vfs_inode;#ifdef CONFIG_NFS_V4_2 struct nfs4_xattr_cache *xattr_cache;
@@ -281,9 +289,22 @@ struct nfs4_copy_state {#define NFS_INO_LAYOUTSTATS (11)/* layoutstats inflight */ #define NFS_INO_ODIRECT (12)/* I/O setting is O_DIRECT */ +static inline struct inode *NFSI_TO_INODE (struct nfs_inode *nfsi) +{ +#ifdef CONFIG_NFS_FSCACHE +return &nfsi->netfs.inode; +#else +return &nfsi->vfs_inode; +#endif +} +static inline struct nfs_inode *NFS_I (const struct inode *inode) { +#ifdef CONFIG_NFS_FSCACHE + return container_of(inode, struct nfs_inode, netfs.inode); +#else return container_of(inode, struct nfs_inode, vfs_inode); +#endif }static inline struct nfs_server *NFS_SB (const struct super_block *s)
@@ -328,15 +349,6 @@ static inline int NFS_STALE(const struct inode *inode)return test_bit (NFS_INO_STALE , &NFS_I (inode)->flags); } -static inline struct fscache_cookie *nfs_i_fscache (struct inode *inode) -{ -#ifdef CONFIG_NFS_FSCACHE -return NFS_I (inode)->fscache; -#else -return NULL ; -#endif -} -static inline __u64 NFS_FILEID (const struct inode *inode) {return NFS_I (inode)->fileid;
Signature · 1 line
2.31.1
RFC PATCH v2 3/3 NFS: Convert buffered read paths to use netfs when fscache is enabled
In reply to Dave WysochanskiConvert the NFS buffered read code paths to corresponding netfs APIs, but only when fscache is configured and enabled.
The netfs API defines struct netfs_request_ops which must be filled in by the network filesystem. For NFS, we only need to define 5 of the functions, the main one being the issue_read() function. The issue_read() function is called by the netfs layer when a read cannot be fulfilled locally, and must be sent to the server (either the cache is not active, or it is active but the data is not available). Once the read from the server is complete, netfs requires a call to netfs_subreq_terminated() which conveys either how many bytes were read successfully, or an error. Note that issue_read() is called with a structure, netfs_io_subrequest, which defines the IO requested, and contains a start and a length (both in bytes), and assumes the underlying netfs will return a either an error on the whole region, or the number of bytes successfully read.
The NFS IO path is page based and the main APIs are the pgio APIs defined in pagelist.c. For the pgio APIs, there is no way for the caller to know how many RPCs will be sent and how the pages will be broken up into underlying RPCs, each of which will have their own return code. Thus, NFS needs some way to accommodate the netfs API requirement on the single response to the whole request, while also minimizing disruptive changes to the NFS pgio layer. The approach taken with this patch is to allocate a small structure for each call to nfs_issue_read() to keep some accounting information for the outstanding RPCs, as well as the final error value or the number of bytes successfully read. The accounting data is updated inside the pgio layer, when a nfs_pgio_header contains a valid pointer to this data. In the NFS read completion function, nfs_read_completion(), the final error value and bytes read is updated, and the accounting data is used to determine whether this completion represents the last RPC. If this is the last RPC, call netfs_subreq_terminated() with the final error value or the number of bytes transferred.
--- fs/nfs/fscache.c | 176 ++++++++++++++++++--------------------- fs/nfs/fscache.h | 69 ++++++++------- fs/nfs/inode.c | 3 + fs/nfs/internal.h | 9 ++ fs/nfs/pagelist.c | 22 +++++ fs/nfs/read.c | 78 ++++++++++++----- include/linux/nfs_page.h | 3 + include/linux/nfs_xdr.h | 3 + 8 files changed, 217 insertions(+), 146 deletions(-)
fs/nfs/fscache.c +82 -94
@@ -15,6 +15,9 @@#include <linux/seq_file.h> #include <linux/slab.h> #include <linux/iversion.h> +#include <linux/xarray.h> +#include <linux/fscache.h> +#include <linux/netfs.h> #include "internal.h" #include "iostat.h"
@@ -235,112 +238,97 @@ void nfs_fscache_release_file(struct inode *inode, struct file *filp)fscache_unuse_cookie (cookie, &auxdata, &i_size); } -/* -* Fallback page reading interface. -*/ -static int fscache_fallback_read_page (struct inode *inode,struct page *page) + +atomic_t nfs_netfs_debug_id; +static int nfs_netfs_init_request (struct netfs_io_request *rreq,struct file *file) { -struct netfs_cache_resources cres; -struct fscache_cookie *cookie =netfs_i_cookie (&NFS_I (inode)->netfs); -struct iov_iter iter; -struct bio_vec bvec[1 ]; -int ret; - -memset (&cres,0 ,sizeof (cres)); - bvec[0 ].bv_page = page; - bvec[0 ].bv_offset =0 ; - bvec[0 ].bv_len =PAGE_SIZE ; -iov_iter_bvec (&iter,READ , bvec,ARRAY_SIZE (bvec),PAGE_SIZE ); - - ret =fscache_begin_read_operation (&cres, cookie); -if (ret <0 ) -return ret; - - ret =fscache_read (&cres,page_offset (page), &iter,NETFS_READ_HOLE_FAIL , -NULL ,NULL ); -fscache_end_operation (&cres); -return ret; +struct nfs_open_context *ctx; + +if (file ==NULL ) { + ctx =nfs_find_open_context (rreq->inode,NULL ,FMODE_READ ); +if (!ctx) +return -ENOMEM ; + }else + ctx =get_nfs_open_context (nfs_file_open_context (file)); + + rreq->netfs_priv = ctx; + +if (netfs_i_cookie (&NFS_I (rreq->inode)->netfs)) + rreq->debug_id =atomic_inc_return (&nfs_netfs_debug_id); + +return 0 ; } -/* -* Fallback page writing interface. -*/ -static int fscache_fallback_write_page (struct inode *inode,struct page *page, -bool no_space_allocated_yet) +static void nfs_netfs_free_request (struct netfs_io_request *rreq) { -struct netfs_cache_resources cres; -struct fscache_cookie *cookie =netfs_i_cookie (&NFS_I (inode)->netfs); -struct iov_iter iter; -struct bio_vec bvec[1 ]; -loff_t start =page_offset (page); -size_t len =PAGE_SIZE ; -int ret; - -memset (&cres,0 ,sizeof (cres)); - bvec[0 ].bv_page = page; - bvec[0 ].bv_offset =0 ; - bvec[0 ].bv_len =PAGE_SIZE ; -iov_iter_bvec (&iter,WRITE , bvec,ARRAY_SIZE (bvec),PAGE_SIZE ); - - ret =fscache_begin_write_operation (&cres, cookie); -if (ret <0 ) -return ret; - - ret = cres.ops->prepare_write (&cres, &start, &len,i_size_read (inode), - no_space_allocated_yet); -if (ret ==0 ) - ret =fscache_write (&cres,page_offset (page), &iter,NULL ,NULL ); -fscache_end_operation (&cres); -return ret; +put_nfs_open_context (rreq->netfs_priv); } -/* -* Retrieve a page from fscache -*/ -int __nfs_fscache_read_page (struct inode *inode,struct page *page) +static inline int nfs_begin_cache_operation (struct netfs_io_request *rreq) { -int ret; - -trace_nfs_fscache_read_page (inode, page); -if (PageChecked (page)) { -ClearPageChecked (page); - ret =1 ; - goto out; - } - - ret =fscache_fallback_read_page (inode, page); -if (ret <0 ) { -nfs_inc_fscache_stats (inode,NFSIOS_FSCACHE_PAGES_READ_FAIL ); -SetPageChecked (page); - goto out; - } - -/* Read completed synchronously */ -nfs_inc_fscache_stats (inode,NFSIOS_FSCACHE_PAGES_READ_OK ); -SetPageUptodate (page); - ret =0 ; -out: -trace_nfs_fscache_read_page_exit (inode, page, ret); -return ret; +return fscache_begin_read_operation (&rreq->cache_resources, +netfs_i_cookie (&NFS_I (rreq->inode)->netfs)); } -/* -* Store a newly fetched page in fscache. We can be certain there's no page -* stored in the cache as yet otherwise we would've read it from there. -*/ -void __nfs_fscache_write_page (struct inode *inode,struct page *page) +static struct nfs_netfs_io_data *nfs_netfs_alloc (struct netfs_io_subrequest *sreq) { -int ret; +struct nfs_netfs_io_data *netfs; + + netfs =kzalloc (sizeof (*netfs),GFP_KERNEL_ACCOUNT ); +if (!netfs) +return NULL ; + netfs->sreq = sreq; +refcount_set (&netfs->refcount,1 ); +spin_lock_init (&netfs->lock); +return netfs; +} -trace_nfs_fscache_write_page (inode, page); +static bool nfs_netfs_clamp_length (struct netfs_io_subrequest *sreq) +{ +size_t rsize =NFS_SB (sreq->rreq->inode->i_sb)->rsize; - ret =fscache_fallback_write_page (inode, page, true); + sreq->len =min (sreq->len, rsize); +return true; +} -if (ret !=0 ) { -nfs_inc_fscache_stats (inode,NFSIOS_FSCACHE_PAGES_WRITTEN_FAIL ); -nfs_inc_fscache_stats (inode,NFSIOS_FSCACHE_PAGES_UNCACHED ); - }else { -nfs_inc_fscache_stats (inode,NFSIOS_FSCACHE_PAGES_WRITTEN_OK ); +static void nfs_issue_read (struct netfs_io_subrequest *sreq) +{ +struct nfs_pageio_descriptor pgio; +struct inode *inode = sreq->rreq->inode; +struct nfs_open_context *ctx = sreq->rreq->netfs_priv; +struct page *page; +int err; +pgoff_t start = (sreq->start + sreq->transferred) >>PAGE_SHIFT ; +pgoff_t last = ((sreq->start + sreq->len - + sreq->transferred -1 ) >>PAGE_SHIFT ); +XA_STATE (xas, &sreq->rreq->mapping->i_pages, start); + +nfs_pageio_init_read (&pgio, inode, false, + &nfs_async_read_completion_ops); + + pgio.pg_netfs =nfs_netfs_alloc (sreq);/* used in completion */ +if (!pgio.pg_netfs) +return netfs_subreq_terminated (sreq, -ENOMEM , false); + +xas_lock (&xas); +xas_for_each (&xas, page, last) { +/* nfs_pageio_add_page() may schedule() due to pNFS layout and other RPCs */ +xas_pause (&xas); +xas_unlock (&xas); + err =nfs_pageio_add_page (&pgio, ctx, page); +if (err <0 ) +return netfs_subreq_terminated (sreq, err, false); +xas_lock (&xas); } -trace_nfs_fscache_write_page_exit (inode, page, ret); +xas_unlock (&xas); +nfs_pageio_complete_read (&pgio); +nfs_netfs_put (pgio.pg_netfs); } + +const struct netfs_request_ops nfs_netfs_ops = { + .init_request = nfs_netfs_init_request, + .free_request = nfs_netfs_free_request, + .begin_cache_operation = nfs_begin_cache_operation, + .issue_read = nfs_issue_read, + .clamp_length = nfs_netfs_clamp_length +};
fs/nfs/fscache.h +37 -32
97 lines not on this page · raw message
fs/nfs/inode.c +3 -0
@@ -2247,6 +2247,9 @@ struct inode *nfs_alloc_inode(struct super_block *sb)#endif /* CONFIG_NFS_V4 */ #ifdef CONFIG_NFS_V4_2 nfsi->xattr_cache =NULL ; +#endif +#ifdef CONFIG_NFS_FSCACHE +netfs_inode_init (&nfsi->netfs, &nfs_netfs_ops);#endif return NFSI_TO_INODE (nfsi); }
fs/nfs/internal.h +9 -0
@@ -453,6 +453,10 @@ extern void nfs_sb_deactive(struct super_block *sb);extern int nfs_client_for_each_server (struct nfs_client *clp,int (*fn)(struct nfs_server *,void *),void *data); +#ifdef CONFIG_NFS_FSCACHE +extern const struct netfs_request_ops nfs_netfs_ops; +#endif +/* io.c */ extern void nfs_start_io_read (struct inode *inode);extern void nfs_end_io_read (struct inode *inode);
@@ -482,9 +486,14 @@ extern int nfs4_get_rootfh(struct nfs_server *server, struct nfs_fh *mntfh, boolstruct nfs_pgio_completion_ops ;/* read.c */ +extern const struct nfs_pgio_completion_ops nfs_async_read_completion_ops;extern void nfs_pageio_init_read (struct nfs_pageio_descriptor *pgio,struct inode *inode,bool force_mds,const struct nfs_pgio_completion_ops *compl_ops); +extern int nfs_pageio_add_page (struct nfs_pageio_descriptor *pgio, +struct nfs_open_context *ctx, +struct page *page); +extern void nfs_pageio_complete_read (struct nfs_pageio_descriptor *pgio);extern void nfs_read_prepare (struct rpc_task *task,void *calldata);extern void nfs_pageio_reset_read_mds (struct nfs_pageio_descriptor *pgio);
fs/nfs/pagelist.c +22 -0
@@ -25,6 +25,7 @@#include "internal.h" #include "pnfs.h" #include "nfstrace.h" +#include "fscache.h" #define NFSDBG_FACILITY NFSDBG_PAGECACHE
@@ -68,6 +69,12 @@ void nfs_pgheader_init(struct nfs_pageio_descriptor *desc, hdr->good_bytes = mirror->pg_count; hdr->io_completion = desc->pg_io_completion; hdr->dreq = desc->pg_dreq; +#ifdef CONFIG_NFS_FSCACHE +if (desc->pg_netfs) { + hdr->netfs = desc->pg_netfs; +nfs_netfs_get (desc->pg_netfs); + } +#endif hdr->release = release; hdr->completion_ops = desc->pg_completion_ops;if (hdr->completion_ops->init_hdr)
@@ -846,6 +853,9 @@ void nfs_pageio_init(struct nfs_pageio_descriptor *desc, desc->pg_lseg =NULL ; desc->pg_io_completion =NULL ; desc->pg_dreq =NULL ; +#ifdef CONFIG_NFS_FSCACHE + desc->pg_netfs =NULL ; +#endif desc->pg_bsize = bsize; desc->pg_mirror_count =1 ;
@@ -940,6 +950,15 @@ int nfs_generic_pgio(struct nfs_pageio_descriptor *desc,/* Set up the argument struct */ nfs_pgio_rpcsetup (hdr, mirror->pg_count, desc->pg_ioflags, &cinfo); desc->pg_rpc_callops = &nfs_pgio_common_ops; + +#ifdef CONFIG_NFS_FSCACHE +if (hdr->netfs) { +struct nfs_netfs_io_data *netfs = hdr->netfs; + + netfs->rpc_byte_count += hdr->args.count; +atomic_inc (&netfs->rpcs); + } +#endif return 0 ; }EXPORT_SYMBOL_GPL (nfs_generic_pgio);
@@ -1360,6 +1379,9 @@ int nfs_pageio_resend(struct nfs_pageio_descriptor *desc, desc->pg_io_completion = hdr->io_completion; desc->pg_dreq = hdr->dreq; +#ifdef CONFIG_NFS_FSCACHE + desc->pg_netfs = hdr->netfs; +#endif list_splice_init (&hdr->pages, &pages);while (!list_empty (&pages)) {struct nfs_page *req =nfs_list_entry (pages.next);
fs/nfs/read.c +58 -20
148 lines not on this page · raw message
include/linux/nfs_page.h +3 -0
@@ -101,6 +101,9 @@ struct nfs_pageio_descriptor {struct pnfs_layout_segment *pg_lseg;struct nfs_io_completion *pg_io_completion;struct nfs_direct_req *pg_dreq; +#ifdef CONFIG_NFS_FSCACHE +void *pg_netfs; +#endif unsigned int pg_bsize;/* default bsize for mirrors */ u32 pg_mirror_count;
include/linux/nfs_xdr.h +3 -0
@@ -1619,6 +1619,9 @@ struct nfs_pgio_header {const struct nfs_rw_ops *rw_ops;struct nfs_io_completion *io_completion;struct nfs_direct_req *dreq; +#ifdef CONFIG_NFS_FSCACHE +void *netfs; +#endif int pnfs_error;int error;/* merge with pnfs_error */
Signature · 1 line
2.31.1
kernel test robot
build botRe: [RFC PATCH v2 3/3] NFS: Convert buffered read paths to use netfs when fscache is enabled
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in…
Hi Dave,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on v6.0-rc2]
[also build test WARNING on linus/master next-20220826] [cannot apply to trondmy-nfs/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Dave-Wysochanski/Convert-NFS-with-fscache-to-the-netfs-API/20220829-044110 base: 1c23f9e627a7b412978b4e852793c5e3c3efc555 config: i386-randconfig-a014-20220829 (https://download.01.org/0day-ci/archive/20220829/[email protected]/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/3c0431802baaa9bc2065d84310f2771a76c4351c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Dave-Wysochanski/Convert-NFS-with-fscache-to-the-netfs-API/20220829-044110 git checkout 3c0431802baaa9bc2065d84310f2771a76c4351c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/nfs/
If you fix the issue, kindly add following tag where applicable
All warnings (new ones prefixed by >>):
>> fs/nfs/read.c:113:16: warning: unused variable 'inode' [-Wunused-variable]
struct inode *inode = d_inode(nfs_req_openctx(req)->dentry);
^1 warning generated.
vim +/inode +113 fs/nfs/read.c
493292ddc78d18 Trond Myklebust 2011-07-13 110
8f54c7a4babf58 Trond Myklebust 2019-08-15 111 static void nfs_readpage_release(struct nfs_page *req, int error)
0bcbf039f6b2bc Peng Tao 2015-12-05 112 {
9fcd5960e88bbd Trond Myklebust 2019-04-07 @113 struct inode *inode = d_inode(nfs_req_openctx(req)->dentry);
8f54c7a4babf58 Trond Myklebust 2019-08-15 114 struct page *page = req->wb_page;
0bcbf039f6b2bc Peng Tao 2015-12-05 115
0bcbf039f6b2bc Peng Tao 2015-12-05 116 dprintk("NFS: read done (%s/%llu %d@%lld)\n", inode->i_sb->s_id,
0bcbf039f6b2bc Peng Tao 2015-12-05 117 (unsigned long long)NFS_FILEID(inode), req->wb_bytes,
0bcbf039f6b2bc Peng Tao 2015-12-05 118 (long long)req_offset(req));
0bcbf039f6b2bc Peng Tao 2015-12-05 119
8f54c7a4babf58 Trond Myklebust 2019-08-15 120 if (nfs_error_is_fatal_on_server(error) && error != -ETIMEDOUT)
8f54c7a4babf58 Trond Myklebust 2019-08-15 121 SetPageError(page);
3c0431802baaa9 Dave Wysochanski 2022-08-28 122 if (nfs_page_group_sync_on_bit(req, PG_UNLOCKPAGE))
3c0431802baaa9 Dave Wysochanski 2022-08-28 123 #ifndef CONFIG_NFS_FSCACHE
8f54c7a4babf58 Trond Myklebust 2019-08-15 124 unlock_page(page);
3c0431802baaa9 Dave Wysochanski 2022-08-28 125 #else
3c0431802baaa9 Dave Wysochanski 2022-08-28 126 /*
3c0431802baaa9 Dave Wysochanski 2022-08-28 127 * If fscache is enabled, netfs will unlock pages.
3c0431802baaa9 Dave Wysochanski 2022-08-28 128 * Otherwise, we have to unlock the page here
3c0431802baaa9 Dave Wysochanski 2022-08-28 129 */
3c0431802baaa9 Dave Wysochanski 2022-08-28 130 if (!netfs_inode(inode)->cache)
3c0431802baaa9 Dave Wysochanski 2022-08-28 131 unlock_page(page);
3c0431802baaa9 Dave Wysochanski 2022-08-28 132 #endif
0bcbf039f6b2bc Peng Tao 2015-12-05 133 nfs_release_request(req);
0bcbf039f6b2bc Peng Tao 2015-12-05 134 }
0bcbf039f6b2bc Peng Tao 2015-12-05 135 Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp