drivers/base/auxiliary: check return value of strrchr()
Subsystems (2)
PATCH 1/1 drivers/base/auxiliary: check return value of strrchr()
From: lily <[email protected]>
The return value of strrchr() could be NULL, which will cause invalid offset in (int)(p - name). So we check it here.
--- drivers/base/auxiliary.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/base/auxiliary.c +2 -1
@@ -191,7 +191,8 @@ static int auxiliary_uevent(struct device *dev, struct kobj_uevent_env *env) name =dev_name (dev); p =strrchr (name,'.' ); - +if (!p) +return -EINVAL ;return add_uevent_var (env,"MODALIAS=%s%.*s" ,AUXILIARY_MODULE_PREFIX , (int )(p - name), name); }
Signature · 1 line
2.25.1
Greg KH
maintainerQuoted 27 lines · Li Zhong
From: lily <[email protected]>
The return value of
strrchr()could be NULL, which will cause invalid offset in (int)(p - name). So we check it here.Signed-off-by Li Zhong <[email protected]>--- drivers/base/auxiliary.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/base/auxiliary.c +2
-1@@ -191,7 +191,8 @@ static int auxiliary_uevent(struct device *dev, struct kobj_uevent_env *env) name =dev_name (dev); p =strrchr (name,'.' ); - +if (!p) +return -EINVAL ;return add_uevent_var (env,"MODALIAS=%s%.*s" ,AUXILIARY_MODULE_PREFIX , (int )(p - name), name); }Signature · 1 line
2.25.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/SubmittingPatches for how to do this correctly.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot