Skip to contentSkip to conversation

cpuidle: tegra: restrict to ARCH_SUSPEND_POSSIBLE

PATCH New Randy Dunlap 1 participant 1 message Aug 29, 2022 CPU idle time management framework

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 cpuidle: tegra: restrict to ARCH_SUSPEND_POSSIBLE

Since 'select' does not follow any dependency chain (ARM_CPU_SUSPEND in this case), make ARM_TEGRA_CPUIDLE depend on ARCH_SUSPEND_POSSIBLE, just as ARM_CPU_SUSPEND does.

Fix this kconfig warning:

WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
Selected by [y]:
- ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]

and subsequent build errors:

arm-linux-gnueabi-ld: arch/arm/kernel/sleep.o: in function `__cpu_suspend':
(.text+0x68): undefined reference to `cpu_sa110_suspend_size'
arm-linux-gnueabi-ld: arch/arm/kernel/suspend.o: in function `__cpu_suspend_save':
suspend.c:(.text+0x478): undefined reference to `cpu_sa110_do_suspend'
arm-linux-gnueabi-ld: suspend.c:(.text+0x4e8): undefined reference to `cpu_sa110_do_resume'

Fixes faae6c9f2e68 ("cpuidle: tegra: Enable compile testing")
Cc Dmitry Osipenko <[email protected]>
Cc Thierry Reding <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Cc Daniel Lezcano <[email protected]>
Cc Arnd Bergmann <[email protected]>

---
v2: add Arnd's Reviewed-by.

 drivers/cpuidle/Kconfig.arm |    1 +
 1 file changed, 1 insertion(+)
drivers/cpuidle/Kconfig.arm +1 -0
@@ -102,6 +102,7 @@ config ARM_MVEBU_V7_CPUIDLE
 config ARM_TEGRA_CPUIDLE
 	bool "CPU Idle Driver for NVIDIA Tegra SoCs"
 	depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 && MMU
+	depends on ARCH_SUSPEND_POSSIBLE
 	select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
 	select ARM_CPU_SUSPEND
 	help