Skip to contentSkip to conversation

dt-bindings: iio: Add missing (unevaluated|additional)Properties on child nodes

PATCH In review Rob Herring 3 participants 5 messages Aug 23, 2022 – Aug 29, 2022

Subsystems (10)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: iio: Add missing (unevaluated|additional)Properties on child nodes

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

---
 Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 1 +
 .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml       | 2 ++
 Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml     | 1 +
 .../devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml          | 1 +
 Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml | 1 +
 Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml    | 1 +
 Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml    | 4 ++++
 Documentation/devicetree/bindings/iio/dac/adi,ltc2688.yaml    | 1 +
 8 files changed, 12 insertions(+)
Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml +1 -0
index 74a4a9d95798..8bac0c4120dd 100644
@@ -58,6 +58,7 @@ required:
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
+    additionalProperties: false
     description: |
       Represents the external channels which are connected to the ADC.
       For compatible property "qcom,spmi-vadc" following channels, also known as
Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml +2 -0
index 92f9472a77ae..1970503389aa 100644
@@ -72,6 +72,7 @@ additionalProperties: false
 patternProperties:
   "^filter@[0-9]+$":
     type: object
+    unevaluatedProperties: false
     description: child node
 
     properties:
@@ -225,6 +226,7 @@ patternProperties:
           patternProperties:
             "^dfsdm-dai+$":
               type: object
+              additionalProperties: false
               description: child node
 
               properties:
Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml +1 -0
index a3b79438a13a..2c3c2cf2145c 100644
@@ -43,6 +43,7 @@ additionalProperties: false
 patternProperties:
   "^channel@[0-7]+$":
     type: object
+    additionalProperties: false
     description:
       Child nodes needed for each channel that the platform uses.
 
Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml +1 -0
index 3698b4b0900f..be93c109d6ac 100644
@@ -134,6 +134,7 @@ properties:
 
   ams-pl@400:
     type: object
+    additionalProperties: false
     description:
       PL-SYSMON is capable of monitoring off chip voltage and temperature.
       PL-SYSMON block has DRP, JTAG and I2C interface to enable monitoring
Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml +1 -0
index baa65a521bad..03bb90a7f4f8 100644
@@ -63,6 +63,7 @@ additionalProperties: false
 patternProperties:
   "^channel@[0-3]$":
     type: object
+    additionalProperties: false
     description: Represents the external channels which are connected to the device.
 
     properties:
Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml +1 -0
index 9c48c76993fe..fee0f023a8c8 100644
@@ -78,6 +78,7 @@ patternProperties:
 
       custom-output-range-config:
         type: object
+        additionalProperties: false
         description: Configuration of custom range when
           adi,output-range-microvolt is not present.
           The formulas for calculation the output voltages are
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml +4 -0
index 24ac40180ac1..c2d9ae3039b2 100644
@@ -62,6 +62,7 @@ properties:
       connected to the DAC. Channel 0 can act both as a current
       source and sink.
     type: object
+    additionalProperties: false
 
     properties:
       reg:
@@ -85,6 +86,7 @@ properties:
     description: Represents an external channel which are
       connected to the DAC.
     type: object
+    additionalProperties: false
 
     properties:
       reg:
@@ -101,6 +103,7 @@ properties:
     description: Represents an external channel which are
       connected to the DAC.
     type: object
+    additionalProperties: false
 
     properties:
       reg:
@@ -116,6 +119,7 @@ properties:
 patternProperties:
   "^channel@([3-5])$":
     type: object
+    additionalProperties: false
     description: Represents the external channels which are connected to the DAC.
     properties:
       reg:
Documentation/devicetree/bindings/iio/dac/adi,ltc2688.yaml +1 -0
index 48f9e7d29423..15cc6bf59b13 100644
@@ -48,6 +48,7 @@ properties:
 patternProperties:
   "^channel@([0-9]|1[0-5])$":
     type: object
+    additionalProperties: false
 
     properties:
       reg:
Signature · 1 line
2.34.1
maintainer
#2 lore raw
Quoted 8 lines · On Thu, 25 Aug 2022 15:04:33 +0300 Krzysztof Kozlowski…
Quoted 4 lines · Rob Herring

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

Applied to the togreg branch of iio.git and pushed out as testing for 0-day to poke at it before I push out as togreg for linux-next to pick up.

Side note. Some odd entries in your cc list... alsa-devel?

Thanks,

Jonathan

Quoted 4 lines

Best regards,
Krzysztof

author maintainer
#3 lore raw
Quoted 10 lines · Jonathan Cameron
Quoted 7 lines · On Thu, 25 Aug 2022 15:04:33 +0300 Krzysztof Kozlowski…
Quoted 4 lines · Rob Herring

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

Quoted 4 lines
Quoted 1 line

Applied to the togreg branch of iio.git and pushed out as testing for 0-day to poke at it before I push out as togreg for linux-next to pick up.

Thanks.

Quoted 1 line

Side note. Some odd entries in your cc list... alsa-devel?

Blame MAINTAINERS:

STM32 AUDIO (ASoC) DRIVERS

M:      Olivier Moysan <[email protected]>
M:      Arnaud Pouliquen <[email protected]>
L:      [email protected] (moderated for non-subscribers)
S:      Maintained
F:      Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
F:      Documentation/devicetree/bindings/sound/st,stm32-*.yaml
F:      sound/soc/stm/
maintainer
#4 lore raw
Quoted 22 lines · On Mon, 29 Aug 2022 09:10:29 -0500 Rob Herring <[email protected]> wrote:
Quoted 10 lines · Jonathan Cameron
Quoted 7 lines · On Thu, 25 Aug 2022 15:04:33 +0300 Krzysztof Kozlowski…
Quoted 4 lines · Rob Herring

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

Quoted 4 lines
Quoted 1 line

Applied to the togreg branch of iio.git and pushed out as testing for 0-day to poke at it before I push out as togreg for linux-next to pick up.

Thanks.

Quoted 1 line

Side note. Some odd entries in your cc list... alsa-devel?

Blame MAINTAINERS:

Quoted 8 lines

STM32 AUDIO (ASoC) DRIVERS

M:      Olivier Moysan <[email protected]>
M:      Arnaud Pouliquen <[email protected]>
L:      [email protected] (moderated for non-subscribers)
S:      Maintained
F:      Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
F:      Documentation/devicetree/bindings/sound/st,stm32-*.yaml
F:      sound/soc/stm/

There is some logic to that entry I suppose.

Thanks for explanation!

Jonathan