Skip to contentSkip to conversation

dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes

PATCH Applied Rob Herring 4 participants 5 messages Aug 23, 2022 – Aug 29, 2022

Subsystems (10)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

---
 Documentation/devicetree/bindings/display/arm,komeda.yaml        | 1 +
 Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
 Documentation/devicetree/bindings/display/msm/gpu.yaml           | 1 +
 .../bindings/display/samsung/samsung,exynos7-decon.yaml          | 1 +
 .../devicetree/bindings/display/samsung/samsung,fimd.yaml        | 1 +
 5 files changed, 5 insertions(+)
Documentation/devicetree/bindings/display/arm,komeda.yaml +1 -0
index 9f4aade97f10..3ad3eef89ca8 100644
@@ -58,6 +58,7 @@ properties:
 patternProperties:
   '^pipeline@[01]$':
     type: object
+    additionalProperties: false
     description:
       clocks
 
Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml +1 -0
index 3a8614e0f627..84aafcbf0919 100644
@@ -51,6 +51,7 @@ properties:
     properties:
       port@0:
         $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description: |
           For LVDS encoders, port 0 is the parallel input
           For LVDS decoders, port 0 is the LVDS input
Documentation/devicetree/bindings/display/msm/gpu.yaml +1 -0
index 3397bc31d087..0179c816fa6d 100644
@@ -81,6 +81,7 @@ properties:
 
   zap-shader:
     type: object
+    additionalProperties: false
     description: |
       For a5xx and a6xx devices this node contains a memory-region that
       points to reserved memory to store the zap shader that can be used to
Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml +1 -0
index 969bd8c563a5..dec1c9058876 100644
@@ -37,6 +37,7 @@ properties:
 
   i80-if-timings:
     type: object
+    additionalProperties: false
     description: timing configuration for lcd i80 interface support
     properties:
       cs-setup:
Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml +1 -0
index 5d5cc220f78a..7593938601bb 100644
@@ -40,6 +40,7 @@ properties:
 
   i80-if-timings:
     type: object
+    additionalProperties: false
     description: |
       Timing configuration for lcd i80 interface support.
       The parameters are defined as::
Signature · 1 line
2.34.1
reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring

Hi Rob,

Thank you for the patch.

Quoted 5 lines · Rob Herring

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

Quoted 68 lines
---
 Documentation/devicetree/bindings/display/arm,komeda.yaml        | 1 +
 Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
 Documentation/devicetree/bindings/display/msm/gpu.yaml           | 1 +
 .../bindings/display/samsung/samsung,exynos7-decon.yaml          | 1 +
 .../devicetree/bindings/display/samsung/samsung,fimd.yaml        | 1 +
 5 files changed, 5 insertions(+)
Documentation/devicetree/bindings/display/arm,komeda.yaml +1 -0
index 9f4aade97f10..3ad3eef89ca8 100644
@@ -58,6 +58,7 @@ properties:
 patternProperties:
   '^pipeline@[01]$':
     type: object
+    additionalProperties: false
     description:
       clocks
 
Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml +1 -0
index 3a8614e0f627..84aafcbf0919 100644
@@ -51,6 +51,7 @@ properties:
     properties:
       port@0:
         $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description: |
           For LVDS encoders, port 0 is the parallel input
           For LVDS decoders, port 0 is the LVDS input
Documentation/devicetree/bindings/display/msm/gpu.yaml +1 -0
index 3397bc31d087..0179c816fa6d 100644
@@ -81,6 +81,7 @@ properties:
 
   zap-shader:
     type: object
+    additionalProperties: false
     description: |
       For a5xx and a6xx devices this node contains a memory-region that
       points to reserved memory to store the zap shader that can be used to
Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml +1 -0
index 969bd8c563a5..dec1c9058876 100644
@@ -37,6 +37,7 @@ properties:
 
   i80-if-timings:
     type: object
+    additionalProperties: false
     description: timing configuration for lcd i80 interface support
     properties:
       cs-setup:
Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml +1 -0
index 5d5cc220f78a..7593938601bb 100644
@@ -40,6 +40,7 @@ properties:
 
   i80-if-timings:
     type: object
+    additionalProperties: false
     description: |
       Timing configuration for lcd i80 interface support.
       The parameters are defined as::
Signature · 3 lines
Regards,

Laurent Pinchart
Reviewed-by on v1 1/1
#3 lore raw
In reply to Rob Herring
Quoted 9 lines · Rob Herring

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

---
  Documentation/devicetree/bindings/display/arm,komeda.yaml        | 1 +
  Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
  Documentation/devicetree/bindings/display/msm/gpu.yaml           | 1 +
Quoted 3 lines
  .../bindings/display/samsung/samsung,exynos7-decon.yaml          | 1 +
  .../devicetree/bindings/display/samsung/samsung,fimd.yaml        | 1 +
  5 files changed, 5 insertions(+)
Signature · 2 lines
With best wishes
Dmitry
author maintainer Applied
#4 lore raw
In reply to Rob Herring
Quoted 4 lines · Rob Herring

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

Quoted 9 lines
---
 Documentation/devicetree/bindings/display/arm,komeda.yaml        | 1 +
 Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
 Documentation/devicetree/bindings/display/msm/gpu.yaml           | 1 +
 .../bindings/display/samsung/samsung,exynos7-decon.yaml          | 1 +
 .../devicetree/bindings/display/samsung/samsung,fimd.yaml        | 1 +
 5 files changed, 5 insertions(+)

Applied, thanks!