Skip to contentSkip to conversation

ar0521: Fix return value check in writing initial registers

PATCH In review Sakari Ailus 2 participants 2 messages Aug 30, 2022 – Sep 5, 2022

Subsystems (3)
lore
Share & tools
lore

Sakari Ailus

author maintainer
#0 lore raw

PATCH 1/1 ar0521: Fix return value check in writing initial registers

The return value from register writes is ignored apart from the last value. Fix this.

---
 drivers/media/i2c/ar0521.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/i2c/ar0521.c +2 -1
index 9e90b02b15e36..a586e0fc0ea3f 100644
@@ -755,11 +755,12 @@ static int ar0521_power_on(struct device *dev)
 		gpiod_set_value(sensor->reset_gpio, 0);
 	usleep_range(4500, 5000); /* min 45000 clocks */
 
-	for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++)
+	for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) {
 		ret = ar0521_write_regs(sensor, initial_regs[cnt].data,
 					initial_regs[cnt].count);
 		if (ret)
 			goto off;
+	}
 
 	ret = ar0521_write_reg(sensor, AR0521_REG_SERIAL_FORMAT,
 			       AR0521_REG_SERIAL_FORMAT_MIPI |
Signature · 1 line
2.30.2
maintainer Acked-by on v1 1/1
#1 lore raw

Hi Sakari,

Quoted 2 lines · Sakari Ailus

The return value from register writes is ignored apart from the last value. Fix this.

Must be Emacs' fault :-)

Quoted 2 lines
Quoted 12 lines

+++ b/drivers/media/i2c/ar0521.c

drivers/media/i2c/ar0521.c +2 -1
@@ -755,11 +755,12 @@ static int ar0521_power_on(struct device *dev)
 		gpiod_set_value(sensor->reset_gpio, 0);
 	usleep_range(4500, 5000); /* min 45000 clocks */
 
-	for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++)
+	for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) {
 		ret = ar0521_write_regs(sensor, initial_regs[cnt].data,
 					initial_regs[cnt].count);
 		if (ret)
 			goto off;
+	}
Signature · 5 lines
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa