ar0521: Fix return value check in writing initial registers
Subsystems (3)
Sakari Ailus
maintainerPATCH 1/1 ar0521: Fix return value check in writing initial registers
The return value from register writes is ignored apart from the last value. Fix this.
Reported-by kernel test robot <[email protected]>
Signed-off-by Sakari Ailus <[email protected]>
--- drivers/media/i2c/ar0521.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/i2c/ar0521.c +2 -1
@@ -755,11 +755,12 @@ static int ar0521_power_on(struct device *dev)gpiod_set_value (sensor->reset_gpio,0 );usleep_range (4500 ,5000 );/* min 45000 clocks */ -for (cnt =0 ; cnt <ARRAY_SIZE (initial_regs); cnt++) +for (cnt =0 ; cnt <ARRAY_SIZE (initial_regs); cnt++) { ret =ar0521_write_regs (sensor, initial_regs[cnt].data, initial_regs[cnt].count);if (ret) goto off; + } ret = ar0521_write_reg(sensor, AR0521_REG_SERIAL_FORMAT, AR0521_REG_SERIAL_FORMAT_MIPI |
Signature · 1 line
2.30.2
Hi Sakari,
Quoted 2 lines · Sakari Ailus
The return value from register writes is ignored apart from the last value. Fix this.
Must be Emacs' fault :-)
Quoted 2 lines
Reported-by kernel test robot <[email protected]>Signed-off-by Sakari Ailus <[email protected]>
Acked-by Krzysztof Hałasa <[email protected]>
Quoted 12 lines
+++
b/drivers/media/i2c/ar0521.cdrivers/media/i2c/ar0521.c +2
-1@@ -755,11 +755,12 @@ static int ar0521_power_on(struct device *dev)gpiod_set_value (sensor->reset_gpio,0 );usleep_range (4500 ,5000 );/* min 45000 clocks */ -for (cnt =0 ; cnt <ARRAY_SIZE (initial_regs); cnt++) +for (cnt =0 ; cnt <ARRAY_SIZE (initial_regs); cnt++) { ret =ar0521_write_regs (sensor, initial_regs[cnt].data, initial_regs[cnt].count);if (ret) goto off; + }
Signature · 5 lines
Krzysztof "Chris" Hałasa Sieć Badawcza Łukasiewicz Przemysłowy Instytut Automatyki i Pomiarów PIAP Al. Jerozolimskie 202, 02-486 Warszawa