mxs: Don't enable 4P2 reg if mx28 is powered only from DCDC_BATT without 5V
Subsystems (2)
RFC PATCH 1/1 mxs: Don't enable 4P2 reg if mx28 is powered only from DCDC_BATT without 5V
mxs_power_enable_4p2() was added to mxs_batt_boot() in
'commit a0f97610757d ("ARM: mxs: Enable DCDC converter for battery boot")' to enable DCDC converter when board is powered from 5V and has detected sufficient battery voltage.
This involves enabling 4P2 regulator and there is a code
in mxs_power_enable_4p2() that disables VDDIO, VDDA, VDDD outputs of the DCDC converter and enables BO for each power rail e.g.
setbits_le32(&power_regs->hw_power_vddioctrl, POWER_VDDIOCTRL_DISABLE_FET | POWER_VDDIOCTRL_PWDN_BRNOUT);
In case the mx28 is powered by the 5V source and linear regulators are supplying power to the VDDIO, VDDA, VDDD rails there is no issue.
However if the mx28 is powered by the DCDC_BATT source only without 5V, disabling the DCDC converter outputs causes brownout power down.
The proposed solution is not to call mxs_power_enable_4p2() at all if the mx28 is powered by the DCDC_BATT source only. There is no reason to enable 4P2 regulator in this case and setup of all registers is done in mxs_batt_boot().
Also there is no need to enable 5V brownout inmxs_power_init() in this case.
Please consider if this is acceptable and I will submit a proper patch.
---
arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/cpu/arm926ejs/mxs/spl_power_init.c +4 -0
@@ -752,7 +752,9 @@ static void mxs_batt_boot(void)POWER_5VCTRL_CHARGE_4P2_ILIMIT_MASK , 0x8 << POWER_5VCTRL_CHARGE_4P2_ILIMIT_OFFSET); +#ifndef CONFIG_SPL_MXS_NO_VDD5V_SOURCE mxs_power_enable_4p2 (); +#endif }/**
@@ -1267,7 +1269,9 @@ void mxs_power_init(void)POWER_CTRL_VBUS_VALID_IRQ |POWER_CTRL_BATT_BO_IRQ | POWER_CTRL_DCDC4P2_BO_IRQ, &power_regs->hw_power_ctrl_clr); +#ifndef CONFIG_SPL_MXS_NO_VDD5V_SOURCE writel (POWER_5VCTRL_PWDN_5VBRNOUT , &power_regs->hw_power_5vctrl_set); +#endif early_delay (1000 ); }
Signature · 1 line
2.25.1
Fabio Estevam
reviewerHi Alan,
[Adding Lukasz and Cody]
Quoted 23 lines · Alan Kay
mxs_power_enable_4p2()was added tomxs_batt_boot()in
'commita0f97610757d("ARM: mxs: Enable DCDC converter for battery boot")' to enable DCDC converter when board is powered from 5V and has detected sufficient battery voltage.
This involves enabling 4P2 regulator and there is a code
inmxs_power_enable_4p2()that disables VDDIO, VDDA, VDDD outputs of the DCDC converter and enables BO for each power rail e.g.setbits_le32(&power_regs->hw_power_vddioctrl, POWER_VDDIOCTRL_DISABLE_FET | POWER_VDDIOCTRL_PWDN_BRNOUT);In case the mx28 is powered by the 5V source and linear regulators are supplying power to the VDDIO, VDDA, VDDD rails there is no issue.
However if the mx28 is powered by the
DCDC_BATTsource only without 5V, disabling the DCDC converter outputs causes brownout power down.The proposed solution is not to call
mxs_power_enable_4p2()at all if the mx28 is powered by theDCDC_BATTsource only. There is no reason to enable 4P2 regulator in this case and setup of all registers is done inmxs_batt_boot().
Quoted 6 lines
Also there is no need to enable 5V brownout in
mxs_power_init()in this case.Please consider if this is acceptable and I will submit a proper patch.
Signed-off-by Alan Kay <[email protected]>
Cody also sent a fix for this issue:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Hi Fabio, Alan,
Quoted 33 lines
Hi Alan,
[Adding Lukasz and Cody]
Quoted 28 lines · Alan Kay
mxs_power_enable_4p2()was added tomxs_batt_boot()in 'commita0f97610757d("ARM: mxs: Enable DCDC converter for battery boot")' to enable DCDC converter when board is powered from 5V and has detected sufficient battery voltage.
This involves enabling 4P2 regulator and there is a code inmxs_power_enable_4p2()that disables VDDIO, VDDA, VDDD outputs of the DCDC converter and enables BO for each power rail e.g.setbits_le32(&power_regs->hw_power_vddioctrl, POWER_VDDIOCTRL_DISABLE_FET |
POWER_VDDIOCTRL_PWDN_BRNOUT);In case the mx28 is powered by the 5V source and linear regulators are supplying power to the VDDIO, VDDA, VDDD rails there is no issue.
However if the mx28 is powered by the
DCDC_BATTsource only without 5V, disabling the DCDC converter outputs causes brownout power down.The proposed solution is not to call
mxs_power_enable_4p2()at all if the mx28 is powered by theDCDC_BATTsource only. There is no reason to enable 4P2 regulator in this case and setup of all registers is done inmxs_batt_boot().Also there is no need to enable 5V brownout in
mxs_power_init()in this case.
Quoted 8 lines
Quoted 4 lines
Please consider if this is acceptable and I will submit a proper patch.
Signed-off-by Alan Kay <[email protected]>Cody also sent a fix for this issue:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Isn't this already addressed with:
https://source.denx.de/u-boot/u-boot/-/commit/79230640cb4fb780e2be9bb9a47b31976b18cac4
Please also look into the recent patches for imx287 (xea board for reference):
tig -- arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
At least SHA1: 65b9b3462bec2966911658836983819ab4e4823e
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]
Hi Lukasz,
Quoted 58 lines · Lukasz Majewski
Hi Fabio, Alan,
Quoted 33 lines
Hi Alan,
[Adding Lukasz and Cody]
Quoted 28 lines · Alan Kay
mxs_power_enable_4p2()was added tomxs_batt_boot()in 'commita0f97610757d("ARM: mxs: Enable DCDC converter for battery boot")' to enable DCDC converter when board is powered from 5V and has detected sufficient battery voltage.
This involves enabling 4P2 regulator and there is a code inmxs_power_enable_4p2()that disables VDDIO, VDDA, VDDD outputs of the DCDC converter and enables BO for each power rail e.g.setbits_le32(&power_regs->hw_power_vddioctrl, POWER_VDDIOCTRL_DISABLE_FET |
POWER_VDDIOCTRL_PWDN_BRNOUT);In case the mx28 is powered by the 5V source and linear regulators are supplying power to the VDDIO, VDDA, VDDD rails there is no issue.
However if the mx28 is powered by the
DCDC_BATTsource only without 5V, disabling the DCDC converter outputs causes brownout power down.The proposed solution is not to call
mxs_power_enable_4p2()at all if the mx28 is powered by theDCDC_BATTsource only. There is no reason to enable 4P2 regulator in this case and setup of all registers is done inmxs_batt_boot().Also there is no need to enable 5V brownout in
mxs_power_init()in this case.Quoted 8 lines
Quoted 4 lines
Please consider if this is acceptable and I will submit a proper patch.
Signed-off-by Alan Kay <[email protected]>Cody also sent a fix for this issue:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Isn't this already addressed with:
https://source.denx.de/u-boot/u-boot/-/commit/79230640cb4fb780e2be9bb9a47b31976b18cac4Please also look into the recent patches for imx287 (xea board for reference):
tig --
arch/arm/cpu/arm926ejs/mxs/spl_power_init.cAt least SHA1:
65b9b3462bec2966911658836983819ab4e4823eBest regards,
Quoted 7 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]
The patch:
https://source.denx.de/u-boot/u-boot/-/commit/79230640cb4fb780e2be9bb9a47b31976b18cac4
does fix the issue, please feel free to discard my patch, thank you.
Best regards,
Alan Kay
Fabio Estevam
reviewerHi Alan and Cody,
Quoted 3 lines · Alan Kay
The patch:
https://source.denx.de/u-boot/u-boot/-/commit/79230640cb4fb780e2be9bb9a47b31976b18cac4
does fix the issue, please feel free to discard my patch, thank you.
Ok, what about the patch below?
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Is this still needed?
Fabio Estevam
reviewerQuoted 5 lines · Fabio Estevam
Ok, what about the patch below?
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Is this still needed?
I looked in the i.MX28 Reference Manual, and the one above looks a correct fix. I will queue it.
Quoted 11 lines · Fabio Estevam
Quoted 5 lines · Fabio Estevam
Ok, what about the patch below?
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Is this still needed?
I looked in the i.MX28 Reference Manual, and the one above looks a correct fix. I will queue it.
Yes, this patch is needed, thank you for queuing it.