Skip to contentSkip to conversation

configs: stm32mp*: reset via CONFIG_RESET_SCMI

PATCH In review Jorge Ramirez-Ortiz 3 participants 4 messages Aug 30, 2022 – Sep 19, 2022 Arm STM32

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: stm32mp*: reset via CONFIG_RESET_SCMI

Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI from executing.

The side effect observed are I2C devices no longer being accessible from U-boot after a soft reset.

---
 configs/stm32mp13_defconfig         | 1 -
 configs/stm32mp15_defconfig         | 1 -
 configs/stm32mp15_trusted_defconfig | 1 -
 3 files changed, 3 deletions(-)
configs/stm32mp13_defconfig +0 -1
index 673b468d31..44cee2e656 100644
@@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y
 CONFIG_DM_RTC=y
 CONFIG_RTC_STM32=y
 CONFIG_SERIAL_RX_BUFFER=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
configs/stm32mp15_defconfig +0 -1
index e5a2996c2c..2ad02f3652 100644
@@ -133,7 +133,6 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_STM32_QSPI=y
 CONFIG_STM32_SPI=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
configs/stm32mp15_trusted_defconfig +0 -1
index e14668042f..9e24e82920 100644
@@ -134,7 +134,6 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_STM32_QSPI=y
 CONFIG_STM32_SPI=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
Signature · 1 line
2.34.1
#1 lore raw
Quoted 5 lines · Jorge Ramirez-Ortiz

Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI from executing.

The side effect observed are I2C devices no longer being accessible from U-boot after a soft reset.

I think this PR should get a bit more of attention.

The current reset configuration is broken, this is a fix. Do I need to rename the PR?

TIA
jorge

Quoted 47 lines
---
 configs/stm32mp13_defconfig         | 1 -
 configs/stm32mp15_defconfig         | 1 -
 configs/stm32mp15_trusted_defconfig | 1 -
 3 files changed, 3 deletions(-)
configs/stm32mp13_defconfig +0 -1
index 673b468d31..44cee2e656 100644
@@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y
 CONFIG_DM_RTC=y
 CONFIG_RTC_STM32=y
 CONFIG_SERIAL_RX_BUFFER=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
configs/stm32mp15_defconfig +0 -1
index e5a2996c2c..2ad02f3652 100644
@@ -133,7 +133,6 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_STM32_QSPI=y
 CONFIG_STM32_SPI=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
configs/stm32mp15_trusted_defconfig +0 -1
index e14668042f..9e24e82920 100644
@@ -134,7 +134,6 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_STM32_QSPI=y
 CONFIG_STM32_SPI=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
Signature · 1 line
2.34.1
#2 lore raw

Jorge,

I think, renaming the patch to "fix" and adding a field "Fixes:" should help accept it faster.

Quoted 64 lines · Foundries
Quoted 5 lines · Jorge Ramirez-Ortiz

Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI from executing.

The side effect observed are I2C devices no longer being accessible from U-boot after a soft reset.

I think this PR should get a bit more of attention.

The current reset configuration is broken, this is a fix. Do I need to rename the PR?

TIA
jorge

Quoted 47 lines
---
 configs/stm32mp13_defconfig         | 1 -
 configs/stm32mp15_defconfig         | 1 -
 configs/stm32mp15_trusted_defconfig | 1 -
 3 files changed, 3 deletions(-)
configs/stm32mp13_defconfig +0 -1
index 673b468d31..44cee2e656 100644
@@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y
 CONFIG_DM_RTC=y
 CONFIG_RTC_STM32=y
 CONFIG_SERIAL_RX_BUFFER=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
configs/stm32mp15_defconfig +0 -1
index e5a2996c2c..2ad02f3652 100644
@@ -133,7 +133,6 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_STM32_QSPI=y
 CONFIG_STM32_SPI=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
configs/stm32mp15_trusted_defconfig +0 -2
index e14668042f..9e24e82920 100644
@@ -134,7 +134,6 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_STM32_QSPI=y
 CONFIG_STM32_SPI=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
--

2.34.1

Signature · 5 lines
Best regards
Oleksandr

Oleksandr Suvorov
[email protected]
#3 lore raw

Hi,

Quoted 60 lines · Oleksandr Suvorov

Jorge,

I think, renaming the patch to "fix" and adding a field "Fixes:" should help accept it faster.

Quoted 53 lines · Foundries
Quoted 5 lines · Jorge Ramirez-Ortiz

Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI from executing.

The side effect observed are I2C devices no longer being accessible from U-boot after a soft reset.

I think this PR should get a bit more of attention.

The current reset configuration is broken, this is a fix. Do I need to rename the PR?

TIA
jorge

Quoted 38 lines
---
  configs/stm32mp13_defconfig         | 1 -
  configs/stm32mp15_defconfig         | 1 -
  configs/stm32mp15_trusted_defconfig | 1 -
  3 files changed, 3 deletions(-)
configs/stm32mp13_defconfig +0 -1
index 673b468d31..44cee2e656 100644
@@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y
  CONFIG_DM_RTC=y
  CONFIG_RTC_STM32=y
  CONFIG_SERIAL_RX_BUFFER=y
-CONFIG_SYSRESET_PSCI=y
  CONFIG_TEE=y
  CONFIG_OPTEE=y
  # CONFIG_OPTEE_TA_AVB is not set
configs/stm32mp15_defconfig +0 -1
index e5a2996c2c..2ad02f3652 100644
@@ -133,7 +133,6 @@ CONFIG_SPI=y
  CONFIG_DM_SPI=y
  CONFIG_STM32_QSPI=y
  CONFIG_STM32_SPI=y
-CONFIG_SYSRESET_PSCI=y
  CONFIG_TEE=y
  CONFIG_OPTEE=y
  # CONFIG_OPTEE_TA_AVB is not set
configs/stm32mp15_trusted_defconfig +0 -0
index e14668042f..9e24e82920 100644
@@ -134,7 +134,6 @@ CONFIG_SPI=y
  CONFIG_DM_SPI=y
  CONFIG_STM32_QSPI=y
Quoted 10 lines
Quoted 8 lines
Quoted 8 lines
configs/stm32mp15_trusted_defconfig +0 -2
  CONFIG_STM32_SPI=y
-CONFIG_SYSRESET_PSCI=y
  CONFIG_TEE=y
  CONFIG_OPTEE=y
  # CONFIG_OPTEE_TA_AVB is not set
--

2.34.1

This patch it is superseded by "configs: stm32mp*: fix system reset"

http://patchwork.ozlabs.org/project/uboot/list/?series=316914&state=*

http://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

with the added "Fixes:"

Regards

Patrick