Skip to contentSkip to conversation

nvme-target: add missing goto in nvmet_setup_auth()

PATCH Applied Hannes Reinecke 4 participants 4 messages Aug 24, 2022 – Aug 31, 2022

Subsystems (3)
lore
Share & tools
lore

Hannes Reinecke

author maintainer
#0 lore raw

PATCH 1/1 nvme-target: add missing goto in nvmet_setup_auth()

There's a goto missing in nvmet_setup_auth(), causing a kernel oops when nvme_auth_extract_key() fails.

---
 drivers/nvme/target/auth.c | 1 +
 1 file changed, 1 insertion(+)
drivers/nvme/target/auth.c +1 -0
index cf690df34775..c4113b43dbfe 100644
@@ -196,6 +196,7 @@ int nvmet_setup_auth(struct nvmet_ctrl *ctrl)
 	if (IS_ERR(ctrl->ctrl_key)) {
 		ret = PTR_ERR(ctrl->ctrl_key);
 		ctrl->ctrl_key = NULL;
+		goto out_free_hash;
 	}
 	pr_debug("%s: using ctrl hash %s key %*ph\n", __func__,
 		 ctrl->ctrl_key->hash > 0 ?
Signature · 1 line
2.35.3