Skip to contentSkip to conversation

dt-bindings: power: Add missing (unevaluated|additional)Properties on child nodes

PATCH Applied Rob Herring 3 participants 4 messages Aug 23, 2022 – Aug 31, 2022

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: power: Add missing (unevaluated|additional)Properties on child nodes

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

---
 .../bindings/power/domain-idle-state.yaml          | 10 ++++++++++
 .../devicetree/bindings/power/fsl,imx-gpc.yaml     | 14 ++++++++++++++
 .../devicetree/bindings/power/fsl,imx-gpcv2.yaml   | 14 ++++++++++++++
 3 files changed, 38 insertions(+)
Documentation/devicetree/bindings/power/domain-idle-state.yaml +10 -0
index 6a12efdf436a..4ee920a1de69 100644
@@ -20,6 +20,7 @@ properties:
 patternProperties:
   "^(cpu|cluster|domain)-":
     type: object
+    additionalProperties: false
     description:
       Each state node represents a domain idle state description.
 
@@ -44,6 +45,15 @@ patternProperties:
           state will yield power benefits, after overcoming the overhead while
           entering the idle state.
 
+      arm,psci-suspend-param:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        description: |
+          power_state parameter to pass to the ARM PSCI suspend call.
+
+          Device tree nodes that require usage of PSCI CPU_SUSPEND function
+          (i.e. idle states node with entry-method property is set to "psci")
+          must specify this property.
+
     required:
       - compatible
       - entry-latency-us
Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml +14 -0
index a055b3e819d8..777e1d852ddd 100644
@@ -43,11 +43,21 @@ properties:
 
   pgc:
     type: object
+    additionalProperties: false
     description: list of power domains provided by this controller.
 
+    properties:
+      '#address-cells':
+        const: 1
+
+      '#size-cells':
+        const: 0
+
     patternProperties:
       "power-domain@[0-9]$":
         type: object
+        additionalProperties: false
+
         properties:
 
           '#power-domain-cells':
@@ -78,6 +88,10 @@ properties:
           - '#power-domain-cells'
           - reg
 
+    required:
+      - '#address-cells'
+      - '#size-cells'
+
 required:
   - compatible
   - reg
Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml +14 -0
index 747622bdc57b..3b161e01f920 100644
@@ -42,11 +42,21 @@ properties:
 
   pgc:
     type: object
+    additionalProperties: false
     description: list of power domains provided by this controller.
 
+    properties:
+      '#address-cells':
+        const: 1
+
+      '#size-cells':
+        const: 0
+
     patternProperties:
       "power-domain@[0-9]$":
         type: object
+        additionalProperties: false
+
         properties:
 
           '#power-domain-cells':
@@ -85,6 +95,10 @@ properties:
           - '#power-domain-cells'
           - reg
 
+    required:
+      - '#address-cells'
+      - '#size-cells'
+
 required:
   - compatible
   - reg
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Acked-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 6 lines · Rob Herring

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

Kind regards
Uffe

Quoted 109 lines
---
 .../bindings/power/domain-idle-state.yaml          | 10 ++++++++++
 .../devicetree/bindings/power/fsl,imx-gpc.yaml     | 14 ++++++++++++++
 .../devicetree/bindings/power/fsl,imx-gpcv2.yaml   | 14 ++++++++++++++
 3 files changed, 38 insertions(+)
Documentation/devicetree/bindings/power/domain-idle-state.yaml +10 -0
index 6a12efdf436a..4ee920a1de69 100644
@@ -20,6 +20,7 @@ properties:
 patternProperties:
   "^(cpu|cluster|domain)-":
     type: object
+    additionalProperties: false
     description:
       Each state node represents a domain idle state description.
 
@@ -44,6 +45,15 @@ patternProperties:
           state will yield power benefits, after overcoming the overhead while
           entering the idle state.
 
+      arm,psci-suspend-param:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        description: |
+          power_state parameter to pass to the ARM PSCI suspend call.
+
+          Device tree nodes that require usage of PSCI CPU_SUSPEND function
+          (i.e. idle states node with entry-method property is set to "psci")
+          must specify this property.
+
     required:
       - compatible
       - entry-latency-us
Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml +14 -0
index a055b3e819d8..777e1d852ddd 100644
@@ -43,11 +43,21 @@ properties:
 
   pgc:
     type: object
+    additionalProperties: false
     description: list of power domains provided by this controller.
 
+    properties:
+      '#address-cells':
+        const: 1
+
+      '#size-cells':
+        const: 0
+
     patternProperties:
       "power-domain@[0-9]$":
         type: object
+        additionalProperties: false
+
         properties:
 
           '#power-domain-cells':
@@ -78,6 +88,10 @@ properties:
           - '#power-domain-cells'
           - reg
 
+    required:
+      - '#address-cells'
+      - '#size-cells'
+
 required:
   - compatible
   - reg
Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml +14 -1
index 747622bdc57b..3b161e01f920 100644
@@ -42,11 +42,21 @@ properties:
 
   pgc:
     type: object
+    additionalProperties: false
     description: list of power domains provided by this controller.
 
+    properties:
+      '#address-cells':
+        const: 1
+
+      '#size-cells':
+        const: 0
+
     patternProperties:
       "power-domain@[0-9]$":
         type: object
+        additionalProperties: false
+
         properties:
 
           '#power-domain-cells':
@@ -85,6 +95,10 @@ properties:
           - '#power-domain-cells'
           - reg
 
+    required:
+      - '#address-cells'
+      - '#size-cells'
+
 required:
   - compatible
   - reg
--
Quoted 2 lines

2.34.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer Applied
#3 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring

In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically).

---
 .../bindings/power/domain-idle-state.yaml          | 10 ++++++++++
 .../devicetree/bindings/power/fsl,imx-gpc.yaml     | 14 ++++++++++++++
 .../devicetree/bindings/power/fsl,imx-gpcv2.yaml   | 14 ++++++++++++++
 3 files changed, 38 insertions(+)

Applied, thanks!