Initial Meteorlake Support
Subsystems (3)
v4 cover Initial Meteorlake Support
The PCI Id's and platform definition are posted earlier. This series adds handful of early enablement patches including support for display power wells, VBT and AUX Channel mapping, PCH and gmbus support, dbus, mbus, sagv and memory bandwidth support.
This series also add the support for a new way to read Graphics, Media and Display versions
This is based out of the earlier series posted at [1]. Several of the patches from the earlier series got merged. This version is rebased on top of the earlier patches that got merged.
[1] https://patchwork.freedesktop.org/series/106786/
Imre Deak (2):
drm/i915/mtl: Add display power wells
drm/i915/mtl: Add DP AUX support on TypeC ports
José Roberto de Souza (1):
drm/i915: Parse and set stepping for platforms with GMD
Madhumitha Tolakanahalli Pradeep (1):
drm/i915/mtl: Update CHICKEN_TRANS* register addresses
Matt Roper (2):
drm/i915: Read graphics/media/display arch version from hw drm/i915/mtl: Define engine context layouts
Radhakrishna Sripada (5):
drm/i915: Move display and media IP version to runtime info drm/i915/mtl: Add gmbus and gpio support
drm/i915/mtl: Obtain SAGV values from MMIO instead of GT pcode mailbox drm/i915/mtl: Update MBUS_DBOX credits
drm/i915/mtl: Do not update GV point, mask value
drivers/gpu/drm/i915/display/intel_bw.c | 42 ++++++- drivers/gpu/drm/i915/display/intel_display.c | 14 ++- .../i915/display/intel_display_power_map.c | 115 +++++++++++++++++- .../i915/display/intel_display_power_well.c | 44 +++++++ .../i915/display/intel_display_power_well.h | 4 + drivers/gpu/drm/i915/display/intel_dp_aux.c | 53 +++++++- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +- drivers/gpu/drm/i915/display/intel_gmbus.c | 15 +++ drivers/gpu/drm/i915/display/intel_gmbus.h | 1 + drivers/gpu/drm/i915/display/intel_psr.c | 6 +- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/gt/intel_lrc.c | 81 +++++++++++- drivers/gpu/drm/i915/i915_driver.c | 3 +- drivers/gpu/drm/i915/i915_drv.h | 16 +-- drivers/gpu/drm/i915/i915_pci.c | 39 +++--- drivers/gpu/drm/i915/i915_reg.h | 83 ++++++++++++- drivers/gpu/drm/i915/intel_device_info.c | 102 ++++++++++++++-- drivers/gpu/drm/i915/intel_device_info.h | 27 ++-- drivers/gpu/drm/i915/intel_dram.c | 41 ++++++- drivers/gpu/drm/i915/intel_pm.c | 73 ++++++++++- drivers/gpu/drm/i915/intel_step.c | 60 +++++++++ 21 files changed, 754 insertions(+), 72 deletions(-)
Signature · 1 line
2.34.1
PATCH v4 1/11 drm/i915: Move display and media IP version to runtime info
Future platforms can read the IP version from a register and the IP version numbers need not be hard coded in device info. Move the ip version for media and display to runtime info.
On platforms where hard coding of IP version is required, update the IP version in __runtime under device_info.
v2:
- Avoid name collision for ip versions(Jani)
--- drivers/gpu/drm/i915/i915_drv.h | 14 ++++----- drivers/gpu/drm/i915/i915_pci.c | 38 ++++++++++++------------ drivers/gpu/drm/i915/intel_device_info.c | 28 ++++++++++------- drivers/gpu/drm/i915/intel_device_info.h | 15 ++++++---- 4 files changed, 53 insertions(+), 42 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +7 -7
@@ -469,19 +469,19 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)#define IP_VER (ver, rel) ((ver) << 8 | (rel)) -#define GRAPHICS_VER (i915) (RUNTIME_INFO(i915)->graphics.ver) -#define GRAPHICS_VER_FULL (i915) IP_VER(RUNTIME_INFO(i915)->graphics.ver, \ - RUNTIME_INFO(i915)->graphics.rel) +#define GRAPHICS_VER (i915) (RUNTIME_INFO(i915)->graphics.version.ver) +#define GRAPHICS_VER_FULL (i915) IP_VER(RUNTIME_INFO(i915)->graphics.version.ver, \ + RUNTIME_INFO(i915)->graphics.version.rel)#define IS_GRAPHICS_VER (i915, from, until) \ (GRAPHICS_VER(i915) >= (from) && GRAPHICS_VER(i915) <= (until)) -#define MEDIA_VER (i915) (INTEL_INFO(i915)->media.ver) -#define MEDIA_VER_FULL (i915) IP_VER(INTEL_INFO(i915)->media.ver, \ - INTEL_INFO(i915)->media.rel) +#define MEDIA_VER (i915) (RUNTIME_INFO(i915)->media.version.ver) +#define MEDIA_VER_FULL (i915) IP_VER(RUNTIME_INFO(i915)->media.version.ver, \ + RUNTIME_INFO(i915)->media.version.rel)#define IS_MEDIA_VER (i915, from, until) \ (MEDIA_VER(i915) >= (from) && MEDIA_VER(i915) <= (until)) -#define DISPLAY_VER (i915) (INTEL_INFO(i915)->display.ver) +#define DISPLAY_VER (i915) (RUNTIME_INFO(i915)->display.version.ver)#define IS_DISPLAY_VER (i915, from, until) \ (DISPLAY_VER(i915) >= (from) && DISPLAY_VER(i915) <= (until))
drivers/gpu/drm/i915/i915_pci.c +19 -19
@@ -34,9 +34,9 @@#define PLATFORM (x) .platform = (x)#define GEN (x) \ - .__runtime.graphics.ver = (x), \ - .media.ver = (x), \ - .display.ver = (x) + .__runtime.graphics.version.ver = (x), \ + .__runtime.media.version.ver = (x), \ + .__runtime.display.version.ver = (x)#define I845_PIPE_OFFSETS \ .display.pipe_offsets = { \
@@ -740,7 +740,7 @@ static const struct intel_device_info bxt_info = {static const struct intel_device_info glk_info = {GEN9_LP_FEATURES ,PLATFORM (INTEL_GEMINILAKE ), - .display.ver =10 , + .__runtime.display.version.ver =10 , .display.dbuf.size =1024 -4 ,/* 4 blocks for bypass path allocation */ GLK_COLORS , };
@@ -919,7 +919,7 @@ static const struct intel_device_info rkl_info = {static const struct intel_device_info dg1_info = {GEN12_FEATURES ,DGFX_FEATURES , - .__runtime.graphics.rel =10 , + .__runtime.graphics.version.rel =10 ,PLATFORM (INTEL_DG1 ), .__runtime.pipe_mask =BIT (PIPE_A ) |BIT (PIPE_B ) |BIT (PIPE_C ) |BIT (PIPE_D ), .require_force_probe =1 ,
@@ -962,7 +962,7 @@ static const struct intel_device_info adl_s_info = { .display.has_hotplug = 1, \ .display.has_ipc = 1, \ .display.has_psr = 1, \ - .display.ver = 13, \ + .__runtime.display.version.ver = 13, \ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \ .display.pipe_offsets = { \ [TRANSCODER_A] = PIPE_A_OFFSET, \
@@ -1006,8 +1006,8 @@ static const struct intel_device_info adl_p_info = { I915_GTT_PAGE_SIZE_2M#define XE_HP_FEATURES \ - .__runtime.graphics.ver = 12, \ - .__runtime.graphics.rel = 50, \ + .__runtime.graphics.version.ver = 12, \ + .__runtime.graphics.version.rel = 50, \ XE_HP_PAGE_SIZES, \ .dma_mask_size = 46, \ .has_3d_pipeline = 1, \
@@ -1027,8 +1027,8 @@ static const struct intel_device_info adl_p_info = { .__runtime.ppgtt_type = INTEL_PPGTT_FULL#define XE_HPM_FEATURES \ - .media.ver = 12, \ - .media.rel = 50 + .__runtime.media.version.ver = 12, \ + .__runtime.media.version.rel = 50__maybe_unused static const struct intel_device_info xehpsdv_info = {
@@ -1053,8 +1053,8 @@ static const struct intel_device_info xehpsdv_info = {XE_HP_FEATURES , \XE_HPM_FEATURES , \DGFX_FEATURES , \ - .__runtime.graphics.rel = 55, \ - .media.rel = 55, \ + .__runtime.graphics.version.rel = 55, \ + .__runtime.media.version.rel = 55, \PLATFORM (INTEL_DG2 ), \ .has_4tile = 1, \ .has_64k_pages = 1, \
@@ -1097,8 +1097,8 @@ static const struct intel_device_info pvc_info = {XE_HPC_FEATURES ,XE_HPM_FEATURES ,DGFX_FEATURES , - .__runtime.graphics.rel = 60, - .media.rel = 60, + .__runtime.graphics.version.rel = 60, + .__runtime.media.version.rel = 60,PLATFORM (INTEL_PONTEVECCHIO ), .display = { 0 }, .has_flat_ccs = 0,
@@ -1111,7 +1111,7 @@ static const struct intel_device_info pvc_info = {#define XE_LPDP_FEATURES \ XE_LPD_FEATURES, \ - .display.ver = 14, \ + .__runtime.display.version.ver = 14, \ .display.has_cdclk_crawl = 1, \ .__runtime.fbc_mask = BIT(INTEL_FBC_A) | BIT(INTEL_FBC_B)
@@ -1123,9 +1123,9 @@ static const struct intel_device_info mtl_info = {* Real graphics IP version will be obtained from hardware GMD_ID * register. Value provided here is just for sanity checking. */ - .__runtime.graphics.ver = 12, - .__runtime.graphics.rel = 70, - .media.ver =13 , + .__runtime.graphics.version.ver = 12, + .__runtime.graphics.version.rel = 70, + .__runtime.media.version.ver =13 ,PLATFORM (INTEL_METEORLAKE ), .display.has_modular_fia = 1, .has_flat_ccs = 0,
@@ -1281,7 +1281,7 @@ bool i915_pci_resource_valid(struct pci_dev *pdev, int bar)static bool intel_mmio_bar_valid (struct pci_dev *pdev,struct intel_device_info *intel_info) { -int gttmmaddr_bar = intel_info->__runtime.graphics.ver ==2 ?GEN2_GTTMMADR_BAR :GTTMMADR_BAR ; +int gttmmaddr_bar = intel_info->__runtime.graphics.version.ver ==2 ?GEN2_GTTMMADR_BAR :GTTMMADR_BAR ;return i915_pci_resource_valid (pdev, gttmmaddr_bar); }
drivers/gpu/drm/i915/intel_device_info.c +18 -10
@@ -92,21 +92,29 @@ void intel_device_info_print(const struct intel_device_info *info, const struct intel_runtime_info *runtime, struct drm_printer *p) { - if (runtime->graphics.rel) - drm_printf(p, "graphics version: %u.%02u\n", runtime->graphics.ver, - runtime->graphics.rel); + if (runtime->graphics.version.rel) + drm_printf(p, "graphics version: %u.%02u\n", + runtime->graphics.version.ver, + runtime->graphics.version.rel); else - drm_printf(p, "graphics version: %u\n", runtime->graphics.ver); + drm_printf(p, "graphics version: %u\n", + runtime->graphics.version.ver); -if (info->media.rel) -drm_printf (p,"media version: %u.%02u\n" , info->media.ver, info->media.rel); +if (runtime->media.version.rel) +drm_printf (p,"media version: %u.%02u\n" , + runtime->media.version.ver, + runtime->media.version.rel);else -drm_printf (p,"media version: %u\n" , info->media.ver); +drm_printf (p,"media version: %u\n" , + runtime->media.version.ver); -if (info->display.rel) -drm_printf (p,"display version: %u.%02u\n" , info->display.ver, info->display.rel); +if (runtime->display.version.rel) +drm_printf (p,"display version: %u.%02u\n" , + runtime->display.version.ver, + runtime->display.version.rel);else -drm_printf (p,"display version: %u\n" , info->display.ver); +drm_printf (p,"display version: %u\n" , + runtime->display.version.ver);drm_printf (p,"gt: %d\n" , info->gt);drm_printf (p,"memory-regions: %x\n" , runtime->memory_regions);
drivers/gpu/drm/i915/intel_device_info.h +9 -6
@@ -200,7 +200,15 @@ struct ip_version { };struct intel_runtime_info { -struct ip_version graphics; +struct { +struct ip_version version; + } graphics; +struct { +struct ip_version version; + } media; +struct { +struct ip_version version; + } display;/* * Platform mask is used for optimizing or-ed IS_PLATFORM calls into
@@ -246,8 +254,6 @@ struct intel_runtime_info { };struct intel_device_info { -struct ip_version media; -enum intel_platform platform;unsigned int dma_mask_size;/* available DMA address bits */
@@ -259,9 +265,6 @@ struct intel_device_info {#undef DEFINE_FLAGstruct { -u8 ver; -u8 rel; -u8 abox_mask;struct {
Signature · 1 line
2.34.1
kernel test robot
build botRe: [PATCH v4 01/11] drm/i915: Move display and media IP version to runtime info
Thank you for the patch! Yet something to improve:
Hi Radhakrishna,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20220901]
[cannot apply to drm-intel/for-linux-next drm/drm-next drm-misc/drm-misc-next linus/master v6.0-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Radhakrishna-Sripada/Initial-Meteorlake-Support/20220902-140730 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220903/[email protected]/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/159b13997e25c824f0404a44fd47e559eb56b97d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Radhakrishna-Sripada/Initial-Meteorlake-Support/20220902-140730 git checkout 159b13997e25c824f0404a44fd47e559eb56b97d # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/i915_gem.c:1267:
drivers/gpu/drm/i915/selftests/mock_gem_device.c: In function 'mock_gem_device':
>> drivers/gpu/drm/i915/selftests/mock_gem_device.c:175:37: error: 'struct <anonymous>' has no member named 'ver'
175 | RUNTIME_INFO(i915)->graphics.ver = -1;
| ^vim +175 drivers/gpu/drm/i915/selftests/mock_gem_device.c
bec68cc9ea42d8 Tvrtko Ursulin 2022-03-19 119
66d9cb5d805af7 Chris Wilson 2017-02-13 120 struct drm_i915_private *mock_gem_device(void)
66d9cb5d805af7 Chris Wilson 2017-02-13 121 {
01b9d4e21148c8 Joerg Roedel 2020-06-25 122 #if IS_ENABLED(CONFIG_IOMMU_API) && defined(CONFIG_INTEL_IOMMU)
9f9f4101fc98db Chris Wilson 2020-09-16 123 static struct dev_iommu fake_iommu = { .priv = (void *)-1 };
01b9d4e21148c8 Joerg Roedel 2020-06-25 124 #endif
9f9f4101fc98db Chris Wilson 2020-09-16 125 struct drm_i915_private *i915;
9f9f4101fc98db Chris Wilson 2020-09-16 126 struct pci_dev *pdev;
d148738923fdb5 Thomas Hellström 2021-06-02 127 int ret;
66d9cb5d805af7 Chris Wilson 2017-02-13 128
7fb81e9d80738e Daniel Vetter 2020-03-23 129 pdev = kzalloc(sizeof(*pdev), GFP_KERNEL);
66d9cb5d805af7 Chris Wilson 2017-02-13 130 if (!pdev)
7fb81e9d80738e Daniel Vetter 2020-03-23 131 return NULL;
66d9cb5d805af7 Chris Wilson 2017-02-13 132 device_initialize(&pdev->dev);
29f31623d7a830 Chris Wilson 2017-05-18 133 pdev->class = PCI_BASE_CLASS_DISPLAY << 16;
66d9cb5d805af7 Chris Wilson 2017-02-13 134 pdev->dev.release = release_dev;
66d9cb5d805af7 Chris Wilson 2017-02-13 135 dev_set_name(&pdev->dev, "mock");
d58f0083d39a17 Chris Wilson 2019-01-07 136 dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
66d9cb5d805af7 Chris Wilson 2017-02-13 137
764d2997ec0edb Arnd Bergmann 2017-10-05 138 #if IS_ENABLED(CONFIG_IOMMU_API) && defined(CONFIG_INTEL_IOMMU)
9f9f4101fc98db Chris Wilson 2020-09-16 139 /* HACK to disable iommu for the fake device; force identity mapping */
9f9f4101fc98db Chris Wilson 2020-09-16 140 pdev->dev.iommu = &fake_iommu;
f46f156ea7704a Chris Wilson 2017-09-18 141 #endif
cd01269d11a352 Daniel Vetter 2020-09-19 142 if (!devres_open_group(&pdev->dev, NULL, GFP_KERNEL)) {
cd01269d11a352 Daniel Vetter 2020-09-19 143 put_device(&pdev->dev);
cd01269d11a352 Daniel Vetter 2020-09-19 144 return NULL;
cd01269d11a352 Daniel Vetter 2020-09-19 145 }
cd01269d11a352 Daniel Vetter 2020-09-19 146
cd01269d11a352 Daniel Vetter 2020-09-19 147 i915 = devm_drm_dev_alloc(&pdev->dev, &mock_driver,
cd01269d11a352 Daniel Vetter 2020-09-19 148 struct drm_i915_private, drm);
cd01269d11a352 Daniel Vetter 2020-09-19 149 if (IS_ERR(i915)) {
cd01269d11a352 Daniel Vetter 2020-09-19 150 pr_err("Failed to allocate mock GEM device: err=%ld\n", PTR_ERR(i915));
cd01269d11a352 Daniel Vetter 2020-09-19 151 devres_release_group(&pdev->dev, NULL);
cd01269d11a352 Daniel Vetter 2020-09-19 152 put_device(&pdev->dev);
cd01269d11a352 Daniel Vetter 2020-09-19 153
cd01269d11a352 Daniel Vetter 2020-09-19 154 return NULL;
cd01269d11a352 Daniel Vetter 2020-09-19 155 }
b5891fb520f742 Chris Wilson 2017-09-14 156
bd780f37a3617d Chris Wilson 2019-01-14 157 pci_set_drvdata(pdev, i915);
bd780f37a3617d Chris Wilson 2019-01-14 158
1a0c19248a2f69 Chris Wilson 2017-07-18 159 dev_pm_domain_set(&pdev->dev, &pm_domain);
1a0c19248a2f69 Chris Wilson 2017-07-18 160 pm_runtime_enable(&pdev->dev);
66d9cb5d805af7 Chris Wilson 2017-02-13 161 pm_runtime_dont_use_autosuspend(&pdev->dev);
07e070e1e3b24e Chris Wilson 2018-07-06 162 if (pm_runtime_enabled(&pdev->dev))
1a0c19248a2f69 Chris Wilson 2017-07-18 163 WARN_ON(pm_runtime_get_sync(&pdev->dev));
66d9cb5d805af7 Chris Wilson 2017-02-13 164
66d9cb5d805af7 Chris Wilson 2017-02-13 165
c499f6cb5ea470 Chris Wilson 2020-07-28 166 i915_params_copy(&i915->params, &i915_modparams);
c499f6cb5ea470 Chris Wilson 2020-07-28 167
69c663554452e6 Daniele Ceraolo Spurio 2019-06-13 168 intel_runtime_pm_init_early(&i915->runtime_pm);
985a0256df3290 Ville Syrjälä 2022-02-04 169 /* wakeref tracking has significant overhead */
985a0256df3290 Ville Syrjälä 2022-02-04 170 i915->runtime_pm.no_wakeref_tracking = true;
d5b6c275d04aac Daniele Ceraolo Spurio 2019-06-13 171
3b5bb0a37665ce Chris Wilson 2017-02-13 172 /* Using the global GTT may ask questions about KMS users, so prepare */
3b5bb0a37665ce Chris Wilson 2017-02-13 173 drm_mode_config_init(&i915->drm);
3b5bb0a37665ce Chris Wilson 2017-02-13 174
43ba44a176a420 Jani Nikula 2022-08-19 @175 RUNTIME_INFO(i915)->graphics.ver = -1;
66d9cb5d805af7 Chris Wilson 2017-02-13 176
9d0bad177af9fd Jani Nikula 2022-08-19 177 RUNTIME_INFO(i915)->page_sizes =
f1f3f98272b9bb Matthew Auld 2017-10-06 178 I915_GTT_PAGE_SIZE_4K |
a883241c392200 Matthew Auld 2017-10-06 179 I915_GTT_PAGE_SIZE_64K |
a883241c392200 Matthew Auld 2017-10-06 180 I915_GTT_PAGE_SIZE_2M;
2a9654b2cdd8f9 Matthew Auld 2017-10-06 181
f81f30b305d2c7 Jani Nikula 2022-08-19 182 RUNTIME_INFO(i915)->memory_regions = REGION_SMEM;
3fc794f27fec8f Chris Wilson 2019-10-26 183 intel_memory_regions_hw_probe(i915);
da1184cd41d4c6 Matthew Auld 2019-10-18 184
9a7fc952717ea6 Tvrtko Ursulin 2021-11-11 185 spin_lock_init(&i915->gpu_error.lock);
9a7fc952717ea6 Tvrtko Ursulin 2021-11-11 186
9c52d1c816baa5 Chris Wilson 2017-11-10 187 i915_gem_init__mm(i915);
bec68cc9ea42d8 Tvrtko Ursulin 2022-03-19 188 intel_root_gt_init_early(i915);
030def2cc91f51 Michał Winiarski 2021-12-14 189 mock_uncore_init(&i915->uncore, i915);
8c2699fad60e3f Andi Shyti 2021-12-14 190 atomic_inc(&to_gt(i915)->wakeref.count); /* disable; no hw support */
8c2699fad60e3f Andi Shyti 2021-12-14 191 to_gt(i915)->awake = -ENODEV;
bec68cc9ea42d8 Tvrtko Ursulin 2022-03-19 192 mock_gt_probe(i915);
66d9cb5d805af7 Chris Wilson 2017-02-13 193
d148738923fdb5 Thomas Hellström 2021-06-02 194 ret = intel_region_ttm_device_init(i915);
d148738923fdb5 Thomas Hellström 2021-06-02 195 if (ret)
d148738923fdb5 Thomas Hellström 2021-06-02 196 goto err_ttm;
d148738923fdb5 Thomas Hellström 2021-06-02 197
0daf0113cff688 Chris Wilson 2017-02-13 198 i915->wq = alloc_ordered_workqueue("mock", 0);
0daf0113cff688 Chris Wilson 2017-02-13 199 if (!i915->wq)
19553d57dcddf6 Chris Wilson 2017-12-09 200 goto err_drv;
0daf0113cff688 Chris Wilson 2017-02-13 201
5f09a9c8ab6b16 Chris Wilson 2017-06-20 202 mock_init_contexts(i915);
0daf0113cff688 Chris Wilson 2017-02-13 203
cdeea858d8df98 Andi Shyti 2021-12-19 204 /* allocate the ggtt */
cdeea858d8df98 Andi Shyti 2021-12-19 205 ret = intel_gt_assign_ggtt(to_gt(i915));
cdeea858d8df98 Andi Shyti 2021-12-19 206 if (ret)
cdeea858d8df98 Andi Shyti 2021-12-19 207 goto err_unlock;
cdeea858d8df98 Andi Shyti 2021-12-19 208
cdeea858d8df98 Andi Shyti 2021-12-19 209 mock_init_ggtt(to_gt(i915));
cdeea858d8df98 Andi Shyti 2021-12-19 210 to_gt(i915)->vm = i915_vm_get(&to_gt(i915)->ggtt->vm);
3b5bb0a37665ce Chris Wilson 2017-02-13 211
488e29fedc1f2b Jani Nikula 2022-08-19 212 RUNTIME_INFO(i915)->platform_engine_mask = BIT(0);
8c2699fad60e3f Andi Shyti 2021-12-14 213 to_gt(i915)->info.engine_mask = BIT(0);
4a774ee35c9f57 Chris Wilson 2018-05-23 214
8c2699fad60e3f Andi Shyti 2021-12-14 215 to_gt(i915)->engine[RCS0] = mock_engine(i915, "mock", RCS0);
8c2699fad60e3f Andi Shyti 2021-12-14 216 if (!to_gt(i915)->engine[RCS0])
11334c6aad9500 Chris Wilson 2019-04-26 217 goto err_unlock;
11334c6aad9500 Chris Wilson 2019-04-26 218
8c2699fad60e3f Andi Shyti 2021-12-14 219 if (mock_engine_init(to_gt(i915)->engine[RCS0]))
4a774ee35c9f57 Chris Wilson 2018-05-23 220 goto err_context;
0daf0113cff688 Chris Wilson 2017-02-13 221
8c2699fad60e3f Andi Shyti 2021-12-14 222 __clear_bit(I915_WEDGED, &to_gt(i915)->reset.flags);
cbb153c50ebe4f Chris Wilson 2019-08-08 223 intel_engines_driver_register(i915);
1d7a99f5148fdc Chris Wilson 2018-05-08 224
7fb81e9d80738e Daniel Vetter 2020-03-23 225 i915->do_release = true;
d148738923fdb5 Thomas Hellström 2021-06-02 226 ida_init(&i915->selftest.mock_region_instances);
7fb81e9d80738e Daniel Vetter 2020-03-23 227
66d9cb5d805af7 Chris Wilson 2017-02-13 228 return i915;
66d9cb5d805af7 Chris Wilson 2017-02-13 229
4a774ee35c9f57 Chris Wilson 2018-05-23 230 err_context:
8c2699fad60e3f Andi Shyti 2021-12-14 231 intel_gt_driver_remove(to_gt(i915));
1d7a99f5148fdc Chris Wilson 2018-05-08 232 err_unlock:
0daf0113cff688 Chris Wilson 2017-02-13 233 destroy_workqueue(i915->wq);
19553d57dcddf6 Chris Wilson 2017-12-09 234 err_drv:
d148738923fdb5 Thomas Hellström 2021-06-02 235 intel_region_ttm_device_fini(i915);
d148738923fdb5 Thomas Hellström 2021-06-02 236 err_ttm:
bec68cc9ea42d8 Tvrtko Ursulin 2022-03-19 237 intel_gt_driver_late_release_all(i915);
3fc794f27fec8f Chris Wilson 2019-10-26 238 intel_memory_regions_driver_release(i915);
19553d57dcddf6 Chris Wilson 2017-12-09 239 drm_mode_config_cleanup(&i915->drm);
82be0d7540b104 Daniel Vetter 2020-09-18 240 mock_destroy_device(i915);
7fb81e9d80738e Daniel Vetter 2020-03-23 241
66d9cb5d805af7 Chris Wilson 2017-02-13 242 return NULL;
66d9cb5d805af7 Chris Wilson 2017-02-13 243 }
82be0d7540b104 Daniel Vetter 2020-09-18 244 Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp
PATCH 1/1 drm/i915: Move display and media IP version to runtime info
In reply to Radhakrishna SripadaFuture platforms can read the IP version from a register and the IP version numbers need not be hard coded in device info. Move the ip version for media and display to runtime info.
On platforms where hard coding of IP version is required, update the IP version in __runtime under device_info.
v2:
- Avoid name collision for ip versions(Jani)
v4.1:
- Fix build error in mock_gem_device.c
--- drivers/gpu/drm/i915/i915_drv.h | 14 +++---- drivers/gpu/drm/i915/i915_pci.c | 38 +++++++++---------- drivers/gpu/drm/i915/intel_device_info.c | 28 +++++++++----- drivers/gpu/drm/i915/intel_device_info.h | 15 +++++--- .../gpu/drm/i915/selftests/mock_gem_device.c | 2 +- 5 files changed, 54 insertions(+), 43 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +7 -7
@@ -469,19 +469,19 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)#define IP_VER (ver, rel) ((ver) << 8 | (rel)) -#define GRAPHICS_VER (i915) (RUNTIME_INFO(i915)->graphics.ver) -#define GRAPHICS_VER_FULL (i915) IP_VER(RUNTIME_INFO(i915)->graphics.ver, \ - RUNTIME_INFO(i915)->graphics.rel) +#define GRAPHICS_VER (i915) (RUNTIME_INFO(i915)->graphics.version.ver) +#define GRAPHICS_VER_FULL (i915) IP_VER(RUNTIME_INFO(i915)->graphics.version.ver, \ + RUNTIME_INFO(i915)->graphics.version.rel)#define IS_GRAPHICS_VER (i915, from, until) \ (GRAPHICS_VER(i915) >= (from) && GRAPHICS_VER(i915) <= (until)) -#define MEDIA_VER (i915) (INTEL_INFO(i915)->media.ver) -#define MEDIA_VER_FULL (i915) IP_VER(INTEL_INFO(i915)->media.ver, \ - INTEL_INFO(i915)->media.rel) +#define MEDIA_VER (i915) (RUNTIME_INFO(i915)->media.version.ver) +#define MEDIA_VER_FULL (i915) IP_VER(RUNTIME_INFO(i915)->media.version.ver, \ + RUNTIME_INFO(i915)->media.version.rel)#define IS_MEDIA_VER (i915, from, until) \ (MEDIA_VER(i915) >= (from) && MEDIA_VER(i915) <= (until)) -#define DISPLAY_VER (i915) (INTEL_INFO(i915)->display.ver) +#define DISPLAY_VER (i915) (RUNTIME_INFO(i915)->display.version.ver)#define IS_DISPLAY_VER (i915, from, until) \ (DISPLAY_VER(i915) >= (from) && DISPLAY_VER(i915) <= (until))
drivers/gpu/drm/i915/i915_pci.c +19 -19
@@ -34,9 +34,9 @@#define PLATFORM (x) .platform = (x)#define GEN (x) \ - .__runtime.graphics.ver = (x), \ - .media.ver = (x), \ - .display.ver = (x) + .__runtime.graphics.version.ver = (x), \ + .__runtime.media.version.ver = (x), \ + .__runtime.display.version.ver = (x)#define I845_PIPE_OFFSETS \ .display.pipe_offsets = { \
@@ -740,7 +740,7 @@ static const struct intel_device_info bxt_info = {static const struct intel_device_info glk_info = {GEN9_LP_FEATURES ,PLATFORM (INTEL_GEMINILAKE ), - .display.ver =10 , + .__runtime.display.version.ver =10 , .display.dbuf.size =1024 -4 ,/* 4 blocks for bypass path allocation */ GLK_COLORS , };
@@ -919,7 +919,7 @@ static const struct intel_device_info rkl_info = {static const struct intel_device_info dg1_info = {GEN12_FEATURES ,DGFX_FEATURES , - .__runtime.graphics.rel =10 , + .__runtime.graphics.version.rel =10 ,PLATFORM (INTEL_DG1 ), .__runtime.pipe_mask =BIT (PIPE_A ) |BIT (PIPE_B ) |BIT (PIPE_C ) |BIT (PIPE_D ), .require_force_probe =1 ,
@@ -962,7 +962,7 @@ static const struct intel_device_info adl_s_info = { .display.has_hotplug = 1, \ .display.has_ipc = 1, \ .display.has_psr = 1, \ - .display.ver = 13, \ + .__runtime.display.version.ver = 13, \ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \ .display.pipe_offsets = { \ [TRANSCODER_A] = PIPE_A_OFFSET, \
@@ -1006,8 +1006,8 @@ static const struct intel_device_info adl_p_info = { I915_GTT_PAGE_SIZE_2M#define XE_HP_FEATURES \ - .__runtime.graphics.ver = 12, \ - .__runtime.graphics.rel = 50, \ + .__runtime.graphics.version.ver = 12, \ + .__runtime.graphics.version.rel = 50, \ XE_HP_PAGE_SIZES, \ .dma_mask_size = 46, \ .has_3d_pipeline = 1, \
@@ -1027,8 +1027,8 @@ static const struct intel_device_info adl_p_info = { .__runtime.ppgtt_type = INTEL_PPGTT_FULL#define XE_HPM_FEATURES \ - .media.ver = 12, \ - .media.rel = 50 + .__runtime.media.version.ver = 12, \ + .__runtime.media.version.rel = 50__maybe_unused static const struct intel_device_info xehpsdv_info = {
@@ -1053,8 +1053,8 @@ static const struct intel_device_info xehpsdv_info = {XE_HP_FEATURES , \XE_HPM_FEATURES , \DGFX_FEATURES , \ - .__runtime.graphics.rel = 55, \ - .media.rel = 55, \ + .__runtime.graphics.version.rel = 55, \ + .__runtime.media.version.rel = 55, \PLATFORM (INTEL_DG2 ), \ .has_4tile = 1, \ .has_64k_pages = 1, \
@@ -1097,8 +1097,8 @@ static const struct intel_device_info pvc_info = {XE_HPC_FEATURES ,XE_HPM_FEATURES ,DGFX_FEATURES , - .__runtime.graphics.rel = 60, - .media.rel = 60, + .__runtime.graphics.version.rel = 60, + .__runtime.media.version.rel = 60,PLATFORM (INTEL_PONTEVECCHIO ), .display = { 0 }, .has_flat_ccs = 0,
@@ -1111,7 +1111,7 @@ static const struct intel_device_info pvc_info = {#define XE_LPDP_FEATURES \ XE_LPD_FEATURES, \ - .display.ver = 14, \ + .__runtime.display.version.ver = 14, \ .display.has_cdclk_crawl = 1, \ .__runtime.fbc_mask = BIT(INTEL_FBC_A) | BIT(INTEL_FBC_B)
@@ -1123,9 +1123,9 @@ static const struct intel_device_info mtl_info = {* Real graphics IP version will be obtained from hardware GMD_ID * register. Value provided here is just for sanity checking. */ - .__runtime.graphics.ver = 12, - .__runtime.graphics.rel = 70, - .media.ver =13 , + .__runtime.graphics.version.ver = 12, + .__runtime.graphics.version.rel = 70, + .__runtime.media.version.ver =13 ,PLATFORM (INTEL_METEORLAKE ), .display.has_modular_fia = 1, .has_flat_ccs = 0,
@@ -1281,7 +1281,7 @@ bool i915_pci_resource_valid(struct pci_dev *pdev, int bar)static bool intel_mmio_bar_valid (struct pci_dev *pdev,struct intel_device_info *intel_info) { -int gttmmaddr_bar = intel_info->__runtime.graphics.ver ==2 ?GEN2_GTTMMADR_BAR :GTTMMADR_BAR ; +int gttmmaddr_bar = intel_info->__runtime.graphics.version.ver ==2 ?GEN2_GTTMMADR_BAR :GTTMMADR_BAR ;return i915_pci_resource_valid (pdev, gttmmaddr_bar); }
drivers/gpu/drm/i915/intel_device_info.c +18 -10
@@ -92,21 +92,29 @@ void intel_device_info_print(const struct intel_device_info *info, const struct intel_runtime_info *runtime, struct drm_printer *p) { - if (runtime->graphics.rel) - drm_printf(p, "graphics version: %u.%02u\n", runtime->graphics.ver, - runtime->graphics.rel); + if (runtime->graphics.version.rel) + drm_printf(p, "graphics version: %u.%02u\n", + runtime->graphics.version.ver, + runtime->graphics.version.rel); else - drm_printf(p, "graphics version: %u\n", runtime->graphics.ver); + drm_printf(p, "graphics version: %u\n", + runtime->graphics.version.ver); -if (info->media.rel) -drm_printf (p,"media version: %u.%02u\n" , info->media.ver, info->media.rel); +if (runtime->media.version.rel) +drm_printf (p,"media version: %u.%02u\n" , + runtime->media.version.ver, + runtime->media.version.rel);else -drm_printf (p,"media version: %u\n" , info->media.ver); +drm_printf (p,"media version: %u\n" , + runtime->media.version.ver); -if (info->display.rel) -drm_printf (p,"display version: %u.%02u\n" , info->display.ver, info->display.rel); +if (runtime->display.version.rel) +drm_printf (p,"display version: %u.%02u\n" , + runtime->display.version.ver, + runtime->display.version.rel);else -drm_printf (p,"display version: %u\n" , info->display.ver); +drm_printf (p,"display version: %u\n" , + runtime->display.version.ver);drm_printf (p,"gt: %d\n" , info->gt);drm_printf (p,"memory-regions: %x\n" , runtime->memory_regions);
drivers/gpu/drm/i915/intel_device_info.h +9 -6
@@ -200,7 +200,15 @@ struct ip_version { };struct intel_runtime_info { -struct ip_version graphics; +struct { +struct ip_version version; + } graphics; +struct { +struct ip_version version; + } media; +struct { +struct ip_version version; + } display;/* * Platform mask is used for optimizing or-ed IS_PLATFORM calls into
@@ -246,8 +254,6 @@ struct intel_runtime_info { };struct intel_device_info { -struct ip_version media; -enum intel_platform platform;unsigned int dma_mask_size;/* available DMA address bits */
@@ -259,9 +265,6 @@ struct intel_device_info {#undef DEFINE_FLAGstruct { -u8 ver; -u8 rel; -u8 abox_mask;struct {
drivers/gpu/drm/i915/selftests/mock_gem_device.c +1 -1
@@ -172,7 +172,7 @@ struct drm_i915_private *mock_gem_device(void)/* Using the global GTT may ask questions about KMS users, so prepare */ drm_mode_config_init (&i915->drm); -RUNTIME_INFO (i915)->graphics.ver =-1 ; +RUNTIME_INFO (i915)->graphics.version.ver =-1 ;RUNTIME_INFO (i915)->page_sizes = I915_GTT_PAGE_SIZE_4K |
Signature · 1 line
2.34.1
Re: [PATCH v4.1] drm/i915: Move display and media IP version to runtime info
Quoted 222 lines · Radhakrishna Sripada
Future platforms can read the IP version from a register and the IP version numbers need not be hard coded in device info. Move the ip version for media and display to runtime info.
On platforms where hard coding of IP version is required, update the IP version in
__runtimeunderdevice_info.v2:
- Avoid name collision for ip versions(Jani)
v4.1:
- Fix build error inmock_gem_device.cSuggested-by Jani Nikula <[email protected]>Cc Matt Roper <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 14 +++---- drivers/gpu/drm/i915/i915_pci.c | 38 +++++++++---------- drivers/gpu/drm/i915/intel_device_info.c | 28 +++++++++----- drivers/gpu/drm/i915/intel_device_info.h | 15 +++++--- .../gpu/drm/i915/selftests/mock_gem_device.c | 2 +- 5 files changed, 54 insertions(+), 43 deletions(-)drivers/gpu/drm/i915/i915_drv.h +7
-7@@ -469,19 +469,19 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)#define IP_VER (ver, rel) ((ver) << 8 | (rel)) -#define GRAPHICS_VER (i915) (RUNTIME_INFO(i915)->graphics.ver) -#define GRAPHICS_VER_FULL (i915) IP_VER(RUNTIME_INFO(i915)->graphics.ver, \ - RUNTIME_INFO(i915)->graphics.rel) +#define GRAPHICS_VER (i915) (RUNTIME_INFO(i915)->graphics.version.ver) +#define GRAPHICS_VER_FULL (i915) IP_VER(RUNTIME_INFO(i915)->graphics.version.ver, \ + RUNTIME_INFO(i915)->graphics.version.rel)#define IS_GRAPHICS_VER (i915, from, until) \ (GRAPHICS_VER(i915) >= (from) && GRAPHICS_VER(i915) <= (until)) -#define MEDIA_VER (i915) (INTEL_INFO(i915)->media.ver) -#define MEDIA_VER_FULL (i915) IP_VER(INTEL_INFO(i915)->media.ver, \ - INTEL_INFO(i915)->media.rel) +#define MEDIA_VER (i915) (RUNTIME_INFO(i915)->media.version.ver) +#define MEDIA_VER_FULL (i915) IP_VER(RUNTIME_INFO(i915)->media.version.ver, \ + RUNTIME_INFO(i915)->media.version.rel)#define IS_MEDIA_VER (i915, from, until) \ (MEDIA_VER(i915) >= (from) && MEDIA_VER(i915) <= (until)) -#define DISPLAY_VER (i915) (INTEL_INFO(i915)->display.ver) +#define DISPLAY_VER (i915) (RUNTIME_INFO(i915)->display.version.ver)#define IS_DISPLAY_VER (i915, from, until) \ (DISPLAY_VER(i915) >= (from) && DISPLAY_VER(i915) <= (until))drivers/gpu/drm/i915/i915_pci.c +19
-19@@ -34,9 +34,9 @@#define PLATFORM (x) .platform = (x)#define GEN (x) \ - .__runtime.graphics.ver = (x), \ - .media.ver = (x), \ - .display.ver = (x) + .__runtime.graphics.version.ver = (x), \ + .__runtime.media.version.ver = (x), \ + .__runtime.display.version.ver = (x)#define I845_PIPE_OFFSETS \ .display.pipe_offsets = { \@@ -740,7 +740,7 @@ static const struct intel_device_info bxt_info = {static const struct intel_device_info glk_info = {GEN9_LP_FEATURES ,PLATFORM (INTEL_GEMINILAKE ), - .display.ver =10 , + .__runtime.display.version.ver =10 , .display.dbuf.size =1024 -4 ,/* 4 blocks for bypass path allocation */ GLK_COLORS , };@@ -919,7 +919,7 @@ static const struct intel_device_info rkl_info = {static const struct intel_device_info dg1_info = {GEN12_FEATURES ,DGFX_FEATURES , - .__runtime.graphics.rel =10 , + .__runtime.graphics.version.rel =10 ,PLATFORM (INTEL_DG1 ), .__runtime.pipe_mask =BIT (PIPE_A ) |BIT (PIPE_B ) |BIT (PIPE_C ) |BIT (PIPE_D ), .require_force_probe =1 ,@@ -962,7 +962,7 @@ static const struct intel_device_info adl_s_info = { .display.has_hotplug = 1, \ .display.has_ipc = 1, \ .display.has_psr = 1, \ - .display.ver = 13, \ + .__runtime.display.version.ver = 13, \ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \ .display.pipe_offsets = { \ [TRANSCODER_A] = PIPE_A_OFFSET, \@@ -1006,8 +1006,8 @@ static const struct intel_device_info adl_p_info = { I915_GTT_PAGE_SIZE_2M#define XE_HP_FEATURES \ - .__runtime.graphics.ver = 12, \ - .__runtime.graphics.rel = 50, \ + .__runtime.graphics.version.ver = 12, \ + .__runtime.graphics.version.rel = 50, \ XE_HP_PAGE_SIZES, \ .dma_mask_size = 46, \ .has_3d_pipeline = 1, \@@ -1027,8 +1027,8 @@ static const struct intel_device_info adl_p_info = { .__runtime.ppgtt_type = INTEL_PPGTT_FULL#define XE_HPM_FEATURES \ - .media.ver = 12, \ - .media.rel = 50 + .__runtime.media.version.ver = 12, \ + .__runtime.media.version.rel = 50__maybe_unused static const struct intel_device_info xehpsdv_info = {@@ -1053,8 +1053,8 @@ static const struct intel_device_info xehpsdv_info = {XE_HP_FEATURES , \XE_HPM_FEATURES , \DGFX_FEATURES , \ - .__runtime.graphics.rel = 55, \ - .media.rel = 55, \ + .__runtime.graphics.version.rel = 55, \ + .__runtime.media.version.rel = 55, \PLATFORM (INTEL_DG2 ), \ .has_4tile = 1, \ .has_64k_pages = 1, \@@ -1097,8 +1097,8 @@ static const struct intel_device_info pvc_info = {XE_HPC_FEATURES ,XE_HPM_FEATURES ,DGFX_FEATURES , - .__runtime.graphics.rel = 60, - .media.rel = 60, + .__runtime.graphics.version.rel = 60, + .__runtime.media.version.rel = 60,PLATFORM (INTEL_PONTEVECCHIO ), .display = { 0 }, .has_flat_ccs = 0,@@ -1111,7 +1111,7 @@ static const struct intel_device_info pvc_info = {#define XE_LPDP_FEATURES \ XE_LPD_FEATURES, \ - .display.ver = 14, \ + .__runtime.display.version.ver = 14, \ .display.has_cdclk_crawl = 1, \ .__runtime.fbc_mask = BIT(INTEL_FBC_A) | BIT(INTEL_FBC_B)@@ -1123,9 +1123,9 @@ static const struct intel_device_info mtl_info = {* Real graphics IP version will be obtained from hardware GMD_ID * register. Value provided here is just for sanity checking. */ - .__runtime.graphics.ver = 12, - .__runtime.graphics.rel = 70, - .media.ver =13 , + .__runtime.graphics.version.ver = 12, + .__runtime.graphics.version.rel = 70, + .__runtime.media.version.ver =13 ,PLATFORM (INTEL_METEORLAKE ), .display.has_modular_fia = 1, .has_flat_ccs = 0,@@ -1281,7 +1281,7 @@ bool i915_pci_resource_valid(struct pci_dev *pdev, int bar)static bool intel_mmio_bar_valid (struct pci_dev *pdev,struct intel_device_info *intel_info) { -int gttmmaddr_bar = intel_info->__runtime.graphics.ver ==2 ?GEN2_GTTMMADR_BAR :GTTMMADR_BAR ; +int gttmmaddr_bar = intel_info->__runtime.graphics.version.ver ==2 ?GEN2_GTTMMADR_BAR :GTTMMADR_BAR ;return i915_pci_resource_valid (pdev, gttmmaddr_bar); }drivers/gpu/drm/i915/intel_device_info.c +18
-10@@ -92,21 +92,29 @@ void intel_device_info_print(const struct intel_device_info *info, const struct intel_runtime_info *runtime, struct drm_printer *p) { - if (runtime->graphics.rel) - drm_printf(p, "graphics version: %u.%02u\n", runtime->graphics.ver, - runtime->graphics.rel); + if (runtime->graphics.version.rel) + drm_printf(p, "graphics version: %u.%02u\n", + runtime->graphics.version.ver, + runtime->graphics.version.rel); else - drm_printf(p, "graphics version: %u\n", runtime->graphics.ver); + drm_printf(p, "graphics version: %u\n", + runtime->graphics.version.ver); -if (info->media.rel) -drm_printf (p,"media version: %u.%02u\n" , info->media.ver, info->media.rel); +if (runtime->media.version.rel) +drm_printf (p,"media version: %u.%02u\n" , + runtime->media.version.ver, + runtime->media.version.rel);else -drm_printf (p,"media version: %u\n" , info->media.ver); +drm_printf (p,"media version: %u\n" , + runtime->media.version.ver); -if (info->display.rel) -drm_printf (p,"display version: %u.%02u\n" , info->display.ver, info->display.rel); +if (runtime->display.version.rel) +drm_printf (p,"display version: %u.%02u\n" , + runtime->display.version.ver, + runtime->display.version.rel);else -drm_printf (p,"display version: %u\n" , info->display.ver); +drm_printf (p,"display version: %u\n" , + runtime->display.version.ver);drm_printf (p,"gt: %d\n" , info->gt);drm_printf (p,"memory-regions: %x\n" , runtime->memory_regions);drivers/gpu/drm/i915/intel_device_info.h +0
-0
drivers/gpu/drm/i915/intel_device_info.h struct ip_version { · line 204
Quoted 6 lines
drivers/gpu/drm/i915/intel_device_info.h +2
-1@@ -200,7 +200,15 @@ struct ip_version { };struct intel_runtime_info { -struct ip_version graphics; +struct { +struct ip_version version;
Bikeshed: It might be more natural to name these inner structures 'ip' rather than 'version' so that elsewhere in the code we'll be dealing with things like runtime->graphics.ip.ver and runtime->graphics.ip.rel.
Up to you though. Either way,
Quoted 45 lines
drivers/gpu/drm/i915/intel_device_info.h +7
-5+ } graphics; +struct { +struct ip_version version; + } media; +struct { +struct ip_version version; + } display;/* * Platform mask is used for optimizing or-ed IS_PLATFORM calls into @@ -246,8 +254,6 @@ struct intel_runtime_info { };struct intel_device_info { -struct ip_version media; -enum intel_platform platform;unsigned int dma_mask_size;/* available DMA address bits */ @@ -259,9 +265,6 @@ struct intel_device_info {#undef DEFINE_FLAGstruct { -u8 ver; -u8 rel; -u8 abox_mask;struct {drivers/gpu/drm/i915/selftests/mock_gem_device.c +1
-1@@ -172,7 +172,7 @@ struct drm_i915_private *mock_gem_device(void)/* Using the global GTT may ask questions about KMS users, so prepare */ drm_mode_config_init (&i915->drm); -RUNTIME_INFO (i915)->graphics.ver =-1 ; +RUNTIME_INFO (i915)->graphics.version.ver =-1 ;RUNTIME_INFO (i915)->page_sizes = I915_GTT_PAGE_SIZE_4K |Signature · 1 line
2.34.1
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
PATCH v4 2/11 drm/i915: Read graphics/media/display arch version from hw
In reply to Radhakrishna SripadaFrom: Matt Roper <[email protected]>
Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be read directly from a register in the MMIO space. New hardware programming styles, features, and workarounds should be conditional solely on the architecture version, and should no longer be derived from the PCI device ID, revision ID, or platform-specific feature flags.
Bspec: 63361, 64111
v2:
- Move the IP version readout to intel_device_info.c
- Convert the macro into a function
v3:
- Move subplatform init to runtime early init
- Cache runtime ver, release info to compare with hardware values.
--- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_driver.c | 3 +- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 7 +++ drivers/gpu/drm/i915/intel_device_info.c | 74 +++++++++++++++++++++++- drivers/gpu/drm/i915/intel_device_info.h | 12 +++- 7 files changed, 98 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt_regs.h +2 -0
@@ -39,6 +39,8 @@#define FORCEWAKE_ACK_RENDER_GEN9 _MMIO(0xd84)#define FORCEWAKE_ACK_MEDIA_GEN9 _MMIO(0xd88) +#define GMD_ID_GRAPHICS _MMIO(0xd8c) +#define MCFG_MCR_SELECTOR _MMIO(0xfd0)#define SF_MCR_SELECTOR _MMIO(0xfd8)#define GEN8_MCR_SELECTOR _MMIO(0xfdc)
drivers/gpu/drm/i915/i915_driver.c +2 -1
@@ -323,7 +323,8 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)if (i915_inject_probe_failure (dev_priv))return -ENODEV ; -intel_device_info_subplatform_init (dev_priv); +intel_device_info_runtime_init_early (dev_priv); +intel_step_init (dev_priv);intel_uncore_mmio_debug_init_early (&dev_priv->mmio_debug);
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -936,6 +936,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_GMCH (dev_priv) (INTEL_INFO(dev_priv)->display.has_gmch) +#define HAS_GMD_ID (i915) INTEL_INFO(i915)->has_gmd_id +#define HAS_LSPCON (dev_priv) (IS_DISPLAY_VER(dev_priv, 9, 10))#define HAS_L3_CCS_READ (i915) (INTEL_INFO(i915)->has_l3_ccs_read)
drivers/gpu/drm/i915/i915_pci.c +1 -0
@@ -1129,6 +1129,7 @@ static const struct intel_device_info mtl_info = {PLATFORM (INTEL_METEORLAKE ), .display.has_modular_fia = 1, .has_flat_ccs = 0, + .has_gmd_id = 1, .has_snoop = 1, .__runtime.memory_regions = REGION_SMEM | REGION_STOLEN_LMEM, .__runtime.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),
drivers/gpu/drm/i915/i915_reg.h +7 -0
@@ -5798,6 +5798,11 @@#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz (1 << 29)#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz (2 << 29) +#define GMD_ID_DISPLAY _MMIO(0x510a0) +#define GMD_ID_ARCH_MASK REG_GENMASK(31, 22) +#define GMD_ID_RELEASE_MASK REG_GENMASK(21, 14) +#define GMD_ID_STEP REG_GENMASK(5, 0) +/*GEN11 chicken */ #define _PIPEA_CHICKEN 0x70038#define _PIPEB_CHICKEN 0x71038
@@ -8298,4 +8303,6 @@ enum skl_power_gate {#define MTL_LATENCY_LEVEL_EVEN_MASK REG_GENMASK(12, 0)#define MTL_LATENCY_LEVEL_ODD_MASK REG_GENMASK(28, 16) +#define MTL_MEDIA_GSI_BASE 0x380000 +#endif /* _I915_REG_H_ */
drivers/gpu/drm/i915/intel_device_info.c +73 -1
92 lines not on this page · raw message
drivers/gpu/drm/i915/intel_device_info.h +11 -1
@@ -152,6 +152,7 @@ enum intel_ppgtt_type {func (has_4tile); \func (has_flat_ccs); \func (has_global_mocs); \ +func (has_gmd_id); \func (has_gt_uc); \func (has_heci_pxp); \func (has_heci_gscfi); \
@@ -197,9 +198,18 @@ enum intel_ppgtt_type {struct ip_version {u8 ver;u8 rel; +u8 step; };struct intel_runtime_info { +/* +* On modern platforms, the architecture major.minor version numbers +* and stepping are read directly from the hardware rather than derived +* from the PCI device and revision ID's. +* +* Note that the hardware gives us a single "graphics" number that +* should represent render, compute, and copy behavior. +*/ struct {struct ip_version version; } graphics;
@@ -305,7 +315,7 @@ struct intel_driver_caps {const char *intel_platform_name (enum intel_platform platform); -void intel_device_info_subplatform_init (struct drm_i915_private *dev_priv); +void intel_device_info_runtime_init_early (struct drm_i915_private *dev_priv);void intel_device_info_runtime_init (struct drm_i915_private *dev_priv); void intel_device_info_print(const struct intel_device_info *info,
Signature · 1 line
2.34.1
kernel test robot
build botRe: [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw
Thank you for the patch! Perhaps something to improve:
Hi Radhakrishna,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on next-20220901]
[cannot apply to drm-intel/for-linux-next drm/drm-next drm-misc/drm-misc-next linus/master v6.0-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Radhakrishna-Sripada/Initial-Meteorlake-Support/20220902-140730 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: i386-randconfig-a004 (https://download.01.org/0day-ci/archive/20220902/[email protected]/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/59999fd809c2d1e77bdd9f02a79322602bc7ef3d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Radhakrishna-Sripada/Initial-Meteorlake-Support/20220902-140730
git checkout 59999fd809c2d1e77bdd9f02a79322602bc7ef3d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/
If you fix the issue, kindly add following tag where applicable
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/i915/intel_device_info.c:319: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Setup the graphics version for the current device. This must be done before
vim +319 drivers/gpu/drm/i915/intel_device_info.c
317
318 /**
> 319 * Setup the graphics version for the current device. This must be done before
320 * any code that performs checks on GRAPHICS_VER or DISPLAY_VER, so this
321 * function should be called very early in the driver initialization sequence.
322 *
323 * Regular MMIO access is not yet setup at the point this function is called so
324 * we peek at the appropriate MMIO offset directly. The GMD_ID register is
325 * part of an 'always on' power well by design, so we don't need to worry about
326 * forcewake while reading it.
327 */
328 static void intel_ipver_early_init(struct drm_i915_private *i915)
329 {
330 struct intel_runtime_info *runtime = RUNTIME_INFO(i915);
331
332 if (!HAS_GMD_ID(i915))
333 return;
334
335 ip_ver_read(i915, i915_mmio_reg_offset(GMD_ID_GRAPHICS),
336 &runtime->graphics.version);
337 ip_ver_read(i915, i915_mmio_reg_offset(GMD_ID_DISPLAY),
338 &runtime->display.version);
339 ip_ver_read(i915, MTL_MEDIA_GSI_BASE + i915_mmio_reg_offset(GMD_ID_GRAPHICS),
340 &runtime->media.version);
341 }
342
Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp
Re: [Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw
In reply to Radhakrishna SripadaQuoted 145 lines · Radhakrishna Sripada
From: Matt Roper <[email protected]>
Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be read directly from a register in the MMIO space. New hardware programming styles, features, and workarounds should be conditional solely on the architecture version, and should no longer be derived from the PCI device ID, revision ID, or platform-specific feature flags.
Bspec: 63361, 64111
v2:
- Move the IP version readout tointel_device_info.c
- Convert the macro into a functionv3:
- Move subplatform init to runtime early init
- Cache runtime ver, release info to compare with hardware values.Signed-off-by Matt Roper <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_driver.c | 3 +- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 7 +++ drivers/gpu/drm/i915/intel_device_info.c | 74 +++++++++++++++++++++++- drivers/gpu/drm/i915/intel_device_info.h | 12 +++- 7 files changed, 98 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/gt/intel_gt_regs.h +2
-0@@ -39,6 +39,8 @@#define FORCEWAKE_ACK_RENDER_GEN9 _MMIO(0xd84)#define FORCEWAKE_ACK_MEDIA_GEN9 _MMIO(0xd88) +#define GMD_ID_GRAPHICS _MMIO(0xd8c) +#define MCFG_MCR_SELECTOR _MMIO(0xfd0)#define SF_MCR_SELECTOR _MMIO(0xfd8)#define GEN8_MCR_SELECTOR _MMIO(0xfdc)drivers/gpu/drm/i915/i915_driver.c +2
-1@@ -323,7 +323,8 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)if (i915_inject_probe_failure (dev_priv))return -ENODEV ; -intel_device_info_subplatform_init (dev_priv); +intel_device_info_runtime_init_early (dev_priv); +intel_step_init (dev_priv);intel_uncore_mmio_debug_init_early (&dev_priv->mmio_debug);drivers/gpu/drm/i915/i915_drv.h +2
-0@@ -936,6 +936,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_GMCH (dev_priv) (INTEL_INFO(dev_priv)->display.has_gmch) +#define HAS_GMD_ID (i915) INTEL_INFO(i915)->has_gmd_id +#define HAS_LSPCON (dev_priv) (IS_DISPLAY_VER(dev_priv, 9, 10))#define HAS_L3_CCS_READ (i915) (INTEL_INFO(i915)->has_l3_ccs_read)drivers/gpu/drm/i915/i915_pci.c +1
-0@@ -1129,6 +1129,7 @@ static const struct intel_device_info mtl_info = {PLATFORM (INTEL_METEORLAKE ), .display.has_modular_fia = 1, .has_flat_ccs = 0, + .has_gmd_id = 1, .has_snoop = 1, .__runtime.memory_regions = REGION_SMEM | REGION_STOLEN_LMEM, .__runtime.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),drivers/gpu/drm/i915/i915_reg.h +7
-0@@ -5798,6 +5798,11 @@#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz (1 << 29)#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz (2 << 29) +#define GMD_ID_DISPLAY _MMIO(0x510a0) +#define GMD_ID_ARCH_MASK REG_GENMASK(31, 22) +#define GMD_ID_RELEASE_MASK REG_GENMASK(21, 14) +#define GMD_ID_STEP REG_GENMASK(5, 0) +/*GEN11 chicken */ #define _PIPEA_CHICKEN 0x70038#define _PIPEB_CHICKEN 0x71038@@ -8298,4 +8303,6 @@ enum skl_power_gate {#define MTL_LATENCY_LEVEL_EVEN_MASK REG_GENMASK(12, 0)#define MTL_LATENCY_LEVEL_ODD_MASK REG_GENMASK(28, 16) +#define MTL_MEDIA_GSI_BASE 0x380000 +#endif /* _I915_REG_H_ */ drivers/gpu/drm/i915/intel_device_info.c +13
-1@@ -29,6 +29,7 @@#include "display/intel_cdclk.h" #include "display/intel_de.h" +#include "gt/intel_gt_regs.h" #include "intel_device_info.h" #include "i915_drv.h" #include "i915_utils.h" @@ -231,7 +232,7 @@ static bool find_devid(u16 id, const u16 *p, unsigned int num)return false; } -void intel_device_info_subplatform_init (struct drm_i915_private *i915) +static void intel_device_info_subplatform_init (struct drm_i915_private *i915) {const struct intel_device_info *info =INTEL_INFO (i915);const struct intel_runtime_info *rinfo =RUNTIME_INFO (i915);@@ -288,6 +289,77 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)RUNTIME_INFO (i915)->platform_mask[pi] |= mask; } +static void ip_ver_read (struct drm_i915_private *i915,u32 offset,struct ip_version *ip) +{ +struct pci_dev *pdev =to_pci_dev (i915->drm.dev); +void __iomem *addr; +u32 val; +u8 ver = ip->ver; +u8 rel = ip->rel; + + addr =pci_iomap_range (pdev,0 , offset,sizeof (u32)); +if (drm_WARN_ON (&i915->drm, !addr)) +return ;
drivers/gpu/drm/i915/intel_device_info.c void intel_device_info_subplatform_init(struct drm_i915_private *i915) · line 312
Quoted 10 lines
drivers/gpu/drm/i915/intel_device_info.c +10
-0+ + val =ioread32 (addr); +pci_iounmap (pdev, addr); + + ip->ver =REG_FIELD_GET (GMD_ID_ARCH_MASK , val); + ip->rel =REG_FIELD_GET (GMD_ID_RELEASE_MASK , val); + ip->step =REG_FIELD_GET (GMD_ID_STEP , val); + +/* Sanity check against expected versions from device info */ +if (ip->ver != ver || ip->rel > rel)
this doesn't seem correct.. if we have
ip->ver == 12, ip->rel == 1 ver == 12, rel == 0
we will print
Hardware reports GMD IP version 12.1 but minimum expected is 12.0"
should it be || ip->rel < rel? Once we land the static number in device info, we can only expect new .rel versions greater than that.
Lucas De Marchi
Re: [Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw
Quoted 162 lines · Lucas De Marchi
Quoted 145 lines · Radhakrishna Sripada
From: Matt Roper <[email protected]>
Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be read directly from a register in the MMIO space. New hardware programming styles, features, and workarounds should be conditional solely on the architecture version, and should no longer be derived from the PCI device ID, revision ID, or platform-specific feature flags.
Bspec: 63361, 64111
v2:
- Move the IP version readout tointel_device_info.c
- Convert the macro into a functionv3:
- Move subplatform init to runtime early init
- Cache runtime ver, release info to compare with hardware values.Signed-off-by Matt Roper <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_driver.c | 3 +- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 7 +++ drivers/gpu/drm/i915/intel_device_info.c | 74 +++++++++++++++++++++++- drivers/gpu/drm/i915/intel_device_info.h | 12 +++- 7 files changed, 98 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/gt/intel_gt_regs.h +2
-0@@ -39,6 +39,8 @@#define FORCEWAKE_ACK_RENDER_GEN9 _MMIO(0xd84)#define FORCEWAKE_ACK_MEDIA_GEN9 _MMIO(0xd88) +#define GMD_ID_GRAPHICS _MMIO(0xd8c) +#define MCFG_MCR_SELECTOR _MMIO(0xfd0)#define SF_MCR_SELECTOR _MMIO(0xfd8)#define GEN8_MCR_SELECTOR _MMIO(0xfdc)drivers/gpu/drm/i915/i915_driver.c +2
-1@@ -323,7 +323,8 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)if (i915_inject_probe_failure (dev_priv))return -ENODEV ; -intel_device_info_subplatform_init (dev_priv); +intel_device_info_runtime_init_early (dev_priv); +intel_step_init (dev_priv);intel_uncore_mmio_debug_init_early (&dev_priv->mmio_debug);drivers/gpu/drm/i915/i915_drv.h +2
-0@@ -936,6 +936,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_GMCH (dev_priv) (INTEL_INFO(dev_priv)->display.has_gmch) +#define HAS_GMD_ID (i915) INTEL_INFO(i915)->has_gmd_id +#define HAS_LSPCON (dev_priv) (IS_DISPLAY_VER(dev_priv, 9, 10))#define HAS_L3_CCS_READ (i915) (INTEL_INFO(i915)->has_l3_ccs_read)drivers/gpu/drm/i915/i915_pci.c +1
-0@@ -1129,6 +1129,7 @@ static const struct intel_device_info mtl_info = {PLATFORM (INTEL_METEORLAKE ), .display.has_modular_fia = 1, .has_flat_ccs = 0, + .has_gmd_id = 1, .has_snoop = 1, .__runtime.memory_regions = REGION_SMEM | REGION_STOLEN_LMEM, .__runtime.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),drivers/gpu/drm/i915/i915_reg.h +7
-0@@ -5798,6 +5798,11 @@#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz (1 << 29)#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz (2 << 29) +#define GMD_ID_DISPLAY _MMIO(0x510a0) +#define GMD_ID_ARCH_MASK REG_GENMASK(31, 22) +#define GMD_ID_RELEASE_MASK REG_GENMASK(21, 14) +#define GMD_ID_STEP REG_GENMASK(5, 0) +/*GEN11 chicken */ #define _PIPEA_CHICKEN 0x70038#define _PIPEB_CHICKEN 0x71038@@ -8298,4 +8303,6 @@ enum skl_power_gate {#define MTL_LATENCY_LEVEL_EVEN_MASK REG_GENMASK(12, 0)#define MTL_LATENCY_LEVEL_ODD_MASK REG_GENMASK(28, 16) +#define MTL_MEDIA_GSI_BASE 0x380000 +#endif /* _I915_REG_H_ */ drivers/gpu/drm/i915/intel_device_info.c +13
-1@@ -29,6 +29,7 @@#include "display/intel_cdclk.h" #include "display/intel_de.h" +#include "gt/intel_gt_regs.h" #include "intel_device_info.h" #include "i915_drv.h" #include "i915_utils.h" @@ -231,7 +232,7 @@ static bool find_devid(u16 id, const u16 *p, unsigned int num)return false; } -void intel_device_info_subplatform_init (struct drm_i915_private *i915) +static void intel_device_info_subplatform_init (struct drm_i915_private *i915) {const struct intel_device_info *info =INTEL_INFO (i915);const struct intel_runtime_info *rinfo =RUNTIME_INFO (i915);@@ -288,6 +289,77 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)RUNTIME_INFO (i915)->platform_mask[pi] |= mask; } +static void ip_ver_read (struct drm_i915_private *i915,u32 offset,struct ip_version *ip) +{ +struct pci_dev *pdev =to_pci_dev (i915->drm.dev); +void __iomem *addr; +u32 val; +u8 ver = ip->ver; +u8 rel = ip->rel; + + addr =pci_iomap_range (pdev,0 , offset,sizeof (u32)); +if (drm_WARN_ON (&i915->drm, !addr)) +return ;drivers/gpu/drm/i915/intel_device_info.c void intel_device_info_subplatform_init(struct drm_i915_private *i915) · line 312
Quoted 10 lines
drivers/gpu/drm/i915/intel_device_info.c +10
-0+ + val =ioread32 (addr); +pci_iounmap (pdev, addr); + + ip->ver =REG_FIELD_GET (GMD_ID_ARCH_MASK , val); + ip->rel =REG_FIELD_GET (GMD_ID_RELEASE_MASK , val); + ip->step =REG_FIELD_GET (GMD_ID_STEP , val); + +/* Sanity check against expected versions from device info */ +if (ip->ver != ver || ip->rel > rel)this doesn't seem correct.. if we have
ip->ver == 12, ip->rel == 1 ver == 12, rel == 0
Quoted 6 lines
we will print
Hardware reports GMD IP version 12.1 but minimum expected is 12.0"
should it be
|| ip->rel < rel? Once we land the static number in device info, we can only expect new .rel versions greater than that.
I'm not sure how much value there is in keeping this sanity check at all given that we plan to remove the device info versions completely for platforms with GMD_ID. But if you want to test this in an easy-to-read manner in the short term,
if (IP_VER(ip->ver, ip->rel) < IP_VER(ver, rel))
would probably be best.
Matt
Quoted 2 lines
Lucas De Marchi
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
Re: [Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw
Quoted 170 lines · Matt Roper
Quoted 162 lines · Lucas De Marchi
Quoted 145 lines · Radhakrishna Sripada
From: Matt Roper <[email protected]>
Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be read directly from a register in the MMIO space. New hardware programming styles, features, and workarounds should be conditional solely on the architecture version, and should no longer be derived from the PCI device ID, revision ID, or platform-specific feature flags.
Bspec: 63361, 64111
v2:
- Move the IP version readout tointel_device_info.c
- Convert the macro into a functionv3:
- Move subplatform init to runtime early init
- Cache runtime ver, release info to compare with hardware values.Signed-off-by Matt Roper <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_driver.c | 3 +- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 7 +++ drivers/gpu/drm/i915/intel_device_info.c | 74 +++++++++++++++++++++++- drivers/gpu/drm/i915/intel_device_info.h | 12 +++- 7 files changed, 98 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/gt/intel_gt_regs.h +2
-0@@ -39,6 +39,8 @@#define FORCEWAKE_ACK_RENDER_GEN9 _MMIO(0xd84)#define FORCEWAKE_ACK_MEDIA_GEN9 _MMIO(0xd88) +#define GMD_ID_GRAPHICS _MMIO(0xd8c) +#define MCFG_MCR_SELECTOR _MMIO(0xfd0)#define SF_MCR_SELECTOR _MMIO(0xfd8)#define GEN8_MCR_SELECTOR _MMIO(0xfdc)drivers/gpu/drm/i915/i915_driver.c +2
-1@@ -323,7 +323,8 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)if (i915_inject_probe_failure (dev_priv))return -ENODEV ; -intel_device_info_subplatform_init (dev_priv); +intel_device_info_runtime_init_early (dev_priv); +intel_step_init (dev_priv);intel_uncore_mmio_debug_init_early (&dev_priv->mmio_debug);drivers/gpu/drm/i915/i915_drv.h +2
-0@@ -936,6 +936,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_GMCH (dev_priv) (INTEL_INFO(dev_priv)->display.has_gmch) +#define HAS_GMD_ID (i915) INTEL_INFO(i915)->has_gmd_id +#define HAS_LSPCON (dev_priv) (IS_DISPLAY_VER(dev_priv, 9, 10))#define HAS_L3_CCS_READ (i915) (INTEL_INFO(i915)->has_l3_ccs_read)drivers/gpu/drm/i915/i915_pci.c +1
-0@@ -1129,6 +1129,7 @@ static const struct intel_device_info mtl_info = {PLATFORM (INTEL_METEORLAKE ), .display.has_modular_fia = 1, .has_flat_ccs = 0, + .has_gmd_id = 1, .has_snoop = 1, .__runtime.memory_regions = REGION_SMEM | REGION_STOLEN_LMEM, .__runtime.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),drivers/gpu/drm/i915/i915_reg.h +7
-0@@ -5798,6 +5798,11 @@#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz (1 << 29)#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz (2 << 29) +#define GMD_ID_DISPLAY _MMIO(0x510a0) +#define GMD_ID_ARCH_MASK REG_GENMASK(31, 22) +#define GMD_ID_RELEASE_MASK REG_GENMASK(21, 14) +#define GMD_ID_STEP REG_GENMASK(5, 0) +/*GEN11 chicken */ #define _PIPEA_CHICKEN 0x70038#define _PIPEB_CHICKEN 0x71038@@ -8298,4 +8303,6 @@ enum skl_power_gate {#define MTL_LATENCY_LEVEL_EVEN_MASK REG_GENMASK(12, 0)#define MTL_LATENCY_LEVEL_ODD_MASK REG_GENMASK(28, 16) +#define MTL_MEDIA_GSI_BASE 0x380000 +#endif /* _I915_REG_H_ */ drivers/gpu/drm/i915/intel_device_info.c +13
-1@@ -29,6 +29,7 @@#include "display/intel_cdclk.h" #include "display/intel_de.h" +#include "gt/intel_gt_regs.h" #include "intel_device_info.h" #include "i915_drv.h" #include "i915_utils.h" @@ -231,7 +232,7 @@ static bool find_devid(u16 id, const u16 *p, unsigned int num)return false; } -void intel_device_info_subplatform_init (struct drm_i915_private *i915) +static void intel_device_info_subplatform_init (struct drm_i915_private *i915) {const struct intel_device_info *info =INTEL_INFO (i915);const struct intel_runtime_info *rinfo =RUNTIME_INFO (i915);@@ -288,6 +289,77 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)RUNTIME_INFO (i915)->platform_mask[pi] |= mask; } +static void ip_ver_read (struct drm_i915_private *i915,u32 offset,struct ip_version *ip) +{ +struct pci_dev *pdev =to_pci_dev (i915->drm.dev); +void __iomem *addr; +u32 val; +u8 ver = ip->ver; +u8 rel = ip->rel; + + addr =pci_iomap_range (pdev,0 , offset,sizeof (u32)); +if (drm_WARN_ON (&i915->drm, !addr)) +return ;drivers/gpu/drm/i915/intel_device_info.c void intel_device_info_subplatform_init(struct drm_i915_private *i915) · line 312
Quoted 10 lines
drivers/gpu/drm/i915/intel_device_info.c +10
-0+ + val =ioread32 (addr); +pci_iounmap (pdev, addr); + + ip->ver =REG_FIELD_GET (GMD_ID_ARCH_MASK , val); + ip->rel =REG_FIELD_GET (GMD_ID_RELEASE_MASK , val); + ip->step =REG_FIELD_GET (GMD_ID_STEP , val); + +/* Sanity check against expected versions from device info */ +if (ip->ver != ver || ip->rel > rel)this doesn't seem correct.. if we have
ip->ver == 12, ip->rel == 1 ver == 12, rel == 0Quoted 6 lines
we will print
Hardware reports GMD IP version 12.1 but minimum expected is 12.0"
should it be
|| ip->rel < rel? Once we land the static number in device info, we can only expect new .rel versions greater than that.
Quoted 8 lines
I'm not sure how much value there is in keeping this sanity check at all given that we plan to remove the device info versions completely for platforms with
GMD_ID. But if you want to test this in an easy-to-read manner in the short term,if (IP_VER(ip->ver, ip->rel) < IP_VER(ver, rel))would probably be best.
I'm ok with removing the sanity check as long as we log the value read. We still do when printing all the info, so lgtm.
Lucas De Marchi
Quoted 12 lines
Matt
Quoted 2 lines
Lucas De Marchi
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
RE: [Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw
Hi Lucas/Matt,
Quoted 201 lines
-----Original Message-----
From: De Marchi, Lucas <[email protected]>
Sent: Wednesday, September 7, 2022 3:21 PM
To: Roper, Matthew D <[email protected]>
Cc: Sripada, Radhakrishna <[email protected]>; intel- [email protected]; [email protected]; Vivi, Rodrigo <[email protected]>
Subject: Re: [Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hwQuoted 23 lines · Matt Roper
Quoted 22 lines · Lucas De Marchi
Quoted 21 lines · Radhakrishna Sripada
From: Matt Roper <[email protected]>
Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be read directly from a register in the MMIO space. New hardware programming styles, features, and workarounds should be conditional solely on the architecture version, and should no longer be derived from the PCI device ID, revision ID, or platform-specific feature flags.
Bspec: 63361, 64111
v2:
- Move the IP version readout tointel_device_info.c
- Convert the macro into a functionv3:
- Move subplatform init to runtime early init
- Cache runtime ver, release info to compare with hardware values.Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Signed-off-by Matt Roper <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_driver.c | 3 +- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 7 +++ drivers/gpu/drm/i915/intel_device_info.c | 74+++++++++++++++++++++++-
Quoted 4 lines
Quoted 4 lines
Review
Quoted 4 lines
drivers/gpu/drm/i915/intel_device_info.h| 12 +++-7 files changed, 98 insertions(+), 3 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/gt/intel_gt_regs.hQuoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_gt_regs.h line 42
Quoted 8 lines
index
d414785003cc..579da62158c4100644drivers/gpu/drm/i915/gt/intel_gt_regs.h +1
-0@@ -39,6 +39,8 @@#define FORCEWAKE_ACK_RENDER_GEN9 _MMIO(0xd84)#define FORCEWAKE_ACK_MEDIA_GEN9 _MMIO(0xd88) +#define GMD_ID_GRAPHICS _MMIO(0xd8c)Quoted 5 lines
Quoted 5 lines
Review
Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_gt_regs.h +1
-0+#define MCFG_MCR_SELECTOR _MMIO(0xfd0)#define SF_MCR_SELECTOR _MMIO(0xfd8)#define GEN8_MCR_SELECTOR _MMIO(0xfdc)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_driver.cQuoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/i915_driver.c static int i915_driver_early_probe(struct
Quoted 4 lines
index
56a2bcddb2af..a1ab49521d19100644drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -323,7 +323,8 @@ static int i915_driver_early_probe(struct
drm_i915_private*dev_priv)Quoted 10 lines
Quoted 10 lines
Review
Quoted 10 lines
drivers/gpu/drm/i915/i915_driver.c +2
-1if (i915_inject_probe_failure (dev_priv))return -ENODEV ; -intel_device_info_subplatform_init (dev_priv); +intel_device_info_runtime_init_early (dev_priv); +intel_step_init (dev_priv);intel_uncore_mmio_debug_init_early (&dev_priv->mmio_debug);(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_drv.hQuoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private
Quoted 4 lines
index
f85a470397a5..405b59b8c05c100644drivers/gpu/drm/i915/i915_drv.h +0
-0@@ -936,6 +936,8 @@ IS_SUBPLATFORM(const struct drm_i915_private*i915,
Quoted 9 lines
Quoted 9 lines
Review
Quoted 9 lines
drivers/gpu/drm/i915/i915_drv.h +2
-0#define HAS_GMCH (dev_priv) (INTEL_INFO(dev_priv)->display.has_gmch) +#define HAS_GMD_ID (i915) INTEL_INFO(i915)->has_gmd_id +#define HAS_LSPCON (dev_priv) (IS_DISPLAY_VER(dev_priv, 9, 10))#define HAS_L3_CCS_READ (i915) (INTEL_INFO(i915)->has_l3_ccs_read)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_pci.cQuoted 10 lines
Quoted 10 lines
drivers/gpu/drm/i915/i915_pci.c static const struct intel_device_info mtl_info = { · line 1134
Quoted 10 lines
index
f6aaf938c53c..4672894f4bc1100644drivers/gpu/drm/i915/i915_pci.c +1
-0@@ -1129,6 +1129,7 @@ static const struct intel_device_info mtl_info = {PLATFORM (INTEL_METEORLAKE ), .display.has_modular_fia = 1, .has_flat_ccs = 0, + .has_gmd_id = 1, .has_snoop = 1, .__runtime.memory_regions = REGION_SMEM |
REGION_STOLEN_LMEM,Quoted 2 lines
Quoted 2 lines
Review
Quoted 2 lines
drivers/gpu/drm/i915/i915_pci.c +0
-0.__runtime.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_reg.hQuoted 19 lines
Quoted 19 lines
Quoted 19 lines
index
5e6239864c35..e02e461a4b5d100644drivers/gpu/drm/i915/i915_reg.h +5
-0@@ -5798,6 +5798,11 @@#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz (1 << 29)#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz (2 << 29) +#define GMD_ID_DISPLAY _MMIO(0x510a0) +#define GMD_ID_ARCH_MASK REG_GENMASK(31, 22) +#define GMD_ID_RELEASE_MASK REG_GENMASK(21, 14) +#define GMD_ID_STEP REG_GENMASK(5, 0) +/*GEN11 chicken */ #define _PIPEA_CHICKEN 0x70038#define _PIPEB_CHICKEN 0x71038@@ -8298,4 +8303,6 @@ enum skl_power_gate {#define MTL_LATENCY_LEVEL_EVEN_MASK REG_GENMASK(12, 0)#define MTL_LATENCY_LEVEL_ODD_MASK REG_GENMASK(28, 16)Quoted 4 lines
Quoted 4 lines
Review
Quoted 4 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0+#define MTL_MEDIA_GSI_BASE 0x380000 +#endif /* _I915_REG_H_ */ (quoted diff) +0
-0
b/drivers/gpu/drm/i915/intel_device_info.cQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
index
56f19683dd55..a5bafc9be1fa100644drivers/gpu/drm/i915/intel_device_info.c +0
-0@@ -29,6 +29,7 @@Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/i915/intel_device_info.c static bool find_devid(u16 id, const u16 *p,
Quoted 7 lines
drivers/gpu/drm/i915/intel_device_info.c +1
-0#include "display/intel_cdclk.h" #include "display/intel_de.h" +#include "gt/intel_gt_regs.h" #include "intel_device_info.h" #include "i915_drv.h" #include "i915_utils.h" @@ -231,7 +232,7 @@ static bool find_devid(u16 id, const u16 *p,unsigned int num)
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/i915/intel_device_info.c static bool find_devid(u16 id, const u16 *p, unsigned int num)
Quoted 5 lines
drivers/gpu/drm/i915/intel_device_info.c +1
-1return false; } -void intel_device_info_subplatform_init (struct drm_i915_private *i915) +static void intel_device_info_subplatform_init(struct drm_i915_private*i915)
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/intel_device_info.c void intel_device_info_subplatform_init(struct
Quoted 4 lines
drivers/gpu/drm/i915/intel_device_info.c +0
-0{const struct intel_device_info *info =INTEL_INFO (i915);const struct intel_runtime_info *rinfo =RUNTIME_INFO (i915);@@ -288,6 +289,77 @@ void intel_device_info_subplatform_init(struct
drm_i915_private*i915)Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/intel_device_info.c void intel_device_info_subplatform_init(struct drm_i915_private *i915)
Quoted 4 lines
drivers/gpu/drm/i915/intel_device_info.c +1
-0RUNTIME_INFO (i915)->platform_mask[pi] |= mask; } +static void ip_ver_read(struct drm_i915_private *i915, u32 offset, struct
ip_version*ip)Quoted 38 lines
Quoted 26 lines
Quoted 10 lines
drivers/gpu/drm/i915/intel_device_info.c +10
-0+{ +struct pci_dev *pdev =to_pci_dev (i915->drm.dev); +void __iomem *addr; +u32 val; +u8 ver = ip->ver; +u8 rel = ip->rel; + + addr =pci_iomap_range (pdev,0 , offset,sizeof (u32)); +if (drm_WARN_ON (&i915->drm, !addr)) +return ;drivers/gpu/drm/i915/intel_device_info.c void intel_device_info_subplatform_init(struct drm_i915_private *i915) · line 312
Quoted 10 lines
drivers/gpu/drm/i915/intel_device_info.c +10
-0+ + val =ioread32 (addr); +pci_iounmap (pdev, addr); + + ip->ver =REG_FIELD_GET (GMD_ID_ARCH_MASK , val); + ip->rel =REG_FIELD_GET (GMD_ID_RELEASE_MASK , val); + ip->step =REG_FIELD_GET (GMD_ID_STEP , val); + +/* Sanity check against expected versions from device info */ +if (ip->ver != ver || ip->rel > rel)this doesn't seem correct.. if we have
ip->ver == 12, ip->rel == 1 ver == 12, rel == 0Quoted 6 lines
we will print
Hardware reports GMD IP version 12.1 but minimum expected is 12.0"
should it be
|| ip->rel < rel? Once we land the static number in device info, we can only expect new .rel versions greater than that.I'm not sure how much value there is in keeping this sanity check at all given that we plan to remove the device info versions completely for platforms with
GMD_ID. But if you want to test this in an easy-to-read manner in the short term,
Quoted 6 lines
Quoted 3 lines
if (IP_VER(ip->ver, ip->rel) < IP_VER(ver, rel))would probably be best.
I'm ok with removing the sanity check as long as we log the value read. We still do when printing all the info, so lgtm.
I agree with Matt's suggestion. Will spin a new rev with IP_VER based check. Although we print the info later. It is worth doing a sanity check as we read the info.
-RK
Quoted 15 lines
Lucas De Marchi
Quoted 12 lines
Matt
Quoted 2 lines
Lucas De Marchi
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
PATCH 1/1 drm/i915: Read graphics/media/display arch version from hw
In reply to Radhakrishna SripadaFrom: Matt Roper <[email protected]>
Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be read directly from a register in the MMIO space. New hardware programming styles, features, and workarounds should be conditional solely on the architecture version, and should no longer be derived from the PCI device ID, revision ID, or platform-specific feature flags.
Bspec: 63361, 64111
v2:
- Move the IP version readout to intel_device_info.c
- Convert the macro into a function
v3:
- Move subplatform init to runtime early init
- Cache runtime ver, release info to compare with hardware values.
- Use IP_VER for snaity check(MattR)
--- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_driver.c | 3 +- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 7 +++ drivers/gpu/drm/i915/intel_device_info.c | 74 +++++++++++++++++++++++- drivers/gpu/drm/i915/intel_device_info.h | 12 +++- 7 files changed, 98 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt_regs.h +2 -0
@@ -39,6 +39,8 @@#define FORCEWAKE_ACK_RENDER_GEN9 _MMIO(0xd84)#define FORCEWAKE_ACK_MEDIA_GEN9 _MMIO(0xd88) +#define GMD_ID_GRAPHICS _MMIO(0xd8c) +#define MCFG_MCR_SELECTOR _MMIO(0xfd0)#define SF_MCR_SELECTOR _MMIO(0xfd8)#define GEN8_MCR_SELECTOR _MMIO(0xfdc)
drivers/gpu/drm/i915/i915_driver.c +2 -1
@@ -323,7 +323,8 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)if (i915_inject_probe_failure (dev_priv))return -ENODEV ; -intel_device_info_subplatform_init (dev_priv); +intel_device_info_runtime_init_early (dev_priv); +intel_step_init (dev_priv);intel_uncore_mmio_debug_init_early (&dev_priv->mmio_debug);
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -936,6 +936,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_GMCH (dev_priv) (INTEL_INFO(dev_priv)->display.has_gmch) +#define HAS_GMD_ID (i915) INTEL_INFO(i915)->has_gmd_id +#define HAS_LSPCON (dev_priv) (IS_DISPLAY_VER(dev_priv, 9, 10))#define HAS_L3_CCS_READ (i915) (INTEL_INFO(i915)->has_l3_ccs_read)
drivers/gpu/drm/i915/i915_pci.c +1 -0
@@ -1129,6 +1129,7 @@ static const struct intel_device_info mtl_info = {PLATFORM (INTEL_METEORLAKE ), .display.has_modular_fia = 1, .has_flat_ccs = 0, + .has_gmd_id = 1, .has_snoop = 1, .__runtime.memory_regions = REGION_SMEM | REGION_STOLEN_LMEM, .__runtime.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),
drivers/gpu/drm/i915/i915_reg.h +7 -0
@@ -5798,6 +5798,11 @@#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz (1 << 29)#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz (2 << 29) +#define GMD_ID_DISPLAY _MMIO(0x510a0) +#define GMD_ID_ARCH_MASK REG_GENMASK(31, 22) +#define GMD_ID_RELEASE_MASK REG_GENMASK(21, 14) +#define GMD_ID_STEP REG_GENMASK(5, 0) +/*GEN11 chicken */ #define _PIPEA_CHICKEN 0x70038#define _PIPEB_CHICKEN 0x71038
@@ -8298,4 +8303,6 @@ enum skl_power_gate {#define MTL_LATENCY_LEVEL_EVEN_MASK REG_GENMASK(12, 0)#define MTL_LATENCY_LEVEL_ODD_MASK REG_GENMASK(28, 16) +#define MTL_MEDIA_GSI_BASE 0x380000 +#endif /* _I915_REG_H_ */
drivers/gpu/drm/i915/intel_device_info.c +73 -1
92 lines not on this page · raw message
drivers/gpu/drm/i915/intel_device_info.h +11 -1
@@ -152,6 +152,7 @@ enum intel_ppgtt_type {func (has_4tile); \func (has_flat_ccs); \func (has_global_mocs); \ +func (has_gmd_id); \func (has_gt_uc); \func (has_heci_pxp); \func (has_heci_gscfi); \
@@ -197,9 +198,18 @@ enum intel_ppgtt_type {struct ip_version {u8 ver;u8 rel; +u8 step; };struct intel_runtime_info { +/* +* On modern platforms, the architecture major.minor version numbers +* and stepping are read directly from the hardware rather than derived +* from the PCI device and revision ID's. +* +* Note that the hardware gives us a single "graphics" number that +* should represent render, compute, and copy behavior. +*/ struct {struct ip_version version; } graphics;
@@ -305,7 +315,7 @@ struct intel_driver_caps {const char *intel_platform_name (enum intel_platform platform); -void intel_device_info_subplatform_init (struct drm_i915_private *dev_priv); +void intel_device_info_runtime_init_early (struct drm_i915_private *dev_priv);void intel_device_info_runtime_init (struct drm_i915_private *dev_priv); void intel_device_info_print(const struct intel_device_info *info,
Signature · 1 line
2.34.1
PATCH v4 3/11 drm/i915: Parse and set stepping for platforms with GMD
In reply to Radhakrishna SripadaFrom: José Roberto de Souza <[email protected]>
The GMD step field do not properly match the current stepping convention that we use(STEP_A0, STEP_A1, STEP_B0...).
One platform could have { arch = 12, rel = 70, step = 1 } and the actual stepping is STEP_B0 but without the translation of the step field would mean STEP_A1.
That is why we will need to have gmd_to_intel_step tables for each IP.
v2:
- Pass the updated ip version structure
--- drivers/gpu/drm/i915/intel_step.c | 60 +++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+)
drivers/gpu/drm/i915/intel_step.c +60 -0
@@ -135,6 +135,48 @@ static const struct intel_step_info adlp_n_revids[] = { [0x0] = { COMMON_GT_MEDIA_STEP(A0), .display_step = STEP_D0 }, }; +struct gmd_to_intel_step { +struct ip_version gmd; +enum intel_step step; +}; + +static const struct gmd_to_intel_step gmd_graphics_table[] = { + { .gmd.ver =12 , .gmd.rel =70 , .gmd.step =0 , .step =STEP_A0 }, + { .gmd.ver =12 , .gmd.rel =70 , .gmd.step =4 , .step =STEP_B0 }, + { .gmd.ver =12 , .gmd.rel =71 , .gmd.step =0 , .step =STEP_A0 }, + { .gmd.ver =12 , .gmd.rel =71 , .gmd.step =4 , .step =STEP_B0 }, + { .gmd.ver =12 , .gmd.rel =73 , .gmd.step =0 , .step =STEP_A0 }, + { .gmd.ver =12 , .gmd.rel =73 , .gmd.step =4 , .step =STEP_B0 }, +}; + +static const struct gmd_to_intel_step gmd_media_table[] = { + { .gmd.ver =13 , .gmd.rel =70 , .gmd.step =0 , .step =STEP_A0 }, + { .gmd.ver =13 , .gmd.rel =70 , .gmd.step =4 , .step =STEP_B0 }, +}; + +static const struct gmd_to_intel_step gmd_display_table[] = { + { .gmd.ver =14 , .gmd.rel =0 , .gmd.step =0 , .step =STEP_A0 }, + { .gmd.ver =14 , .gmd.rel =0 , .gmd.step =4 , .step =STEP_B0 }, +}; + +static u8 gmd_to_intel_step (struct drm_i915_private *i915, +struct ip_version *gmd, +const struct gmd_to_intel_step *table, +int len) +{ +int i; + +for (i =0 ; i < len; i++) { +if (table[i].gmd.ver == gmd->ver && + table[i].gmd.rel == gmd->rel && + table[i].gmd.step == gmd->step) +return table[i].step; + } + +drm_dbg (&i915->drm,"Using future steppings\n" ); +return STEP_FUTURE ; +} +static void pvc_step_init (struct drm_i915_private *i915,int pci_revid);void intel_step_init (struct drm_i915_private *i915)
@@ -144,6 +186,24 @@ void intel_step_init(struct drm_i915_private *i915)int revid =INTEL_REVID (i915);struct intel_step_info step = {}; +if (HAS_GMD_ID (i915)) { + step.graphics_step =gmd_to_intel_step (i915, + &RUNTIME_INFO (i915)->graphics.version, + gmd_graphics_table, +ARRAY_SIZE (gmd_graphics_table)); + step.media_step =gmd_to_intel_step (i915, + &RUNTIME_INFO (i915)->media.version, + gmd_media_table, +ARRAY_SIZE (gmd_media_table)); + step.display_step =gmd_to_intel_step (i915, + &RUNTIME_INFO (i915)->display.version, + gmd_display_table, +ARRAY_SIZE (gmd_display_table)); +RUNTIME_INFO (i915)->step = step; + +return ; + } +if (IS_PONTEVECCHIO (i915)) {pvc_step_init (i915, revid);return ;
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v4 03/11] drm/i915: Parse and set stepping for platforms with GMD
Quoted 9 lines · Radhakrishna Sripada
From: José Roberto de Souza <[email protected]>
The GMD step field do not properly match the current stepping convention that we
use(STEP_A0, STEP_A1, STEP_B0...).One platform could have { arch = 12, rel = 70, step = 1 } and the actual stepping is
STEP_B0but without the translation of the step field would meanSTEP_A1.
That is why we will need to havegmd_to_intel_steptables for each IP.
The (unofficial) claim by the hardware team when GMD_ID was introduced was that they planned to standardize stepping numbering going forward such that they would leave space for up to four minor steppings between each major stepping. I.e., B0 is expected to be 0x4 on all future platforms, C0 is expected to be 0x8, etc.
While I'm not super confident that they'll actually stick with that plan forever (e.g., what happens if we wind up having an A5 stepping someday?), it seems like we could at least start with that as our initial assumption and write generic translation code for now; if/when we encounter a platform that deviates, we can add a platform-specific table for it at that time.
Matt
Quoted 91 lines
v2:
- Pass the updated ip version structureCc Balasubramani Vivekanandan <[email protected]>Signed-off-by José Roberto de Souza <[email protected]>--- drivers/gpu/drm/i915/intel_step.c | 60 +++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+)drivers/gpu/drm/i915/intel_step.c +60
-0@@ -135,6 +135,48 @@ static const struct intel_step_info adlp_n_revids[] = { [0x0] = { COMMON_GT_MEDIA_STEP(A0), .display_step = STEP_D0 }, }; +struct gmd_to_intel_step { +struct ip_version gmd; +enum intel_step step; +}; + +static const struct gmd_to_intel_step gmd_graphics_table[] = { + { .gmd.ver =12 , .gmd.rel =70 , .gmd.step =0 , .step =STEP_A0 }, + { .gmd.ver =12 , .gmd.rel =70 , .gmd.step =4 , .step =STEP_B0 }, + { .gmd.ver =12 , .gmd.rel =71 , .gmd.step =0 , .step =STEP_A0 }, + { .gmd.ver =12 , .gmd.rel =71 , .gmd.step =4 , .step =STEP_B0 }, + { .gmd.ver =12 , .gmd.rel =73 , .gmd.step =0 , .step =STEP_A0 }, + { .gmd.ver =12 , .gmd.rel =73 , .gmd.step =4 , .step =STEP_B0 }, +}; + +static const struct gmd_to_intel_step gmd_media_table[] = { + { .gmd.ver =13 , .gmd.rel =70 , .gmd.step =0 , .step =STEP_A0 }, + { .gmd.ver =13 , .gmd.rel =70 , .gmd.step =4 , .step =STEP_B0 }, +}; + +static const struct gmd_to_intel_step gmd_display_table[] = { + { .gmd.ver =14 , .gmd.rel =0 , .gmd.step =0 , .step =STEP_A0 }, + { .gmd.ver =14 , .gmd.rel =0 , .gmd.step =4 , .step =STEP_B0 }, +}; + +static u8 gmd_to_intel_step (struct drm_i915_private *i915, +struct ip_version *gmd, +const struct gmd_to_intel_step *table, +int len) +{ +int i; + +for (i =0 ; i < len; i++) { +if (table[i].gmd.ver == gmd->ver && + table[i].gmd.rel == gmd->rel && + table[i].gmd.step == gmd->step) +return table[i].step; + } + +drm_dbg (&i915->drm,"Using future steppings\n" ); +return STEP_FUTURE ; +} +static void pvc_step_init (struct drm_i915_private *i915,int pci_revid);void intel_step_init (struct drm_i915_private *i915)@@ -144,6 +186,24 @@ void intel_step_init(struct drm_i915_private *i915)int revid =INTEL_REVID (i915);struct intel_step_info step = {}; +if (HAS_GMD_ID (i915)) { + step.graphics_step =gmd_to_intel_step (i915, + &RUNTIME_INFO (i915)->graphics.version, + gmd_graphics_table, +ARRAY_SIZE (gmd_graphics_table)); + step.media_step =gmd_to_intel_step (i915, + &RUNTIME_INFO (i915)->media.version, + gmd_media_table, +ARRAY_SIZE (gmd_media_table)); + step.display_step =gmd_to_intel_step (i915, + &RUNTIME_INFO (i915)->display.version, + gmd_display_table, +ARRAY_SIZE (gmd_display_table)); +RUNTIME_INFO (i915)->step = step; + +return ; + } +if (IS_PONTEVECCHIO (i915)) {pvc_step_init (i915, revid);return ;Signature · 1 line
2.34.1
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
PATCH v4 4/11 drm/i915/mtl: Define engine context layouts
In reply to Radhakrishna SripadaFrom: Matt Roper <[email protected]>
The part of the media and blitter engine contexts that we care about for setting up an initial state are the same on MTL as they were on DG2 (and PVC), so we need to update the driver conditions to re-use the DG2 context table.
For render/compute engines, the part of the context images are nearly the same, although the layout had a very slight change --- one POSH register was removed and the placement of some LRI/noops adjusted slightly to compensate.
v2:
- Dg2, mtl xcs offsets slightly vary. Use a separate offsets array(Bala)
- Drop unused registers in mtl rcs offsets.(Bala)
Bspec: 46261, 46260, 45585
--- drivers/gpu/drm/i915/gt/intel_lrc.c | 81 ++++++++++++++++++++++++++++- 1 file changed, 79 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_lrc.c +79 -2
@@ -264,6 +264,38 @@ static const u8 dg2_xcs_offsets[] = {END }; +static const u8 mtl_xcs_offsets[] = { +NOP (1 ), +LRI (13 ,POSTED ), +REG16 (0x244 ), +REG (0x034 ), +REG (0x030 ), +REG (0x038 ), +REG (0x03c ), +REG (0x168 ), +REG (0x140 ), +REG (0x110 ), +REG (0x1c0 ), +REG (0x1c4 ), +REG (0x1c8 ), +REG (0x180 ), +REG16 (0x2b4 ), + +NOP (1 ), +LRI (9 ,POSTED ), +REG16 (0x3a8 ), +REG16 (0x28c ), +REG16 (0x288 ), +REG16 (0x284 ), +REG16 (0x280 ), +REG16 (0x27c ), +REG16 (0x278 ), +REG16 (0x274 ), +REG16 (0x270 ), + +END +}; +static const u8 gen8_rcs_offsets[] = {NOP (1 ),LRI (14 ,POSTED ),
@@ -606,6 +638,47 @@ static const u8 dg2_rcs_offsets[] = { END }; +static const u8 mtl_rcs_offsets[] = { +NOP (1 ), +LRI (13 ,POSTED ), +REG16 (0x244 ), +REG (0x034 ), +REG (0x030 ), +REG (0x038 ), +REG (0x03c ), +REG (0x168 ), +REG (0x140 ), +REG (0x110 ), +REG (0x1c0 ), +REG (0x1c4 ), +REG (0x1c8 ), +REG (0x180 ), +REG16 (0x2b4 ), + +NOP (1 ), +LRI (9 ,POSTED ), +REG16 (0x3a8 ), +REG16 (0x28c ), +REG16 (0x288 ), +REG16 (0x284 ), +REG16 (0x280 ), +REG16 (0x27c ), +REG16 (0x278 ), +REG16 (0x274 ), +REG16 (0x270 ), + +NOP (2 ), +LRI (2 ,POSTED ), +REG16 (0x5a8 ), +REG16 (0x5ac ), + +NOP (6 ), +LRI (1 ,0 ), +REG (0x0c8 ), + +END +}; +#undef END#undef REG16#undef REG
@@ -624,7 +697,9 @@ static const u8 *reg_offsets(const struct intel_engine_cs *engine) !intel_engine_has_relative_mmio(engine));if (engine->flags &I915_ENGINE_HAS_RCS_REG_STATE ) { -if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 )) +if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,70 )) +return mtl_rcs_offsets; +else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 ))return dg2_rcs_offsets;else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,50 ))return xehp_rcs_offsets;
@@ -637,7 +712,9 @@ static const u8 *reg_offsets(const struct intel_engine_cs *engine)else return gen8_rcs_offsets; }else { -if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 )) +if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,70 )) +return mtl_xcs_offsets; +else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 ))return dg2_xcs_offsets;else if (GRAPHICS_VER (engine->i915) >=12 )return gen12_xcs_offsets;
Signature · 1 line
2.34.1
Re: [PATCH v4 04/11] drm/i915/mtl: Define engine context layouts
Quoted 38 lines · Radhakrishna Sripada
From: Matt Roper <[email protected]>
The part of the media and blitter engine contexts that we care about for setting up an initial state are the same on MTL as they were on DG2 (and PVC), so we need to update the driver conditions to re-use the DG2 context table.
For render/compute engines, the part of the context images are nearly the same, although the layout had a very slight change --- one POSH register was removed and the placement of some LRI/noops adjusted slightly to compensate.
v2:
- Dg2, mtl xcs offsets slightly vary. Use a separate offsets array(Bala)
- Drop unused registers in mtl rcs offsets.(Bala)Bspec: 46261, 46260, 45585
Cc Balasubramani Vivekanandan <[email protected]>Signed-off-by Matt Roper <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/gt/intel_lrc.c | 81 ++++++++++++++++++++++++++++- 1 file changed, 79 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/gt/intel_lrc.c +6
-0@@ -264,6 +264,38 @@ static const u8 dg2_xcs_offsets[] = {END }; +static const u8 mtl_xcs_offsets[] = { +NOP (1 ), +LRI (13 ,POSTED ), +REG16 (0x244 ), +REG (0x034 ), +REG (0x030 ),
drivers/gpu/drm/i915/gt/intel_lrc.c static const u8 dg2_xcs_offsets[] = { · line 282
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_lrc.c +10
-0+REG (0x038 ), +REG (0x03c ), +REG (0x168 ), +REG (0x140 ), +REG (0x110 ), +REG (0x1c0 ), +REG (0x1c4 ), +REG (0x1c8 ), +REG (0x180 ), + REG16(0x2b4),
Comparing Bspec 45585, there are few NOP missing here
Quoted 92 lines
drivers/gpu/drm/i915/gt/intel_lrc.c +63
-2+ +NOP (1 ), +LRI (9 ,POSTED ), +REG16 (0x3a8 ), +REG16 (0x28c ), +REG16 (0x288 ), +REG16 (0x284 ), +REG16 (0x280 ), +REG16 (0x27c ), +REG16 (0x278 ), +REG16 (0x274 ), +REG16 (0x270 ), + +END +}; +static const u8 gen8_rcs_offsets[] = {NOP (1 ), LRI(14, POSTED),@@ -606,6 +638,47 @@ static const u8 dg2_rcs_offsets[] = { END }; +static const u8 mtl_rcs_offsets[] = { +NOP (1 ), +LRI (13 ,POSTED ), +REG16 (0x244 ), +REG (0x034 ), +REG (0x030 ), +REG (0x038 ), +REG (0x03c ), +REG (0x168 ), +REG (0x140 ), +REG (0x110 ), +REG (0x1c0 ), +REG (0x1c4 ), +REG (0x1c8 ), +REG (0x180 ), +REG16 (0x2b4 ), + +NOP (1 ), +LRI (9 ,POSTED ), +REG16 (0x3a8 ), +REG16 (0x28c ), +REG16 (0x288 ), +REG16 (0x284 ), +REG16 (0x280 ), +REG16 (0x27c ), +REG16 (0x278 ), +REG16 (0x274 ), +REG16 (0x270 ), + +NOP (2 ), +LRI (2 ,POSTED ), +REG16 (0x5a8 ), +REG16 (0x5ac ), + +NOP (6 ), +LRI (1 ,0 ), +REG (0x0c8 ), + +END +}; +#undef END#undef REG16#undef REG@@ -624,7 +697,9 @@ static const u8 *reg_offsets(const struct intel_engine_cs *engine) !intel_engine_has_relative_mmio(engine));if (engine->flags &I915_ENGINE_HAS_RCS_REG_STATE ) { -if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 )) +if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,70 )) +return mtl_rcs_offsets; +else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 ))return dg2_rcs_offsets;else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,50 ))return xehp_rcs_offsets;@@ -637,7 +712,9 @@ static const u8 *reg_offsets(const struct intel_engine_cs *engine)else return gen8_rcs_offsets; }else { -if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 )) +if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,70 )) +return mtl_xcs_offsets; +else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 ))return dg2_xcs_offsets;else if (GRAPHICS_VER (engine->i915) >=12 )return gen12_xcs_offsets;Signature · 1 line
2.34.1
PATCH 1/1 drm/i915/mtl: Define engine context layouts
In reply to Radhakrishna SripadaFrom: Matt Roper <[email protected]>
The part of the media and blitter engine contexts that we care about for setting up an initial state are the same on MTL as they were on DG2 (and PVC), so we need to update the driver conditions to re-use the DG2 context table.
For render/compute engines, the part of the context images are nearly the same, although the layout had a very slight change --- one POSH register was removed and the placement of some LRI/noops adjusted slightly to compensate.
v2:
- Dg2, mtl xcs offsets slightly vary. Use a separate offsets array(Bala)
- Drop unused registers in mtl rcs offsets.(Bala)
- Add missing nop in xcs offsets(Bala)
Bspec: 46261, 46260, 45585
--- drivers/gpu/drm/i915/gt/intel_lrc.c | 82 ++++++++++++++++++++++++++++- 1 file changed, 80 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_lrc.c +80 -2
@@ -264,6 +264,39 @@ static const u8 dg2_xcs_offsets[] = {END }; +static const u8 mtl_xcs_offsets[] = { +NOP (1 ), +LRI (13 ,POSTED ), +REG16 (0x244 ), +REG (0x034 ), +REG (0x030 ), +REG (0x038 ), +REG (0x03c ), +REG (0x168 ), +REG (0x140 ), +REG (0x110 ), +REG (0x1c0 ), +REG (0x1c4 ), +REG (0x1c8 ), +REG (0x180 ), +REG16 (0x2b4 ), +NOP (1 ), + +NOP (1 ), +LRI (9 ,POSTED ), +REG16 (0x3a8 ), +REG16 (0x28c ), +REG16 (0x288 ), +REG16 (0x284 ), +REG16 (0x280 ), +REG16 (0x27c ), +REG16 (0x278 ), +REG16 (0x274 ), +REG16 (0x270 ), + +END +}; +static const u8 gen8_rcs_offsets[] = {NOP (1 ),LRI (14 ,POSTED ),
@@ -606,6 +639,47 @@ static const u8 dg2_rcs_offsets[] = { END }; +static const u8 mtl_rcs_offsets[] = { +NOP (1 ), +LRI (13 ,POSTED ), +REG16 (0x244 ), +REG (0x034 ), +REG (0x030 ), +REG (0x038 ), +REG (0x03c ), +REG (0x168 ), +REG (0x140 ), +REG (0x110 ), +REG (0x1c0 ), +REG (0x1c4 ), +REG (0x1c8 ), +REG (0x180 ), +REG16 (0x2b4 ), + +NOP (1 ), +LRI (9 ,POSTED ), +REG16 (0x3a8 ), +REG16 (0x28c ), +REG16 (0x288 ), +REG16 (0x284 ), +REG16 (0x280 ), +REG16 (0x27c ), +REG16 (0x278 ), +REG16 (0x274 ), +REG16 (0x270 ), + +NOP (2 ), +LRI (2 ,POSTED ), +REG16 (0x5a8 ), +REG16 (0x5ac ), + +NOP (6 ), +LRI (1 ,0 ), +REG (0x0c8 ), + +END +}; +#undef END#undef REG16#undef REG
@@ -624,7 +698,9 @@ static const u8 *reg_offsets(const struct intel_engine_cs *engine) !intel_engine_has_relative_mmio(engine));if (engine->flags &I915_ENGINE_HAS_RCS_REG_STATE ) { -if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 )) +if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,70 )) +return mtl_rcs_offsets; +else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 ))return dg2_rcs_offsets;else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,50 ))return xehp_rcs_offsets;
@@ -637,7 +713,9 @@ static const u8 *reg_offsets(const struct intel_engine_cs *engine)else return gen8_rcs_offsets; }else { -if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 )) +if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,70 )) +return mtl_xcs_offsets; +else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 ))return dg2_xcs_offsets;else if (GRAPHICS_VER (engine->i915) >=12 )return gen12_xcs_offsets;
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v4.1] drm/i915/mtl: Define engine context layouts
Quoted 40 lines · Radhakrishna Sripada
From: Matt Roper <[email protected]>
The part of the media and blitter engine contexts that we care about for setting up an initial state are the same on MTL as they were on DG2 (and PVC), so we need to update the driver conditions to re-use the DG2 context table.
For render/compute engines, the part of the context images are nearly the same, although the layout had a very slight change --- one POSH register was removed and the placement of some LRI/noops adjusted slightly to compensate.
v2:
- Dg2, mtl xcs offsets slightly vary. Use a separate offsets array(Bala)
- Drop unused registers in mtl rcs offsets.(Bala)
- Add missing nop in xcs offsets(Bala)Bspec: 46261, 46260, 45585
Cc Balasubramani Vivekanandan <[email protected]>Signed-off-by Matt Roper <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/gt/intel_lrc.c | 82 ++++++++++++++++++++++++++++- 1 file changed, 80 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/gt/intel_lrc.c +7
-0@@ -264,6 +264,39 @@ static const u8 dg2_xcs_offsets[] = {END }; +static const u8 mtl_xcs_offsets[] = { +NOP (1 ), +LRI (13 ,POSTED ), +REG16 (0x244 ), +REG (0x034 ), +REG (0x030 ), +REG (0x038 ),
drivers/gpu/drm/i915/gt/intel_lrc.c static const u8 dg2_xcs_offsets[] = { · line 283
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_lrc.c +10
-0+REG (0x03c ), +REG (0x168 ), +REG (0x140 ), +REG (0x110 ), +REG (0x1c0 ), +REG (0x1c4 ), +REG (0x1c8 ), +REG (0x180 ), +REG16 (0x2b4 ), + NOP(1),
Shouldn't this be NOP(4)?
Matt
Quoted 92 lines
drivers/gpu/drm/i915/gt/intel_lrc.c +63
-2+ +NOP (1 ), +LRI (9 ,POSTED ), +REG16 (0x3a8 ), +REG16 (0x28c ), +REG16 (0x288 ), +REG16 (0x284 ), +REG16 (0x280 ), +REG16 (0x27c ), +REG16 (0x278 ), +REG16 (0x274 ), +REG16 (0x270 ), + +END +}; +static const u8 gen8_rcs_offsets[] = {NOP (1 ), LRI(14, POSTED),@@ -606,6 +639,47 @@ static const u8 dg2_rcs_offsets[] = { END }; +static const u8 mtl_rcs_offsets[] = { +NOP (1 ), +LRI (13 ,POSTED ), +REG16 (0x244 ), +REG (0x034 ), +REG (0x030 ), +REG (0x038 ), +REG (0x03c ), +REG (0x168 ), +REG (0x140 ), +REG (0x110 ), +REG (0x1c0 ), +REG (0x1c4 ), +REG (0x1c8 ), +REG (0x180 ), +REG16 (0x2b4 ), + +NOP (1 ), +LRI (9 ,POSTED ), +REG16 (0x3a8 ), +REG16 (0x28c ), +REG16 (0x288 ), +REG16 (0x284 ), +REG16 (0x280 ), +REG16 (0x27c ), +REG16 (0x278 ), +REG16 (0x274 ), +REG16 (0x270 ), + +NOP (2 ), +LRI (2 ,POSTED ), +REG16 (0x5a8 ), +REG16 (0x5ac ), + +NOP (6 ), +LRI (1 ,0 ), +REG (0x0c8 ), + +END +}; +#undef END#undef REG16#undef REG@@ -624,7 +698,9 @@ static const u8 *reg_offsets(const struct intel_engine_cs *engine) !intel_engine_has_relative_mmio(engine));if (engine->flags &I915_ENGINE_HAS_RCS_REG_STATE ) { -if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 )) +if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,70 )) +return mtl_rcs_offsets; +else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 ))return dg2_rcs_offsets;else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,50 ))return xehp_rcs_offsets;@@ -637,7 +713,9 @@ static const u8 *reg_offsets(const struct intel_engine_cs *engine)else return gen8_rcs_offsets; }else { -if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 )) +if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,70 )) +return mtl_xcs_offsets; +else if (GRAPHICS_VER_FULL (engine->i915) >=IP_VER (12 ,55 ))return dg2_xcs_offsets;else if (GRAPHICS_VER (engine->i915) >=12 )return gen12_xcs_offsets;Signature · 1 line
2.34.1
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
PATCH v4 5/11 drm/i915/mtl: Add gmbus and gpio support
In reply to Radhakrishna SripadaAdd tables to map the GMBUS pin pairs to GPIO registers and port to DDC. From spec we have registers GPIO_CTL[1-5] mapped to native display phys and GPIO_CTL[9-12] are mapped to TC ports.
v2:
- Drop unused GPIO pins(MattR)
BSpec: 49306
Cc: Matt Roper <[email protected]>
Original Author: Brian J Lovin
--- drivers/gpu/drm/i915/display/intel_gmbus.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/intel_gmbus.h | 1 + 2 files changed, 16 insertions(+)
drivers/gpu/drm/i915/display/intel_gmbus.c +15 -0
@@ -117,6 +117,18 @@ static const struct gmbus_pin gmbus_pins_dg2[] = { [GMBUS_PIN_9_TC1_ICP] = { "tc1", GPIOJ }, }; +static const struct gmbus_pin gmbus_pins_mtp[] = { + [GMBUS_PIN_1_BXT ] = {"dpa" ,GPIOB }, + [GMBUS_PIN_2_BXT ] = {"dpb" ,GPIOC }, + [GMBUS_PIN_3_BXT ] = {"dpc" ,GPIOD }, + [GMBUS_PIN_4_CNP ] = {"dpd" ,GPIOE }, + [GMBUS_PIN_5_MTP ] = {"dpe" ,GPIOF }, + [GMBUS_PIN_9_TC1_ICP ] = {"tc1" ,GPIOJ }, + [GMBUS_PIN_10_TC2_ICP ] = {"tc2" ,GPIOK }, + [GMBUS_PIN_11_TC3_ICP ] = {"tc3" ,GPIOL }, + [GMBUS_PIN_12_TC4_ICP ] = {"tc4" ,GPIOM }, +}; +static const struct gmbus_pin *get_gmbus_pin (struct drm_i915_private *i915,unsigned int pin) {
@@ -129,6 +141,9 @@ static const struct gmbus_pin *get_gmbus_pin(struct drm_i915_private *i915, }else if (INTEL_PCH_TYPE (i915) >=PCH_DG1 ) { pins = gmbus_pins_dg1; size =ARRAY_SIZE (gmbus_pins_dg1); + }else if (INTEL_PCH_TYPE (i915) >=PCH_MTP ) { + pins = gmbus_pins_mtp; + size =ARRAY_SIZE (gmbus_pins_mtp); }else if (INTEL_PCH_TYPE (i915) >=PCH_ICP ) { pins = gmbus_pins_icp; size =ARRAY_SIZE (gmbus_pins_icp);
drivers/gpu/drm/i915/display/intel_gmbus.h +1 -0
@@ -24,6 +24,7 @@ struct i2c_adapter;#define GMBUS_PIN_2_BXT 2#define GMBUS_PIN_3_BXT 3#define GMBUS_PIN_4_CNP 4 +#define GMBUS_PIN_5_MTP 5#define GMBUS_PIN_9_TC1_ICP 9#define GMBUS_PIN_10_TC2_ICP 10#define GMBUS_PIN_11_TC3_ICP 11
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v4 05/11] drm/i915/mtl: Add gmbus and gpio support
Quoted 9 lines · Radhakrishna Sripada
Add tables to map the GMBUS pin pairs to GPIO registers and port to DDC. From spec we have registers GPIO_CTL[1-5] mapped to native display phys and GPIO_CTL[9-12] are mapped to TC ports.
v2:
- Drop unused GPIO pins(MattR)BSpec: 49306
Quoted 7 lines
Cc: Matt Roper <[email protected]>
Original Author: Brian J LovinSigned-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/display/intel_gmbus.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/intel_gmbus.h | 1 + 2 files changed, 16 insertions(+)
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_gmbus.c +0
-0@@ -117,6 +117,18 @@ static const struct gmbus_pin gmbus_pins_dg2[] = { [GMBUS_PIN_9_TC1_ICP] = { "tc1", GPIOJ }, };
Re: [Intel-gfx] [PATCH v4 05/11] drm/i915/mtl: Add gmbus and gpio support
In reply to Radhakrishna SripadaQuoted 4 lines · Radhakrishna Sripada
Add tables to map the GMBUS pin pairs to GPIO registers and port to DDC. From spec we have registers GPIO_CTL[1-5] mapped to native display phys and GPIO_CTL[9-12] are mapped to TC ports.
Quoted 8 lines
v2:
- Drop unused GPIO pins(MattR)BSpec: 49306
Cc: Matt Roper <[email protected]>
Original Author: Brian J LovinSigned-off-by Radhakrishna Sripada <[email protected]>
Quoted 53 lines
--- drivers/gpu/drm/i915/display/intel_gmbus.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/intel_gmbus.h | 1 + 2 files changed, 16 insertions(+)drivers/gpu/drm/i915/display/intel_gmbus.c +15
-0@@ -117,6 +117,18 @@ static const struct gmbus_pin gmbus_pins_dg2[] = { [GMBUS_PIN_9_TC1_ICP] = { "tc1", GPIOJ }, }; +static const struct gmbus_pin gmbus_pins_mtp[] = { + [GMBUS_PIN_1_BXT ] = {"dpa" ,GPIOB }, + [GMBUS_PIN_2_BXT ] = {"dpb" ,GPIOC }, + [GMBUS_PIN_3_BXT ] = {"dpc" ,GPIOD }, + [GMBUS_PIN_4_CNP ] = {"dpd" ,GPIOE }, + [GMBUS_PIN_5_MTP ] = {"dpe" ,GPIOF }, + [GMBUS_PIN_9_TC1_ICP ] = {"tc1" ,GPIOJ }, + [GMBUS_PIN_10_TC2_ICP ] = {"tc2" ,GPIOK }, + [GMBUS_PIN_11_TC3_ICP ] = {"tc3" ,GPIOL }, + [GMBUS_PIN_12_TC4_ICP ] = {"tc4" ,GPIOM }, +}; +static const struct gmbus_pin *get_gmbus_pin (struct drm_i915_private *i915,unsigned int pin) {@@ -129,6 +141,9 @@ static const struct gmbus_pin *get_gmbus_pin(struct drm_i915_private *i915, }else if (INTEL_PCH_TYPE (i915) >=PCH_DG1 ) { pins = gmbus_pins_dg1; size =ARRAY_SIZE (gmbus_pins_dg1); + }else if (INTEL_PCH_TYPE (i915) >=PCH_MTP ) { + pins = gmbus_pins_mtp; + size =ARRAY_SIZE (gmbus_pins_mtp); }else if (INTEL_PCH_TYPE (i915) >=PCH_ICP ) { pins = gmbus_pins_icp; size =ARRAY_SIZE (gmbus_pins_icp);drivers/gpu/drm/i915/display/intel_gmbus.h +1
-0@@ -24,6 +24,7 @@ struct i2c_adapter;#define GMBUS_PIN_2_BXT 2#define GMBUS_PIN_3_BXT 3#define GMBUS_PIN_4_CNP 4 +#define GMBUS_PIN_5_MTP 5#define GMBUS_PIN_9_TC1_ICP 9#define GMBUS_PIN_10_TC2_ICP 10#define GMBUS_PIN_11_TC3_ICP 11Signature · 1 line
2.34.1
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
PATCH v4 6/11 drm/i915/mtl: Add display power wells
In reply to Radhakrishna SripadaFrom: Imre Deak <[email protected]>
Add support for display power wells on MTL. The differences from XE_LPD:
- The AUX HW block is moved to the PICA block, where the registers are on an always-on power well and the functionality needs to be powered on/off via the AUX_CH_CTL register: [1], [2]
- The DDI IO power on/off programming sequence is moved to the PHY PLL enable/disable sequence. [3], [4], [5]
Bspec: [1] 49233, [2] 65247, [3] 64568, [4] 65451, [5] 65450
v2:
- Update the comment in aux power well enable
- Reuse the noop sync fn for aux sync.
- Use REG_BIT for new register bit definitions
--- .../i915/display/intel_display_power_map.c | 115 +++++++++++++++++- .../i915/display/intel_display_power_well.c | 44 +++++++ .../i915/display/intel_display_power_well.h | 4 + drivers/gpu/drm/i915/display/intel_dp_aux.c | 8 ++ drivers/gpu/drm/i915/i915_reg.h | 21 ++++ 5 files changed, 191 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +114 -1
@@ -1350,6 +1350,117 @@ static const struct i915_power_well_desc_list xelpd_power_wells[] = { I915_PW_DESCRIPTORS(xelpd_power_wells_main), }; +/* +* MTL is based on XELPD power domains with the exception of power gating for: +* - DDI_IO (moved to PLL logic) +* - AUX and AUX_IO functionality and register access for USBC1-4 (PICA always-on) +*/ +#define XELPDP_PW_2_POWER_DOMAINS \ + XELPD_PW_B_POWER_DOMAINS, \ + XELPD_PW_C_POWER_DOMAINS, \ + XELPD_PW_D_POWER_DOMAINS, \ + POWER_DOMAIN_AUDIO_PLAYBACK, \ + POWER_DOMAIN_VGA, \ + POWER_DOMAIN_PORT_DDI_LANES_TC1, \ + POWER_DOMAIN_PORT_DDI_LANES_TC2, \ + POWER_DOMAIN_PORT_DDI_LANES_TC3, \ + POWER_DOMAIN_PORT_DDI_LANES_TC4 + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_pw_2, +XELPDP_PW_2_POWER_DOMAINS , +POWER_DOMAIN_INIT ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_dc_off, +XELPDP_PW_2_POWER_DOMAINS , +POWER_DOMAIN_AUDIO_MMIO , +POWER_DOMAIN_MODESET , +POWER_DOMAIN_AUX_A , +POWER_DOMAIN_AUX_B , +POWER_DOMAIN_INIT ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc1, +POWER_DOMAIN_AUX_USBC1 , +POWER_DOMAIN_AUX_TBT1 ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc2, +POWER_DOMAIN_AUX_USBC2 , +POWER_DOMAIN_AUX_TBT2 ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc3, +POWER_DOMAIN_AUX_USBC3 , +POWER_DOMAIN_AUX_TBT3 ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc4, +POWER_DOMAIN_AUX_USBC4 , +POWER_DOMAIN_AUX_TBT4 ); + +static const struct i915_power_well_desc xelpdp_power_wells_main[] = { + { + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &xelpdp_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), + .ops = &gen9_dc_off_power_well_ops, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_2" , &xelpdp_pwdoms_pw_2, + .hsw.idx = ICL_PW_CTL_IDX_PW_2, + .id = SKL_DISP_PW_2), + ), + .ops = &hsw_power_well_ops, + .has_vga = true, + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_A" , &xelpd_pwdoms_pw_a, + .hsw.idx = XELPD_PW_CTL_IDX_PW_A), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_A ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_B" , &xelpd_pwdoms_pw_b, + .hsw.idx = XELPD_PW_CTL_IDX_PW_B), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_B ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_C" , &xelpd_pwdoms_pw_c, + .hsw.idx = XELPD_PW_CTL_IDX_PW_C), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_C ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_D" , &xelpd_pwdoms_pw_d, + .hsw.idx = XELPD_PW_CTL_IDX_PW_D), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_D ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_A", &icl_pwdoms_aux_a, .xelpdp.aux_ch = AUX_CH_A), + I915_PW("AUX_B", &icl_pwdoms_aux_b, .xelpdp.aux_ch = AUX_CH_B), + I915_PW("AUX_TC1", &xelpdp_pwdoms_aux_tc1, .xelpdp.aux_ch = AUX_CH_USBC1), + I915_PW("AUX_TC2", &xelpdp_pwdoms_aux_tc2, .xelpdp.aux_ch = AUX_CH_USBC2), + I915_PW("AUX_TC3", &xelpdp_pwdoms_aux_tc3, .xelpdp.aux_ch = AUX_CH_USBC3), + I915_PW("AUX_TC4", &xelpdp_pwdoms_aux_tc4, .xelpdp.aux_ch = AUX_CH_USBC4), + ), + .ops = &xelpdp_aux_power_well_ops, + }, +}; + +static const struct i915_power_well_desc_list xelpdp_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (xelpdp_power_wells_main), +}; +static void init_power_well_domains (const struct i915_power_well_instance *inst,struct i915_power_well *power_well) {
@@ -1457,7 +1568,9 @@ int intel_display_power_map_init(struct i915_power_domains *power_domains)return 0 ; } -if (DISPLAY_VER (i915) >=13 ) +if (DISPLAY_VER (i915) >=14 ) +return set_power_wells (power_domains, xelpdp_power_wells); +else if (DISPLAY_VER (i915) >=13 )return set_power_wells (power_domains, xelpd_power_wells);else if (IS_DG1 (i915))return set_power_wells (power_domains, dg1_power_wells);
drivers/gpu/drm/i915/display/intel_display_power_well.c +44 -0
53 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power_well.h +4 -0
@@ -80,6 +80,9 @@ struct i915_power_well_instance {*/ u8 idx; } hsw; +struct { +u8 aux_ch; + } xelpdp; }; };
@@ -169,5 +172,6 @@ extern const struct i915_power_well_ops vlv_dpio_power_well_ops;extern const struct i915_power_well_ops icl_aux_power_well_ops;extern const struct i915_power_well_ops icl_ddi_power_well_ops;extern const struct i915_power_well_ops tgl_tc_cold_off_ops; +extern const struct i915_power_well_ops xelpdp_aux_power_well_ops;#endif
drivers/gpu/drm/i915/display/intel_dp_aux.c +8 -0
@@ -150,6 +150,7 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp, u32 unused) {struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp); +struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev);u32 ret;/*
@@ -170,6 +171,13 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp,if (intel_tc_port_in_tbt_alt_mode (dig_port)) ret |=DP_AUX_CH_CTL_TBT_IO ; +/* +* Power request bit is already set during aux power well enable. +* Preserve the bit across aux transactions. +*/ +if (DISPLAY_VER (i915) >=14 ) + ret |=XELPDP_DP_AUX_CH_CTL_POWER_REQUEST ; +return ret; }
drivers/gpu/drm/i915/i915_reg.h +21 -0
@@ -3451,6 +3451,25 @@#define DP_AUX_CH_CTL (aux_ch) _MMIO_PORT(aux_ch, _DPA_AUX_CH_CTL, _DPB_AUX_CH_CTL)#define DP_AUX_CH_DATA (aux_ch, i) _MMIO(_PORT(aux_ch, _DPA_AUX_CH_DATA1, _DPB_AUX_CH_DATA1) + (i) * 4)/* 5 registers */ +#define _XELPDP_USBC1_AUX_CH_CTL 0x16F210 +#define _XELPDP_USBC2_AUX_CH_CTL 0x16F410 +#define _XELPDP_USBC3_AUX_CH_CTL 0x16F610 +#define _XELPDP_USBC4_AUX_CH_CTL 0x16F810 + +#define _XELPDP_USBC1_AUX_CH_DATA1 0x16F214 +#define _XELPDP_USBC2_AUX_CH_DATA1 0x16F414 +#define _XELPDP_USBC3_AUX_CH_DATA1 0x16F614 +#define _XELPDP_USBC4_AUX_CH_DATA1 0x16F814 + +#define XELPDP_DP_AUX_CH_CTL(aux_ch) _MMIO(_PICK(aux_ch, \ + _DPA_AUX_CH_CTL, \ + _DPB_AUX_CH_CTL, \ + 0, /* port/aux_ch C is non-existent */ \ + _XELPDP_USBC1_AUX_CH_CTL, \ + _XELPDP_USBC2_AUX_CH_CTL, \ + _XELPDP_USBC3_AUX_CH_CTL, \ + _XELPDP_USBC4_AUX_CH_CTL)) +#define DP_AUX_CH_CTL_SEND_BUSY (1 << 31)#define DP_AUX_CH_CTL_DONE (1 << 30)#define DP_AUX_CH_CTL_INTERRUPT (1 << 29)
@@ -3463,6 +3482,8 @@#define DP_AUX_CH_CTL_RECEIVE_ERROR (1 << 25)#define DP_AUX_CH_CTL_MESSAGE_SIZE_MASK (0x1f << 20)#define DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT 20 +#define XELPDP_DP_AUX_CH_CTL_POWER_REQUEST REG_BIT(19) +#define XELPDP_DP_AUX_CH_CTL_POWER_STATUS REG_BIT(18)#define DP_AUX_CH_CTL_PRECHARGE_2US_MASK (0xf << 16)#define DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT 16#define DP_AUX_CH_CTL_AUX_AKSV_SELECT (1 << 15)
Signature · 1 line
2.34.1
Re: [PATCH v4 06/11] drm/i915/mtl: Add display power wells
Quoted 11 lines · Radhakrishna Sripada
From: Imre Deak <[email protected]>
Add support for display power wells on MTL. The differences from
XE_LPD:
- The AUX HW block is moved to the PICA block, where the registers are on an always-on power well and the functionality needs to be powered on/off via theAUX_CH_CTLregister: [1], [2]
- The DDI IO power on/off programming sequence is moved to the PHY PLL enable/disable sequence. [3], [4], [5]Bspec: [1] 49233, [2] 65247, [3] 64568, [4] 65451, [5] 65450
Quoted 7 lines
v2:
- Update the comment in aux power well enable
- Reuse the noop sync fn for aux sync.
- UseREG_BITfor new register bit definitionsSigned-off-by Imre Deak <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>
Quoted 289 lines
--- .../i915/display/intel_display_power_map.c | 115 +++++++++++++++++- .../i915/display/intel_display_power_well.c | 44 +++++++ .../i915/display/intel_display_power_well.h | 4 + drivers/gpu/drm/i915/display/intel_dp_aux.c | 8 ++ drivers/gpu/drm/i915/i915_reg.h | 21 ++++ 5 files changed, 191 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_display_power_map.c +114
-1@@ -1350,6 +1350,117 @@ static const struct i915_power_well_desc_list xelpd_power_wells[] = { I915_PW_DESCRIPTORS(xelpd_power_wells_main), }; +/* +* MTL is based on XELPD power domains with the exception of power gating for: +* - DDI_IO (moved to PLL logic) +* - AUX and AUX_IO functionality and register access for USBC1-4 (PICA always-on) +*/ +#define XELPDP_PW_2_POWER_DOMAINS \ + XELPD_PW_B_POWER_DOMAINS, \ + XELPD_PW_C_POWER_DOMAINS, \ + XELPD_PW_D_POWER_DOMAINS, \ + POWER_DOMAIN_AUDIO_PLAYBACK, \ + POWER_DOMAIN_VGA, \ + POWER_DOMAIN_PORT_DDI_LANES_TC1, \ + POWER_DOMAIN_PORT_DDI_LANES_TC2, \ + POWER_DOMAIN_PORT_DDI_LANES_TC3, \ + POWER_DOMAIN_PORT_DDI_LANES_TC4 + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_pw_2, +XELPDP_PW_2_POWER_DOMAINS , +POWER_DOMAIN_INIT ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_dc_off, +XELPDP_PW_2_POWER_DOMAINS , +POWER_DOMAIN_AUDIO_MMIO , +POWER_DOMAIN_MODESET , +POWER_DOMAIN_AUX_A , +POWER_DOMAIN_AUX_B , +POWER_DOMAIN_INIT ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc1, +POWER_DOMAIN_AUX_USBC1 , +POWER_DOMAIN_AUX_TBT1 ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc2, +POWER_DOMAIN_AUX_USBC2 , +POWER_DOMAIN_AUX_TBT2 ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc3, +POWER_DOMAIN_AUX_USBC3 , +POWER_DOMAIN_AUX_TBT3 ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc4, +POWER_DOMAIN_AUX_USBC4 , +POWER_DOMAIN_AUX_TBT4 ); + +static const struct i915_power_well_desc xelpdp_power_wells_main[] = { + { + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &xelpdp_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), + .ops = &gen9_dc_off_power_well_ops, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_2" , &xelpdp_pwdoms_pw_2, + .hsw.idx = ICL_PW_CTL_IDX_PW_2, + .id = SKL_DISP_PW_2), + ), + .ops = &hsw_power_well_ops, + .has_vga = true, + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_A" , &xelpd_pwdoms_pw_a, + .hsw.idx = XELPD_PW_CTL_IDX_PW_A), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_A ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_B" , &xelpd_pwdoms_pw_b, + .hsw.idx = XELPD_PW_CTL_IDX_PW_B), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_B ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_C" , &xelpd_pwdoms_pw_c, + .hsw.idx = XELPD_PW_CTL_IDX_PW_C), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_C ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_D" , &xelpd_pwdoms_pw_d, + .hsw.idx = XELPD_PW_CTL_IDX_PW_D), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_D ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_A", &icl_pwdoms_aux_a, .xelpdp.aux_ch = AUX_CH_A), + I915_PW("AUX_B", &icl_pwdoms_aux_b, .xelpdp.aux_ch = AUX_CH_B), + I915_PW("AUX_TC1", &xelpdp_pwdoms_aux_tc1, .xelpdp.aux_ch = AUX_CH_USBC1), + I915_PW("AUX_TC2", &xelpdp_pwdoms_aux_tc2, .xelpdp.aux_ch = AUX_CH_USBC2), + I915_PW("AUX_TC3", &xelpdp_pwdoms_aux_tc3, .xelpdp.aux_ch = AUX_CH_USBC3), + I915_PW("AUX_TC4", &xelpdp_pwdoms_aux_tc4, .xelpdp.aux_ch = AUX_CH_USBC4), + ), + .ops = &xelpdp_aux_power_well_ops, + }, +}; + +static const struct i915_power_well_desc_list xelpdp_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (xelpdp_power_wells_main), +}; +static void init_power_well_domains (const struct i915_power_well_instance *inst,struct i915_power_well *power_well) {@@ -1457,7 +1568,9 @@ int intel_display_power_map_init(struct i915_power_domains *power_domains)return 0 ; } -if (DISPLAY_VER (i915) >=13 ) +if (DISPLAY_VER (i915) >=14 ) +return set_power_wells (power_domains, xelpdp_power_wells); +else if (DISPLAY_VER (i915) >=13 )return set_power_wells (power_domains, xelpd_power_wells);else if (IS_DG1 (i915))return set_power_wells (power_domains, dg1_power_wells);drivers/gpu/drm/i915/display/intel_display_power_well.c +44
-0@@ -1798,6 +1798,43 @@ tgl_tc_cold_off_power_well_is_enabled(struct drm_i915_private *dev_priv,return intel_power_well_refcount (power_well); } +static void xelpdp_aux_power_well_enable (struct drm_i915_private *dev_priv, +struct i915_power_well *power_well) +{ +enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch; + +intel_de_rmw (dev_priv,XELPDP_DP_AUX_CH_CTL (aux_ch), +XELPDP_DP_AUX_CH_CTL_POWER_REQUEST , +XELPDP_DP_AUX_CH_CTL_POWER_REQUEST ); + +/* +* The power status flag cannot be used to determine whether aux +* power wells have finished powering up. Instead we're +* expected to just wait a fixed 600us after raising the request +* bit. +*/ +usleep_range (600 ,1200 ); +} + +static void xelpdp_aux_power_well_disable (struct drm_i915_private *dev_priv, +struct i915_power_well *power_well) +{ +enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch; + +intel_de_rmw (dev_priv,XELPDP_DP_AUX_CH_CTL (aux_ch), +XELPDP_DP_AUX_CH_CTL_POWER_REQUEST , +0 ); +usleep_range (10 ,30 ); +} + +static bool xelpdp_aux_power_well_enabled (struct drm_i915_private *dev_priv, +struct i915_power_well *power_well) +{ +enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch; + +return intel_de_read (dev_priv,XELPDP_DP_AUX_CH_CTL (aux_ch)) & +XELPDP_DP_AUX_CH_CTL_POWER_STATUS ; +}const struct i915_power_well_ops i9xx_always_on_power_well_ops = { .sync_hw = i9xx_power_well_sync_hw_noop,@@ -1911,3 +1948,10 @@ const struct i915_power_well_ops tgl_tc_cold_off_ops = { .disable = tgl_tc_cold_off_power_well_disable, .is_enabled = tgl_tc_cold_off_power_well_is_enabled, }; + +const struct i915_power_well_ops xelpdp_aux_power_well_ops = { + .sync_hw = i9xx_power_well_sync_hw_noop, + .enable = xelpdp_aux_power_well_enable, + .disable = xelpdp_aux_power_well_disable, + .is_enabled = xelpdp_aux_power_well_enabled, +};drivers/gpu/drm/i915/display/intel_display_power_well.h +4
-0@@ -80,6 +80,9 @@ struct i915_power_well_instance {*/ u8 idx; } hsw; +struct { +u8 aux_ch; + } xelpdp; }; };@@ -169,5 +172,6 @@ extern const struct i915_power_well_ops vlv_dpio_power_well_ops;extern const struct i915_power_well_ops icl_aux_power_well_ops;extern const struct i915_power_well_ops icl_ddi_power_well_ops;extern const struct i915_power_well_ops tgl_tc_cold_off_ops; +extern const struct i915_power_well_ops xelpdp_aux_power_well_ops;#endif drivers/gpu/drm/i915/display/intel_dp_aux.c +8
-0@@ -150,6 +150,7 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp, u32 unused) {struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp); +struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev);u32 ret;/* @@ -170,6 +171,13 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp,if (intel_tc_port_in_tbt_alt_mode (dig_port)) ret |=DP_AUX_CH_CTL_TBT_IO ; +/* +* Power request bit is already set during aux power well enable. +* Preserve the bit across aux transactions. +*/ +if (DISPLAY_VER (i915) >=14 ) + ret |=XELPDP_DP_AUX_CH_CTL_POWER_REQUEST ; +return ret; }drivers/gpu/drm/i915/i915_reg.h +21
-0@@ -3451,6 +3451,25 @@#define DP_AUX_CH_CTL (aux_ch) _MMIO_PORT(aux_ch, _DPA_AUX_CH_CTL, _DPB_AUX_CH_CTL)#define DP_AUX_CH_DATA (aux_ch, i) _MMIO(_PORT(aux_ch, _DPA_AUX_CH_DATA1, _DPB_AUX_CH_DATA1) + (i) * 4)/* 5 registers */ +#define _XELPDP_USBC1_AUX_CH_CTL 0x16F210 +#define _XELPDP_USBC2_AUX_CH_CTL 0x16F410 +#define _XELPDP_USBC3_AUX_CH_CTL 0x16F610 +#define _XELPDP_USBC4_AUX_CH_CTL 0x16F810 + +#define _XELPDP_USBC1_AUX_CH_DATA1 0x16F214 +#define _XELPDP_USBC2_AUX_CH_DATA1 0x16F414 +#define _XELPDP_USBC3_AUX_CH_DATA1 0x16F614 +#define _XELPDP_USBC4_AUX_CH_DATA1 0x16F814 + +#define XELPDP_DP_AUX_CH_CTL(aux_ch) _MMIO(_PICK(aux_ch, \ + _DPA_AUX_CH_CTL, \ + _DPB_AUX_CH_CTL, \ + 0, /* port/aux_ch C is non-existent */ \ + _XELPDP_USBC1_AUX_CH_CTL, \ + _XELPDP_USBC2_AUX_CH_CTL, \ + _XELPDP_USBC3_AUX_CH_CTL, \ + _XELPDP_USBC4_AUX_CH_CTL)) +#define DP_AUX_CH_CTL_SEND_BUSY (1 << 31)#define DP_AUX_CH_CTL_DONE (1 << 30)#define DP_AUX_CH_CTL_INTERRUPT (1 << 29)@@ -3463,6 +3482,8 @@#define DP_AUX_CH_CTL_RECEIVE_ERROR (1 << 25)#define DP_AUX_CH_CTL_MESSAGE_SIZE_MASK (0x1f << 20)#define DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT 20 +#define XELPDP_DP_AUX_CH_CTL_POWER_REQUEST REG_BIT(19) +#define XELPDP_DP_AUX_CH_CTL_POWER_STATUS REG_BIT(18)#define DP_AUX_CH_CTL_PRECHARGE_2US_MASK (0xf << 16)#define DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT 16#define DP_AUX_CH_CTL_AUX_AKSV_SELECT (1 << 15)Signature · 1 line
2.34.1
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
Re: [PATCH v4 06/11] drm/i915/mtl: Add display power wells
Quoted 17 lines · Matt Roper
Quoted 16 lines · Radhakrishna Sripada
From: Imre Deak <[email protected]>
Add support for display power wells on MTL. The differences from
XE_LPD:
- The AUX HW block is moved to the PICA block, where the registers are on an always-on power well and the functionality needs to be powered on/off via theAUX_CH_CTLregister: [1], [2]
- The DDI IO power on/off programming sequence is moved to the PHY PLL enable/disable sequence. [3], [4], [5]Bspec: [1] 49233, [2] 65247, [3] 64568, [4] 65451, [5] 65450
v2:
- Update the comment in aux power well enable
- Reuse the noop sync fn for aux sync.
- UseREG_BITfor new register bit definitions
Quoted 4 lines
Quoted 2 lines
Signed-off-by Imre Deak <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>Reviewed-by Matt Roper <[email protected]>
Oops, one very minor comment down at the bottom.
Quoted 256 lines
Quoted 256 lines
--- .../i915/display/intel_display_power_map.c | 115 +++++++++++++++++- .../i915/display/intel_display_power_well.c | 44 +++++++ .../i915/display/intel_display_power_well.h | 4 + drivers/gpu/drm/i915/display/intel_dp_aux.c | 8 ++ drivers/gpu/drm/i915/i915_reg.h | 21 ++++ 5 files changed, 191 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_display_power_map.c +114
-1@@ -1350,6 +1350,117 @@ static const struct i915_power_well_desc_list xelpd_power_wells[] = { I915_PW_DESCRIPTORS(xelpd_power_wells_main), }; +/* +* MTL is based on XELPD power domains with the exception of power gating for: +* - DDI_IO (moved to PLL logic) +* - AUX and AUX_IO functionality and register access for USBC1-4 (PICA always-on) +*/ +#define XELPDP_PW_2_POWER_DOMAINS \ + XELPD_PW_B_POWER_DOMAINS, \ + XELPD_PW_C_POWER_DOMAINS, \ + XELPD_PW_D_POWER_DOMAINS, \ + POWER_DOMAIN_AUDIO_PLAYBACK, \ + POWER_DOMAIN_VGA, \ + POWER_DOMAIN_PORT_DDI_LANES_TC1, \ + POWER_DOMAIN_PORT_DDI_LANES_TC2, \ + POWER_DOMAIN_PORT_DDI_LANES_TC3, \ + POWER_DOMAIN_PORT_DDI_LANES_TC4 + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_pw_2, +XELPDP_PW_2_POWER_DOMAINS , +POWER_DOMAIN_INIT ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_dc_off, +XELPDP_PW_2_POWER_DOMAINS , +POWER_DOMAIN_AUDIO_MMIO , +POWER_DOMAIN_MODESET , +POWER_DOMAIN_AUX_A , +POWER_DOMAIN_AUX_B , +POWER_DOMAIN_INIT ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc1, +POWER_DOMAIN_AUX_USBC1 , +POWER_DOMAIN_AUX_TBT1 ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc2, +POWER_DOMAIN_AUX_USBC2 , +POWER_DOMAIN_AUX_TBT2 ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc3, +POWER_DOMAIN_AUX_USBC3 , +POWER_DOMAIN_AUX_TBT3 ); + +I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc4, +POWER_DOMAIN_AUX_USBC4 , +POWER_DOMAIN_AUX_TBT4 ); + +static const struct i915_power_well_desc xelpdp_power_wells_main[] = { + { + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &xelpdp_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), + .ops = &gen9_dc_off_power_well_ops, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_2" , &xelpdp_pwdoms_pw_2, + .hsw.idx = ICL_PW_CTL_IDX_PW_2, + .id = SKL_DISP_PW_2), + ), + .ops = &hsw_power_well_ops, + .has_vga = true, + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_A" , &xelpd_pwdoms_pw_a, + .hsw.idx = XELPD_PW_CTL_IDX_PW_A), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_A ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_B" , &xelpd_pwdoms_pw_b, + .hsw.idx = XELPD_PW_CTL_IDX_PW_B), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_B ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_C" , &xelpd_pwdoms_pw_c, + .hsw.idx = XELPD_PW_CTL_IDX_PW_C), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_C ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_D" , &xelpd_pwdoms_pw_d, + .hsw.idx = XELPD_PW_CTL_IDX_PW_D), + ), + .ops = &hsw_power_well_ops, + .irq_pipe_mask =BIT (PIPE_D ), + .has_fuses = true, + }, { + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_A", &icl_pwdoms_aux_a, .xelpdp.aux_ch = AUX_CH_A), + I915_PW("AUX_B", &icl_pwdoms_aux_b, .xelpdp.aux_ch = AUX_CH_B), + I915_PW("AUX_TC1", &xelpdp_pwdoms_aux_tc1, .xelpdp.aux_ch = AUX_CH_USBC1), + I915_PW("AUX_TC2", &xelpdp_pwdoms_aux_tc2, .xelpdp.aux_ch = AUX_CH_USBC2), + I915_PW("AUX_TC3", &xelpdp_pwdoms_aux_tc3, .xelpdp.aux_ch = AUX_CH_USBC3), + I915_PW("AUX_TC4", &xelpdp_pwdoms_aux_tc4, .xelpdp.aux_ch = AUX_CH_USBC4), + ), + .ops = &xelpdp_aux_power_well_ops, + }, +}; + +static const struct i915_power_well_desc_list xelpdp_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (xelpdp_power_wells_main), +}; +static void init_power_well_domains (const struct i915_power_well_instance *inst,struct i915_power_well *power_well) {@@ -1457,7 +1568,9 @@ int intel_display_power_map_init(struct i915_power_domains *power_domains)return 0 ; } -if (DISPLAY_VER (i915) >=13 ) +if (DISPLAY_VER (i915) >=14 ) +return set_power_wells (power_domains, xelpdp_power_wells); +else if (DISPLAY_VER (i915) >=13 )return set_power_wells (power_domains, xelpd_power_wells);else if (IS_DG1 (i915))return set_power_wells (power_domains, dg1_power_wells);drivers/gpu/drm/i915/display/intel_display_power_well.c +44
-0@@ -1798,6 +1798,43 @@ tgl_tc_cold_off_power_well_is_enabled(struct drm_i915_private *dev_priv,return intel_power_well_refcount (power_well); } +static void xelpdp_aux_power_well_enable (struct drm_i915_private *dev_priv, +struct i915_power_well *power_well) +{ +enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch; + +intel_de_rmw (dev_priv,XELPDP_DP_AUX_CH_CTL (aux_ch), +XELPDP_DP_AUX_CH_CTL_POWER_REQUEST , +XELPDP_DP_AUX_CH_CTL_POWER_REQUEST ); + +/* +* The power status flag cannot be used to determine whether aux +* power wells have finished powering up. Instead we're +* expected to just wait a fixed 600us after raising the request +* bit. +*/ +usleep_range (600 ,1200 ); +} + +static void xelpdp_aux_power_well_disable (struct drm_i915_private *dev_priv, +struct i915_power_well *power_well) +{ +enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch; + +intel_de_rmw (dev_priv,XELPDP_DP_AUX_CH_CTL (aux_ch), +XELPDP_DP_AUX_CH_CTL_POWER_REQUEST , +0 ); +usleep_range (10 ,30 ); +} + +static bool xelpdp_aux_power_well_enabled (struct drm_i915_private *dev_priv, +struct i915_power_well *power_well) +{ +enum aux_ch aux_ch =i915_power_well_instance (power_well)->xelpdp.aux_ch; + +return intel_de_read (dev_priv,XELPDP_DP_AUX_CH_CTL (aux_ch)) & +XELPDP_DP_AUX_CH_CTL_POWER_STATUS ; +}const struct i915_power_well_ops i9xx_always_on_power_well_ops = { .sync_hw = i9xx_power_well_sync_hw_noop,@@ -1911,3 +1948,10 @@ const struct i915_power_well_ops tgl_tc_cold_off_ops = { .disable = tgl_tc_cold_off_power_well_disable, .is_enabled = tgl_tc_cold_off_power_well_is_enabled, }; + +const struct i915_power_well_ops xelpdp_aux_power_well_ops = { + .sync_hw = i9xx_power_well_sync_hw_noop, + .enable = xelpdp_aux_power_well_enable, + .disable = xelpdp_aux_power_well_disable, + .is_enabled = xelpdp_aux_power_well_enabled, +};drivers/gpu/drm/i915/display/intel_display_power_well.h +4
-0@@ -80,6 +80,9 @@ struct i915_power_well_instance {*/ u8 idx; } hsw; +struct { +u8 aux_ch; + } xelpdp; }; };@@ -169,5 +172,6 @@ extern const struct i915_power_well_ops vlv_dpio_power_well_ops;extern const struct i915_power_well_ops icl_aux_power_well_ops;extern const struct i915_power_well_ops icl_ddi_power_well_ops;extern const struct i915_power_well_ops tgl_tc_cold_off_ops; +extern const struct i915_power_well_ops xelpdp_aux_power_well_ops;#endif drivers/gpu/drm/i915/display/intel_dp_aux.c +8
-0@@ -150,6 +150,7 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp, u32 unused) {struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp); +struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev);u32 ret;/* @@ -170,6 +171,13 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp,if (intel_tc_port_in_tbt_alt_mode (dig_port)) ret |=DP_AUX_CH_CTL_TBT_IO ; +/* +* Power request bit is already set during aux power well enable. +* Preserve the bit across aux transactions. +*/ +if (DISPLAY_VER (i915) >=14 ) + ret |=XELPDP_DP_AUX_CH_CTL_POWER_REQUEST ; +return ret; }drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -3451,6 +3451,25 @@#define DP_AUX_CH_CTL (aux_ch) _MMIO_PORT(aux_ch, _DPA_AUX_CH_CTL, _DPB_AUX_CH_CTL)#define DP_AUX_CH_DATA (aux_ch, i) _MMIO(_PORT(aux_ch, _DPA_AUX_CH_DATA1, _DPB_AUX_CH_DATA1) + (i) * 4)/* 5 registers */
Quoted 9 lines
drivers/gpu/drm/i915/i915_reg.h line 3462
Quoted 9 lines
drivers/gpu/drm/i915/i915_reg.h +9
-0+#define _XELPDP_USBC1_AUX_CH_CTL 0x16F210 +#define _XELPDP_USBC2_AUX_CH_CTL 0x16F410 +#define _XELPDP_USBC3_AUX_CH_CTL 0x16F610 +#define _XELPDP_USBC4_AUX_CH_CTL 0x16F810 + +#define _XELPDP_USBC1_AUX_CH_DATA1 0x16F214 +#define _XELPDP_USBC2_AUX_CH_DATA1 0x16F414 +#define _XELPDP_USBC3_AUX_CH_DATA1 0x16F614 +#define _XELPDP_USBC4_AUX_CH_DATA1 0x16F814
These data register definitions aren't used until the next patch, so you should probably move them there.
Aside from that, the r-b still stands.
Matt
Quoted 31 lines
Quoted 25 lines
drivers/gpu/drm/i915/i915_reg.h +12
-0+ +#define XELPDP_DP_AUX_CH_CTL(aux_ch) _MMIO(_PICK(aux_ch, \ + _DPA_AUX_CH_CTL, \ + _DPB_AUX_CH_CTL, \ + 0, /* port/aux_ch C is non-existent */ \ + _XELPDP_USBC1_AUX_CH_CTL, \ + _XELPDP_USBC2_AUX_CH_CTL, \ + _XELPDP_USBC3_AUX_CH_CTL, \ + _XELPDP_USBC4_AUX_CH_CTL)) +#define DP_AUX_CH_CTL_SEND_BUSY (1 << 31)#define DP_AUX_CH_CTL_DONE (1 << 30)#define DP_AUX_CH_CTL_INTERRUPT (1 << 29)@@ -3463,6 +3482,8 @@#define DP_AUX_CH_CTL_RECEIVE_ERROR (1 << 25)#define DP_AUX_CH_CTL_MESSAGE_SIZE_MASK (0x1f << 20)#define DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT 20 +#define XELPDP_DP_AUX_CH_CTL_POWER_REQUEST REG_BIT(19) +#define XELPDP_DP_AUX_CH_CTL_POWER_STATUS REG_BIT(18)#define DP_AUX_CH_CTL_PRECHARGE_2US_MASK (0xf << 16)#define DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT 16#define DP_AUX_CH_CTL_AUX_AKSV_SELECT (1 << 15)Signature · 1 line
2.34.1Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
PATCH v4 7/11 drm/i915/mtl: Add DP AUX support on TypeC ports
In reply to Radhakrishna SripadaFrom: Imre Deak <[email protected]>
On MTL TypeC ports the AUX_CH_CTL and AUX_CH_DATA addresses have changed wrt. previous platforms, adjust the code accordingly.
--- drivers/gpu/drm/i915/display/intel_dp_aux.c | 45 ++++++++++++++++++++- drivers/gpu/drm/i915/i915_reg.h | 9 +++++ 2 files changed, 53 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dp_aux.c +44 -1
@@ -637,6 +637,46 @@ static i915_reg_t tgl_aux_data_reg(struct intel_dp *intel_dp, int index) } } +static i915_reg_t xelpdp_aux_ctl_reg (struct intel_dp *intel_dp) +{ +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp); +enum aux_ch aux_ch = dig_port->aux_ch; + +switch (aux_ch) { +case AUX_CH_A : +case AUX_CH_B : +case AUX_CH_USBC1 : +case AUX_CH_USBC2 : +case AUX_CH_USBC3 : +case AUX_CH_USBC4 : +return XELPDP_DP_AUX_CH_CTL (aux_ch); +default : +MISSING_CASE (aux_ch); +return XELPDP_DP_AUX_CH_CTL (AUX_CH_A ); + } +} + +static i915_reg_t xelpdp_aux_data_reg (struct intel_dp *intel_dp,int index) +{ +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp); +enum aux_ch aux_ch = dig_port->aux_ch; + +switch (aux_ch) { +case AUX_CH_A : +case AUX_CH_B : +case AUX_CH_USBC1 : +case AUX_CH_USBC2 : +case AUX_CH_USBC3 : +case AUX_CH_USBC4 : +return XELPDP_DP_AUX_CH_DATA (aux_ch, index); +default : +MISSING_CASE (aux_ch); +return XELPDP_DP_AUX_CH_DATA (AUX_CH_A , index); + } +} +void intel_dp_aux_fini (struct intel_dp *intel_dp) {if (cpu_latency_qos_request_active (&intel_dp->pm_qos))
@@ -652,7 +692,10 @@ void intel_dp_aux_init(struct intel_dp *intel_dp)struct intel_encoder *encoder = &dig_port->base;enum aux_ch aux_ch = dig_port->aux_ch; -if (DISPLAY_VER (dev_priv) >=12 ) { +if (DISPLAY_VER (dev_priv) >=14 ) { + intel_dp->aux_ch_ctl_reg = xelpdp_aux_ctl_reg; + intel_dp->aux_ch_data_reg = xelpdp_aux_data_reg; + }else if (DISPLAY_VER (dev_priv) >=12 ) { intel_dp->aux_ch_ctl_reg = tgl_aux_ctl_reg; intel_dp->aux_ch_data_reg = tgl_aux_data_reg; }else if (DISPLAY_VER (dev_priv) >=9 ) {
drivers/gpu/drm/i915/i915_reg.h +9 -0
@@ -3470,6 +3470,15 @@ _XELPDP_USBC3_AUX_CH_CTL, \ _XELPDP_USBC4_AUX_CH_CTL)) +#define XELPDP_DP_AUX_CH_DATA(aux_ch, i) _MMIO(_PICK(aux_ch, \ + _DPA_AUX_CH_DATA1, \ + _DPB_AUX_CH_DATA1, \ + 0, /* port/aux_ch C is non-existent */ \ + _XELPDP_USBC1_AUX_CH_DATA1, \ + _XELPDP_USBC2_AUX_CH_DATA1, \ + _XELPDP_USBC3_AUX_CH_DATA1, \ + _XELPDP_USBC4_AUX_CH_DATA1) + (i) * 4) +#define DP_AUX_CH_CTL_SEND_BUSY (1 << 31)#define DP_AUX_CH_CTL_DONE (1 << 30)#define DP_AUX_CH_CTL_INTERRUPT (1 << 29)
Signature · 1 line
2.34.1
Re: [PATCH v4 07/11] drm/i915/mtl: Add DP AUX support on TypeC ports
Quoted 7 lines · Radhakrishna Sripada
From: Imre Deak <[email protected]>
On MTL TypeC ports the
AUX_CH_CTLandAUX_CH_DATAaddresses have changed wrt. previous platforms, adjust the code accordingly.Signed-off-by Imre Deak <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>
As noted on the previous patch, the _XELPDP_USBC1_AUX_CH_DATA* definitions aren't used until this patch so they should probably move into this one. Aside from that,
Quoted 91 lines
--- drivers/gpu/drm/i915/display/intel_dp_aux.c | 45 ++++++++++++++++++++- drivers/gpu/drm/i915/i915_reg.h | 9 +++++ 2 files changed, 53 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_dp_aux.c +44
-1@@ -637,6 +637,46 @@ static i915_reg_t tgl_aux_data_reg(struct intel_dp *intel_dp, int index) } } +static i915_reg_t xelpdp_aux_ctl_reg (struct intel_dp *intel_dp) +{ +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp); +enum aux_ch aux_ch = dig_port->aux_ch; + +switch (aux_ch) { +case AUX_CH_A : +case AUX_CH_B : +case AUX_CH_USBC1 : +case AUX_CH_USBC2 : +case AUX_CH_USBC3 : +case AUX_CH_USBC4 : +return XELPDP_DP_AUX_CH_CTL (aux_ch); +default : +MISSING_CASE (aux_ch); +return XELPDP_DP_AUX_CH_CTL (AUX_CH_A ); + } +} + +static i915_reg_t xelpdp_aux_data_reg (struct intel_dp *intel_dp,int index) +{ +struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp); +enum aux_ch aux_ch = dig_port->aux_ch; + +switch (aux_ch) { +case AUX_CH_A : +case AUX_CH_B : +case AUX_CH_USBC1 : +case AUX_CH_USBC2 : +case AUX_CH_USBC3 : +case AUX_CH_USBC4 : +return XELPDP_DP_AUX_CH_DATA (aux_ch, index); +default : +MISSING_CASE (aux_ch); +return XELPDP_DP_AUX_CH_DATA (AUX_CH_A , index); + } +} +void intel_dp_aux_fini (struct intel_dp *intel_dp) {if (cpu_latency_qos_request_active (&intel_dp->pm_qos))@@ -652,7 +692,10 @@ void intel_dp_aux_init(struct intel_dp *intel_dp)struct intel_encoder *encoder = &dig_port->base;enum aux_ch aux_ch = dig_port->aux_ch; -if (DISPLAY_VER (dev_priv) >=12 ) { +if (DISPLAY_VER (dev_priv) >=14 ) { + intel_dp->aux_ch_ctl_reg = xelpdp_aux_ctl_reg; + intel_dp->aux_ch_data_reg = xelpdp_aux_data_reg; + }else if (DISPLAY_VER (dev_priv) >=12 ) { intel_dp->aux_ch_ctl_reg = tgl_aux_ctl_reg; intel_dp->aux_ch_data_reg = tgl_aux_data_reg; }else if (DISPLAY_VER (dev_priv) >=9 ) {drivers/gpu/drm/i915/i915_reg.h +9
-0@@ -3470,6 +3470,15 @@ _XELPDP_USBC3_AUX_CH_CTL, \ _XELPDP_USBC4_AUX_CH_CTL)) +#define XELPDP_DP_AUX_CH_DATA(aux_ch, i) _MMIO(_PICK(aux_ch, \ + _DPA_AUX_CH_DATA1, \ + _DPB_AUX_CH_DATA1, \ + 0, /* port/aux_ch C is non-existent */ \ + _XELPDP_USBC1_AUX_CH_DATA1, \ + _XELPDP_USBC2_AUX_CH_DATA1, \ + _XELPDP_USBC3_AUX_CH_DATA1, \ + _XELPDP_USBC4_AUX_CH_DATA1) + (i) * 4) +#define DP_AUX_CH_CTL_SEND_BUSY (1 << 31)#define DP_AUX_CH_CTL_DONE (1 << 30)#define DP_AUX_CH_CTL_INTERRUPT (1 << 29)Signature · 1 line
2.34.1
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
PATCH v4 8/11 drm/i915/mtl: Obtain SAGV values from MMIO instead of GT pcode mailbox
In reply to Radhakrishna SripadaFrom Meteorlake, Latency Level, SAGV bloack time are read from LATENCY_SAGV register instead of the GT driver pcode mailbox. DDR type and QGV information are also to be read from Mem SS registers.
v2:
- Simplify MTL_MEM_SS_INFO_QGV_POINT macro(MattR)
- Nit: Rearrange the bit def's from higher to lower(MattR)
- Restore platform definition for ADL-P(MattR)
- Move back intel_qgv_point def to intel_bw.c(Jani)
Bspec: 64636, 64608
Original Author: Caz Yokoyama
--- drivers/gpu/drm/i915/display/intel_bw.c | 42 ++++++++++++++++++++++--- drivers/gpu/drm/i915/i915_reg.h | 17 ++++++++++ drivers/gpu/drm/i915/intel_dram.c | 41 +++++++++++++++++++++++- drivers/gpu/drm/i915/intel_pm.c | 8 ++++- 4 files changed, 101 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_bw.c +37 -5
@@ -137,6 +137,42 @@ int icl_pcode_restrict_qgv_points(struct drm_i915_private *dev_priv,return 0 ; } +static int mtl_read_qgv_point_info (struct drm_i915_private *dev_priv, +struct intel_qgv_point *sp,int point) +{ +u32 val, val2; +u16 dclk; + + val =intel_uncore_read (&dev_priv->uncore, +MTL_MEM_SS_INFO_QGV_POINT_LOW (point)); + val2 =intel_uncore_read (&dev_priv->uncore, +MTL_MEM_SS_INFO_QGV_POINT_HIGH (point)); + dclk =REG_FIELD_GET (MTL_DCLK_MASK , val); + sp->dclk =DIV_ROUND_UP ((16667 * dclk),1000 ); + sp->t_rp =REG_FIELD_GET (MTL_TRP_MASK , val); + sp->t_rcd =REG_FIELD_GET (MTL_TRCD_MASK , val); + + sp->t_rdpre =REG_FIELD_GET (MTL_TRDPRE_MASK , val2); + sp->t_ras =REG_FIELD_GET (MTL_TRAS_MASK , val2); + + sp->t_rc = sp->t_rp + sp->t_ras; + +return 0 ; +} + +static int +intel_read_qgv_point_info (struct drm_i915_private *dev_priv, +struct intel_qgv_point *sp, +int point) +{ +if (DISPLAY_VER (dev_priv) >=14 ) +return mtl_read_qgv_point_info (dev_priv, sp, point); +else if (IS_DG1 (dev_priv)) +return dg1_mchbar_read_qgv_point_info (dev_priv, sp, point); +else +return icl_pcode_read_qgv_point_info (dev_priv, sp, point); +} +static int icl_get_qgv_points (struct drm_i915_private *dev_priv,struct intel_qgv_info *qi,bool is_y_tile)
@@ -218,11 +254,7 @@ static int icl_get_qgv_points(struct drm_i915_private *dev_priv,for (i =0 ; i < qi->num_points; i++) {struct intel_qgv_point *sp = &qi->points[i]; -if (IS_DG1 (dev_priv)) - ret =dg1_mchbar_read_qgv_point_info (dev_priv, sp, i); -else - ret =icl_pcode_read_qgv_point_info (dev_priv, sp, i); - + ret =intel_read_qgv_point_info (dev_priv, sp, i);if (ret)return ret;
drivers/gpu/drm/i915/i915_reg.h +17 -0
@@ -8335,4 +8335,21 @@ enum skl_power_gate {#define MTL_MEDIA_GSI_BASE 0x380000 +#define MTL_LATENCY_SAGV _MMIO(0x4578c) +#define MTL_LATENCY_QCLK_SAGV REG_GENMASK(12, 0) + +#define MTL_MEM_SS_INFO_GLOBAL _MMIO(0x45700) +#define MTL_N_OF_ENABLED_QGV_POINTS_MASK REG_GENMASK(11, 8) +#define MTL_N_OF_POPULATED_CH_MASK REG_GENMASK(7, 4) +#define MTL_DDR_TYPE_MASK REG_GENMASK(3, 0) + +#define MTL_MEM_SS_INFO_QGV_POINT_LOW (point) _MMIO(0x45710 + (point) * 2) +#define MTL_TRCD_MASK REG_GENMASK(31, 24) +#define MTL_TRP_MASK REG_GENMASK(23, 16) +#define MTL_DCLK_MASK REG_GENMASK(15, 0) + +#define MTL_MEM_SS_INFO_QGV_POINT_HIGH (point) _MMIO(0x45714 + (point) * 2) +#define MTL_TRAS_MASK REG_GENMASK(16, 8) +#define MTL_TRDPRE_MASK REG_GENMASK(7, 0) +#endif /* _I915_REG_H_ */
drivers/gpu/drm/i915/intel_dram.c +40 -1
53 lines not on this page · raw message
drivers/gpu/drm/i915/intel_pm.c +7 -1
@@ -3697,7 +3697,13 @@ intel_has_sagv(struct drm_i915_private *dev_priv)static u32 intel_sagv_block_time (struct drm_i915_private *dev_priv) { -if (DISPLAY_VER (dev_priv) >=12 ) { +if (DISPLAY_VER (dev_priv) >=14 ) { +u32 val; + + val =intel_uncore_read (&dev_priv->uncore,MTL_LATENCY_SAGV ); + +return REG_FIELD_GET (MTL_LATENCY_QCLK_SAGV , val); + }else if (DISPLAY_VER (dev_priv) >=12 ) {u32 val =0 ;int ret;
Signature · 1 line
2.34.1
PATCH v4 9/11 drm/i915/mtl: Update MBUS_DBOX credits
In reply to Radhakrishna SripadaDisplay version 14 platforms have different credits values compared to ADL-P. Update the credits based on pipe usage.
v2: Simplify DBOX BW Credit definition(MattR)
Bspec: 49213
Cc: Jose Roberto de Souza <[email protected]>
Cc: Matt Roper <[email protected]> Original Author: Caz Yokoyama
--- drivers/gpu/drm/i915/i915_reg.h | 4 +++ drivers/gpu/drm/i915/intel_pm.c | 47 ++++++++++++++++++++++++++++++--- 2 files changed, 47 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +4 -0
@@ -1125,8 +1125,12 @@#define MBUS_DBOX_REGULATE_B2B_TRANSACTIONS_EN REG_BIT(16)/* tgl+ */ #define MBUS_DBOX_BW_CREDIT_MASK REG_GENMASK(15, 14)#define MBUS_DBOX_BW_CREDIT (x) REG_FIELD_PREP(MBUS_DBOX_BW_CREDIT_MASK, x) +#define MBUS_DBOX_BW_4CREDITS_MTL REG_FIELD_PREP(MBUS_DBOX_BW_CREDIT_MASK, 0x2) +#define MBUS_DBOX_BW_8CREDITS_MTL REG_FIELD_PREP(MBUS_DBOX_BW_CREDIT_MASK, 0x3)#define MBUS_DBOX_B_CREDIT_MASK REG_GENMASK(12, 8)#define MBUS_DBOX_B_CREDIT (x) REG_FIELD_PREP(MBUS_DBOX_B_CREDIT_MASK, x) +#define MBUS_DBOX_I_CREDIT_MASK REG_GENMASK(7, 5) +#define MBUS_DBOX_I_CREDIT (x) REG_FIELD_PREP(MBUS_DBOX_I_CREDIT_MASK, x)#define MBUS_DBOX_A_CREDIT_MASK REG_GENMASK(3, 0)#define MBUS_DBOX_A_CREDIT (x) REG_FIELD_PREP(MBUS_DBOX_A_CREDIT_MASK, x)
drivers/gpu/drm/i915/intel_pm.c +43 -4
79 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH v4 09/11] drm/i915/mtl: Update MBUS_DBOX credits
Quoted 39 lines · Radhakrishna Sripada
Display version 14 platforms have different credits values compared to ADL-P. Update the credits based on pipe usage.
v2: Simplify DBOX BW Credit definition(MattR)
Bspec: 49213
Cc: Jose Roberto de Souza <[email protected]>
Cc: Matt Roper <[email protected]> Original Author: Caz YokoyamaSigned-off-by José Roberto de Souza <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 4 +++ drivers/gpu/drm/i915/intel_pm.c | 47 ++++++++++++++++++++++++++++++--- 2 files changed, 47 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_reg.h +4
-0@@ -1125,8 +1125,12 @@#define MBUS_DBOX_REGULATE_B2B_TRANSACTIONS_EN REG_BIT(16)/* tgl+ */ #define MBUS_DBOX_BW_CREDIT_MASK REG_GENMASK(15, 14)#define MBUS_DBOX_BW_CREDIT (x) REG_FIELD_PREP(MBUS_DBOX_BW_CREDIT_MASK, x) +#define MBUS_DBOX_BW_4CREDITS_MTL REG_FIELD_PREP(MBUS_DBOX_BW_CREDIT_MASK, 0x2) +#define MBUS_DBOX_BW_8CREDITS_MTL REG_FIELD_PREP(MBUS_DBOX_BW_CREDIT_MASK, 0x3)#define MBUS_DBOX_B_CREDIT_MASK REG_GENMASK(12, 8)#define MBUS_DBOX_B_CREDIT (x) REG_FIELD_PREP(MBUS_DBOX_B_CREDIT_MASK, x) +#define MBUS_DBOX_I_CREDIT_MASK REG_GENMASK(7, 5) +#define MBUS_DBOX_I_CREDIT (x) REG_FIELD_PREP(MBUS_DBOX_I_CREDIT_MASK, x)#define MBUS_DBOX_A_CREDIT_MASK REG_GENMASK(3, 0)#define MBUS_DBOX_A_CREDIT (x) REG_FIELD_PREP(MBUS_DBOX_A_CREDIT_MASK, x)drivers/gpu/drm/i915/intel_pm.c +0
-0
drivers/gpu/drm/i915/intel_pm.c void intel_dbuf_post_plane_update(struct intel_atomic_state *state) · line 8451
Quoted 4 lines
drivers/gpu/drm/i915/intel_pm.c +1
-0@@ -8448,6 +8448,27 @@ void intel_dbuf_post_plane_update(struct intel_atomic_state *state) new_dbuf_state->enabled_slices); } +static bool xelpdp_is_one_pipe_per_dbuf_bank (enum pipe pipe,u8 active_pipes)
Bikeshed: s/one/only/ might be slightly more clear?
drivers/gpu/drm/i915/intel_pm.c void intel_dbuf_post_plane_update(struct intel_atomic_state *state) · line 8456
Quoted 5 lines
drivers/gpu/drm/i915/intel_pm.c +5
-0+{ +switch (pipe) { +case PIPE_A : +case PIPE_D : +if (is_power_of_2 (active_pipes & (BIT (PIPE_A ) |BIT (PIPE_D ))))
Bikeshed: writing this with hweight might be more intuitive than power_of_2? Or even just a direct check of the other pipe like
case PIPE_A:
return !(active_pipes & BIT(PIPE_D))
case PIPE_D:
return !(active_pipes & BIT(PIPE_A))
...
Quoted 51 lines
drivers/gpu/drm/i915/intel_pm.c +26
-3+return true; +break ; +case PIPE_B : +case PIPE_C : +if (is_power_of_2 (active_pipes & (BIT (PIPE_B ) |BIT (PIPE_C )))) +return true; +break ; +default :/* to suppress compiler warning */ +MISSING_CASE (pipe); +break ; + } + +return false; +} +void intel_mbus_dbox_update (struct intel_atomic_state *state) {struct drm_i915_private *i915 =to_i915 (state->base.dev);@@ -8467,20 +8488,28 @@ void intel_mbus_dbox_update(struct intel_atomic_state *state) new_dbuf_state->active_pipes == old_dbuf_state->active_pipes))return ; +if (DISPLAY_VER (i915) >=14 ) + val |=MBUS_DBOX_I_CREDIT (2 ); +if (DISPLAY_VER (i915) >=12 ) { val |=MBUS_DBOX_B2B_TRANSACTIONS_MAX (16 ); val |=MBUS_DBOX_B2B_TRANSACTIONS_DELAY (1 ); val |=MBUS_DBOX_REGULATE_B2B_TRANSACTIONS_EN ; } -/* Wa_22010947358:adl-p */ -if (IS_ALDERLAKE_P (i915)) +if (DISPLAY_VER (i915) >=14 ) + val |= new_dbuf_state->joined_mbus ?MBUS_DBOX_A_CREDIT (12 ) : +MBUS_DBOX_A_CREDIT (8 ); +else if (IS_ALDERLAKE_P (i915)) +/* Wa_22010947358:adl-p */ val |= new_dbuf_state->joined_mbus ?MBUS_DBOX_A_CREDIT (6 ) :MBUS_DBOX_A_CREDIT (4 );else val |=MBUS_DBOX_A_CREDIT (2 ); -if (IS_ALDERLAKE_P (i915)) { +if (DISPLAY_VER (i915) >=14 ) { + val |=MBUS_DBOX_B_CREDIT (0xA ); + }else if (IS_ALDERLAKE_P (i915)) { val |=MBUS_DBOX_BW_CREDIT (2 ); val |=MBUS_DBOX_B_CREDIT (8 ); }else if (DISPLAY_VER (i915) >=12 ) {
drivers/gpu/drm/i915/intel_pm.c void intel_mbus_dbox_update(struct intel_atomic_state *state) · line 8528
Quoted 8 lines
drivers/gpu/drm/i915/intel_pm.c +2
-0@@ -8492,10 +8521,20 @@ void intel_mbus_dbox_update(struct intel_atomic_state *state) }for_each_new_intel_crtc_in_state (state, crtc, new_crtc_state, i) { +u32 pipe_val = val; +if (!new_crtc_state->hw.active || !intel_crtc_needs_modeset (new_crtc_state))continue ;
What if the number of BW credits for a pipe changes when this pipe itself isn't undergoing a modeset? E.g., what if you initially had pipe A active as the only pipe and thus programmed 8 BW credits. Then you turn on pipe D; since we're not touching pipe A directly we skip any programming here (leaving it at 8 credits) and only program the 4 credits for pipe D's instance of the register. Am I missing something here?
Matt
Quoted 16 lines
drivers/gpu/drm/i915/intel_pm.c +9
-1-intel_de_write (i915,PIPE_MBUS_DBOX_CTL (crtc->pipe), val); +if (DISPLAY_VER (i915) >=14 ) { +if (xelpdp_is_one_pipe_per_dbuf_bank (crtc->pipe, + new_dbuf_state->active_pipes)) + pipe_val |=MBUS_DBOX_BW_8CREDITS_MTL ; +else + pipe_val |=MBUS_DBOX_BW_4CREDITS_MTL ; + } + +intel_de_write (i915,PIPE_MBUS_DBOX_CTL (crtc->pipe), pipe_val); } }Signature · 1 line
2.34.1
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
PATCH v4 10/11 drm/i915/mtl: Update CHICKEN_TRANS* register addresses
In reply to Radhakrishna SripadaFrom: Madhumitha Tolakanahalli Pradeep <[email protected]>
In Display version 14, Transcoder Chicken Registers have updated address. This patch performs checks to use the right register when required.
v2: Omit display version check in i915_reg.h(Jani)
Bspec: 34387, 50054
--- drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++++--- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +++- drivers/gpu/drm/i915/display/intel_psr.c | 6 +++-- drivers/gpu/drm/i915/i915_reg.h | 25 +++++++++++++++----- 4 files changed, 38 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +11 -3
@@ -618,7 +618,10 @@ void intel_disable_transcoder(const struct intel_crtc_state *old_crtc_state)if (!IS_I830 (dev_priv)) val &= ~PIPECONF_ENABLE ; -if (DISPLAY_VER (dev_priv) >=12 ) +if (DISPLAY_VER (dev_priv) >=14 ) +intel_de_rmw (dev_priv,MTL_CHICKEN_TRANS (cpu_transcoder), +FECSTALL_DIS_DPTSTREAM_DPTTG ,0 ); +else if (DISPLAY_VER (dev_priv) >=12 )intel_de_rmw (dev_priv,CHICKEN_TRANS (cpu_transcoder),FECSTALL_DIS_DPTSTREAM_DPTTG ,0 );
@@ -1838,7 +1841,9 @@ static void hsw_set_frame_start_delay(const struct intel_crtc_state *crtc_state) {struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); -i915_reg_t reg =CHICKEN_TRANS (crtc_state->cpu_transcoder); +enum transcoder transcoder = crtc_state->cpu_transcoder; +i915_reg_t reg =DISPLAY_VER (dev_priv) >=14 ?MTL_CHICKEN_TRANS (transcoder) : +CHICKEN_TRANS (transcoder);u32 val; val =intel_de_read (dev_priv, reg);
@@ -4033,6 +4038,7 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc, {struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);struct intel_display_power_domain_set power_domain_set = { }; +i915_reg_t reg;bool active;u32 tmp;
@@ -4124,7 +4130,9 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc, }if (!transcoder_is_dsi (pipe_config->cpu_transcoder)) { - tmp =intel_de_read (dev_priv,CHICKEN_TRANS (pipe_config->cpu_transcoder)); + reg =DISPLAY_VER (dev_priv) >=14 ?MTL_CHICKEN_TRANS (pipe_config->cpu_transcoder) : +CHICKEN_TRANS (pipe_config->cpu_transcoder); + tmp =intel_de_read (dev_priv, reg); pipe_config->framestart_delay =REG_FIELD_GET (HSW_FRAME_START_DELAY_MASK , tmp) +1 ; }else {
drivers/gpu/drm/i915/display/intel_dp_mst.c +4 -1
@@ -568,7 +568,10 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,drm_dp_add_payload_part2 (&intel_dp->mst_mgr, &state->base,drm_atomic_get_mst_payload_state (mst_state, connector->port)); -if (DISPLAY_VER (dev_priv) >=12 && pipe_config->fec_enable) +if (DISPLAY_VER (dev_priv) >=14 && pipe_config->fec_enable) +intel_de_rmw (dev_priv,MTL_CHICKEN_TRANS (trans),0 , +FECSTALL_DIS_DPTSTREAM_DPTTG ); +else if (DISPLAY_VER (dev_priv) >=12 && pipe_config->fec_enable)intel_de_rmw (dev_priv,CHICKEN_TRANS (trans),0 ,FECSTALL_DIS_DPTSTREAM_DPTTG );
drivers/gpu/drm/i915/display/intel_psr.c +4 -2
@@ -1139,7 +1139,8 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp,if (intel_dp->psr.psr2_enabled) {if (DISPLAY_VER (dev_priv) ==9 ) -intel_de_rmw (dev_priv,CHICKEN_TRANS (cpu_transcoder),0 , +intel_de_rmw (dev_priv, +CHICKEN_TRANS (cpu_transcoder),0 ,PSR2_VSC_ENABLE_PROG_HEADER |PSR2_ADD_VERTICAL_LINE_COUNT );
@@ -1149,7 +1150,8 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp,* cause issues if non-supported panels are used. */ if (IS_ALDERLAKE_P (dev_priv)) -intel_de_rmw (dev_priv,CHICKEN_TRANS (cpu_transcoder),0 , +intel_de_rmw (dev_priv, +CHICKEN_TRANS (cpu_transcoder),0 ,ADLP_1_BASED_X_GRANULARITY );/* Wa_16011168373:adl-p */
drivers/gpu/drm/i915/i915_reg.h +19 -6
@@ -5717,17 +5717,30 @@#define SKL_PLANE1_STRETCH_MAX_X1 REG_FIELD_PREP(SKL_PLANE1_STRETCH_MAX_MASK, 3)#define CHICKEN_PIPESL_1 (pipe) _MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B) +#define _MTL_CHICKEN_TRANS_A 0x604e0 +#define _MTL_CHICKEN_TRANS_B 0x614e0 +#define _MTL_CHICKEN_TRANS_C 0x624e0 +#define _MTL_CHICKEN_TRANS_D 0x634e0 +#define _CHICKEN_TRANS_A 0x420c0#define _CHICKEN_TRANS_B 0x420c4#define _CHICKEN_TRANS_C 0x420c8#define _CHICKEN_TRANS_EDP 0x420cc#define _CHICKEN_TRANS_D 0x420d8 -#define CHICKEN_TRANS (trans) _MMIO(_PICK((trans), \ - [TRANSCODER_EDP] = _CHICKEN_TRANS_EDP, \ - [TRANSCODER_A] = _CHICKEN_TRANS_A, \ - [TRANSCODER_B] = _CHICKEN_TRANS_B, \ - [TRANSCODER_C] = _CHICKEN_TRANS_C, \ - [TRANSCODER_D] = _CHICKEN_TRANS_D)) + +#define CHICKEN_TRANS (trans) _MMIO(_PICK((trans), \ + [TRANSCODER_EDP] = _CHICKEN_TRANS_EDP, \ + [TRANSCODER_A] = _CHICKEN_TRANS_A, \ + [TRANSCODER_B] = _CHICKEN_TRANS_B, \ + [TRANSCODER_C] = _CHICKEN_TRANS_C, \ + [TRANSCODER_D] = _CHICKEN_TRANS_D)) + +#define MTL_CHICKEN_TRANS (trans) _MMIO(_PICK((trans), \ + [TRANSCODER_A] = _MTL_CHICKEN_TRANS_A, \ + [TRANSCODER_B] = _MTL_CHICKEN_TRANS_B, \ + [TRANSCODER_C] = _MTL_CHICKEN_TRANS_C, \ + [TRANSCODER_D] = _MTL_CHICKEN_TRANS_D)) +#define HSW_FRAME_START_DELAY_MASK REG_GENMASK(28, 27)#define HSW_FRAME_START_DELAY (x) REG_FIELD_PREP(HSW_FRAME_START_DELAY_MASK, x)#define VSC_DATA_SEL_SOFTWARE_CONTROL REG_BIT(25)/* GLK */
Signature · 1 line
2.34.1
Re: [PATCH v4 10/11] drm/i915/mtl: Update CHICKEN_TRANS* register addresses
Quoted 85 lines · Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep <[email protected]>
In Display version 14, Transcoder Chicken Registers have updated address. This patch performs checks to use the right register when required.
v2: Omit display version check in
i915_reg.h(Jani)Bspec: 34387, 50054
Cc Jani Nikula <[email protected]>Signed-off-by Madhumitha Tolakanahalli Pradeep <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++++--- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +++- drivers/gpu/drm/i915/display/intel_psr.c | 6 +++-- drivers/gpu/drm/i915/i915_reg.h | 25 +++++++++++++++----- 4 files changed, 38 insertions(+), 12 deletions(-)drivers/gpu/drm/i915/display/intel_display.c +11
-3@@ -618,7 +618,10 @@ void intel_disable_transcoder(const struct intel_crtc_state *old_crtc_state)if (!IS_I830 (dev_priv)) val &= ~PIPECONF_ENABLE ; -if (DISPLAY_VER (dev_priv) >=12 ) +if (DISPLAY_VER (dev_priv) >=14 ) +intel_de_rmw (dev_priv,MTL_CHICKEN_TRANS (cpu_transcoder), +FECSTALL_DIS_DPTSTREAM_DPTTG ,0 ); +else if (DISPLAY_VER (dev_priv) >=12 )intel_de_rmw (dev_priv,CHICKEN_TRANS (cpu_transcoder),FECSTALL_DIS_DPTSTREAM_DPTTG ,0 );@@ -1838,7 +1841,9 @@ static void hsw_set_frame_start_delay(const struct intel_crtc_state *crtc_state) {struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); -i915_reg_t reg =CHICKEN_TRANS (crtc_state->cpu_transcoder); +enum transcoder transcoder = crtc_state->cpu_transcoder; +i915_reg_t reg =DISPLAY_VER (dev_priv) >=14 ?MTL_CHICKEN_TRANS (transcoder) : +CHICKEN_TRANS (transcoder);u32 val; val =intel_de_read (dev_priv, reg);@@ -4033,6 +4038,7 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc, {struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);struct intel_display_power_domain_set power_domain_set = { }; +i915_reg_t reg;bool active;u32 tmp;@@ -4124,7 +4130,9 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc, }if (!transcoder_is_dsi (pipe_config->cpu_transcoder)) { - tmp =intel_de_read (dev_priv,CHICKEN_TRANS (pipe_config->cpu_transcoder)); + reg =DISPLAY_VER (dev_priv) >=14 ?MTL_CHICKEN_TRANS (pipe_config->cpu_transcoder) : +CHICKEN_TRANS (pipe_config->cpu_transcoder); + tmp =intel_de_read (dev_priv, reg); pipe_config->framestart_delay =REG_FIELD_GET (HSW_FRAME_START_DELAY_MASK , tmp) +1 ; }else {drivers/gpu/drm/i915/display/intel_dp_mst.c +4
-1@@ -568,7 +568,10 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,drm_dp_add_payload_part2 (&intel_dp->mst_mgr, &state->base,drm_atomic_get_mst_payload_state (mst_state, connector->port)); -if (DISPLAY_VER (dev_priv) >=12 && pipe_config->fec_enable) +if (DISPLAY_VER (dev_priv) >=14 && pipe_config->fec_enable) +intel_de_rmw (dev_priv,MTL_CHICKEN_TRANS (trans),0 , +FECSTALL_DIS_DPTSTREAM_DPTTG ); +else if (DISPLAY_VER (dev_priv) >=12 && pipe_config->fec_enable)intel_de_rmw (dev_priv,CHICKEN_TRANS (trans),0 ,FECSTALL_DIS_DPTSTREAM_DPTTG );drivers/gpu/drm/i915/display/intel_psr.c +0
-0
drivers/gpu/drm/i915/display/intel_psr.c static void intel_psr_enable_source(struct intel_dp *intel_dp, · line 1143
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_psr.c +2
-1@@ -1139,7 +1139,8 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp,if (intel_dp->psr.psr2_enabled) {if (DISPLAY_VER (dev_priv) ==9 ) - intel_de_rmw(dev_priv, CHICKEN_TRANS(cpu_transcoder), 0, + intel_de_rmw(dev_priv, + CHICKEN_TRANS(cpu_transcoder), 0,
This whitespace-only change on a non-MTL codepath doesn't look necessary.
drivers/gpu/drm/i915/display/intel_psr.c static void intel_psr_enable_source(struct intel_dp *intel_dp, · line 1154
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_psr.c +2
-1PSR2_VSC_ENABLE_PROG_HEADER | PSR2_ADD_VERTICAL_LINE_COUNT);@@ -1149,7 +1150,8 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp,* cause issues if non-supported panels are used. */ if (IS_ALDERLAKE_P (dev_priv)) - intel_de_rmw(dev_priv, CHICKEN_TRANS(cpu_transcoder), 0, + intel_de_rmw(dev_priv, + CHICKEN_TRANS(cpu_transcoder), 0,
Ditto.
Quoted 19 lines
drivers/gpu/drm/i915/display/intel_psr.c +0
-0ADLP_1_BASED_X_GRANULARITY);/* Wa_16011168373:adl-p */ drivers/gpu/drm/i915/i915_reg.h +5
-0@@ -5717,17 +5717,30 @@#define SKL_PLANE1_STRETCH_MAX_X1 REG_FIELD_PREP(SKL_PLANE1_STRETCH_MAX_MASK, 3)#define CHICKEN_PIPESL_1 (pipe) _MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B) +#define _MTL_CHICKEN_TRANS_A 0x604e0 +#define _MTL_CHICKEN_TRANS_B 0x614e0 +#define _MTL_CHICKEN_TRANS_C 0x624e0 +#define _MTL_CHICKEN_TRANS_D 0x634e0 +#define _CHICKEN_TRANS_A 0x420c0#define _CHICKEN_TRANS_B 0x420c4#define _CHICKEN_TRANS_C 0x420c8
drivers/gpu/drm/i915/i915_reg.h line 5731
Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h +2
-6#define _CHICKEN_TRANS_EDP 0x420cc#define _CHICKEN_TRANS_D 0x420d8 -#define CHICKEN_TRANS (trans) _MMIO(_PICK((trans), \ - [TRANSCODER_EDP] = _CHICKEN_TRANS_EDP, \ - [TRANSCODER_A] = _CHICKEN_TRANS_A, \ - [TRANSCODER_B] = _CHICKEN_TRANS_B, \ - [TRANSCODER_C] = _CHICKEN_TRANS_C, \ - [TRANSCODER_D] = _CHICKEN_TRANS_D)) + +#define CHICKEN_TRANS (trans) _MMIO(_PICK((trans), \
Nitpick: there's an extra space between 'define' and the register name that shouldn't be there (same with the MTL definition below). It looks like some of the subsequent register definitions in i915_reg.h are misformatted, but we shouldn't copy that mistake here.
drivers/gpu/drm/i915/i915_reg.h line 5742
Quoted 11 lines
drivers/gpu/drm/i915/i915_reg.h +11
-0+ [TRANSCODER_EDP] = _CHICKEN_TRANS_EDP, \ + [TRANSCODER_A] = _CHICKEN_TRANS_A, \ + [TRANSCODER_B] = _CHICKEN_TRANS_B, \ + [TRANSCODER_C] = _CHICKEN_TRANS_C, \ + [TRANSCODER_D] = _CHICKEN_TRANS_D)) + +#define MTL_CHICKEN_TRANS (trans) _MMIO(_PICK((trans), \ + [TRANSCODER_A] = _MTL_CHICKEN_TRANS_A, \ + [TRANSCODER_B] = _MTL_CHICKEN_TRANS_B, \ + [TRANSCODER_C] = _MTL_CHICKEN_TRANS_C, \ + [TRANSCODER_D] = _MTL_CHICKEN_TRANS_D))
The registers are equally-spaced and there's no edp transcoder anymore, so this definition can be simplified down to just
#define MTL_CHICKEN_TRANS _MMIO_TRANS((trans), \
_MTL_CHICKEN_TRANS_A, \
_MTL_CHICKEN_TRANS_B)and we can drop the definitions of _MTL_CHICKEN_TRANS_C and _MTL_CHICKEN_TRANS_D.
Matt
Quoted 7 lines
drivers/gpu/drm/i915/i915_reg.h +1
-0+#define HSW_FRAME_START_DELAY_MASK REG_GENMASK(28, 27)#define HSW_FRAME_START_DELAY (x) REG_FIELD_PREP(HSW_FRAME_START_DELAY_MASK, x)#define VSC_DATA_SEL_SOFTWARE_CONTROL REG_BIT(25)/* GLK */ Signature · 1 line
2.34.1
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
PATCH v4 11/11 drm/i915/mtl: Do not update GV point, mask value
In reply to Radhakrishna SripadaDisplay 14 and future platforms do not directly communicate to Pcode via mailbox the SAGV bandwidth information. PM Demand registers are used to communicate display power requirements to the PUnit which would include GV point and mask value.
Skip programming GV point and mask values through legacy pcode mailbox interface.
Bspec: 64636
Cc: Matt Roper <[email protected]>
Original Author: Caz Yokoyama
--- drivers/gpu/drm/i915/intel_pm.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +18 -0
@@ -3923,6 +3923,14 @@ void intel_sagv_pre_plane_update(struct intel_atomic_state *state) {struct drm_i915_private *i915 =to_i915 (state->base.dev); +/* +* No need to update mask value/restrict because +* "Pcode only wants to use GV bandwidth value, not the mask value." +* for DISPLAY_VER() >= 14. +*/ +if (DISPLAY_VER (i915) >=14 ) +return ; +/* * Just return if we can't control SAGV or don't have it. * This is different from situation when we have SAGV but just can't
@@ -3943,6 +3951,16 @@ void intel_sagv_post_plane_update(struct intel_atomic_state *state) {struct drm_i915_private *i915 =to_i915 (state->base.dev); +/* +* No need to update mask value/restrict because +* "Pcode only wants to use GV bandwidth value, not the mask value." +* for DISPLAY_VER() >= 14. +* +* GV bandwidth will be set by intel_pmdemand_post_plane_update() +*/ +if (DISPLAY_VER (i915) >=14 ) +return ; +/* * Just return if we can't control SAGV or don't have it. * This is different from situation when we have SAGV but just can't
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v4 11/11] drm/i915/mtl: Do not update GV point, mask value
Quoted 7 lines · Radhakrishna Sripada
Display 14 and future platforms do not directly communicate to Pcode via mailbox the SAGV bandwidth information. PM Demand registers are used to communicate display power requirements to the PUnit which would include GV point and mask value.
Skip programming GV point and mask values through legacy pcode mailbox interface.
I agree to Matt's suggestion in v2 of this patch series, to move this patch to the future series where we would introduce the new pm_demand interface. It would make more sense there.
Quoted 15 lines
Bspec: 64636
Cc: Matt Roper <[email protected]>
Original Author: Caz YokoyamaSigned-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)drivers/gpu/drm/i915/intel_pm.c +0
-0@@ -3923,6 +3923,14 @@ void intel_sagv_pre_plane_update(struct intel_atomic_state *state) {
drivers/gpu/drm/i915/intel_pm.c void intel_sagv_pre_plane_update(struct intel_atomic_state *state) · line 3933
Quoted 10 lines
drivers/gpu/drm/i915/intel_pm.c +8
-0struct drm_i915_private *i915 =to_i915 (state->base.dev); +/* +* No need to update mask value/restrict because +* "Pcode only wants to use GV bandwidth value, not the mask value." +* for DISPLAY_VER() >= 14. +*/ +if (DISPLAY_VER (i915) >=14 ) +return ; +
My suggestion would be to remove the DISPLAY version check here and do it at the place where this function is invoked from. So for versions <14, intel_sagv_pre_plane_update can be called and for higher we need to implement the new pm_demand interface.
Quoted 6 lines
drivers/gpu/drm/i915/intel_pm.c +0
-0/* * Just return if we can't control SAGV or don't have it. * This is different from situation when we have SAGV but just can't @@ -3943,6 +3951,16 @@ void intel_sagv_post_plane_update(struct intel_atomic_state *state) {struct drm_i915_private *i915 =to_i915 (state->base.dev);
drivers/gpu/drm/i915/intel_pm.c void intel_sagv_post_plane_update(struct intel_atomic_state *state) · line 3962
Quoted 10 lines
drivers/gpu/drm/i915/intel_pm.c +9
-0+/* +* No need to update mask value/restrict because +* "Pcode only wants to use GV bandwidth value, not the mask value." +* for DISPLAY_VER() >= 14. +* +* GV bandwidth will be set by intel_pmdemand_post_plane_update() +*/ +if (DISPLAY_VER (i915) >=14 ) +return ;
ditto
drivers/gpu/drm/i915/intel_pm.c void intel_sagv_pre_plane_update(struct intel_atomic_state *state) · line 3936
Quoted 4 lines
drivers/gpu/drm/i915/intel_pm.c +1
-0+/* * Just return if we can't control SAGV or don't have it. * This is different from situation when we have SAGV but just can't
Regards,
Bala
Quoted 3 lines
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BUILD: failure for Initial Meteorlake Support (rev5)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Initial Meteorlake Support (rev5)
URL : https://patchwork.freedesktop.org/series/106786/
State : failure
== Summary ==
Error: make failed
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/i915_gem.o
In file included from drivers/gpu/drm/i915/i915_gem.c:1267:drivers/gpu/drm/i915/selftests/mock_gem_device.c: In function ‘mock_gem_device’:drivers/gpu/drm/i915/selftests/mock_gem_device.c:175:30: error: ‘struct <anonymous>’ has no member named ‘ver’
RUNTIME_INFO(i915)->graphics.ver = -1;
^scripts/Makefile.build:249: recipe for target 'drivers/gpu/drm/i915/i915_gem.o' failed make[4]: *** [drivers/gpu/drm/i915/i915_gem.o] Error 1 scripts/Makefile.build:465: recipe for target 'drivers/gpu/drm/i915' failed make[3]: *** [drivers/gpu/drm/i915] Error 2scripts/Makefile.build:465: recipe for target 'drivers/gpu/drm' failed make[2]: *** [drivers/gpu/drm] Error 2scripts/Makefile.build:465: recipe for target 'drivers/gpu' failed make[1]: *** [drivers/gpu] Error 2
Makefile:1853: recipe for target 'drivers' failed
make: *** [drivers] Error 2
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Initial Meteorlake Support (rev6)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Initial Meteorlake Support (rev6)
URL : https://patchwork.freedesktop.org/series/106786/
State : warning
== Summary ==
Error: dim checkpatch failed400c5e5c3553 drm/i915: Move display and media IP version to runtime info -:34: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #34: FILE: drivers/gpu/drm/i915/i915_drv.h:473:
+#define GRAPHICS_VER_FULL(i915) IP_VER(RUNTIME_INFO(i915)->graphics.version.ver, \
+ RUNTIME_INFO(i915)->graphics.version.rel)
-:43: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #43: FILE: drivers/gpu/drm/i915/i915_drv.h:479:
+#define MEDIA_VER_FULL(i915) IP_VER(RUNTIME_INFO(i915)->media.version.ver, \
+ RUNTIME_INFO(i915)->media.version.rel)
-:168: WARNING:LONG_LINE: line length of 111 exceeds 100 columns #168: FILE: drivers/gpu/drm/i915/i915_pci.c:1284:
+ int gttmmaddr_bar = intel_info->__runtime.graphics.version.ver == 2 ? GEN2_GTTMMADR_BAR : GTTMMADR_BAR;
total: 0 errors, 1 warnings, 2 checks, 210 lines checked 96ff892a02f3 drm/i915: Read graphics/media/display arch version from hw 496446695d67 drm/i915: Parse and set stepping for platforms with GMD 590ffac3b5cd drm/i915/mtl: Define engine context layouts -:73: WARNING:LEADING_SPACE: please, no spaces at the start of a line #73: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:642:
+ NOP(1),$
-:74: WARNING:LEADING_SPACE: please, no spaces at the start of a line #74: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:643:
+ LRI(13, POSTED),$
-:75: WARNING:LEADING_SPACE: please, no spaces at the start of a line #75: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:644:
+ REG16(0x244),$
-:76: WARNING:LEADING_SPACE: please, no spaces at the start of a line #76: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:645:
+ REG(0x034),$
-:77: WARNING:LEADING_SPACE: please, no spaces at the start of a line #77: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:646:
+ REG(0x030),$
-:78: WARNING:LEADING_SPACE: please, no spaces at the start of a line #78: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:647:
+ REG(0x038),$
-:79: WARNING:LEADING_SPACE: please, no spaces at the start of a line #79: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:648:
+ REG(0x03c),$
-:80: WARNING:LEADING_SPACE: please, no spaces at the start of a line #80: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:649:
+ REG(0x168),$
-:81: WARNING:LEADING_SPACE: please, no spaces at the start of a line #81: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:650:
+ REG(0x140),$
-:82: WARNING:LEADING_SPACE: please, no spaces at the start of a line #82: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:651:
+ REG(0x110),$
-:83: WARNING:LEADING_SPACE: please, no spaces at the start of a line #83: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:652:
+ REG(0x1c0),$
-:84: WARNING:LEADING_SPACE: please, no spaces at the start of a line #84: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:653:
+ REG(0x1c4),$
-:85: WARNING:LEADING_SPACE: please, no spaces at the start of a line #85: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:654:
+ REG(0x1c8),$
-:86: WARNING:LEADING_SPACE: please, no spaces at the start of a line #86: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:655:
+ REG(0x180),$
-:87: WARNING:LEADING_SPACE: please, no spaces at the start of a line #87: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:656:
+ REG16(0x2b4),$
-:89: WARNING:LEADING_SPACE: please, no spaces at the start of a line #89: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:658:
+ NOP(1),$
-:90: WARNING:LEADING_SPACE: please, no spaces at the start of a line #90: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:659:
+ LRI(9, POSTED),$
-:91: WARNING:LEADING_SPACE: please, no spaces at the start of a line #91: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:660:
+ REG16(0x3a8),$
-:92: WARNING:LEADING_SPACE: please, no spaces at the start of a line #92: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:661:
+ REG16(0x28c),$
-:93: WARNING:LEADING_SPACE: please, no spaces at the start of a line #93: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:662:
+ REG16(0x288),$
-:94: WARNING:LEADING_SPACE: please, no spaces at the start of a line #94: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:663:
+ REG16(0x284),$
-:95: WARNING:LEADING_SPACE: please, no spaces at the start of a line #95: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:664:
+ REG16(0x280),$
-:96: WARNING:LEADING_SPACE: please, no spaces at the start of a line #96: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:665:
+ REG16(0x27c),$
-:97: WARNING:LEADING_SPACE: please, no spaces at the start of a line #97: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:666:
+ REG16(0x278),$
-:98: WARNING:LEADING_SPACE: please, no spaces at the start of a line #98: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:667:
+ REG16(0x274),$
-:99: WARNING:LEADING_SPACE: please, no spaces at the start of a line #99: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:668:
+ REG16(0x270),$
-:101: WARNING:LEADING_SPACE: please, no spaces at the start of a line #101: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:670:
+ NOP(2),$
-:102: WARNING:LEADING_SPACE: please, no spaces at the start of a line #102: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:671:
+ LRI(2, POSTED),$
-:103: WARNING:LEADING_SPACE: please, no spaces at the start of a line #103: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:672:
+ REG16(0x5a8),$
-:104: WARNING:LEADING_SPACE: please, no spaces at the start of a line #104: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:673:
+ REG16(0x5ac),$
-:106: WARNING:LEADING_SPACE: please, no spaces at the start of a line #106: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:675:
+ NOP(6),$
-:107: WARNING:LEADING_SPACE: please, no spaces at the start of a line #107: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:676:
+ LRI(1, 0),$
-:108: WARNING:LEADING_SPACE: please, no spaces at the start of a line #108: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:677:
+ REG(0x0c8),$
-:110: WARNING:LEADING_SPACE: please, no spaces at the start of a line #110: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:679:
+ END$
total: 0 errors, 34 warnings, 0 checks, 105 lines checked4c81250058aa drm/i915/mtl: Add gmbus and gpio support65a57c3f9435 drm/i915/mtl: Add display power wells
-:36: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #36: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1358:
+#define XELPDP_PW_2_POWER_DOMAINS \
+ XELPD_PW_B_POWER_DOMAINS, \
+ XELPD_PW_C_POWER_DOMAINS, \
+ XELPD_PW_D_POWER_DOMAINS, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC1, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC2, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC3, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC4
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #48: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1370:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_pw_2,
+ XELPDP_PW_2_POWER_DOMAINS,
-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #52: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1374:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_dc_off,
+ XELPDP_PW_2_POWER_DOMAINS,
-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #60: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1382:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_aux_tc1,
+ POWER_DOMAIN_AUX_USBC1,
-:64: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #64: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1386:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_aux_tc2,
+ POWER_DOMAIN_AUX_USBC2,
-:68: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #68: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1390:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_aux_tc3,
+ POWER_DOMAIN_AUX_USBC3,
-:72: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #72: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1394:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_aux_tc4,
+ POWER_DOMAIN_AUX_USBC4,
-:77: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #77: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1399:
+ .instances = &I915_PW_INSTANCES(
-:83: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #83: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1405:
+ .instances = &I915_PW_INSTANCES(
-:92: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #92: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1414:
+ .instances = &I915_PW_INSTANCES(
-:100: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #100: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1422:
+ .instances = &I915_PW_INSTANCES(
-:108: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #108: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1430:
+ .instances = &I915_PW_INSTANCES(
-:116: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #116: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1438:
+ .instances = &I915_PW_INSTANCES(
-:124: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #124: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1446:
+ .instances = &I915_PW_INSTANCES(
total: 1 errors, 0 warnings, 13 checks, 248 lines checked1344ad3d6614 drm/i915/mtl: Add DP AUX support on TypeC ports 3fade45a6406 drm/i915/mtl: Obtain SAGV values from MMIO instead of GT pcode mailbox 07911132425a drm/i915/mtl: Update MBUS_DBOX credits0319593d18bd drm/i915/mtl: Update CHICKEN_TRANS* register addresses 28e053eba389 drm/i915/mtl: Do not update GV point, mask value
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Initial Meteorlake Support (rev6)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Initial Meteorlake Support (rev6)
URL : https://patchwork.freedesktop.org/series/106786/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Initial Meteorlake Support (rev6)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Initial Meteorlake Support (rev6)
URL : https://patchwork.freedesktop.org/series/106786/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12067 -> Patchwork_106786v6
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/index.html
Participating hosts (32 -> 31)
------------------------------
Additional (1): fi-hsw-4770
Missing (2): fi-bdw-samus fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_106786v6 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#3012])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/fi-hsw-4770/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-hsw-g3258: [PASS][2] -> [INCOMPLETE][3] ([i915#3303] / [i915#4785])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/fi-hsw-g3258/igt@i915_selftest@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/fi-hsw-g3258/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][4] -> [DMESG-FAIL][5] ([i915#4528])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/fi-pnv-d510/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/fi-pnv-d510/igt@i915_selftest@[email protected]
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-hsw-4770: NOTRUN -> [SKIP][6] ([fdo#109271]) +9 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/fi-hsw-4770/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-hsw-4770: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/fi-hsw-4770/igt@[email protected]
* igt@kms_psr@sprite_plane_onoff:
- fi-hsw-4770: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1072]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html
* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][9] ([i915#4312])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/fi-bdw-5557u/igt@[email protected]
- fi-hsw-g3258: NOTRUN -> [FAIL][10] ([fdo#109271] / [i915#4312] / [i915#6246])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/fi-hsw-g3258/igt@[email protected]
#### Possible fixes ####
* igt@gem_ringfill@basic-all:
- {bat-dg2-9}: [FAIL][11] ([i915#5886]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/bat-dg2-9/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/bat-dg2-9/igt@[email protected]
* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][13] ([i915#6367]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/bat-rpls-1/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/bat-rpls-1/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5886]: https://gitlab.freedesktop.org/drm/intel/issues/5886
[i915#6246]: https://gitlab.freedesktop.org/drm/intel/issues/6246
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6580]: https://gitlab.freedesktop.org/drm/intel/issues/6580
[i915#6670]: https://gitlab.freedesktop.org/drm/intel/issues/6670
Build changes
-------------
* Linux: CI_DRM_12067 -> Patchwork_106786v6
CI-20190529: 20190529
CI_DRM_12067: d7a4dd8aada1f62a680ecded0719199619eff752 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6642: c018ce1d1ab8e570f665cf5d58c9802a44d66cc1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106786v6: d7a4dd8aada1f62a680ecded0719199619eff752 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
0dec8cb94232 drm/i915/mtl: Do not update GV point, mask value 18f5c7aa9b1a drm/i915/mtl: Update CHICKEN_TRANS* register addresses c4449b314175 drm/i915/mtl: Update MBUS_DBOX credits950c6ebcad62 drm/i915/mtl: Obtain SAGV values from MMIO instead of GT pcode mailbox 2c764dbbaee8 drm/i915/mtl: Add DP AUX support on TypeC ports 35d898d18fab drm/i915/mtl: Add display power wellsc2cd6e8132b0 drm/i915/mtl: Add gmbus and gpio support3722a19b34cd drm/i915/mtl: Define engine context layouts6e4220e90b99 drm/i915: Parse and set stepping for platforms with GMD d80794796337 drm/i915: Read graphics/media/display arch version from hw dfe734f8a689 drm/i915: Move display and media IP version to runtime info
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for Initial Meteorlake Support (rev6)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Initial Meteorlake Support (rev6)
URL : https://patchwork.freedesktop.org/series/106786/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12067_full -> Patchwork_106786v6_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 11)
------------------------------
Additional (1): shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_106786v6_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@kms_cursor_crc@cursor-onscreen-512x512}:
- {shard-tglu}: NOTRUN -> [SKIP][1] +14 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-tglu-3/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_106786v6_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-snb: ([PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26]) -> ([PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [FAIL][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51]) ([i915#4338])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb7/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb7/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb7/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb7/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb6/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb6/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb6/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb6/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb5/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb5/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb4/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb4/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb2/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb2/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb7/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb7/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb7/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb6/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb6/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb5/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb5/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb5/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb4/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb4/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb4/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb4/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb4/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb2/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb2/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@smoketest:
- shard-iclb: [PASS][52] -> [FAIL][53] ([i915#5099])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb8/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb3/igt@[email protected]
* igt@gem_eio@kms:
- shard-tglb: [PASS][54] -> [FAIL][55] ([i915#5784]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-tglb7/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-tglb5/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][56] -> [TIMEOUT][57] ([i915#3070])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb2/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb7/igt@[email protected]
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [PASS][58] -> [SKIP][59] ([i915#4525]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb1/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb5/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][60] -> [FAIL][61] ([i915#2842]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-glk6/igt@gem_exec_fair@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][62] -> [FAIL][63] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb3/igt@gem_exec_fair@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [PASS][64] -> [DMESG-WARN][65] ([i915#180])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-apl7/igt@gem_exec_suspend@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl6/igt@gem_exec_suspend@[email protected]
* igt@gem_lmem_swapping@random:
- shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#4613])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl6/igt@[email protected]
* igt@gem_softpin@evict-single-offset:
- shard-tglb: [PASS][67] -> [FAIL][68] ([i915#4171])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-tglb7/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-tglb3/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][69] ([i915#4991])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl3/igt@[email protected]
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#3886]) +3 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl6/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_color_chamelium@ctm-0-50:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [fdo#111827]) +5 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl3/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][72] -> [FAIL][73] ([i915#2346])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-glk2/igt@kms_cursor_legacy@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-glk6/igt@kms_cursor_legacy@[email protected]
* igt@kms_cursor_legacy@short-flip-after-cursor@atomic-transitions:
- shard-apl: [PASS][74] -> [DMESG-WARN][75] ([i915#62]) +71 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-apl8/igt@kms_cursor_legacy@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl8/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][76] -> [FAIL][77] ([i915#79])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-glk9/igt@kms_flip@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-glk7/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][78] ([i915#2672]) +7 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#3555])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][80] ([i915#2672] / [i915#3555])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-snb: NOTRUN -> [SKIP][81] ([fdo#109271]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-d-alpha-transparent-fb:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271]) +88 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl6/igt@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][83] -> [SKIP][84] ([i915#5235]) +5 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb1/igt@kms_plane_scaling@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb2/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#658])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl6/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][86] -> [SKIP][87] ([fdo#109441]) +2 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
* igt@sysfs_clients@pidname:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2994])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl3/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-apl: [DMESG-WARN][89] ([i915#180]) -> [PASS][90] +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-apl8/igt@gem_ctx_isolation@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl6/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][91] ([i915#4525]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb8/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][93] ([i915#2842]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-apl2/igt@gem_exec_fair@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl8/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][95] ([i915#454]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb7/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb7/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][97] ([i915#4281]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb3/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb8/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][99] ([i915#3921]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-snb7/igt@i915_selftest@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-snb6/igt@i915_selftest@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-tglb: [FAIL][101] ([i915#3743]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-tglb6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-tglb7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [SKIP][103] ([fdo#109441]) -> [PASS][104] +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb1/igt@kms_psr@psr2_sprite_plane_onoff.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
#### Warnings ####
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: [FAIL][105] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][106] ([fdo#108145] / [i915#62])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-apl8/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-apl8/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][107] ([i915#2920]) -> [SKIP][108] ([fdo#111068] / [i915#658])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb2/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb1/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][109] ([fdo#111068] / [i915#658]) -> [SKIP][110] ([i915#2920])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb5/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-iclb: [SKIP][111] ([i915#2920]) -> [SKIP][112] ([i915#658]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb2/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb7/igt@[email protected]
* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [SKIP][113] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][114] ([i915#5939]) +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12067/shard-iclb8/igt@kms_psr2_su@page_flip-nv12.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4338]: https://gitlab.freedesktop.org/drm/intel/issues/4338
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5099]: https://gitlab.freedesktop.org/drm/intel/issues/5099
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12067 -> Patchwork_106786v6
CI-20190529: 20190529
CI_DRM_12067: d7a4dd8aada1f62a680ecded0719199619eff752 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6642: c018ce1d1ab8e570f665cf5d58c9802a44d66cc1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106786v6: d7a4dd8aada1f62a680ecded0719199619eff752 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v6/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Initial Meteorlake Support (rev8)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Initial Meteorlake Support (rev8)
URL : https://patchwork.freedesktop.org/series/106786/
State : warning
== Summary ==
Error: dim checkpatch failed4b29e4a0d695 drm/i915: Move display and media IP version to runtime info -:34: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #34: FILE: drivers/gpu/drm/i915/i915_drv.h:471:
+#define GRAPHICS_VER_FULL(i915) IP_VER(RUNTIME_INFO(i915)->graphics.version.ver, \
+ RUNTIME_INFO(i915)->graphics.version.rel)
-:43: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #43: FILE: drivers/gpu/drm/i915/i915_drv.h:477:
+#define MEDIA_VER_FULL(i915) IP_VER(RUNTIME_INFO(i915)->media.version.ver, \
+ RUNTIME_INFO(i915)->media.version.rel)
-:168: WARNING:LONG_LINE: line length of 111 exceeds 100 columns #168: FILE: drivers/gpu/drm/i915/i915_pci.c:1284:
+ int gttmmaddr_bar = intel_info->__runtime.graphics.version.ver == 2 ? GEN2_GTTMMADR_BAR : GTTMMADR_BAR;
total: 0 errors, 1 warnings, 2 checks, 210 lines checked 6a2c41b22e56 drm/i915: Read graphics/media/display arch version from hw 79280c5d5e17 drm/i915: Parse and set stepping for platforms with GMD 42e768a03bc4 drm/i915/mtl: Define engine context layouts -:75: WARNING:LEADING_SPACE: please, no spaces at the start of a line #75: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:643:
+ NOP(1),$
-:76: WARNING:LEADING_SPACE: please, no spaces at the start of a line #76: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:644:
+ LRI(13, POSTED),$
-:77: WARNING:LEADING_SPACE: please, no spaces at the start of a line #77: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:645:
+ REG16(0x244),$
-:78: WARNING:LEADING_SPACE: please, no spaces at the start of a line #78: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:646:
+ REG(0x034),$
-:79: WARNING:LEADING_SPACE: please, no spaces at the start of a line #79: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:647:
+ REG(0x030),$
-:80: WARNING:LEADING_SPACE: please, no spaces at the start of a line #80: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:648:
+ REG(0x038),$
-:81: WARNING:LEADING_SPACE: please, no spaces at the start of a line #81: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:649:
+ REG(0x03c),$
-:82: WARNING:LEADING_SPACE: please, no spaces at the start of a line #82: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:650:
+ REG(0x168),$
-:83: WARNING:LEADING_SPACE: please, no spaces at the start of a line #83: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:651:
+ REG(0x140),$
-:84: WARNING:LEADING_SPACE: please, no spaces at the start of a line #84: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:652:
+ REG(0x110),$
-:85: WARNING:LEADING_SPACE: please, no spaces at the start of a line #85: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:653:
+ REG(0x1c0),$
-:86: WARNING:LEADING_SPACE: please, no spaces at the start of a line #86: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:654:
+ REG(0x1c4),$
-:87: WARNING:LEADING_SPACE: please, no spaces at the start of a line #87: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:655:
+ REG(0x1c8),$
-:88: WARNING:LEADING_SPACE: please, no spaces at the start of a line #88: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:656:
+ REG(0x180),$
-:89: WARNING:LEADING_SPACE: please, no spaces at the start of a line #89: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:657:
+ REG16(0x2b4),$
-:91: WARNING:LEADING_SPACE: please, no spaces at the start of a line #91: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:659:
+ NOP(1),$
-:92: WARNING:LEADING_SPACE: please, no spaces at the start of a line #92: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:660:
+ LRI(9, POSTED),$
-:93: WARNING:LEADING_SPACE: please, no spaces at the start of a line #93: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:661:
+ REG16(0x3a8),$
-:94: WARNING:LEADING_SPACE: please, no spaces at the start of a line #94: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:662:
+ REG16(0x28c),$
-:95: WARNING:LEADING_SPACE: please, no spaces at the start of a line #95: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:663:
+ REG16(0x288),$
-:96: WARNING:LEADING_SPACE: please, no spaces at the start of a line #96: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:664:
+ REG16(0x284),$
-:97: WARNING:LEADING_SPACE: please, no spaces at the start of a line #97: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:665:
+ REG16(0x280),$
-:98: WARNING:LEADING_SPACE: please, no spaces at the start of a line #98: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:666:
+ REG16(0x27c),$
-:99: WARNING:LEADING_SPACE: please, no spaces at the start of a line #99: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:667:
+ REG16(0x278),$
-:100: WARNING:LEADING_SPACE: please, no spaces at the start of a line #100: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:668:
+ REG16(0x274),$
-:101: WARNING:LEADING_SPACE: please, no spaces at the start of a line #101: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:669:
+ REG16(0x270),$
-:103: WARNING:LEADING_SPACE: please, no spaces at the start of a line #103: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:671:
+ NOP(2),$
-:104: WARNING:LEADING_SPACE: please, no spaces at the start of a line #104: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:672:
+ LRI(2, POSTED),$
-:105: WARNING:LEADING_SPACE: please, no spaces at the start of a line #105: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:673:
+ REG16(0x5a8),$
-:106: WARNING:LEADING_SPACE: please, no spaces at the start of a line #106: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:674:
+ REG16(0x5ac),$
-:108: WARNING:LEADING_SPACE: please, no spaces at the start of a line #108: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:676:
+ NOP(6),$
-:109: WARNING:LEADING_SPACE: please, no spaces at the start of a line #109: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:677:
+ LRI(1, 0),$
-:110: WARNING:LEADING_SPACE: please, no spaces at the start of a line #110: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:678:
+ REG(0x0c8),$
-:112: WARNING:LEADING_SPACE: please, no spaces at the start of a line #112: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:680:
+ END$
total: 0 errors, 34 warnings, 0 checks, 106 lines checked27e4f3657fed drm/i915/mtl: Add gmbus and gpio supportf651287a8095 drm/i915/mtl: Add display power wells
-:36: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #36: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1358:
+#define XELPDP_PW_2_POWER_DOMAINS \
+ XELPD_PW_B_POWER_DOMAINS, \
+ XELPD_PW_C_POWER_DOMAINS, \
+ XELPD_PW_D_POWER_DOMAINS, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC1, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC2, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC3, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC4
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #48: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1370:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_pw_2,
+ XELPDP_PW_2_POWER_DOMAINS,
-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #52: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1374:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_dc_off,
+ XELPDP_PW_2_POWER_DOMAINS,
-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #60: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1382:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_aux_tc1,
+ POWER_DOMAIN_AUX_USBC1,
-:64: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #64: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1386:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_aux_tc2,
+ POWER_DOMAIN_AUX_USBC2,
-:68: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #68: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1390:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_aux_tc3,
+ POWER_DOMAIN_AUX_USBC3,
-:72: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #72: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1394:
+I915_DECL_PW_DOMAINS(xelpdp_pwdoms_aux_tc4,
+ POWER_DOMAIN_AUX_USBC4,
-:77: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #77: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1399:
+ .instances = &I915_PW_INSTANCES(
-:83: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #83: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1405:
+ .instances = &I915_PW_INSTANCES(
-:92: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #92: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1414:
+ .instances = &I915_PW_INSTANCES(
-:100: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #100: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1422:
+ .instances = &I915_PW_INSTANCES(
-:108: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #108: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1430:
+ .instances = &I915_PW_INSTANCES(
-:116: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #116: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1438:
+ .instances = &I915_PW_INSTANCES(
-:124: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #124: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1446:
+ .instances = &I915_PW_INSTANCES(
total: 1 errors, 0 warnings, 13 checks, 248 lines checked81c9d3e70896 drm/i915/mtl: Add DP AUX support on TypeC ports ccc57cfaa0ca drm/i915/mtl: Obtain SAGV values from MMIO instead of GT pcode mailbox b8b2df8aad15 drm/i915/mtl: Update MBUS_DBOX credits1d6873431317 drm/i915/mtl: Update CHICKEN_TRANS* register addresses 5c13352bf291 drm/i915/mtl: Do not update GV point, mask value
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Initial Meteorlake Support (rev8)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Initial Meteorlake Support (rev8)
URL : https://patchwork.freedesktop.org/series/106786/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Initial Meteorlake Support (rev8)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Initial Meteorlake Support (rev8)
URL : https://patchwork.freedesktop.org/series/106786/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12091 -> Patchwork_106786v8
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/index.html
Participating hosts (39 -> 38)
------------------------------
Missing (1): fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_106786v8 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][1] -> [INCOMPLETE][2] ([i915#3921])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/fi-snb-2600/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/fi-snb-2600/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-nick: [PASS][3] -> [DMESG-FAIL][4] ([i915#3428] / [i915#6217])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [PASS][5] -> [INCOMPLETE][6] ([i915#146] / [i915#6598] / [i915#6712])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/fi-bdw-5557u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/fi-bdw-5557u/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/fi-hsw-4770/igt@[email protected]
- fi-skl-6600u: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/fi-skl-6600u/igt@[email protected]
* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][9] ([fdo#109271] / [i915#4312])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/fi-bsw-nick/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- fi-skl-6600u: [INCOMPLETE][10] -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/fi-skl-6600u/igt@gem_exec_suspend@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/fi-skl-6600u/igt@gem_exec_suspend@[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][12] ([i915#4785]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/fi-hsw-4770/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/fi-hsw-4770/igt@i915_selftest@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][14] ([i915#6298]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [FAIL][16] ([fdo#103375]) -> [INCOMPLETE][17] ([i915#5982])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/fi-rkl-11600/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/fi-rkl-11600/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6217]: https://gitlab.freedesktop.org/drm/intel/issues/6217
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6712]: https://gitlab.freedesktop.org/drm/intel/issues/6712
[i915#6730]: https://gitlab.freedesktop.org/drm/intel/issues/6730
Build changes
-------------
* Linux: CI_DRM_12091 -> Patchwork_106786v8
CI-20190529: 20190529
CI_DRM_12091: 09caa2a40c9e377e8386ffbc48c26884cc4b00bc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6648: 3c9079c0b97445fbfc903b9c5a1d69707b80af80 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106786v8: 09caa2a40c9e377e8386ffbc48c26884cc4b00bc @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
f0101bc5af3a drm/i915/mtl: Do not update GV point, mask value ad92175b102e drm/i915/mtl: Update CHICKEN_TRANS* register addresses fdca83745b26 drm/i915/mtl: Update MBUS_DBOX credits6a36a13ad434 drm/i915/mtl: Obtain SAGV values from MMIO instead of GT pcode mailbox cde9df9c2e8c drm/i915/mtl: Add DP AUX support on TypeC ports 112f495a05ed drm/i915/mtl: Add display power wells9fa1be2c73ec drm/i915/mtl: Add gmbus and gpio support2191842911eb drm/i915/mtl: Define engine context layoutsa8d494d9585c drm/i915: Parse and set stepping for platforms with GMD eee048792c0b drm/i915: Read graphics/media/display arch version from hw 4fcee36d4900 drm/i915: Move display and media IP version to runtime info
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for Initial Meteorlake Support (rev8)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Initial Meteorlake Support (rev8)
URL : https://patchwork.freedesktop.org/series/106786/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12091_full -> Patchwork_106786v8_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_106786v8_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_106786v8_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 11)
------------------------------
Additional (2): shard-rkl shard-tglu
Missing (1): shard-kbl
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_106786v8_full:
### IGT changes ###
#### Possible regressions ####
* igt@perf_pmu@interrupts:
- shard-apl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-apl1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl4/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_12091_full and Patchwork_106786v8_full:
### New IGT tests (146) ###
* igt@feature_discovery@chamelium:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.00] s
* igt@feature_discovery@display:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@feature_discovery@display-2x:
- Statuses : 1 pass(s) 6 skip(s)
- Exec time: [0.0] s
* igt@feature_discovery@display-3x:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@feature_discovery@display-4x:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@feature_discovery@psr1:
- Statuses : 2 pass(s) 4 skip(s)
- Exec time: [0.0] s
* igt@feature_discovery@psr2:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 0.00] s
* igt@gem_exec_fence@invalid-timeline-fence-array:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_exec_fence@syncobj-backward-timeline-chain-engines:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0, 0.14] s
* igt@gem_exec_fence@syncobj-stationary-timeline-chain-engines:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 0.16] s
* igt@gem_exec_fence@syncobj-timeline-chain-engines:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 0.15] s
* igt@gem_exec_fence@syncobj-timeline-export:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_exec_fence@syncobj-timeline-invalid-flags:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@gem_exec_fence@syncobj-timeline-invalid-wait:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_exec_fence@syncobj-timeline-multiple-ext-nodes:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_exec_fence@syncobj-timeline-repeat:
- Statuses : 6 pass(s)
- Exec time: [0.27, 1.39] s
* igt@gem_exec_fence@syncobj-timeline-signal:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_exec_fence@syncobj-timeline-unused-fence:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_exec_fence@syncobj-timeline-wait:
- Statuses : 5 pass(s)
- Exec time: [0.02, 0.04] s
* igt@gem_mmap_offset@blt-coherency:
- Statuses : 6 pass(s)
- Exec time: [0.01, 0.03] s
* igt@i915_selftest@live@slpc:
- Statuses : 5 pass(s)
- Exec time: [0.50, 1.65] s
* igt@kms_writeback@writeback-check-output:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_writeback@writeback-fb-id:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_writeback@writeback-invalid-parameters:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_writeback@writeback-pixel-formats:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@32bits-limit:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@device-signal-unordered:
- Statuses : 6 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@device-submit-unordered:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-available-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-available-unsubmitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-available-unsubmitted-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-unsubmitted-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-unsubmitted-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-unsubmitted-submitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@etime-multi-wait-all-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-for-submit-available-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-for-submit-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-for-submit-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@etime-multi-wait-for-submit-unsubmitted-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-all-for-submit-available-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-all-for-submit-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-all-for-submit-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-all-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-for-submit-available-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-for-submit-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-for-submit-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@host-signal-ordered:
- Statuses : 6 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@host-signal-points:
- Statuses : 6 pass(s)
- Exec time: [0.01, 0.02] s
* igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-all-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-multi-wait-all-unsubmitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@invalid-multi-wait-all-unsubmitted-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-all-unsubmitted-submitted-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-submitted-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-unsubmitted:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-unsubmitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-unsubmitted-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-unsubmitted-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@invalid-query-bad-pad:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-query-illegal-handle:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-query-one-illegal-handle:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-query-zero-handles:
- Statuses : 7 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-signal-bad-pad:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-signal-illegal-handle:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-signal-illegal-point:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-signal-one-illegal-handle:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-signal-zero-handles:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-single-wait-all-available-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-single-wait-all-unsubmitted:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-single-wait-available-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-single-wait-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-transfer-bad-pad:
- Statuses : 7 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-transfer-illegal-handle:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-transfer-non-existent-point:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-wait-bad-flags:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-wait-illegal-handle:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-wait-zero-handles:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@multi-wait-all-available-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-all-available-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-all-available-submitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@multi-wait-all-for-submit-available-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@multi-wait-all-for-submit-available-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@multi-wait-all-for-submit-available-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-all-for-submit-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@multi-wait-all-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-available-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-available-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-available-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@multi-wait-for-submit-available-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-for-submit-available-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-for-submit-available-submitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-available-unsubmitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-for-submit-available-unsubmitted-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@multi-wait-for-submit-available-unsubmitted-submitted-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@multi-wait-for-submit-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-for-submit-submitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-for-submit-unsubmitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-unsubmitted-submitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-submitted-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@reset-during-wait-for-submit:
- Statuses : 6 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@reset-multiple-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@reset-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@reset-unsignaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@signal:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@signal-array:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@signal-point-0:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-available-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-available-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-for-submit-available-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-for-submit-available-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-for-submit-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-available-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-available-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-for-submit-available-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-for-submit-available-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-for-submit-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@transfer-timeline-point:
- Statuses : 6 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@wait-all-complex:
- Statuses : 6 pass(s)
- Exec time: [0.21, 0.22] s
* igt@syncobj_timeline@wait-all-delayed-signal:
- Statuses : 6 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@wait-all-for-submit-complex:
- Statuses : 5 pass(s)
- Exec time: [0.21, 0.22] s
* igt@syncobj_timeline@wait-all-for-submit-delayed-submit:
- Statuses : 7 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@wait-all-for-submit-snapshot:
- Statuses : 6 pass(s)
- Exec time: [0.08, 0.09] s
* igt@syncobj_timeline@wait-all-interrupted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@wait-all-snapshot:
- Statuses : 5 pass(s)
- Exec time: [0.08, 0.09] s
* igt@syncobj_timeline@wait-any-complex:
- Statuses : 6 pass(s)
- Exec time: [0.06, 0.07] s
* igt@syncobj_timeline@wait-any-interrupted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@wait-any-snapshot:
- Statuses : 6 pass(s)
- Exec time: [0.08] s
* igt@syncobj_timeline@wait-delayed-signal:
- Statuses : 6 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@wait-for-submit-complex:
- Statuses : 5 pass(s)
- Exec time: [0.06] s
* igt@syncobj_timeline@wait-for-submit-delayed-submit:
- Statuses : 6 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@wait-for-submit-snapshot:
- Statuses : 5 pass(s)
- Exec time: [0.08] s
Known issues
------------
Here are the changes found in Patchwork_106786v8_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@chamelium (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][3] ([fdo#111827])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-rkl-1/igt@[email protected]
- {shard-tglu}: NOTRUN -> [SKIP][4] ([fdo#111827])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-tglu-5/igt@[email protected]
* igt@feature_discovery@display-2x (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][5] ([i915#1839])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-rkl-2/igt@[email protected]
* igt@feature_discovery@display-4x (NEW):
- {shard-tglu}: NOTRUN -> [SKIP][6] ([i915#1839]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-tglu-4/igt@[email protected]
* igt@feature_discovery@psr2 (NEW):
- {shard-tglu}: NOTRUN -> [SKIP][7] ([i915#658]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-tglu-5/igt@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [PASS][8] -> [FAIL][9] ([i915#6268])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-tglb5/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-tglb2/igt@[email protected]
* igt@gem_ctx_shared@detached-shared-gtt:
- shard-snb: NOTRUN -> [SKIP][10] ([fdo#109271]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-snb4/igt@[email protected]
* igt@gem_eio@kms:
- shard-tglb: [PASS][11] -> [FAIL][12] ([i915#5784])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-tglb7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-tglb3/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][13] -> [SKIP][14] ([i915#4525]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-iclb2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb7/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-glk7/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-glk9/igt@gem_exec_fair@[email protected]
- shard-apl: [PASS][17] -> [FAIL][18] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-apl7/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][19] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb2/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl3/igt@[email protected]
* igt@gem_softpin@evict-single-offset:
- shard-apl: NOTRUN -> [FAIL][21] ([i915#4171])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl4/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][22] -> [SKIP][23] ([i915#4281])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-iclb4/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb3/igt@[email protected]
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3886]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl3/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271]) +64 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl4/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +4 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl4/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#2346]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-glk3/igt@kms_cursor_legacy@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-glk8/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#2672] / [i915#3555])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#3555]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#2672]) +8 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary:
- shard-iclb: [PASS][32] -> [FAIL][33] ([i915#1888] / [i915#2546])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-iclb5/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb2/igt@[email protected]
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [PASS][34] -> [SKIP][35] ([i915#5235]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-iclb6/igt@kms_plane_scaling@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb2/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-apl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#658]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl4/igt@[email protected]
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb7/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [PASS][39] -> [SKIP][40] ([i915#5519])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-iclb7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb8/igt@[email protected]
* igt@kms_writeback@writeback-fb-id (NEW):
- {shard-tglu}: NOTRUN -> [SKIP][41] ([i915#2437]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-tglu-4/igt@[email protected]
* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#2530])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-tglb1/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-apl: [PASS][43] -> [FAIL][44] ([i915#5639])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-apl8/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl6/igt@[email protected]
* igt@sysfs_clients@pidname:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#2994])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl4/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@in-flight-suspend:
- shard-apl: [DMESG-WARN][46] ([i915#180]) -> [PASS][47] +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-apl3/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl3/igt@[email protected]
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][48] ([i915#4525]) -> [PASS][49] +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-iclb7/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb1/igt@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][50] ([i915#2842]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-glk7/igt@gem_exec_fair@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglb: [INCOMPLETE][52] -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-tglb1/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-tglb1/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- shard-glk: [FAIL][54] -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-glk7/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-glk5/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][56] ([i915#3921]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-snb4/igt@i915_selftest@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-snb4/igt@i915_selftest@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][58] ([i915#79]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-glk1/igt@kms_flip@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-glk3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-dp1:
- shard-apl: [FAIL][60] ([i915#79]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-apl4/igt@kms_flip@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl7/igt@kms_flip@[email protected]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][62] ([fdo#109441]) -> [PASS][63] +4 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][64] ([i915#6117]) -> [SKIP][65] ([i915#4525])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-iclb1/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb8/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][66] ([i915#2920]) -> [SKIP][67] ([i915#658])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-iclb2/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-iclb6/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][68], [FAIL][69], [FAIL][70], [FAIL][71], [FAIL][72]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][73], [FAIL][74], [FAIL][75]) ([fdo#109271] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-apl6/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-apl3/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-apl8/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-apl7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12091/shard-apl1/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl8/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl6/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/shard-apl2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4941]: https://gitlab.freedesktop.org/drm/intel/issues/4941
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12091 -> Patchwork_106786v8
CI-20190529: 20190529
CI_DRM_12091: 09caa2a40c9e377e8386ffbc48c26884cc4b00bc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6648: 3c9079c0b97445fbfc903b9c5a1d69707b80af80 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106786v8: 09caa2a40c9e377e8386ffbc48c26884cc4b00bc @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106786v8/index.html