net: sparx5: fix function return type to match actual type
Subsystems (3)
PATCH v2 1/1 net: sparx5: fix function return type to match actual type
Function returns error integer, not bool.
Does not have any impact on functionality.
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Casper Andersson <[email protected]>
---
Sorry Dan, I forgot to include you in the first version.
drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c | 4 ++-- drivers/net/ethernet/microchip/sparx5/sparx5_main.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c +2 -2
@@ -186,8 +186,8 @@ bool sparx5_mact_getnext(struct sparx5 *sparx5,return ret ==0 ; } -bool sparx5_mact_find (struct sparx5 *sparx5, -const unsigned char mac[ETH_ALEN ],u16 vid,u32 *pcfg2) +int sparx5_mact_find (struct sparx5 *sparx5, +const unsigned char mac[ETH_ALEN ],u16 vid,u32 *pcfg2) {int ret;u32 cfg2;
drivers/net/ethernet/microchip/sparx5/sparx5_main.h +2 -2
@@ -321,8 +321,8 @@ int sparx5_mact_learn(struct sparx5 *sparx5, int port, const unsigned char mac[ETH_ALEN], u16 vid);bool sparx5_mact_getnext (struct sparx5 *sparx5,unsigned char mac[ETH_ALEN ],u16 *vid,u32 *pcfg2); -bool sparx5_mact_find (struct sparx5 *sparx5, -const unsigned char mac[ETH_ALEN ],u16 vid,u32 *pcfg2); +int sparx5_mact_find (struct sparx5 *sparx5, +const unsigned char mac[ETH_ALEN ],u16 vid,u32 *pcfg2);int sparx5_mact_forget (struct sparx5 *sparx5,const unsigned char mac[ETH_ALEN ],u16 vid); int sparx5_add_mact_entry(struct sparx5 *sparx5,
Signature · 1 line
2.34.1
Quoted 6 lines · Casper Andersson
Function returns error integer, not bool.
Does not have any impact on functionality.
Reported-by Dan Carpenter <[email protected]>Signed-off-by Casper Andersson <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>
Andrew
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:
Quoted 8 lines · On Tue, 6 Sep 2022 08:58:15 +0200 you wrote:
Function returns error integer, not bool.
Does not have any impact on functionality.
Reported-by Dan Carpenter <[email protected]>Signed-off-by Casper Andersson <[email protected]>[...]
Here is the summary with links:
- [v2,net-next] net: sparx5: fix function return type to match actual type
https://git.kernel.org/netdev/net-next/c/75554fe00f94
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html