Skip to contentSkip to conversation

net: sparx5: fix function return type to match actual type

PATCH Applied Casper Andersson 3 participants 3 messages Sep 6, 2022 – Sep 8, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: sparx5: fix function return type to match actual type

Function returns error integer, not bool.

Does not have any impact on functionality.

---
Sorry Dan, I forgot to include you in the first version.

 drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c | 4 ++--
 drivers/net/ethernet/microchip/sparx5/sparx5_main.h     | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c +2 -2
index a5837dbe0c7e..4af285918ea2 100644
@@ -186,8 +186,8 @@ bool sparx5_mact_getnext(struct sparx5 *sparx5,
 	return ret == 0;
 }
 
-bool sparx5_mact_find(struct sparx5 *sparx5,
-		      const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2)
+int sparx5_mact_find(struct sparx5 *sparx5,
+		     const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2)
 {
 	int ret;
 	u32 cfg2;
drivers/net/ethernet/microchip/sparx5/sparx5_main.h +2 -2
index 9b4395b7a9e4..8b42cad0e49c 100644
@@ -321,8 +321,8 @@ int sparx5_mact_learn(struct sparx5 *sparx5, int port,
 		      const unsigned char mac[ETH_ALEN], u16 vid);
 bool sparx5_mact_getnext(struct sparx5 *sparx5,
 			 unsigned char mac[ETH_ALEN], u16 *vid, u32 *pcfg2);
-bool sparx5_mact_find(struct sparx5 *sparx5,
-		      const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2);
+int sparx5_mact_find(struct sparx5 *sparx5,
+		     const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2);
 int sparx5_mact_forget(struct sparx5 *sparx5,
 		       const unsigned char mac[ETH_ALEN], u16 vid);
 int sparx5_add_mact_entry(struct sparx5 *sparx5,
Signature · 1 line
2.34.1
#2 lore raw
In reply to Casper Andersson
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Tue, 6 Sep 2022 08:58:15 +0200 you wrote:

Function returns error integer, not bool.

Does not have any impact on functionality.

[...]

Here is the summary with links:
- [v2,net-next] net: sparx5: fix function return type to match actual type

    https://git.kernel.org/netdev/net-next/c/75554fe00f94

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html