pinctrl: microchip-sgpio: Correct the fwnode_irq_get() return value check
Subsystems (3)
PATCH v2 1/1 pinctrl: microchip-sgpio: Correct the fwnode_irq_get() return value check
fwnode_irq_get() may return all possible signed values, such as Linux error code. Fix the code to handle this properly.
Fixes be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq support (for sparx5)")
Signed-off-by Andy Shevchenko <[email protected]>
Reviewed-by Michael Walle <[email protected]>
---
v2: added tag (Michael), fixed typo in the Subject
drivers/pinctrl/pinctrl-microchip-sgpio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pinctrl/pinctrl-microchip-sgpio.c +3 -2
@@ -864,9 +864,10 @@ static int microchip_sgpio_register_bank(struct device *dev, gc->can_sleep = !bank->is_input;if (bank->is_input && priv->properties->flags &SGPIO_FLAGS_HAS_IRQ ) { -int irq =fwnode_irq_get (fwnode,0 ); +int irq; -if (irq) { + irq =fwnode_irq_get (fwnode,0 ); +if (irq >0 ) {struct gpio_irq_chip *girq = &gc->irq;gpio_irq_chip_set_chip (girq, µchip_sgpio_irqchip);
Signature · 1 line
2.35.1
Quoted 6 lines · Andy Shevchenko
fwnode_irq_get()may return all possible signed values, such as Linux error code. Fix the code to handle this properly.Fixes be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq support (for sparx5)")Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Michael Walle <[email protected]>
Patch applied.
Yours,
Linus Walleij