mfd: intel_soc_pmic_chtdc_ti: Switch from __maybe_unused to pm_sleep_ptr() etc
PATCH RESEND 1/1 mfd: intel_soc_pmic_chtdc_ti: Switch from __maybe_unused to pm_sleep_ptr() etc
Letting the compiler remove these functions when the kernel is built without CONFIG_PM_SLEEP support is simpler and less heavier for builds than the use of __maybe_unused attributes.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/mfd/intel_soc_pmic_chtdc_ti.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/mfd/intel_soc_pmic_chtdc_ti.c +4 -4
@@ -140,7 +140,7 @@ static void chtdc_ti_shutdown(struct i2c_client *i2c)disable_irq (pmic->irq); } -static int __maybe_unused chtdc_ti_suspend (struct device *dev) +static int chtdc_ti_suspend (struct device *dev) {struct intel_soc_pmic *pmic =dev_get_drvdata (dev);
@@ -149,7 +149,7 @@ static int __maybe_unused chtdc_ti_suspend(struct device *dev)return 0 ; } -static int __maybe_unused chtdc_ti_resume (struct device *dev) +static int chtdc_ti_resume (struct device *dev) {struct intel_soc_pmic *pmic =dev_get_drvdata (dev);
@@ -158,7 +158,7 @@ static int __maybe_unused chtdc_ti_resume(struct device *dev)return 0 ; } -static SIMPLE_DEV_PM_OPS(chtdc_ti_pm_ops, chtdc_ti_suspend, chtdc_ti_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(chtdc_ti_pm_ops, chtdc_ti_suspend, chtdc_ti_resume);static const struct acpi_device_id chtdc_ti_acpi_ids[] = { {"INT33F5" },
@@ -169,7 +169,7 @@ MODULE_DEVICE_TABLE(acpi, chtdc_ti_acpi_ids);static struct i2c_driver chtdc_ti_i2c_driver = { .driver = { .name ="intel_soc_pmic_chtdc_ti" , - .pm = &chtdc_ti_pm_ops, + .pm =pm_sleep_ptr (&chtdc_ti_pm_ops), .acpi_match_table = chtdc_ti_acpi_ids, }, .probe_new = chtdc_ti_probe,
Signature · 1 line
2.35.1
Quoted 8 lines · Andy Shevchenko
Letting the compiler remove these functions when the kernel is built without
CONFIG_PM_SLEEPsupport is simpler and less heavier for builds than the use of__maybe_unusedattributes.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/mfd/intel_soc_pmic_chtdc_ti.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
Signature · 1 line
Lee Jones [李琼斯]