mm/damon: Simply damon_ctx check in damon_sysfs_before_terminate
Subsystems (2)
PATCH 1/1 mm/damon: Simply damon_ctx check in damon_sysfs_before_terminate
In damon_sysfs_before_terminate() func, it need to check whether ctx->ops.id supports 'DAMON_OPS_VADDR' or 'DAMON_OPS_FVADDR', there we can use damon_target_has_pid() instead.
Signed-off-by Xin Hao <[email protected]>
--- mm/damon/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/damon/sysfs.c +1 -1
@@ -2309,7 +2309,7 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx) {struct damon_target *t, *next; -if (ctx->ops.id !=DAMON_OPS_VADDR && ctx->ops.id !=DAMON_OPS_FVADDR ) +if (!damon_target_has_pid (ctx))return ;mutex_lock (&ctx->kdamond_lock);
Signature · 1 line
2.31.0
Hi Xin,
Nit: I'd suggest to 's/Simply/simplify/' in the subject.
Quoted 5 lines · On Wed, 7 Sep 2022 16:41:16 +0800 Xin Hao <[email protected]> wrote:
In
damon_sysfs_before_terminate()func, it need to check whetherctx->ops.idsupports 'DAMON_OPS_VADDR' or 'DAMON_OPS_FVADDR', there we can usedamon_target_has_pid()instead.Signed-off-by Xin Hao <[email protected]>
Other than the above trivial nit,
Reviewed-by SeongJae Park <[email protected]>
Thanks,
SJ
Quoted 19 lines
--- mm/damon/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/damon/sysfs.c +1
-1@@ -2309,7 +2309,7 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx) {struct damon_target *t, *next; -if (ctx->ops.id !=DAMON_OPS_VADDR && ctx->ops.id !=DAMON_OPS_FVADDR ) +if (!damon_target_has_pid (ctx))return ;mutex_lock (&ctx->kdamond_lock);Signature · 1 line
2.31.0