Skip to contentSkip to conversation

driver: of: overlay: demote message to warning

PATCH NAK Daniel Walker 3 participants 13 messages Sep 7, 2022 – Sep 26, 2022 Device tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 driver: of: overlay: demote message to warning

This warning message shows by default on the vast majority of overlays applied. Despite the text identifying this as a warning it is marked with the loglevel for error. At Cisco we filter the loglevels to only show error messages. We end up seeing this message but it's not really an error.

For this reason it makes sense to demote the message to the warning loglevel.

---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/overlay.c +1 -1
index bd8ff4df723d..4ae276ed9a65 100644
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {
Signature · 1 line
2.25.1
#1 lore raw
Quoted 20 lines · Daniel Walker

This warning message shows by default on the vast majority of overlays applied. Despite the text identifying this as a warning it is marked with the loglevel for error. At Cisco we filter the loglevels to only show error messages. We end up seeing this message but it's not really an error.

For this reason it makes sense to demote the message to the warning loglevel.

---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/overlay.c +0 -0
index bd8ff4df723d..4ae276ed9a65 100644

drivers/of/overlay.c static int add_changeset_property(struct overlay_changeset *ovcs, · line 364

Quoted 8 lines
drivers/of/overlay.c +1 -1
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {

NACK

This is showing a real problem with the overlay.

-Frank

#2 lore raw
Quoted 28 lines · Frank Rowand
Quoted 27 lines · Daniel Walker

This warning message shows by default on the vast majority of overlays applied. Despite the text identifying this as a warning it is marked with the loglevel for error. At Cisco we filter the loglevels to only show error messages. We end up seeing this message but it's not really an error.

For this reason it makes sense to demote the message to the warning loglevel.

---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/overlay.c +1 -1
index bd8ff4df723d..4ae276ed9a65 100644
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
Quoted 5 lines

drivers/of/overlay.c static int add_changeset_property(struct overlay_changeset *ovcs, · line 364

Quoted 1 line
drivers/of/overlay.c +0 -0
 	if (ret) {

NACK

This is showing a real problem with the overlay.

What's the real problem ?

Daniel

#3 lore raw
Quoted 33 lines · Daniel Walker
Quoted 32 lines · Frank Rowand
Quoted 20 lines · Daniel Walker

This warning message shows by default on the vast majority of overlays applied. Despite the text identifying this as a warning it is marked with the loglevel for error. At Cisco we filter the loglevels to only show error messages. We end up seeing this message but it's not really an error.

For this reason it makes sense to demote the message to the warning loglevel.

---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/overlay.c +0 -0
index bd8ff4df723d..4ae276ed9a65 100644

drivers/of/overlay.c static int add_changeset_property(struct overlay_changeset *ovcs, · line 364

Quoted 8 lines
drivers/of/overlay.c +1 -1
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {

NACK

Quoted 5 lines
Quoted 1 line

This is showing a real problem with the overlay.

What's the real problem ?

Daniel

A memory leak when the overlay is removed.

I'll send a patch to update the overlay file in Documumentation/devicetree/ to provide more information about this. If you don't see a patch by tomorrow, feel free to ping me.

-Frank

#4 lore raw
Quoted 40 lines · Frank Rowand
Quoted 33 lines · Daniel Walker
Quoted 32 lines · Frank Rowand
Quoted 20 lines · Daniel Walker

This warning message shows by default on the vast majority of overlays applied. Despite the text identifying this as a warning it is marked with the loglevel for error. At Cisco we filter the loglevels to only show error messages. We end up seeing this message but it's not really an error.

For this reason it makes sense to demote the message to the warning loglevel.

---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/overlay.c +0 -0
index bd8ff4df723d..4ae276ed9a65 100644

drivers/of/overlay.c static int add_changeset_property(struct overlay_changeset *ovcs, · line 364

Quoted 8 lines
drivers/of/overlay.c +1 -1
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {

NACK

Quoted 5 lines
Quoted 1 line

This is showing a real problem with the overlay.

What's the real problem ?

Daniel

Quoted 7 lines

A memory leak when the overlay is removed.

I'll send a patch to update the overlay file in Documumentation/devicetree/ to provide more information about this. If you don't see a patch by tomorrow, feel free to ping me.

-Frank

The good news is that your question prodded me to start improving the in kernel documentation of overlays. The promised patch is a rough start at:

https://lore.kernel.org/all/[email protected]/

The bad news is that what I wrote doesn't explain the memory leak in any more detail. If an overlay adds a property to a node in the base device tree then the memory allocated to do the add will not be freed when the overlay is removed. Since it is possible to add and remove overlays multiple times, the ensuing size of the memory leak is potentially unbounded.

-Frank

#5 lore raw
Quoted 52 lines · Frank Rowand
Quoted 40 lines · Frank Rowand
Quoted 33 lines · Daniel Walker
Quoted 32 lines · Frank Rowand
Quoted 20 lines · Daniel Walker

This warning message shows by default on the vast majority of overlays applied. Despite the text identifying this as a warning it is marked with the loglevel for error. At Cisco we filter the loglevels to only show error messages. We end up seeing this message but it's not really an error.

For this reason it makes sense to demote the message to the warning loglevel.

---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/overlay.c +0 -0
index bd8ff4df723d..4ae276ed9a65 100644

drivers/of/overlay.c static int add_changeset_property(struct overlay_changeset *ovcs, · line 364

Quoted 8 lines
drivers/of/overlay.c +1 -1
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {

NACK

Quoted 5 lines
Quoted 1 line

This is showing a real problem with the overlay.

What's the real problem ?

Daniel

Quoted 7 lines

A memory leak when the overlay is removed.

I'll send a patch to update the overlay file in Documumentation/devicetree/ to provide more information about this. If you don't see a patch by tomorrow, feel free to ping me.

-Frank

The good news is that your question prodded me to start improving the in kernel documentation of overlays. The promised patch is a rough start at:

Quoted 7 lines
   https://lore.kernel.org/all/[email protected]/

The bad news is that what I wrote doesn't explain the memory leak in any more detail. If an overlay adds a property to a node in the base device tree then the memory allocated to do the add will not be freed when the overlay is removed. Since it is possible to add and remove overlays multiple times, the ensuing size of the memory leak is potentially unbounded.

Isn't this only a problem if you remove the overlay?

if the dt fixup driver does have the ability to remove the overlay doesn't it have responsibility to free the memory? Or is it impossible to free the memory?

Daniel

#6 lore raw
Quoted 55 lines · Daniel Walker
Quoted 54 lines · Frank Rowand
Quoted 40 lines · Frank Rowand
Quoted 33 lines · Daniel Walker
Quoted 32 lines · Frank Rowand
Quoted 20 lines · Daniel Walker

This warning message shows by default on the vast majority of overlays applied. Despite the text identifying this as a warning it is marked with the loglevel for error. At Cisco we filter the loglevels to only show error messages. We end up seeing this message but it's not really an error.

For this reason it makes sense to demote the message to the warning loglevel.

---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/overlay.c +0 -0
index bd8ff4df723d..4ae276ed9a65 100644

drivers/of/overlay.c static int add_changeset_property(struct overlay_changeset *ovcs, · line 364

Quoted 8 lines
drivers/of/overlay.c +1 -1
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {

NACK

Quoted 5 lines
Quoted 1 line

This is showing a real problem with the overlay.

What's the real problem ?

Daniel

Quoted 7 lines

A memory leak when the overlay is removed.

I'll send a patch to update the overlay file in Documumentation/devicetree/ to provide more information about this. If you don't see a patch by tomorrow, feel free to ping me.

-Frank

The good news is that your question prodded me to start improving the in kernel documentation of overlays. The promised patch is a rough start at:

   https://lore.kernel.org/all/[email protected]/
Quoted 7 lines
Quoted 5 lines

The bad news is that what I wrote doesn't explain the memory leak in any more detail. If an overlay adds a property to a node in the base device tree then the memory allocated to do the add will not be freed when the overlay is removed. Since it is possible to add and remove overlays multiple times, the ensuing size of the memory leak is potentially unbounded.

Isn't this only a problem if you remove the overlay?

Yes, but we don't know if the overlay will be removed. And I will not accept a change that suppresses the message if there is no expectation to remove the overlay.

Quoted 3 lines

if the dt fixup driver does have the ability to remove the overlay doesn't it have responsibility to free the memory? Or is it impossible to free the memory?

It is difficult due to architectural issues. Reference counting occurs at the node level, and not at the property level. So memory related to properties is freed when the corresponding overlay node reference count leads to the node being freed.

Quoted 2 lines

Daniel

#7 lore raw
Quoted 62 lines · Frank Rowand
Quoted 61 lines · Daniel Walker
Quoted 59 lines · Frank Rowand
Quoted 40 lines · Frank Rowand
Quoted 33 lines · Daniel Walker
Quoted 32 lines · Frank Rowand
Quoted 20 lines · Daniel Walker

This warning message shows by default on the vast majority of overlays applied. Despite the text identifying this as a warning it is marked with the loglevel for error. At Cisco we filter the loglevels to only show error messages. We end up seeing this message but it's not really an error.

For this reason it makes sense to demote the message to the warning loglevel.

---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/overlay.c +0 -0
index bd8ff4df723d..4ae276ed9a65 100644

drivers/of/overlay.c static int add_changeset_property(struct overlay_changeset *ovcs, · line 364

Quoted 8 lines
drivers/of/overlay.c +1 -1
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {

NACK

Quoted 5 lines
Quoted 1 line

This is showing a real problem with the overlay.

What's the real problem ?

Daniel

Quoted 7 lines

A memory leak when the overlay is removed.

I'll send a patch to update the overlay file in Documumentation/devicetree/ to provide more information about this. If you don't see a patch by tomorrow, feel free to ping me.

-Frank

The good news is that your question prodded me to start improving the in kernel documentation of overlays. The promised patch is a rough start at:

   https://lore.kernel.org/all/[email protected]/

The bad news is that what I wrote doesn't explain the memory leak in any more detail. If an overlay adds a property to a node in the base device tree then the memory allocated to do the add will not be freed when the overlay is removed. Since it is possible to add and remove overlays multiple times, the ensuing size of the memory leak is potentially unbounded.

Quoted 5 lines
Quoted 1 line

Isn't this only a problem if you remove the overlay?

Yes, but we don't know if the overlay will be removed. And I will not accept a change that suppresses the message if there is no expectation to remove the overlay.

I haven't researched the whole overlay system but there was one removal function that I noted, I think in the link you provided above, called of_overlay_remove(). It appears to call free_overlay_changeset() which calls kfree().

so your API seems to deal with freeing the memory. I would think the expectation is that people using the API would free the overlay thru your API.

The only in tree usage of your API (besides the unit test) was drm/rcar-du which had no ability to remove the overlay that I can see. That component of the driver was removed several months ago.

Quoted 7 lines
Quoted 3 lines

if the dt fixup driver does have the ability to remove the overlay doesn't it have responsibility to free the memory? Or is it impossible to free the memory?

It is difficult due to architectural issues. Reference counting occurs at the node level, and not at the property level. So memory related to properties is freed when the corresponding overlay node reference count leads to the node being freed.

How does of_overlay_remove() work then? It seems like it might not be possible to do overlay removal, but your code has removal functions. I also see this one of_overlay_remove_all() ..

It seems like your API supports removal. Is there an issue where your API is maybe not complete or maybe doesn't currentily work ?

Maybe you could add a flag or other indicator which would indicate the overlay will never be removed. Then your code could rely on this property to inform on if the author has consider the removal issues related to overlays.

Daniel

#8 lore raw
Quoted 65 lines · Daniel Walker
Quoted 64 lines · Frank Rowand
Quoted 62 lines · Daniel Walker
Quoted 52 lines · Frank Rowand
Quoted 40 lines · Frank Rowand
Quoted 33 lines · Daniel Walker
Quoted 32 lines · Frank Rowand
Quoted 20 lines · Daniel Walker

This warning message shows by default on the vast majority of overlays applied. Despite the text identifying this as a warning it is marked with the loglevel for error. At Cisco we filter the loglevels to only show error messages. We end up seeing this message but it's not really an error.

For this reason it makes sense to demote the message to the warning loglevel.

---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/overlay.c +0 -0
index bd8ff4df723d..4ae276ed9a65 100644

drivers/of/overlay.c static int add_changeset_property(struct overlay_changeset *ovcs, · line 364

Quoted 8 lines
drivers/of/overlay.c +1 -1
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {

NACK

Quoted 5 lines
Quoted 1 line

This is showing a real problem with the overlay.

What's the real problem ?

Daniel

Quoted 7 lines

A memory leak when the overlay is removed.

I'll send a patch to update the overlay file in Documumentation/devicetree/ to provide more information about this. If you don't see a patch by tomorrow, feel free to ping me.

-Frank

The good news is that your question prodded me to start improving the in kernel documentation of overlays. The promised patch is a rough start at:

Quoted 7 lines
   https://lore.kernel.org/all/[email protected]/

The bad news is that what I wrote doesn't explain the memory leak in any more detail. If an overlay adds a property to a node in the base device tree then the memory allocated to do the add will not be freed when the overlay is removed. Since it is possible to add and remove overlays multiple times, the ensuing size of the memory leak is potentially unbounded.

Isn't this only a problem if you remove the overlay?

Quoted 7 lines
Quoted 3 lines

Yes, but we don't know if the overlay will be removed. And I will not accept a change that suppresses the message if there is no expectation to remove the overlay.

I haven't researched the whole overlay system but there was one removal function that I noted, I think in the link you provided above, called of_overlay_remove(). It appears to call free_overlay_changeset() which calls kfree().

free_overlay_changeset() frees data structures related to the changeset. It does not free memory allocated to the devicetree. The memory allocated to the devicetree is freed as a result of the decreasing reference counts on the devicetree data.

Quoted 3 lines

so your API seems to deal with freeing the memory. I would think the expectation is that people using the API would free the overlay thru your API.

Yes, the way to remove an overlay is of_overlay_remove() or of_overlay_remove_all().

Quoted 4 lines

The only in tree usage of your API (besides the unit test) was drm/rcar-du which had no ability to remove the overlay that I can see. That component of the driver was removed several months ago.

rcar was an early overlay use that was grandfathered in for a long time until we were finally able to remove it. It was not a model for how to use overlays.

Quoted 9 lines
Quoted 8 lines
Quoted 4 lines

if the dt fixup driver does have the ability to remove the overlay doesn't it have responsibility to free the memory? Or is it impossible to free the memory?

It is difficult due to architectural issues. Reference counting occurs at the node level, and not at the property level. So memory related to properties is freed when the corresponding overlay node reference count leads to the node being freed.

Quoted 6 lines

How does of_overlay_remove() work then? It seems like it might not be possible to do overlay removal, but your code has removal functions. I also see this one of_overlay_remove_all() ..

It seems like your API supports removal. Is there an issue where your API is maybe not complete or maybe doesn't currentily work ?

The overlay implementation is definitely not complete. For some details please see:

https://elinux.org/Device_Tree_Reference#Overlays

and:

https://elinux.org/Frank%27s_Evolving_Overlay_Thoughts

If you have not read those two links recently, _please_ read them for a better understanding of the state of overlay implementation!

Quoted 4 lines

Maybe you could add a flag or other indicator which would indicate the overlay will never be removed. Then your code could rely on this property to inform on if the author has consider the removal issues related to overlays.

No. I guess I wasn't clear enough above, where I said:

"And I will not accept a
change that suppresses the message if there is no expectation to remove the overlay."

There are multiple reasons for this, but the most fundamental is that if a new overlay is not removable, then any overlay already applied can not be removed (because overlays must be removed in the reverse order that they are applied). It would be incredibly bad architecture to allow an overlay to block another overlay from being removed.

-Frank

Quoted 2 lines

Daniel

#9 lore raw
Quoted 11 lines · Frank Rowand
Quoted 4 lines

Maybe you could add a flag or other indicator which would indicate the overlay will never be removed. Then your code could rely on this property to inform on if the author has consider the removal issues related to overlays.

No. I guess I wasn't clear enough above, where I said:

"And I will not accept a
change that suppresses the message if there is no expectation to remove the overlay."

Quoted 5 lines

There are multiple reasons for this, but the most fundamental is that if a new overlay is not removable, then any overlay already applied can not be removed (because overlays must be removed in the reverse order that they are applied). It would be incredibly bad architecture to allow an overlay to block another overlay from being removed.

So how about an option to turn off removable overlays entirely? As far as I can tell it's not used currently by the tiny number of implementation I've seen.

Cisco doesn't need it, and we could have a smaller kernel without it.

The issue is that the error log on blast is log level abuse in my opinion. If there's no way to fix it, it should not be an error.

Daniel

#10 lore raw
Quoted 18 lines · Daniel Walker
Quoted 11 lines · Frank Rowand
Quoted 4 lines

Maybe you could add a flag or other indicator which would indicate the overlay will never be removed. Then your code could rely on this property to inform on if the author has consider the removal issues related to overlays.

No. I guess I wasn't clear enough above, where I said:

"And I will not accept a
change that suppresses the message if there is no expectation to remove the overlay."

Quoted 5 lines

There are multiple reasons for this, but the most fundamental is that if a new overlay is not removable, then any overlay already applied can not be removed (because overlays must be removed in the reverse order that they are applied). It would be incredibly bad architecture to allow an overlay to block another overlay from being removed.

Quoted 7 lines

So how about an option to turn off removable overlays entirely? As far as I can tell it's not used currently by the tiny number of implementation I've seen.

Cisco doesn't need it, and we could have a smaller kernel without it.

The issue is that the error log on blast is log level abuse in my opinion. If there's no way to fix it, it should not be an error.

The way to fix it is to not have a construct in the overlay that triggers the message. In other words, do not add a property to a pre-existing node. (At least I think that is what is the underlying cause, if I recall correctly.)

-Frank

Quoted 2 lines

Daniel

#11 lore raw
Quoted 24 lines · Frank Rowand
Quoted 23 lines · Daniel Walker
Quoted 11 lines · Frank Rowand
Quoted 4 lines

Maybe you could add a flag or other indicator which would indicate the overlay will never be removed. Then your code could rely on this property to inform on if the author has consider the removal issues related to overlays.

No. I guess I wasn't clear enough above, where I said:

"And I will not accept a
change that suppresses the message if there is no expectation to remove the overlay."

Quoted 5 lines

There are multiple reasons for this, but the most fundamental is that if a new overlay is not removable, then any overlay already applied can not be removed (because overlays must be removed in the reverse order that they are applied). It would be incredibly bad architecture to allow an overlay to block another overlay from being removed.

So how about an option to turn off removable overlays entirely? As far as I can tell it's not used currently by the tiny number of implementation I've seen.

Cisco doesn't need it, and we could have a smaller kernel without it.

Quoted 8 lines
Quoted 2 lines

The issue is that the error log on blast is log level abuse in my opinion. If there's no way to fix it, it should not be an error.

The way to fix it is to not have a construct in the overlay that triggers the message. In other words, do not add a property to a pre-existing node. (At least I think that is what is the underlying cause, if I recall correctly.)

-Frank

Here's the check,

if (!of_node_check_flag(target->np, OF_OVERLAY))

If the print shows when the modifications is made to a non-overlay, I'm not sure how you could construct a device tree where you only modify other overlays.

It seems like this should print on the vast majority of overlays.

Daniel

#12 lore raw
Quoted 35 lines · Daniel Walker
Quoted 24 lines · Frank Rowand
Quoted 23 lines · Daniel Walker
Quoted 11 lines · Frank Rowand
Quoted 4 lines

Maybe you could add a flag or other indicator which would indicate the overlay will never be removed. Then your code could rely on this property to inform on if the author has consider the removal issues related to overlays.

No. I guess I wasn't clear enough above, where I said:

"And I will not accept a
change that suppresses the message if there is no expectation to remove the overlay."

Quoted 5 lines

There are multiple reasons for this, but the most fundamental is that if a new overlay is not removable, then any overlay already applied can not be removed (because overlays must be removed in the reverse order that they are applied). It would be incredibly bad architecture to allow an overlay to block another overlay from being removed.

So how about an option to turn off removable overlays entirely? As far as I can tell it's not used currently by the tiny number of implementation I've seen.

Cisco doesn't need it, and we could have a smaller kernel without it.

Quoted 8 lines
Quoted 2 lines

The issue is that the error log on blast is log level abuse in my opinion. If there's no way to fix it, it should not be an error.

The way to fix it is to not have a construct in the overlay that triggers the message. In other words, do not add a property to a pre-existing node. (At least I think that is what is the underlying cause, if I recall correctly.)

-Frank

Quoted 8 lines

Here's the check,

if (!of_node_check_flag(target->np, OF_OVERLAY))

If the print shows when the modifications is made to a non-overlay, I'm not sure how you could construct a device tree where you only modify other overlays.

It seems like this should print on the vast majority of overlays.

There is essentially zero support in the kernel for nodes to change once they are in use (typ. bound to a driver), and I don't see us ever supporting that use case. Unless shown otherwise, I don't think that is a good split between a base DT and overlay either.

What I've said multiple times for supporting runtime overlays, is that it needs to be restricted to adding/removing whole nodes/subtrees.

Rob