Skip to contentSkip to conversation

Add DISPCC driver for SM6115

PATCH Applied Adam Skladowski 3 participants 6 messages Sep 11, 2022 – Sep 27, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v3 cover Add DISPCC driver for SM6115

This patch series introduce support for SM6115 display clock controller, this driver is based on QCM2290 one.

Changes since v1
================
1. Changed bindings file names to Vendor,SoC-IP format.
2. Changed include in dispcc-sm6115 to reflect name change of bindings.

Changes since v2
================
1. Changed maintainer email.
2. Converted driver to use .index instead of fw_name.
3. Removed parents which had no passed clock.
4. Updated YAML to reflect changes above.
5. Adjusted driver based on Bjorn's feedback.

Adam Skladowski (2):
dt-bindings: clock: add QCOM SM6115 display clock bindings
clk: qcom: Add display clock controller driver for SM6115

 .../bindings/clock/qcom,sm6115-dispcc.yaml    |  70 ++
 drivers/clk/qcom/Kconfig                      |   9 +
 drivers/clk/qcom/Makefile                     |   1 +
 drivers/clk/qcom/dispcc-sm6115.c              | 608 ++++++++++++++++++
 .../dt-bindings/clock/qcom,sm6115-dispcc.h    |  36 ++
 5 files changed, 724 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
 create mode 100644 drivers/clk/qcom/dispcc-sm6115.c
 create mode 100644 include/dt-bindings/clock/qcom,sm6115-dispcc.h
Signature · 1 line
2.25.1
#1 lore raw

PATCH v3 1/2 dt-bindings: clock: add QCOM SM6115 display clock bindings

Add device tree bindings for display clock controller for Qualcomm Technology Inc's SM6115 SoC.

---
 .../bindings/clock/qcom,sm6115-dispcc.yaml    | 70 +++++++++++++++++++
 .../dt-bindings/clock/qcom,sm6115-dispcc.h    | 36 ++++++++++
 2 files changed, 106 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
 create mode 100644 include/dt-bindings/clock/qcom,sm6115-dispcc.h
Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml new file +70 -0
new file mode 100644
index 000000000000..a6bf363b5015
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,sm6115-dispcc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Display Clock Controller Binding for SM6115
+
+maintainers:
+  - Bjorn Andersson <[email protected]>
+
+description: |
+  Qualcomm display clock control module which supports the clocks and
+  power domains on SM6115.
+
+  See also:
+    dt-bindings/clock/qcom,sm6115-dispcc.h
+
+properties:
+  compatible:
+    enum:
+      - qcom,sm6115-dispcc
+
+  clocks:
+    items:
+      - description: Board XO source
+      - description: Board sleep clock
+      - description: Byte clock from DSI PHY0
+      - description: Pixel clock from DSI PHY0
+      - description: GPLL0 DISP DIV clock from GCC
+
+  '#clock-cells':
+    const: 1
+
+  '#reset-cells':
+    const: 1
+
+  '#power-domain-cells':
+    const: 1
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - '#clock-cells'
+  - '#reset-cells'
+  - '#power-domain-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/qcom,rpmcc.h>
+    #include <dt-bindings/clock/qcom,gcc-sm6115.h>
+    clock-controller@5f00000 {
+      compatible = "qcom,sm6115-dispcc";
+      reg = <0x5f00000 0x20000>;
+      clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>,
+               <&sleep_clk>,
+               <&dsi0_phy 0>,
+               <&dsi0_phy 1>,
+               <&gcc GCC_DISP_GPLL0_DIV_CLK_SRC>;
+      #clock-cells = <1>;
+      #reset-cells = <1>;
+      #power-domain-cells = <1>;
+    };
+...
include/dt-bindings/clock/qcom,sm6115-dispcc.h new file +36 -0
new file mode 100644
index 000000000000..d1a6c45b5029
@@ -0,0 +1,36 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) 2022, The Linux Foundation. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_CLK_QCOM_DISP_CC_SM6115_H
+#define _DT_BINDINGS_CLK_QCOM_DISP_CC_SM6115_H
+
+/* DISP_CC clocks */
+#define DISP_CC_PLL0			0
+#define DISP_CC_PLL0_OUT_MAIN		1
+#define DISP_CC_MDSS_AHB_CLK		2
+#define DISP_CC_MDSS_AHB_CLK_SRC	3
+#define DISP_CC_MDSS_BYTE0_CLK		4
+#define DISP_CC_MDSS_BYTE0_CLK_SRC	5
+#define DISP_CC_MDSS_BYTE0_DIV_CLK_SRC	6
+#define DISP_CC_MDSS_BYTE0_INTF_CLK	7
+#define DISP_CC_MDSS_ESC0_CLK		8
+#define DISP_CC_MDSS_ESC0_CLK_SRC	9
+#define DISP_CC_MDSS_MDP_CLK		10
+#define DISP_CC_MDSS_MDP_CLK_SRC	11
+#define DISP_CC_MDSS_MDP_LUT_CLK	12
+#define DISP_CC_MDSS_NON_GDSC_AHB_CLK	13
+#define DISP_CC_MDSS_PCLK0_CLK		14
+#define DISP_CC_MDSS_PCLK0_CLK_SRC	15
+#define DISP_CC_MDSS_ROT_CLK		16
+#define DISP_CC_MDSS_ROT_CLK_SRC	17
+#define DISP_CC_MDSS_VSYNC_CLK		18
+#define DISP_CC_MDSS_VSYNC_CLK_SRC	19
+#define DISP_CC_SLEEP_CLK		20
+#define DISP_CC_SLEEP_CLK_SRC		21
+
+/* DISP_CC GDSCR */
+#define MDSS_GDSC			0
+
+#endif
Signature · 1 line
2.25.1
maintainer Reviewed-by on v3 1/2
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: clock: add QCOM SM6115 display clock bindings

Quoted 17 lines · Adam Skladowski

Add device tree bindings for display clock controller for Qualcomm Technology Inc's SM6115 SoC.

---
 .../bindings/clock/qcom,sm6115-dispcc.yaml    | 70 +++++++++++++++++++
 .../dt-bindings/clock/qcom,sm6115-dispcc.h    | 36 ++++++++++
 2 files changed, 106 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
 create mode 100644 include/dt-bindings/clock/qcom,sm6115-dispcc.h
Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml new file +0 -0
new file mode 100644
index 000000000000..a6bf363b5015

Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml new file +7 -0
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,sm6115-dispcc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Display Clock Controller Binding for SM6115

s/Binding //

Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml line 12

Quoted 5 lines
Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml new file +5 -0
+
+maintainers:
+  - Bjorn Andersson <[email protected]>
+
+description: |

Don't need '|' when no formatting to preserve.

With those fixes,

maintainer
#3 lore raw

Re: [PATCH v3 1/2] dt-bindings: clock: add QCOM SM6115 display clock bindings

Quoted 28 lines · Rob Herring
Quoted 17 lines · Adam Skladowski

Add device tree bindings for display clock controller for Qualcomm Technology Inc's SM6115 SoC.

---
 .../bindings/clock/qcom,sm6115-dispcc.yaml    | 70 +++++++++++++++++++
 .../dt-bindings/clock/qcom,sm6115-dispcc.h    | 36 ++++++++++
 2 files changed, 106 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
 create mode 100644 include/dt-bindings/clock/qcom,sm6115-dispcc.h
Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml new file +0 -0
new file mode 100644
index 000000000000..a6bf363b5015

Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml new file +7 -0
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,sm6115-dispcc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Display Clock Controller Binding for SM6115

s/Binding //

Quoted 8 lines

Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml line 12

Quoted 5 lines
Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml new file +5 -0
+
+maintainers:
+  - Bjorn Andersson <[email protected]>
+
+description: |

Don't need '|' when no formatting to preserve.

This follows the other dispcc bindings, where I think the intention is to keep the formatting over "See also". In contrast to the other dispcc bindings the "See also" has a ':' at the end in this proposal...

Quoted 3 lines

With those fixes,

I took the liberty of fixing up the description to align with the others and applied this, with your R-b.

Regards,
Bjorn

#4 lore raw

PATCH v3 2/2 clk: qcom: Add display clock controller driver for SM6115

In reply to Adam Skladowski

Add support for the display clock controller found in SM6115/SM4250 based devices. This clock controller feeds the Multimedia Display SubSystem (MDSS).
This driver is based upon one submitted for QCM2290.

---
 drivers/clk/qcom/Kconfig         |   9 +
 drivers/clk/qcom/Makefile        |   1 +
 drivers/clk/qcom/dispcc-sm6115.c | 608 +++++++++++++++++++++++++++++++
 3 files changed, 618 insertions(+)
 create mode 100644 drivers/clk/qcom/dispcc-sm6115.c
drivers/clk/qcom/Kconfig +9 -0
index 1cf1ef70e347..852888a849ae 100644
@@ -616,6 +616,15 @@ config SM_CAMCC_8450
 	  Support for the camera clock controller on SM8450 devices.
 	  Say Y if you want to support camera devices and camera functionality.
 
+config SM_DISPCC_6115
+	tristate "SM6115 Display Clock Controller"
+	depends on SM_GCC_6115
+	help
+	  Support for the display clock controller on Qualcomm Technologies, Inc
+	  SM6115/SM4250 devices.
+	  Say Y if you want to support display devices and functionality such as
+	  splash screen
+
 config SM_DISPCC_6125
 	tristate "SM6125 Display Clock Controller"
 	depends on SM_GCC_6125
drivers/clk/qcom/Makefile +1 -0
index fbcf04073f07..a732ccb3b912 100644
@@ -90,6 +90,7 @@ obj-$(CONFIG_SDX_GCC_55) += gcc-sdx55.o
 obj-$(CONFIG_SDX_GCC_65) += gcc-sdx65.o
 obj-$(CONFIG_SM_CAMCC_8250) += camcc-sm8250.o
 obj-$(CONFIG_SM_CAMCC_8450) += camcc-sm8450.o
+obj-$(CONFIG_SM_DISPCC_6115) += dispcc-sm6115.o
 obj-$(CONFIG_SM_DISPCC_6125) += dispcc-sm6125.o
 obj-$(CONFIG_SM_DISPCC_6350) += dispcc-sm6350.o
 obj-$(CONFIG_SM_DISPCC_8250) += dispcc-sm8250.o
drivers/clk/qcom/dispcc-sm6115.c new file +608 -0

608 lines not on this page · raw message

Signature · 1 line
2.25.1
maintainer Applied
#5 lore raw
In reply to Adam Skladowski
Quoted 9 lines · Adam Skladowski

This patch series introduce support for SM6115 display clock controller, this driver is based on QCM2290 one.

Changes since v1
================
1. Changed bindings file names to Vendor,SoC-IP format.
2. Changed include in dispcc-sm6115 to reflect name change of bindings.

[...]

Applied, thanks!

[1/2] dt-bindings: clock: add QCOM SM6115 display clock bindings

      commit: 38557c6fc0771be5791e16837342db581daa6379
[2/2] clk: qcom: Add display clock controller driver for SM6115
      commit: 9b518788631cf7bc2b10d3967fd2343d1c88d65c

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>