Update minimum required meson version
cover Update minimum required meson version
Following some brief discussion on the dev list[1], here is a patch to update the minimum meson version for DPDK to 0.53. The update itself is fairly smooth, but, at least in my testing, it exposes some issues with objdump not recognising the debug symbols from some clang binaries. When building, one may see warnings like:
objdump: Warning: Unrecognized form: 0x22
These warnings were not previously visible with the 0.49 meson version as the symbol checks were only run in "developer_mode" and auto- detection of developer mode was limited to version 0.53 or later, due to use of the "fs" meson module.
[1] http://inbox.dpdk.org/dev/CAOE1vsNoDP0oOLkj2J4LRttXxTL7F4w1sd=KHGOWSvu+onZGFw@mail.gmail.com/
Bruce Richardson (1):
build: increase minimum meson version to 0.53
.ci/linux-setup.sh | 2 +- doc/guides/linux_gsg/sys_reqs.rst | 2 +- doc/guides/prog_guide/build-sdk-meson.rst | 2 +- drivers/common/mlx5/linux/meson.build | 2 +- meson.build | 8 +++----- 5 files changed, 7 insertions(+), 9 deletions(-)
--
2.34.1
PATCH 1/1 build: increase minimum meson version to 0.53
This patchset bumps the minimum meson version from 0.49.2 to 0.53. Rather than specifying a specific point-release of 0.53, as was done with 0.49, the version specifier is kept to the major release number only for simplicity, as new features are not introduces into bugfix releases of meson.
Some new features of interest which can now be used in DPDK with this new minimum meson version:
* can do header-file checks directly inside find_library calls, rather than needing a separate check.[v0.50].
* can pass multiple cross-files at the same time when cross-compiling [v0.51].
* "alias_target" function, to allow use to give better/shorter names for particular build objects [v0.52].
* auto-generation of clang-format [v0.50] and clang-tidy[v0.52] targets when those tools are present and config dotfiles are present. Similarly ctags and cscope are added as targets when those tools are present [v0.53]
* meson module for filesystem operations, so meson can now check for the presence of particlar files or directories [v0.53].
* "summary" function to provide a configuration summary at the end of the meson run [v0.53].
Plus many other features. See [1] for full details of each version.
[1] https://mesonbuild.com/Release-notes.html
--- .ci/linux-setup.sh | 2 +- doc/guides/linux_gsg/sys_reqs.rst | 2 +- doc/guides/prog_guide/build-sdk-meson.rst | 2 +- drivers/common/mlx5/linux/meson.build | 2 +- meson.build | 8 +++----- 5 files changed, 7 insertions(+), 9 deletions(-)
.ci/linux-setup.sh +1 -1
@@ -4,7 +4,7 @@ [ "$(id -u)" != '0' ] || alias sudo= # need to install as 'root' since some of the unit tests won't run without it -sudo python3 -m pip install --upgrade 'meson==0.49.2' +sudo python3 -m pip install --upgrade 'meson==0.53' # setup hugepages. error ignored because having hugepage is not mandatory. cat /proc/meminfo
doc/guides/linux_gsg/sys_reqs.rst +1 -1
@@ -43,7 +43,7 @@ Compilation of the DPDK * Python 3.5 or later. -* Meson (version 0.49.2+) and ninja +* Meson (version 0.53+) and ninja * ``meson`` & ``ninja-build`` packages in most Linux distributions * If the packaged version is below the minimum version, the latest versions
doc/guides/prog_guide/build-sdk-meson.rst +1 -1
@@ -35,7 +35,7 @@ The ``meson`` tool is used to configure a DPDK build. On most Linux distributions this can be got using the local package management system, e.g. ``dnf install meson`` or ``apt-get install meson``. If meson is not available as a suitable package, it can also be installed using the Python -3 ``pip`` tool, e.g. ``pip3 install meson``. Version 0.49.2 of meson is +3 ``pip`` tool, e.g. ``pip3 install meson``. Version 0.53 of meson is required - if the version packaged is too old, the latest version is generally available from "pip".
drivers/common/mlx5/linux/meson.build +1 -1
@@ -47,7 +47,7 @@ endif libmtcr_ul_found = false lib = cc.find_library('mtcr_ul', required:false) -if lib.found() and run_command('meson', '--version').stdout().version_compare('>= 0.49.2') +if lib.found() libmtcr_ul_found = true ext_deps += lib endif
meson.build +3 -5
@@ -12,16 +12,14 @@ project('DPDK', 'C', 'default_library=static', 'warning_level=2', ], - meson_version: '>= 0.49.2' + meson_version: '>= 0.53' ) # check for developer mode developer_mode = false if get_option('developer_mode').auto() - if meson.version().version_compare('>=0.53') # fs module available - fs = import('fs') - developer_mode = fs.exists('.git') - endif + fs = import('fs') + developer_mode = fs.exists('.git') else developer_mode = get_option('developer_mode').enabled() endif
Signature · 1 line
2.34.1
Re: [PATCH 1/1] build: increase minimum meson version to 0.53
Quoted 25 lines · Bruce Richardson
This patchset bumps the minimum meson version from 0.49.2 to 0.53. Rather than specifying a specific point-release of 0.53, as was done with 0.49, the version specifier is kept to the major release number only for simplicity, as new features are not introduces into bugfix releases of meson.
Some new features of interest which can now be used in DPDK with this new minimum meson version:
* can do header-file checks directly inside
find_librarycalls, rather than needing a separate check.[v0.50].
* can pass multiple cross-files at the same time when cross-compiling [v0.51].
* "alias_target" function, to allow use to give better/shorter names for particular build objects [v0.52].
* auto-generation of clang-format [v0.50] and clang-tidy[v0.52] targets when those tools are present and config dotfiles are present. Similarly ctags and cscope are added as targets when those tools are present [v0.53]
* meson module for filesystem operations, so meson can now check for the presence of particlar files or directories [v0.53].
* "summary" function to provide a configuration summary at the end of the meson run [v0.53].
Quoted 5 lines
Plus many other features. See [1] for full details of each version.
[1] https://mesonbuild.com/Release-notes.html
Signed-off-by Bruce Richardson <[email protected]>
- We have an issue with mingw cross compilation.
https://github.com/ovsrobot/dpdk/actions/runs/3039251235/jobs/4893964186
+ meson build --werror --cross-file config/x86/cross-mingw -Dexamples=helloworld -Dplatform=generic --default-library=static --buildtype=debugoptimized -Dcheck_includes=true
The Meson build system
Version: 0.53.0
Source dir: /home/runner/work/dpdk/dpdk
Build dir: /home/runner/work/dpdk/dpdk/build
Build type: cross build
Program cat found: YES (/usr/bin/cat)
Project name: DPDK
Project version: 22.11.0-rc0
C compiler for the build machine: ccache gcc (gcc 9.4.0 "gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0")
C linker for the build machine: gcc GNU ld.bfd 2.34
meson.build:4:0: ERROR: Unable to determine dynamic linker
- I reproduced locally, it looks like meson is trying to pass some -fuse-ld option that is not understood.
4577 write(2, "x86_64-w64-mingw32-gcc: error: unrecognized command line option \342\200\230-fuse-ld=x86_64-w64-mingw32-ld\342\200\231\n",
101) = 101
- Upgrading to 0.53.1, I don't see the issue anymore for mingw, so I pushed a branch in GHA to get a status for other targets.
https://github.com/david-marchand/dpdk/actions/runs/3205007946
Signature · 1 line
David Marchand
Re: [PATCH 1/1] build: increase minimum meson version to 0.53
Quoted 61 lines · David Marchand
Quoted 25 lines · Bruce Richardson
This patchset bumps the minimum meson version from 0.49.2 to 0.53. Rather than specifying a specific point-release of 0.53, as was done with 0.49, the version specifier is kept to the major release number only for simplicity, as new features are not introduces into bugfix releases of meson.
Some new features of interest which can now be used in DPDK with this new minimum meson version:
* can do header-file checks directly inside
find_librarycalls, rather than needing a separate check.[v0.50].
* can pass multiple cross-files at the same time when cross-compiling [v0.51].
* "alias_target" function, to allow use to give better/shorter names for particular build objects [v0.52].
* auto-generation of clang-format [v0.50] and clang-tidy[v0.52] targets when those tools are present and config dotfiles are present. Similarly ctags and cscope are added as targets when those tools are present [v0.53]
* meson module for filesystem operations, so meson can now check for the presence of particlar files or directories [v0.53].
* "summary" function to provide a configuration summary at the end of the meson run [v0.53].Quoted 5 lines
Plus many other features. See [1] for full details of each version.
[1] https://mesonbuild.com/Release-notes.html
Signed-off-by Bruce Richardson <[email protected]>- We have an issue with mingw cross compilation.
https://github.com/ovsrobot/dpdk/actions/runs/3039251235/jobs/4893964186+ meson build --werror --cross-file config/x86/cross-mingw -Dexamples=helloworld -Dplatform=generic --default-library=static --buildtype=debugoptimized -Dcheck_includes=true
The Meson build system
Version: 0.53.0
Source dir:/home/runner/work/dpdk/dpdk
Build dir:/home/runner/work/dpdk/dpdk/build
Build type: cross build
Program cat found: YES (/usr/bin/cat)
Project name: DPDK
Project version: 22.11.0-rc0
C compiler for the build machine: ccache gcc (gcc 9.4.0 "gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0")
C linker for the build machine: gcc GNU ld.bfd 2.34meson.build:4:0: ERROR: Unable to determine dynamic linker
- I reproduced locally, it looks like meson is trying to pass some -fuse-ld option that is not understood.
4577 write(2, "x86_64-w64-mingw32-gcc: error: unrecognized command line option \342\200\230-fuse-ld=x86_64-w64-mingw32-ld\342\200\231\n",
101) = 101
Quoted 4 lines
- Upgrading to 0.53.1, I don't see the issue anymore for mingw, so I pushed a branch in GHA to get a status for other targets.
https://github.com/david-marchand/dpdk/actions/runs/3205007946
So minimum should be 0.53.1 rather than 0.53 then?
Re: [PATCH 1/1] build: increase minimum meson version to 0.53
Quoted 28 lines · Bruce Richardson
Quoted 28 lines
- We have an issue with mingw cross compilation.
https://github.com/ovsrobot/dpdk/actions/runs/3039251235/jobs/4893964186+ meson build --werror --cross-file config/x86/cross-mingw -Dexamples=helloworld -Dplatform=generic --default-library=static --buildtype=debugoptimized -Dcheck_includes=true
The Meson build system
Version: 0.53.0
Source dir:/home/runner/work/dpdk/dpdk
Build dir:/home/runner/work/dpdk/dpdk/build
Build type: cross build
Program cat found: YES (/usr/bin/cat)
Project name: DPDK
Project version: 22.11.0-rc0
C compiler for the build machine: ccache gcc (gcc 9.4.0 "gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0")
C linker for the build machine: gcc GNU ld.bfd 2.34meson.build:4:0: ERROR: Unable to determine dynamic linker
- I reproduced locally, it looks like meson is trying to pass some -fuse-ld option that is not understood.
4577 write(2, "x86_64-w64-mingw32-gcc: error: unrecognized command line option \342\200\230-fuse-ld=x86_64-w64-mingw32-ld\342\200\231\n",
101) = 101
Quoted 6 lines
Quoted 4 lines
- Upgrading to 0.53.1, I don't see the issue anymore for mingw, so I pushed a branch in GHA to get a status for other targets.
https://github.com/david-marchand/dpdk/actions/runs/3205007946So minimum should be 0.53.1 rather than 0.53 then?
- That's what my test shows.
Fyi, 0.53.2 works too.
- With 0.53, it seems the meaning of the ld variable (in meson config file) changed.
I am unclear though if our current configs still make sense.
Signature · 1 line
David Marchand
Re: [PATCH 1/1] build: increase minimum meson version to 0.53
Quoted 37 lines · David Marchand
Quoted 28 lines · Bruce Richardson
Quoted 28 lines
- We have an issue with mingw cross compilation.
https://github.com/ovsrobot/dpdk/actions/runs/3039251235/jobs/4893964186+ meson build --werror --cross-file config/x86/cross-mingw -Dexamples=helloworld -Dplatform=generic --default-library=static --buildtype=debugoptimized -Dcheck_includes=true
The Meson build system
Version: 0.53.0
Source dir:/home/runner/work/dpdk/dpdk
Build dir:/home/runner/work/dpdk/dpdk/build
Build type: cross build
Program cat found: YES (/usr/bin/cat)
Project name: DPDK
Project version: 22.11.0-rc0
C compiler for the build machine: ccache gcc (gcc 9.4.0 "gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0")
C linker for the build machine: gcc GNU ld.bfd 2.34meson.build:4:0: ERROR: Unable to determine dynamic linker
- I reproduced locally, it looks like meson is trying to pass some -fuse-ld option that is not understood.
4577 write(2, "x86_64-w64-mingw32-gcc: error: unrecognized command line option \342\200\230-fuse-ld=x86_64-w64-mingw32-ld\342\200\231\n",
101) = 101Quoted 6 lines
Quoted 4 lines
- Upgrading to 0.53.1, I don't see the issue anymore for mingw, so I pushed a branch in GHA to get a status for other targets.
https://github.com/david-marchand/dpdk/actions/runs/3205007946So minimum should be 0.53.1 rather than 0.53 then?
Quoted 3 lines
- That's what my test shows.
Fyi, 0.53.2 works too.
As latest point release of 0.53 that is probably better choice.
Quoted 5 lines
- With 0.53, it seems the meaning of the ld variable (in meson config file) changed.
I am unclear though if our current configs still make sense.
Do you want more time to examine this, or shall I respin this patch with 0.53.2 as minimum version?
/Bruce
Re: [PATCH 1/1] build: increase minimum meson version to 0.53
Quoted 45 lines · Bruce Richardson
Quoted 37 lines · David Marchand
Quoted 28 lines · Bruce Richardson
Quoted 28 lines
- We have an issue with mingw cross compilation.
https://github.com/ovsrobot/dpdk/actions/runs/3039251235/jobs/4893964186+ meson build --werror --cross-file config/x86/cross-mingw -Dexamples=helloworld -Dplatform=generic --default-library=static --buildtype=debugoptimized -Dcheck_includes=true
The Meson build system
Version: 0.53.0
Source dir:/home/runner/work/dpdk/dpdk
Build dir:/home/runner/work/dpdk/dpdk/build
Build type: cross build
Program cat found: YES (/usr/bin/cat)
Project name: DPDK
Project version: 22.11.0-rc0
C compiler for the build machine: ccache gcc (gcc 9.4.0 "gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0")
C linker for the build machine: gcc GNU ld.bfd 2.34meson.build:4:0: ERROR: Unable to determine dynamic linker
- I reproduced locally, it looks like meson is trying to pass some -fuse-ld option that is not understood.
4577 write(2, "x86_64-w64-mingw32-gcc: error: unrecognized command line option \342\200\230-fuse-ld=x86_64-w64-mingw32-ld\342\200\231\n",
101) = 101Quoted 6 lines
Quoted 4 lines
- Upgrading to 0.53.1, I don't see the issue anymore for mingw, so I pushed a branch in GHA to get a status for other targets.
https://github.com/david-marchand/dpdk/actions/runs/3205007946So minimum should be 0.53.1 rather than 0.53 then?
Quoted 3 lines
- That's what my test shows.
Fyi, 0.53.2 works too.As latest point release of 0.53 that is probably better choice.
Quoted 1 line
Quoted 6 lines
Quoted 4 lines
- With 0.53, it seems the meaning of the ld variable (in meson config file) changed.
I am unclear though if our current configs still make sense.Do you want more time to examine this, or shall I respin this patch with 0.53.2 as minimum version?
https://github.com/mesonbuild/meson/issues/6442
https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579c11dd389fcb1152a4e8ead8b8782
I understand that the ld variable meaning has been restored, so nothing to change for us.
Please respin to 0.53.2, with a note about this issue for posterity.
Thanks.
Signature · 1 line
David Marchand
PATCH v2 1/1 build: increase minimum meson version to 0.53.2
In reply to Bruce RichardsonThis patchset bumps the minimum meson version from 0.49.2 to 0.53.2. Ideally, the minimum version should be 0.53 without a point release, but some DPDK builds (mingw) are broken with 0.53.0 due to issue[1], fixed by commit[2] in 0.53.1. Therefore we use the latest point release from 0.53 branch i.e. 0.53.2.
Some new features of interest which can now be used in DPDK with this new minimum meson version:
* can do header-file checks directly inside find_library calls, rather than needing a separate check.[v0.50].
* can pass multiple cross-files at the same time when cross-compiling [v0.51].
* "alias_target" function, to allow use to give better/shorter names for particular build objects [v0.52].
* auto-generation of clang-format [v0.50] and clang-tidy[v0.52] targets when those tools are present and config dotfiles are present. Similarly ctags and cscope are added as targets when those tools are present [v0.53]
* meson module for filesystem operations, so meson can now check for the presence of particlar files or directories [v0.53].
* "summary" function to provide a configuration summary at the end of the meson run [v0.53].
Plus many other features. See [3] for full details of each version.
[1] https://github.com/mesonbuild/meson/issues/6442
[2] https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579c11dd389fcb1152a4e8ead8b8782
[3] https://mesonbuild.com/Release-notes.html
--- .ci/linux-setup.sh | 2 +- doc/guides/linux_gsg/sys_reqs.rst | 2 +- doc/guides/prog_guide/build-sdk-meson.rst | 2 +- drivers/common/mlx5/linux/meson.build | 2 +- meson.build | 8 +++----- 5 files changed, 7 insertions(+), 9 deletions(-)
.ci/linux-setup.sh +1 -1
@@ -4,7 +4,7 @@ [ "$(id -u)" != '0' ] || alias sudo= # need to install as 'root' since some of the unit tests won't run without it -sudo python3 -m pip install --upgrade 'meson==0.49.2' +sudo python3 -m pip install --upgrade 'meson==0.53.2' # setup hugepages. error ignored because having hugepage is not mandatory. cat /proc/meminfo
doc/guides/linux_gsg/sys_reqs.rst +1 -1
@@ -43,7 +43,7 @@ Compilation of the DPDK * Python 3.5 or later. -* Meson (version 0.49.2+) and ninja +* Meson (version 0.53.2+) and ninja * ``meson`` & ``ninja-build`` packages in most Linux distributions * If the packaged version is below the minimum version, the latest versions
doc/guides/prog_guide/build-sdk-meson.rst +1 -1
@@ -35,7 +35,7 @@ The ``meson`` tool is used to configure a DPDK build. On most Linux distributions this can be got using the local package management system, e.g. ``dnf install meson`` or ``apt-get install meson``. If meson is not available as a suitable package, it can also be installed using the Python -3 ``pip`` tool, e.g. ``pip3 install meson``. Version 0.49.2 of meson is +3 ``pip`` tool, e.g. ``pip3 install meson``. Version 0.53.2 or later of meson is required - if the version packaged is too old, the latest version is generally available from "pip".
drivers/common/mlx5/linux/meson.build +1 -1
@@ -47,7 +47,7 @@ endif libmtcr_ul_found = false lib = cc.find_library('mtcr_ul', required:false) -if lib.found() and run_command('meson', '--version').stdout().version_compare('>= 0.49.2') +if lib.found() libmtcr_ul_found = true ext_deps += lib endif
meson.build +3 -5
@@ -12,16 +12,14 @@ project('DPDK', 'C', 'default_library=static', 'warning_level=2', ], - meson_version: '>= 0.49.2' + meson_version: '>= 0.53.2' ) # check for developer mode developer_mode = false if get_option('developer_mode').auto() - if meson.version().version_compare('>=0.53') # fs module available - fs = import('fs') - developer_mode = fs.exists('.git') - endif + fs = import('fs') + developer_mode = fs.exists('.git') else developer_mode = get_option('developer_mode').enabled() endif
Signature · 1 line
2.34.1
Re: [PATCH v2] build: increase minimum meson version to 0.53.2
Quoted 25 lines · Bruce Richardson
This patchset bumps the minimum meson version from 0.49.2 to 0.53.2. Ideally, the minimum version should be 0.53 without a point release, but some DPDK builds (mingw) are broken with 0.53.0 due to issue[1], fixed by commit[2] in 0.53.1. Therefore we use the latest point release from 0.53 branch i.e. 0.53.2.
Some new features of interest which can now be used in DPDK with this new minimum meson version:
* can do header-file checks directly inside
find_librarycalls, rather than needing a separate check.[v0.50].
* can pass multiple cross-files at the same time when cross-compiling [v0.51].
* "alias_target" function, to allow use to give better/shorter names for particular build objects [v0.52].
* auto-generation of clang-format [v0.50] and clang-tidy[v0.52] targets when those tools are present and config dotfiles are present. Similarly ctags and cscope are added as targets when those tools are present [v0.53]
* meson module for filesystem operations, so meson can now check for the presence of particlar files or directories [v0.53].
* "summary" function to provide a configuration summary at the end of the meson run [v0.53].
Quoted 4 lines
Plus many other features. See [3] for full details of each version.
[1] https://github.com/mesonbuild/meson/issues/6442
[2] https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579c11dd389fcb1152a4e8ead8b8782
Nit: we can shorten this link and keep only 12 chars for hash.
https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579
Quoted 3 lines
[3] https://mesonbuild.com/Release-notes.html
Signed-off-by Bruce Richardson <[email protected]>
Looking at the test reports for this patch, focusing on compilation:
- it looks like Intel envs are already using a recent enough meson,
- the change passes fine in GHA now,
- UNH envs are reporting failures, but that's expected since the images must be refreshed once this patch is merged,
So from this aspect, I think we are all set to merge this patch.
It seems the "intel-Testing" test is in ... berserk mode and spewing errors for all patches since 10/03.
No clue if we have an issue in the main branch, and this test logs are useless.
I'll wait for Intel PRC to be back and ignore for now.
Signature · 1 line
David Marchand
RE: [PATCH v2] build: increase minimum meson version to 0.53.2
Quoted 64 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Saturday, October 8, 2022 3:13 AM
To: Richardson, Bruce <[email protected]>; Thomas Monjalon <[email protected]>
Cc: [email protected]; [email protected]; Lincoln Lavoie <[email protected]>; Tu, Lijuan <[email protected]>; Chen, Zhaoyan <[email protected]>; Mcnamara, John <[email protected]>
Subject: Re: [PATCH v2] build: increase minimum meson version to 0.53.2Quoted 26 lines · Bruce Richardson
This patchset bumps the minimum meson version from 0.49.2 to 0.53.2. Ideally, the minimum version should be 0.53 without a point release, but some DPDK builds (mingw) are broken with 0.53.0 due to issue[1], fixed by commit[2] in 0.53.1. Therefore we use the latest point release from
0.53 branch i.e. 0.53.2.Some new features of interest which can now be used in DPDK with this new minimum meson version:
* can do header-file checks directly inside
find_librarycalls, rather than needing a separate check.[v0.50].
* can pass multiple cross-files at the same time when cross-compiling [v0.51].
* "alias_target" function, to allow use to give better/shorter names for particular build objects [v0.52].
* auto-generation of clang-format [v0.50] and clang-tidy[v0.52] targets when those tools are present and config dotfiles are present. Similarly ctags and cscope are added as targets when those tools are present [v0.53]
* meson module for filesystem operations, so meson can now check for the presence of particlar files or directories [v0.53].
* "summary" function to provide a configuration summary at the end of the meson run [v0.53].Quoted 5 lines
Plus many other features. See [3] for full details of each version.
https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579c11d
Quoted 1 line
d389fcb1152a4e8ead8b8782Nit: we can shorten this link and keep only 12 chars for hash.
https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579Quoted 3 lines
[3] https://mesonbuild.com/Release-notes.html
Signed-off-by Bruce Richardson <[email protected]>Acked-by David Marchand <[email protected]>Looking at the test reports for this patch, focusing on compilation:
- it looks like Intel envs are already using a recent enough meson,
- the change passes fine in GHA now,
- UNH envs are reporting failures, but that's expected since the images must be refreshed once this patch is merged,
Quoted 8 lines
So from this aspect, I think we are all set to merge this patch.
It seems the "intel-Testing" test is in ... berserk mode and spewing errors for all patches since 10/03.
No clue if we have an issue in the main branch, and this test logs are useless.I'll wait for Intel PRC to be back and ignore for now.
Yes, the main branch had an issue and has been fixed now. Intel-Testing is back to normal. It works fine.
Quoted 4 lines
--
David Marchand
Re: [PATCH v2] build: increase minimum meson version to 0.53.2
Quoted 7 lines · Lijuan
Quoted 5 lines
It seems the "intel-Testing" test is in ... berserk mode and spewing errors for all patches since 10/03.
No clue if we have an issue in the main branch, and this test logs are useless.I'll wait for Intel PRC to be back and ignore for now.
Yes, the main branch had an issue and has been fixed now. Intel-Testing is back to normal. It works fine.
The only info we had was that "something" was broken.
Example: http://mails.dpdk.org/archives/test-report/2022-October/313054.html
When other CI report a failure, executed commands and logs are available in GHA and UNH dashboard, downloadable as zip files. So it is relatively easy to figure out if the issue was due to an infrastructure problem or if it was a test failure.
I don't think Intel CI provide such info. If this is the case, please document it.
Otherwise, please Intel CI team, work on providing the same kind of info.
Thanks.
Signature · 1 line
David Marchand
RE: [PATCH v2] build: increase minimum meson version to 0.53.2
Quoted 27 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Monday, October 10, 2022 3:48 PM
To: Tu, Lijuan <[email protected]>
Cc: Richardson, Bruce <[email protected]>; Thomas Monjalon <[email protected]>; [email protected]; [email protected]; Lincoln Lavoie <[email protected]>; Chen, Zhaoyan <[email protected]>; Mcnamara, John <[email protected]>
Subject: Re: [PATCH v2] build: increase minimum meson version to 0.53.2Quoted 7 lines · Lijuan
Quoted 5 lines
It seems the "intel-Testing" test is in ... berserk mode and spewing errors for all patches since 10/03.
No clue if we have an issue in the main branch, and this test logs are useless.I'll wait for Intel PRC to be back and ignore for now.
Yes, the main branch had an issue and has been fixed now. Intel-Testing is back
to normal. It works fine.
The only info we had was that "something" was broken.
Example: http://mails.dpdk.org/archives/test-report/2022-
October/313054.html
Quoted 8 lines
When other CI report a failure, executed commands and logs are available in GHA and UNH dashboard, downloadable as zip files.
So it is relatively easy to figure out if the issue was due to an infrastructure problem or if it was a test failure.I don't think Intel CI provide such info. If this is the case, please document it. Otherwise, please Intel CI team, work on providing the same kind of info.
Intel don't provide such info, and I don't think community provides API or services to support it.
The https://lab.dpdk.org/results/dashboard/ is for UNH, If dashboard could provide a API for intel, we'd like to provide detail logs. We need community 's help to set up this, I think we can discus it in CI meeting.
Quoted 6 lines
Thanks.
--
David Marchand
David Marchand
AppliedRe: [PATCH v2] build: increase minimum meson version to 0.53.2
In reply to David MarchandQuoted 28 lines · David Marchand
Quoted 25 lines · Bruce Richardson
This patchset bumps the minimum meson version from 0.49.2 to 0.53.2. Ideally, the minimum version should be 0.53 without a point release, but some DPDK builds (mingw) are broken with 0.53.0 due to issue[1], fixed by commit[2] in 0.53.1. Therefore we use the latest point release from 0.53 branch i.e. 0.53.2.
Some new features of interest which can now be used in DPDK with this new minimum meson version:
* can do header-file checks directly inside
find_librarycalls, rather than needing a separate check.[v0.50].
* can pass multiple cross-files at the same time when cross-compiling [v0.51].
* "alias_target" function, to allow use to give better/shorter names for particular build objects [v0.52].
* auto-generation of clang-format [v0.50] and clang-tidy[v0.52] targets when those tools are present and config dotfiles are present. Similarly ctags and cscope are added as targets when those tools are present [v0.53]
* meson module for filesystem operations, so meson can now check for the presence of particlar files or directories [v0.53].
* "summary" function to provide a configuration summary at the end of the meson run [v0.53].
Quoted 8 lines
Quoted 7 lines
Plus many other features. See [3] for full details of each version.
[1] https://github.com/mesonbuild/meson/issues/6442
[2] https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579c11dd389fcb1152a4e8ead8b8782
[3] https://mesonbuild.com/Release-notes.htmlSigned-off-by Bruce Richardson <[email protected]>Acked-by David Marchand <[email protected]>
Applied, thanks.
Signature · 1 line
David Marchand