platform/chrome: cros_ec: Log wake events during resume
Subsystems (2)
PATCH 1/1 platform/chrome: cros_ec: Log wake events during resume
Update cros_ec_report_events_during_suspend to log wake events during resume by calling pm_wakeup_event.
Signed-off-by Jameson Thies <[email protected]>
Reviewed-by Prashant Malani <[email protected]>
--- drivers/platform/chrome/cros_ec.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/platform/chrome/cros_ec.c +7 -1
@@ -349,10 +349,16 @@ EXPORT_SYMBOL(cros_ec_suspend);static void cros_ec_report_events_during_suspend (struct cros_ec_device *ec_dev) { +bool wake_event; +while (ec_dev->mkbp_event_supported && -cros_ec_get_next_event (ec_dev,NULL ,NULL ) >0 ) +cros_ec_get_next_event (ec_dev, &wake_event,NULL ) >0 ) {blocking_notifier_call_chain (&ec_dev->event_notifier,1 , ec_dev); + +if (wake_event &&device_may_wakeup (ec_dev->dev)) +pm_wakeup_event (ec_dev->dev,0 ); + } }/**
Signature · 1 line
2.37.2.789.g6183377224-goog
Benson Leung
maintainerHi Jameson,
Quoted 4 lines · Jameson Thies
Update
cros_ec_report_events_during_suspendto log wake events during resume by callingpm_wakeup_event.
Minor nit, isn't it more accurate to say that this change "signals" or "notifies" a wakeup event rather than just log? Log indicates some print to a logging service, which may happen, but as a side effect of the actual pm_wakeup_event call, which does something real on its own.
Thanks,
Benson
Quoted 32 lines
Signed-off-by Jameson Thies <[email protected]>Reviewed-by Prashant Malani <[email protected]>--- drivers/platform/chrome/cros_ec.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)drivers/platform/chrome/cros_ec.c +7
-2@@ -349,10 +349,16 @@ EXPORT_SYMBOL(cros_ec_suspend);static void cros_ec_report_events_during_suspend (struct cros_ec_device *ec_dev) { +bool wake_event; +while (ec_dev->mkbp_event_supported && -cros_ec_get_next_event (ec_dev,NULL ,NULL ) >0 ) +cros_ec_get_next_event (ec_dev, &wake_event,NULL ) >0 ) {blocking_notifier_call_chain (&ec_dev->event_notifier,1 , ec_dev); + +if (wake_event &&device_may_wakeup (ec_dev->dev)) +pm_wakeup_event (ec_dev->dev,0 ); + } }/** -- 2.37.2.789.g6183377224-goog
Signature · 7 lines
Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. [email protected] Chromium OS Project [email protected]