net: korina: Fix return type of korina_send_packet
Subsystems (2)
PATCH 1/1 net: korina: Fix return type of korina_send_packet
The ndo_start_xmit field in net_device_ops is expected to be of type netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).
The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition.
The return type of korina_send_packet should be changed from int to netdev_tx_t.
--- drivers/net/ethernet/korina.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/korina.c +2 -1
@@ -416,7 +416,8 @@ static void korina_abort_rx(struct net_device *dev) }/* transmit packet */ -static int korina_send_packet (struct sk_buff *skb,struct net_device *dev) +static netdev_tx_t korina_send_packet (struct sk_buff *skb, +struct net_device *dev) {struct korina_private *lp =netdev_priv (dev);u32 chain_prev, chain_next;
Signature · 1 line
2.37.2.789.g6183377224-goog
Quoted 6 lines · Nathan Huckleberry
The
ndo_start_xmitfield innet_device_opsis expected to be of typenetdev_tx_t(*ndo_start_xmit)(structsk_buff*skb, structnet_device*dev).The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition.
Quoted 7 lines
The return type of
korina_send_packetshould be changed from int tonetdev_tx_t.
Quoted 21 lines
--- drivers/net/ethernet/korina.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/net/ethernet/korina.c +2
-1@@ -416,7 +416,8 @@ static void korina_abort_rx(struct net_device *dev) }/* transmit packet */ -static int korina_send_packet (struct sk_buff *skb,struct net_device *dev) +static netdev_tx_t korina_send_packet (struct sk_buff *skb, +struct net_device *dev) {struct korina_private *lp =netdev_priv (dev);u32 chain_prev, chain_next;Signature · 1 line
2.37.2.789.g6183377224-goog
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Mon, 12 Sep 2022 14:43:40 -0700 you wrote:
The
ndo_start_xmitfield innet_device_opsis expected to be of typenetdev_tx_t(*ndo_start_xmit)(structsk_buff*skb, structnet_device*dev).The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition.
The return type of
korina_send_packetshould be changed from int tonetdev_tx_t.[...]
Here is the summary with links:
- net: korina: Fix return type of korina_send_packet
https://git.kernel.org/netdev/net-next/c/106c67ce46f3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html