net: wwan: t7xx: Fix return type of t7xx_ccmni_start_xmit
PATCH 1/1 net: wwan: t7xx: Fix return type of t7xx_ccmni_start_xmit
The ndo_start_xmit field in net_device_ops is expected to be of type netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).
The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition.
The return type of t7xx_ccmni_start_xmit should be changed from int to netdev_tx_t.
--- drivers/net/wwan/t7xx/t7xx_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wwan/t7xx/t7xx_netdev.c +1 -1
@@ -74,7 +74,7 @@ static int t7xx_ccmni_send_packet(struct t7xx_ccmni *ccmni, struct sk_buff *skb,return 0 ; } -static int t7xx_ccmni_start_xmit (struct sk_buff *skb,struct net_device *dev) +static netdev_tx_t t7xx_ccmni_start_xmit (struct sk_buff *skb,struct net_device *dev) {struct t7xx_ccmni *ccmni =wwan_netdev_drvpriv (dev);int skb_len = skb->len;
Signature · 1 line
2.37.2.789.g6183377224-goog
Quoted 6 lines · Nathan Huckleberry
The
ndo_start_xmitfield innet_device_opsis expected to be of typenetdev_tx_t(*ndo_start_xmit)(structsk_buff*skb, structnet_device*dev).The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition.
Quoted 7 lines
The return type of
t7xx_ccmni_start_xmitshould be changed from int tonetdev_tx_t.
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Mon, 12 Sep 2022 14:45:10 -0700 you wrote:
The
ndo_start_xmitfield innet_device_opsis expected to be of typenetdev_tx_t(*ndo_start_xmit)(structsk_buff*skb, structnet_device*dev).The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition.
The return type of
t7xx_ccmni_start_xmitshould be changed from int tonetdev_tx_t.[...]
Here is the summary with links:
- net: wwan: t7xx: Fix return type of t7xx_ccmni_start_xmit
https://git.kernel.org/netdev/net-next/c/73c99e260365
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html