Skip to contentSkip to conversation

Documentation: filesystems: tftp: fix code blocks

PATCH Applied Antony Pavlov 2 participants 4 messages Sep 12, 2022 – Sep 13, 2022 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: filesystems: tftp: fix code blocks

The patch fixes these sphinx errors:

Documentation/filesystems/tftp.rst:44: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 3 supplied.
Documentation/filesystems/tftp.rst:53: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 4 supplied.

---
 Documentation/filesystems/tftp.rst | 2 ++
 1 file changed, 2 insertions(+)
Documentation/filesystems/tftp.rst +2 -0
index 8929213d3c4..e88ad3dd4c8 100644
@@ -42,6 +42,7 @@ the opposite effect.  Performance depends on:
    100 Mb/s) it had to be reduced to
 
    .. code-block:: console
+
      global tftp.windowsize=26
 
    for example.
@@ -51,6 +52,7 @@ the opposite effect.  Performance depends on:
    example, the `fec-imx` driver reserves place for
 
    .. code-block:: c
+
      #define FEC_RBD_NUM		64
 
    packets before they are dropped
Signature · 1 line
2.37.2
Applied
#1 lore raw
Quoted 11 lines · Antony Pavlov

The patch fixes these sphinx errors:

Documentation/filesystems/tftp.rst:44: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 3 supplied.
Documentation/filesystems/tftp.rst:53: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 4 supplied.

---
 Documentation/filesystems/tftp.rst | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks

Sascha

Quoted 25 lines
Documentation/filesystems/tftp.rst +2 -0
index 8929213d3c4..e88ad3dd4c8 100644
@@ -42,6 +42,7 @@ the opposite effect.  Performance depends on:
    100 Mb/s) it had to be reduced to
 
    .. code-block:: console
+
      global tftp.windowsize=26
 
    for example.
@@ -51,6 +52,7 @@ the opposite effect.  Performance depends on:
    example, the `fec-imx` driver reserves place for
 
    .. code-block:: c
+
      #define FEC_RBD_NUM		64
 
    packets before they are dropped
Signature · 1 line
2.37.2
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#2 lore raw

On Tue, 13 Sep 2022 10:08:37 +0200
Sascha Hauer <[email protected]> wrote:

Hi Sascha!

Quoted 8 lines · Antony Pavlov
Quoted 7 lines

The patch fixes these sphinx errors:

Documentation/filesystems/tftp.rst:44: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 3 supplied.
Documentation/filesystems/tftp.rst:53: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 4 supplied.

Quoted 6 lines
Quoted 4 lines
---
 Documentation/filesystems/tftp.rst | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks

I thought that this patch is for ammend. My bad! I shell add "for ammend" or "fixup" tag to the message subject next time.

Quoted 31 lines
Quoted 25 lines
Documentation/filesystems/tftp.rst +2 -0
index 8929213d3c4..e88ad3dd4c8 100644
@@ -42,6 +42,7 @@ the opposite effect.  Performance depends on:
    100 Mb/s) it had to be reduced to
 
    .. code-block:: console
+
      global tftp.windowsize=26
 
    for example.
@@ -51,6 +52,7 @@ the opposite effect.  Performance depends on:
    example, the `fec-imx` driver reserves place for
 
    .. code-block:: c
+
      #define FEC_RBD_NUM		64
 
    packets before they are dropped
Signature · 1 line
2.37.2
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Signature · 2 lines
Best regards,
  Antony Pavlov
#3 lore raw
Quoted 18 lines · Antony Pavlov

On Tue, 13 Sep 2022 10:08:37 +0200
Sascha Hauer <[email protected]> wrote:

Hi Sascha!

Quoted 13 lines · Antony Pavlov
Quoted 11 lines

The patch fixes these sphinx errors:

Documentation/filesystems/tftp.rst:44: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 3 supplied.
Documentation/filesystems/tftp.rst:53: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 4 supplied.

---
 Documentation/filesystems/tftp.rst | 2 ++
 1 file changed, 2 insertions(+)
Quoted 4 lines
Quoted 1 line

Applied, thanks

I thought that this patch is for ammend. My bad! I shell add "for ammend" or "fixup" tag to the message subject next time.

Ah, ok, I didn't realize that. When the to-be-fixed-up patch sits in next you could just commit with --fixup=, this makes it very easy to fix it up on my side.

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |