Skip to contentSkip to conversation

mm/damon: add MADV_COLLAPSE support in damos_action

PATCH In review Xin Hao 2 participants 3 messages Sep 13, 2022

Subsystems (2)
lore
Share & tools
lore

Xin Hao

author
#0 lore raw

PATCH 1/1 mm/damon: add MADV_COLLAPSE support in damos_action

MADV_COLLAPSE has large different with MDVA_HUGE in dealing with huge pages, it doesn't need to rely on 'khugepage' thread to create THP. So combining with it will give damon users more options.

---
 include/linux/damon.h | 1 +
 mm/damon/vaddr.c      | 3 +++
 2 files changed, 4 insertions(+)
include/linux/damon.h +1 -0
index 016b6c9c03d6..c44f9410d997 100644
@@ -97,6 +97,7 @@ enum damos_action {
 	DAMOS_PAGEOUT,
 	DAMOS_HUGEPAGE,
 	DAMOS_NOHUGEPAGE,
+	DAMOS_COLLAPSE,
 	DAMOS_LRU_PRIO,
 	DAMOS_LRU_DEPRIO,
 	DAMOS_STAT,		/* Do nothing but only record the stat */
mm/damon/vaddr.c +3 -0
index c2c08c1b316b..58c0d068563d 100644
@@ -655,6 +655,9 @@ static unsigned long damon_va_apply_scheme(struct damon_ctx *ctx,
 	case DAMOS_NOHUGEPAGE:
 		madv_action = MADV_NOHUGEPAGE;
 		break;
+	case DAMOS_COLLAPSE:
+		madv_action = MADV_COLLAPSE;
+		break;
 	case DAMOS_STAT:
 		return 0;
 	default:
Signature · 1 line
2.31.0
maintainer
#1 lore raw

Hi Xin,

Quoted 3 lines · On Tue, 13 Sep 2022 19:47:35 +0800 Xin Hao <[email protected]> wrote:

MADV_COLLAPSE has large different with MDVA_HUGE in dealing with huge pages, it doesn't need to rely on 'khugepage' thread to create THP. So combining with it will give damon users more options.

I think this is a simple and worthy change, but... could you put some more detailed explanation of the scenario that the action could be used? Also, it would be good to have some evaluation results you got with this change.

Also, to my understanding, MADV_COLLAPSE is not merged in the mainline yet, right? I believe it will make it in v6.1-rc1. That said, to make Andrew's burden less, how about delaying this change until MADV_COLLAPSE is mainlined? If you have some numbers showing clear and great benefit of this change, I think it would be worthy to add immediately, though.

Thanks,
SJ

Quoted 35 lines
---
 include/linux/damon.h | 1 +
 mm/damon/vaddr.c      | 3 +++
 2 files changed, 4 insertions(+)
include/linux/damon.h +1 -0
index 016b6c9c03d6..c44f9410d997 100644
@@ -97,6 +97,7 @@ enum damos_action {
 	DAMOS_PAGEOUT,
 	DAMOS_HUGEPAGE,
 	DAMOS_NOHUGEPAGE,
+	DAMOS_COLLAPSE,
 	DAMOS_LRU_PRIO,
 	DAMOS_LRU_DEPRIO,
 	DAMOS_STAT,		/* Do nothing but only record the stat */
mm/damon/vaddr.c +3 -0
index c2c08c1b316b..58c0d068563d 100644
@@ -655,6 +655,9 @@ static unsigned long damon_va_apply_scheme(struct damon_ctx *ctx,
 	case DAMOS_NOHUGEPAGE:
 		madv_action = MADV_NOHUGEPAGE;
 		break;
+	case DAMOS_COLLAPSE:
+		madv_action = MADV_COLLAPSE;
+		break;
 	case DAMOS_STAT:
 		return 0;
 	default:
Signature · 1 line
2.31.0
author
#2 lore raw

Hi  SJ,

Quoted 10 lines · SeongJae Park

Hi Xin,

Quoted 3 lines · On Tue, 13 Sep 2022 19:47:35 +0800 Xin Hao <[email protected]> wrote:

MADV_COLLAPSE has large different with MDVA_HUGE in dealing with huge pages, it doesn't need to rely on 'khugepage' thread to create THP. So combining with it will give damon users more options.

I think this is a simple and worthy change, but... could you put some more detailed explanation of the scenario that the action could be used? Also, it would be good to have some evaluation results you got with this change.

Yes, internally, we use this feature mainly focus on two reason:

the fist one,

    prevent performance jitter casused by khugepage thread under memory pressure.

the second one,

    khugepage thread merge hugepages is  slowness then MADV_COLLAPSE.

Quoted 45 lines

Als, to my understanding, MADV_COLLAPSE is not merged in the mainline yet, right? I believe it will make it in v6.1-rc1. That said, to make Andrew's burden less, how about delaying this change until MADV_COLLAPSE is mainlined? If you have some numbers showing clear and great benefit of this change, I think it would be worthy to add immediately, though.

Thanks,
SJ

Quoted 34 lines
---
  include/linux/damon.h | 1 +
  mm/damon/vaddr.c      | 3 +++
  2 files changed, 4 insertions(+)
include/linux/damon.h +1 -0
index 016b6c9c03d6..c44f9410d997 100644
@@ -97,6 +97,7 @@ enum damos_action {
  	DAMOS_PAGEOUT,
  	DAMOS_HUGEPAGE,
  	DAMOS_NOHUGEPAGE,
+	DAMOS_COLLAPSE,
  	DAMOS_LRU_PRIO,
  	DAMOS_LRU_DEPRIO,
  	DAMOS_STAT,		/* Do nothing but only record the stat */
mm/damon/vaddr.c +3 -0
index c2c08c1b316b..58c0d068563d 100644
@@ -655,6 +655,9 @@ static unsigned long damon_va_apply_scheme(struct damon_ctx *ctx,
  	case DAMOS_NOHUGEPAGE:
  		madv_action = MADV_NOHUGEPAGE;
  		break;
+	case DAMOS_COLLAPSE:
+		madv_action = MADV_COLLAPSE;
+		break;
  	case DAMOS_STAT:
  		return 0;
  	default:
Signature · 1 line
2.31.0