mm/damon: fix missing damon_del_region()
Subsystems (2)
PATCH 1/1 mm/damon: fix missing damon_del_region()
It should be called damon_del_region() before free each region, so use damon_destroy_region() instead of damon_free_region().
--- mm/damon/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/damon/core.c +1 -1
@@ -361,7 +361,7 @@ void damon_free_target(struct damon_target *t)struct damon_region *r, *next;damon_for_each_region_safe (r, next, t) -damon_free_region (r); +damon_destroy_region (r, t);kfree (t); }
Signature · 1 line
2.25.1
SeongJae Park
maintainerHi Yajun,
Quoted 2 lines · On Wed, 14 Sep 2022 17:36:36 +0800 Yajun Deng <[email protected]> wrote:
It should be called
damon_del_region()before free each region, so usedamon_destroy_region()instead ofdamon_free_region().
What 'damon_del_region()' does is deleting the region from target's regions linked list so that nobody references it later after its freed. However, as each region is linked to one target, and as we will free the target here, the list will also be freed. Therefore, we don't need to worry about future references to the region.
Anything I'm missing?
Thanks,
SJ
Quoted 22 lines
Fixes f23b8eee1871 (mm/damon/core: implement region-based sampling)Signed-off-by Yajun Deng <[email protected]>--- mm/damon/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/damon/core.c +1
-1@@ -361,7 +361,7 @@ void damon_free_target(struct damon_target *t)struct damon_region *r, *next;damon_for_each_region_safe (r, next, t) -damon_free_region (r); +damon_destroy_region (r, t);kfree (t); }Signature · 1 line
2.25.1
Quoted 7 lines · SeongJae Park
Hi Yajun,
Quoted 2 lines · On Wed, 14 Sep 2022 17:36:36 +0800 Yajun Deng <[email protected]> wrote:
It should be called
damon_del_region()before free each region, so usedamon_destroy_region()instead ofdamon_free_region().
Quoted 8 lines
What '
damon_del_region()' does is deleting the region from target's regions linked list so that nobody references it later after its freed. However, as each region is linked to one target, and as we will free the target here, the list will also be freed. Therefore, we don't need to worry about future references to the region.Anything I'm missing?
OK, got it.
Quoted 24 lines
Thanks,
SJQuoted 21 lines
Fixes f23b8eee1871 (mm/damon/core: implement region-based sampling)Signed-off-by Yajun Deng <[email protected]>---
mm/damon/core.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)mm/damon/core.c +1
-2@@ -361,7 +361,7 @@ void damon_free_target(struct damon_target *t)struct damon_region *r, *next; damon_for_each_region_safe(r, next, t) -damon_free_region (r); +damon_destroy_region (r, t);kfree (t); } --2.25.1