eal: make eal_parse_coremask external
PATCH 1/1 eal: make eal_parse_coremask external
DLB2 has a need to parse a user supplied coremask as part of an optimization that associates optimal core/resource pairs. Therefore eal_parse_coremask has been renamed to rte_eal_parse_coremask and exported.
--- lib/eal/common/eal_common_options.c | 6 +++--- lib/eal/common/eal_options.h | 2 ++ lib/eal/version.map | 3 +++ 3 files changed, 8 insertions(+), 3 deletions(-)
lib/eal/common/eal_common_options.c +3 -3
@@ -742,8 +742,8 @@ check_core_list(int *lcores, unsigned int count)return -1 ; } -static int -eal_parse_coremask (const char *coremask,int *cores) +int +rte_eal_parse_coremask (const char *coremask,int *cores) {const char *coremask_orig = coremask;int lcores[RTE_MAX_LCORE ];
@@ -1649,7 +1649,7 @@ eal_parse_common_option(int opt, const char *optarg,if (eal_service_cores_parsed ())RTE_LOG (WARNING ,EAL ,"Service cores parsed before dataplane cores. Please ensure -c is before -s or -S\n" ); -if (eal_parse_coremask (optarg, lcore_indexes) <0 ) { +if (rte_eal_parse_coremask (optarg, lcore_indexes) <0 ) {RTE_LOG (ERR ,EAL ,"invalid coremask syntax\n" );return -1 ; }
lib/eal/common/eal_options.h +2 -0
@@ -108,5 +108,7 @@ int eal_plugins_init(void);int eal_save_args (int argc,char **argv); int handle_eal_info_request(const char *cmd, const char *params __rte_unused,struct rte_tel_data *d); +__rte_experimental +int rte_eal_parse_coremask(const char *coremask, int *cores);#endif /* EAL_OPTIONS_H */
lib/eal/version.map +3 -0
@@ -424,6 +424,9 @@ EXPERIMENTAL { rte_thread_self; rte_thread_set_affinity_by_id; rte_thread_set_priority; + + #added in 22.11 + rte_eal_parse_coremask; }; INTERNAL {
Signature · 1 line
2.25.1
2022-08-19 17:33 (UTC-0500), Timothy McDaniel:
Quoted 4 lines
DLB2 has a need to parse a user supplied coremask as part of an optimization that associates optimal core/resource pairs. Therefore
eal_parse_coremaskhas been renamed torte_eal_parse_coremaskand exported.
INTERNAL would be sufficient since the function is only used within DPDK. EXPERIMENTAL is for symbols that would be used by consumer apps.
PATCH 1/1 eal: make eal_parse_coremask external
In reply to Timothy McDanielDLB2 has a need to parse a user supplied coremask as part of an optimization that associates optimal core/resource pairs. Therefore eal_parse_coremask has been renamed to rte_eal_parse_coremask and exported.
--- lib/eal/common/eal_common_options.c | 6 +++--- lib/eal/common/eal_options.h | 2 ++ lib/eal/version.map | 1 + 3 files changed, 6 insertions(+), 3 deletions(-)
lib/eal/common/eal_common_options.c +3 -3
@@ -742,8 +742,8 @@ check_core_list(int *lcores, unsigned int count)return -1 ; } -static int -eal_parse_coremask (const char *coremask,int *cores) +int +rte_eal_parse_coremask (const char *coremask,int *cores) {const char *coremask_orig = coremask;int lcores[RTE_MAX_LCORE ];
@@ -1649,7 +1649,7 @@ eal_parse_common_option(int opt, const char *optarg,if (eal_service_cores_parsed ())RTE_LOG (WARNING ,EAL ,"Service cores parsed before dataplane cores. Please ensure -c is before -s or -S\n" ); -if (eal_parse_coremask (optarg, lcore_indexes) <0 ) { +if (rte_eal_parse_coremask (optarg, lcore_indexes) <0 ) {RTE_LOG (ERR ,EAL ,"invalid coremask syntax\n" );return -1 ; }
lib/eal/common/eal_options.h +2 -0
@@ -108,5 +108,7 @@ int eal_plugins_init(void);int eal_save_args (int argc,char **argv); int handle_eal_info_request(const char *cmd, const char *params __rte_unused,struct rte_tel_data *d); +__rte_internal +int rte_eal_parse_coremask(const char *coremask, int *cores);#endif /* EAL_OPTIONS_H */
lib/eal/version.map +1 -0
@@ -464,4 +464,5 @@ INTERNAL { rte_mem_map; rte_mem_page_size; rte_mem_unmap; + rte_eal_parse_coremask; };
Signature · 1 line
2.25.1
David Marchand
AppliedHello Abdullah,
Quoted 5 lines · Abdullah Sevincer
DLB2 has a need to parse a user supplied coremask as part of an optimization that associates optimal core/resource pairs. Therefore
eal_parse_coremaskhas been renamed torte_eal_parse_coremaskand exported.
Please version new revisions of a patch for your next contributions.
Quoted 37 lines
Signed-off-by Abdullah Sevincer <[email protected]>--- lib/eal/common/eal_common_options.c | 6 +++--- lib/eal/common/eal_options.h | 2 ++ lib/eal/version.map | 1 + 3 files changed, 6 insertions(+), 3 deletions(-)lib/eal/common/eal_common_options.c +3
-3@@ -742,8 +742,8 @@ check_core_list(int *lcores, unsigned int count)return -1 ; } -static int -eal_parse_coremask (const char *coremask,int *cores) +int +rte_eal_parse_coremask (const char *coremask,int *cores) {const char *coremask_orig = coremask;int lcores[RTE_MAX_LCORE ];@@ -1649,7 +1649,7 @@ eal_parse_common_option(int opt, const char *optarg,if (eal_service_cores_parsed ())RTE_LOG (WARNING ,EAL ,"Service cores parsed before dataplane cores. Please ensure -c is before -s or -S\n" ); -if (eal_parse_coremask (optarg, lcore_indexes) <0 ) { +if (rte_eal_parse_coremask (optarg, lcore_indexes) <0 ) {RTE_LOG (ERR ,EAL ,"invalid coremask syntax\n" );return -1 ; }lib/eal/common/eal_options.h +0
-0
lib/eal/common/eal_options.h int eal_plugins_init(void); · line 112
Quoted 5 lines
lib/eal/common/eal_options.h +2
-0@@ -108,5 +108,7 @@ int eal_plugins_init(void);int eal_save_args (int argc,char **argv); int handle_eal_info_request(const char *cmd, const char *params __rte_unused,struct rte_tel_data *d); +__rte_internal +int rte_eal_parse_coremask(const char *coremask, int *cores);
I moved this to rte_eal.h and added a (doxygen) description of what this helper does.
lib/eal/version.map INTERNAL { · line 467
Quoted 11 lines
lib/eal/common/eal_options.h +0
-0#endif /* EAL_OPTIONS_H */ lib/eal/version.map +1
-0@@ -464,4 +464,5 @@ INTERNAL { rte_mem_map; rte_mem_page_size; rte_mem_unmap; + rte_eal_parse_coremask;
Fixed to alphabetical order.
Applied, thanks.
Signature · 1 line
David Marchand