mm/damon: use 'struct damon_target *' instead of 'void *' in target_valid()
Subsystems (2)
PATCH 1/1 mm/damon: use 'struct damon_target *' instead of 'void *' in target_valid()
From: Kaixu Xia <[email protected]>
We could use 'struct damon_target *' directly instead of 'void *' in target_valid() operation to make code simple.
Signed-off-by Kaixu Xia <[email protected]>
--- include/linux/damon.h | 2 +- mm/damon/vaddr.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
include/linux/damon.h +1 -1
@@ -346,7 +346,7 @@ struct damon_operations {unsigned long (*apply_scheme)(struct damon_ctx *context,struct damon_target *t,struct damon_region *r,struct damos *scheme); -bool (*target_valid)(void *target); +bool (*target_valid)(struct damon_target *t);void (*cleanup)(struct damon_ctx *context); };
mm/damon/vaddr.c +1 -2
@@ -593,9 +593,8 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx)* Functions for the target validity check and cleanup */ -static bool damon_va_target_valid (void *target) +static bool damon_va_target_valid (struct damon_target *t) { -struct damon_target *t = target;struct task_struct *task; task =damon_get_task_struct (t);
Signature · 1 line
2.27.0
Hi Kaixu,
Quoted 4 lines · On Thu, 15 Sep 2022 19:33:41 +0800 [email protected] wrote:
From: Kaixu Xia <[email protected]>
We could use 'struct
damon_target*' directly instead of 'void *' intarget_valid()operation to make code simple.
Nice finding.
Quoted 2 lines
Signed-off-by Kaixu Xia <[email protected]>
Reviewed-by SeongJae Park <[email protected]>
Thanks,
SJ
Quoted 36 lines
--- include/linux/damon.h | 2 +- mm/damon/vaddr.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)include/linux/damon.h +1
-1@@ -346,7 +346,7 @@ struct damon_operations {unsigned long (*apply_scheme)(struct damon_ctx *context,struct damon_target *t,struct damon_region *r,struct damos *scheme); -bool (*target_valid)(void *target); +bool (*target_valid)(struct damon_target *t);void (*cleanup)(struct damon_ctx *context); };mm/damon/vaddr.c +1
-2@@ -593,9 +593,8 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx)* Functions for the target validity check and cleanup */ -static bool damon_va_target_valid (void *target) +static bool damon_va_target_valid (struct damon_target *t) { -struct damon_target *t = target;struct task_struct *task; task =damon_get_task_struct (t);Signature · 1 line
2.27.0