dt-bindings: display: bridge: nxp, tda998x: Json-schema conversion and fixes
Subsystems (5)
Geert Uytterhoeven
maintainerv2 cover dt-bindings: display: bridge: nxp, tda998x: Json-schema conversion and fixes
Hi all,
This patch series converts the NXP TDA998x HDMI transmitter Device Tree binding documentation to json-schema, after a few customary fixes.
Changes compared to v1:
- Add maximum to video-ports,
- Drop unneeded maxItems for audio-ports,
- Complete port descriptions.
Thanks for your comments!
[1] "[PATCH 0/3] dt-bindings: display: bridge: nxp,tda998x: Json-schema conversion and fixes"
https://lore.kernel.org/r/[email protected]/
Geert Uytterhoeven (3):
ARM: dts: am335x: Fix TDA998x ports addressing
[RFC] arm64: dts: renesas: cat874: Drop bogus clocks property
dt-bindings: display: bridge: nxp,tda998x: Convert to json-schema
.../bindings/display/bridge/nxp,tda998x.yaml | 109 ++++++++++++++++++ .../bindings/display/bridge/tda998x.txt | 54 --------- arch/arm/boot/dts/am335x-boneblack-hdmi.dtsi | 7 +- arch/arm/boot/dts/am335x-myirtech-myd.dts | 7 +- .../boot/dts/renesas/r8a774c0-cat874.dts | 1 - 5 files changed, 121 insertions(+), 57 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml delete mode 100644 Documentation/devicetree/bindings/display/bridge/tda998x.txt
Signature · 12 lines
2.25.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsGeert Uytterhoeven
maintainerPATCH v2 1/3 ARM: dts: am335x: Fix TDA998x ports addressing
Fix addressing in the NXP TDA998x HDMI transmitters' subnodes:
- Add missing #{address,size}-cells properties to ports capsule,
- Add missing reg properties to port child nodes,
- Drop bogus unit addresses from endpoint grandchildren nodes.
---
v2:
- No changes.
--- arch/arm/boot/dts/am335x-boneblack-hdmi.dtsi | 7 ++++++- arch/arm/boot/dts/am335x-myirtech-myd.dts | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-)
arch/arm/boot/dts/am335x-boneblack-hdmi.dtsi +6 -1
@@ -85,8 +85,13 @@ tda19988: tda19988@70 { audio-ports = < TDA998x_I2S 0x03>; ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { - hdmi_0: endpoint@0 { + reg = <0>; + + hdmi_0: endpoint { remote-endpoint = <&lcdc_0>; }; };
arch/arm/boot/dts/am335x-myirtech-myd.dts +6 -1
@@ -161,8 +161,13 @@ tda9988: tda9988@70 { #sound-dai-cells = <0>; ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { - hdmi_0: endpoint@0 { + reg = <0>; + + hdmi_0: endpoint { remote-endpoint = <&lcdc_0>; }; };
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerRFC PATCH v2 2/3 arm64: dts: renesas: cat874: Drop bogus clocks property
In reply to Geert UytterhoevenThe NXP TDA998x HDMI transmitter Device Tree binding documentation does not mention a clocks property.
---
Is this property just missing from the bindings?
The driver doesn't seem to use it.
v2:
- No changes.
--- arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 1 - 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts +0 -1
@@ -239,7 +239,6 @@ tda19988: tda19988@70 { #sound-dai-cells = <0>; audio-ports = <TDA998x_I2S 0x03>; - clocks = <&rcar_sound 1>; ports { #address-cells = <1>;
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerPATCH v2 3/3 dt-bindings: display: bridge: nxp, tda998x: Convert to json-schema
In reply to Geert UytterhoevenConvert the NXP TDA998x HDMI transmitter Device Tree binding documentation to json-schema.
Add missing "#sound-dai-cells" property.
Add ports hierarchy, as an alternative to port. Drop pinctrl properties, as they do not belong here.
---
v2:
- Add maximum to video-ports,
- Drop unneeded maxItems for audio-ports,
- Complete port descriptions.
--- .../bindings/display/bridge/nxp,tda998x.yaml | 109 ++++++++++++++++++ .../bindings/display/bridge/tda998x.txt | 54 --------- 2 files changed, 109 insertions(+), 54 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml delete mode 100644 Documentation/devicetree/bindings/display/bridge/tda998x.txt
Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml new file +109 -0
@@ -0,0 +1,109 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/nxp,tda998x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP TDA998x HDMI transmitter + +maintainers: + - Russell King <[email protected]> + +properties: + compatible: + const: nxp,tda998x + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + video-ports: + default: 0x230145 + maximum: 0xffffff + description: + 24 bits value which defines how the video controller output is wired to + the TDA998x input. + + audio-ports: + description: + Array of 8-bit values, 2 values per DAI (Documentation/sound/soc/dai.rst). + The implementation allows one or two DAIs. + If two DAIs are defined, they must be of different type. + $ref: /schemas/types.yaml#/definitions/uint32-matrix + items: + minItems: 1 + items: + - description: | + The first value defines the DAI type: TDA998x_SPDIF or TDA998x_I2S + (see include/dt-bindings/display/tda998x.h). + - description: + The second value defines the tda998x AP_ENA reg content when the + DAI in question is used. + + '#sound-dai-cells': + enum: [ 0, 1 ] + + nxp,calib-gpios: + maxItems: 1 + description: + Calibration GPIO, which must correspond with the gpio used for the + TDA998x interrupt pin. + + port: + $ref: /schemas/graph.yaml#/properties/port + description: Parallel input port + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + type: object + description: Parallel input port + + port@1: + type: object + description: HDMI output port + +required: + - compatible + - reg + +oneOf: + - required: + - port + - required: + - ports + +additionalProperties: false + +examples: + - | + #include <dt-bindings/display/tda998x.h> + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + tda998x: hdmi-encoder@70 { + compatible = "nxp,tda998x"; + reg = <0x70>; + interrupt-parent = <&gpio0>; + interrupts = <27 IRQ_TYPE_EDGE_FALLING>; + video-ports = <0x230145>; + + #sound-dai-cells = <1>; + /* DAI-format / AP_ENA reg value */ + audio-ports = <TDA998x_SPDIF 0x04>, + <TDA998x_I2S 0x03>; + + port { + tda998x_in: endpoint { + remote-endpoint = <&lcdc_0>; + }; + }; + }; + };
Documentation/devicetree/bindings/display/bridge/tda998x.txt deleted +0 -54
54 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH v2 3/3] dt-bindings: display: bridge: nxp,tda998x: Convert to json-schema
Quoted 13 lines · Geert Uytterhoeven
Convert the NXP TDA998x HDMI transmitter Device Tree binding documentation to json-schema.
Add missing "#sound-dai-cells" property.
Add ports hierarchy, as an alternative to port. Drop pinctrl properties, as they do not belong here.Signed-off-by Geert Uytterhoeven <[email protected]>---
v2:
- Add maximum to video-ports,
- Drop unneeded maxItems for audio-ports,
- Complete port descriptions.
Quoted 7 lines
--- .../bindings/display/bridge/nxp,tda998x.yaml | 109 ++++++++++++++++++ .../bindings/display/bridge/tda998x.txt | 54 --------- 2 files changed, 109 insertions(+), 54 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml delete mode 100644 Documentation/devicetree/bindings/display/bridge/tda998x.txt
Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
tda19988@70: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/renesas/r8a774c0-cat874.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874-idk-2121wr.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dtb
tda19988@70: ports: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/am335x-boneblack.dtb arch/arm/boot/dts/am335x-boneblack-wireless.dtb arch/arm/boot/dts/am335x-sancloud-bbe.dtb
tda19988@70: ports:port@0: 'reg' is a required property
arch/arm/boot/dts/am335x-boneblack.dtb arch/arm/boot/dts/am335x-boneblack-wireless.dtb arch/arm/boot/dts/am335x-sancloud-bbe.dtb
tda9988@70: ports: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/am335x-myirtech-myd.dtb
tda9988@70: ports:port@0: 'reg' is a required property
arch/arm/boot/dts/am335x-myirtech-myd.dtb
Re: [PATCH v2 3/3] dt-bindings: display: bridge: nxp, tda998x: Convert to json-schema
Hi Krzysztof,
Quoted 48 lines · Krzysztof Kozlowski
Quoted 13 lines · Geert Uytterhoeven
Convert the NXP TDA998x HDMI transmitter Device Tree binding documentation to json-schema.
Add missing "#sound-dai-cells" property.
Add ports hierarchy, as an alternative to port. Drop pinctrl properties, as they do not belong here.Signed-off-by Geert Uytterhoeven <[email protected]>---
v2:
- Add maximum to video-ports,
- Drop unneeded maxItems for audio-ports,
- Complete port descriptions.Quoted 7 lines
--- .../bindings/display/bridge/nxp,tda998x.yaml | 109 ++++++++++++++++++ .../bindings/display/bridge/tda998x.txt | 54 --------- 2 files changed, 109 insertions(+), 54 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml delete mode 100644 Documentation/devicetree/bindings/display/bridge/tda998x.txtRunning 'make
dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.Note that it is not yet a requirement to have 0 warnings for
dtbs_check. This will change in the future.Full log is available here: https://patchwork.ozlabs.org/patch/
tda19988@70: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/renesas/r8a774c0-cat874.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874-idk-2121wr.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dtbtda19988@70: ports: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/am335x-boneblack.dtbarch/arm/boot/dts/am335x-boneblack-wireless.dtbarch/arm/boot/dts/am335x-sancloud-bbe.dtbtda19988@70: ports:port@0: 'reg' is a required property
arch/arm/boot/dts/am335x-boneblack.dtbarch/arm/boot/dts/am335x-boneblack-wireless.dtbarch/arm/boot/dts/am335x-sancloud-bbe.dtb
Quoted 5 lines
tda9988@70: ports: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/am335x-myirtech-myd.dtbtda9988@70: ports:port@0: 'reg' is a required property
arch/arm/boot/dts/am335x-myirtech-myd.dtb
Please test this with the earlier patches in the same series applied ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Rob Herring
maintainerRe: [PATCH v2 3/3] dt-bindings: display: bridge: nxp,tda998x: Convert to json-schema
Quoted 52 lines · Geert Uytterhoeven
Hi Krzysztof,
Quoted 48 lines · Krzysztof Kozlowski
Quoted 13 lines · Geert Uytterhoeven
Convert the NXP TDA998x HDMI transmitter Device Tree binding documentation to json-schema.
Add missing "#sound-dai-cells" property.
Add ports hierarchy, as an alternative to port. Drop pinctrl properties, as they do not belong here.Signed-off-by Geert Uytterhoeven <[email protected]>---
v2:
- Add maximum to video-ports,
- Drop unneeded maxItems for audio-ports,
- Complete port descriptions.Quoted 7 lines
--- .../bindings/display/bridge/nxp,tda998x.yaml | 109 ++++++++++++++++++ .../bindings/display/bridge/tda998x.txt | 54 --------- 2 files changed, 109 insertions(+), 54 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml delete mode 100644 Documentation/devicetree/bindings/display/bridge/tda998x.txtRunning 'make
dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.Note that it is not yet a requirement to have 0 warnings for
dtbs_check. This will change in the future.Full log is available here: https://patchwork.ozlabs.org/patch/
tda19988@70: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/renesas/r8a774c0-cat874.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874-idk-2121wr.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dtbtda19988@70: ports: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/am335x-boneblack.dtbarch/arm/boot/dts/am335x-boneblack-wireless.dtbarch/arm/boot/dts/am335x-sancloud-bbe.dtbtda19988@70: ports:port@0: 'reg' is a required property
arch/arm/boot/dts/am335x-boneblack.dtbarch/arm/boot/dts/am335x-boneblack-wireless.dtbarch/arm/boot/dts/am335x-sancloud-bbe.dtb
Quoted 7 lines
Quoted 5 lines
tda9988@70: ports: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/am335x-myirtech-myd.dtbtda9988@70: ports:port@0: 'reg' is a required property
arch/arm/boot/dts/am335x-myirtech-myd.dtbPlease test this with the earlier patches in the same series applied ;-)
Just ignore if not useful. It's informational purposes.
The testing doesn't get series because it gets patches from PW which filters out just bindings. And it tests a patch at a time to get warnings for that patch. If folks want to stop sending binding patches for a couple of months, I can improve it.
Rob
Re: [PATCH v2 3/3] dt-bindings: display: bridge: nxp,tda998x: Convert to json-schema
In reply to Geert UytterhoevenQuoted 151 lines · Geert Uytterhoeven
Hi Krzysztof,
Quoted 48 lines · Krzysztof Kozlowski
Quoted 13 lines · Geert Uytterhoeven
Convert the NXP TDA998x HDMI transmitter Device Tree binding documentation to json-schema.
Add missing "#sound-dai-cells" property.
Add ports hierarchy, as an alternative to port. Drop pinctrl properties, as they do not belong here.Signed-off-by Geert Uytterhoeven <[email protected]>---
v2:
- Add maximum to video-ports,
- Drop unneeded maxItems for audio-ports,
- Complete port descriptions.Quoted 7 lines
--- .../bindings/display/bridge/nxp,tda998x.yaml | 109 ++++++++++++++++++ .../bindings/display/bridge/tda998x.txt | 54 --------- 2 files changed, 109 insertions(+), 54 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml delete mode 100644 Documentation/devicetree/bindings/display/bridge/tda998x.txtRunning 'make
dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.Note that it is not yet a requirement to have 0 warnings for
dtbs_check. This will change in the future.Full log is available here: https://patchwork.ozlabs.org/patch/
tda19988@70: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/renesas/r8a774c0-cat874.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874-idk-2121wr.dtb arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dtbtda19988@70: ports: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/am335x-boneblack.dtbarch/arm/boot/dts/am335x-boneblack-wireless.dtbarch/arm/boot/dts/am335x-sancloud-bbe.dtbtda19988@70: ports:port@0: 'reg' is a required property
arch/arm/boot/dts/am335x-boneblack.dtbarch/arm/boot/dts/am335x-boneblack-wireless.dtbarch/arm/boot/dts/am335x-sancloud-bbe.dtbQuoted 5 lines
tda9988@70: ports: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/am335x-myirtech-myd.dtbtda9988@70: ports:port@0: 'reg' is a required property
arch/arm/boot/dts/am335x-myirtech-myd.dtbPlease test this with the earlier patches in the same series applied ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsFrom git@z Thu Jan 1 00:00:00 1970
Return-Path: <[email protected]>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])by smtp.lore.kernel.org (Postfix) with ESMTP id 56EEEC6FA8B for <[email protected]>; Wed, 14 Sep 2022 14:34:04 +0000 (UTC) Received: ([email protected]) by vger.kernel.org via listexpand id S230118AbiINOeC (ORCPT <rfc822;[email protected]>); Wed, 14 Sep 2022 10:34:02 -0400Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57410 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230133AbiINOeA (ORCPT <rfc822;[email protected]>); Wed, 14 Sep 2022 10:34:00 -0400
Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be
[IPv6:2a02:1800:120:4::f00:13])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC42B7C301 for <[email protected]>;
Wed, 14 Sep 2022 07:33:57 -0700 (PDT)
Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed50:e925:8cbe:2e99:b03b])
by baptiste.telenet-ops.be with bizsmtp
id KqZi2800s3vs4GX01qZiPV; Wed, 14 Sep 2022 16:33:55 +0200
Received: from rox.of.borg ([192.168.97.57])
by ramsan.of.borg with esmtps (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384(Exim 4.93) (envelope-from <[email protected]>) id 1oYTSP-005B5L-Rc; Wed, 14 Sep 2022 16:33:41 +0200 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from <[email protected]>) id 1oYTS7-000zXm-2p; Wed, 14 Sep 2022 16:33:23 +0200From: Geert Uytterhoeven <[email protected]>
To: Russell King <[email protected]>,
Rob Herring <[email protected]>,
Krzysztof Kozlowski <[email protected]>,
Tony Lindgren <[email protected]>,
Andrzej Hajda <[email protected]>,
Neil Armstrong <[email protected]>,
Robert Foss <[email protected]>,
Laurent Pinchart <[email protected]>,
Jonas Karlman <[email protected]>,
Jernej Skrabec <[email protected]>,
David Airlie <[email protected]>,
Daniel Vetter <[email protected]>, =?UTF-8?q?Beno=C3=AEt=20Cousson?= <[email protected]>, Magnus Damm <[email protected]>,
Fabrizio Castro <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected], Geert Uytterhoeven <[email protected]>
Subject: [PATCH v2 3/3] dt-bindings: display: bridge: nxp,tda998x: Convert to
json-schema
Date: Wed, 14 Sep 2022 16:33:22 +0200
Message-Id:
<1224e757ec958f8b29ec66e783a7ee805c339d84.1663165552.git.geert+renesas@glider.be>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <[email protected]>
References: <[email protected]>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: [email protected]Convert the NXP TDA998x HDMI transmitter Device Tree binding documentation to json-schema.
Add missing "#sound-dai-cells" property.
Add ports hierarchy, as an alternative to port. Drop pinctrl properties, as they do not belong here.Signed-off-by Geert Uytterhoeven <[email protected]>---
v2:
- Add maximum to video-ports,
- Drop unneeded maxItems for audio-ports,
- Complete port descriptions.
Quoted 7 lines
--- .../bindings/display/bridge/nxp,tda998x.yaml | 109 ++++++++++++++++++ .../bindings/display/bridge/tda998x.txt | 54 --------- 2 files changed, 109 insertions(+), 54 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml delete mode 100644 Documentation/devicetree/bindings/display/bridge/tda998x.txt
Applied, thanks!